Repository navigation
FE-3193 fix(billing): cancel and resubscribe no longer claim success when the workspace never loads - #20039
Conversation
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 10.2 MB gzip 🟢 -12 BDetailsSummary
Category Glance App Entry Points — 3.92 kB (baseline 3.92 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.47 MB (baseline 1.47 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 135 kB (baseline 135 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 648 kB (baseline 648 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 53.7 kB (baseline 53.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 8 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 194 kB (baseline 194 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 10 unchanged Data & Services — 4.09 MB (baseline 4.09 MB) • 🔴 +107 BStores, services, APIs, and repositories
Status: 11 added / 11 removed / 3 unchanged Utilities & Hooks — 587 kB (baseline 587 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 18 unchanged Vendor & Third-Party — 17.2 MB (baseline 17.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.4 MB (baseline 18.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 77 added / 77 removed / 229 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-03T23:52:23.336Z",
"gitSha": "c730ad6151d1a1f26a700aef466f75b6bfc64588",
"branch": "jaewon/fe-3193-fixbilling-legacy-cancel-and-resubscribe-resolve-after-the",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2000.2900000000068,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8369999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.671,
"heapDeltaBytes": 22350908,
"heapUsedBytes": 76220584,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.918,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2042.2869999999875,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.184,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.90500000000003,
"heapDeltaBytes": -27945560,
"heapUsedBytes": 75082012,
"domNodes": -232,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 8.461,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1753.8870000000202,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.666,
"layouts": 12,
"layoutDurationMs": 4.452,
"taskDurationMs": 765.221,
"heapDeltaBytes": -2467744,
"heapUsedBytes": 65398524,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 147.112,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1745.1260000000275,
"styleRecalcs": 53,
"styleRecalcDurationMs": 15.459,
"layouts": 12,
"layoutDurationMs": 4.255,
"taskDurationMs": 742.477,
"heapDeltaBytes": 19496400,
"heapUsedBytes": 73500708,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.378,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1698.880000000031,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.941,
"layouts": 6,
"layoutDurationMs": 1.2309999999999999,
"taskDurationMs": 340.194,
"heapDeltaBytes": 3425844,
"heapUsedBytes": 71114624,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.156000000000008,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.4060000000727,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.713000000000001,
"layouts": 6,
"layoutDurationMs": 1.3269999999999997,
"taskDurationMs": 307.84299999999996,
"heapDeltaBytes": 25591108,
"heapUsedBytes": 79651376,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.260000000000007,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 670.187999999996,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.326000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.1039999999999,
"heapDeltaBytes": 14522420,
"heapUsedBytes": 68862560,
"domNodes": -71,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.00599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 665.8820000000105,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.1129999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.697,
"heapDeltaBytes": 14508132,
"heapUsedBytes": 68385700,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.29500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000018,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1122.9739999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 774.314,
"heapDeltaBytes": 15391804,
"heapUsedBytes": 84505248,
"domNodes": 0,
"jsHeapTotalBytes": 7241728,
"scriptDurationMs": 55.18399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 494,
"frameDurationMs": 33.833333333333336,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1138.3710000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 789.754,
"heapDeltaBytes": 14873136,
"heapUsedBytes": 83760880,
"domNodes": 0,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 59.660999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 501,
"frameDurationMs": 33.332352941176474,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.5320000000152,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.3050000000002,
"heapDeltaBytes": 17332452,
"heapUsedBytes": 104642120,
"domNodes": 0,
"jsHeapTotalBytes": 1576960,
"scriptDurationMs": 138.49500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.776000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.11999999999966,
"heapDeltaBytes": 17219144,
"heapUsedBytes": 104737100,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 142.54,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8957.030000000002,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3800000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7990.039000000001,
"heapDeltaBytes": 11513564,
"heapUsedBytes": 80416892,
"domNodes": -142,
"jsHeapTotalBytes": -7999488,
"scriptDurationMs": 6455.399,
"eventListeners": -74,
"totalBlockingTimeMs": 277,
"frameDurationMs": 29.832,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8429.879999999968,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3809999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7662.027,
"heapDeltaBytes": -7322604,
"heapUsedBytes": 70736796,
"domNodes": -171,
"jsHeapTotalBytes": -6688768,
"scriptDurationMs": 6262.636,
"eventListeners": -78,
"totalBlockingTimeMs": 165,
"frameDurationMs": 30.117857142857144,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8068.1280000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7402.358999999999,
"heapDeltaBytes": -13722584,
"heapUsedBytes": 66885812,
"domNodes": 0,
"jsHeapTotalBytes": -17825792,
"scriptDurationMs": 5947.2390000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 130,
"frameDurationMs": 29.594117647058823,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8415.051000000061,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7673.687,
"heapDeltaBytes": 420664,
"heapUsedBytes": 80716876,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 6198.4439999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 86,
"frameDurationMs": 29.122491349480967,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2022.3209999999767,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2569999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.95,
"heapDeltaBytes": -10324420,
"heapUsedBytes": 77267924,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.211000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2017.1699999999646,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.259999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.079,
"heapDeltaBytes": -10589832,
"heapUsedBytes": 77698492,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.859000000000012,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2221.597000000031,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.439,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1458.755,
"heapDeltaBytes": 128740,
"heapUsedBytes": 63966308,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 768.059,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665413533834588,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2150.4489999999805,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1425.1729999999998,
"heapDeltaBytes": 1508900,
"heapUsedBytes": 65270964,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 754.803,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3547.282999999993,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.076,
"layouts": 60,
"layoutDurationMs": 14.947999999999999,
"taskDurationMs": 1562.2030000000002,
"heapDeltaBytes": 965196,
"heapUsedBytes": 65352260,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 743.545,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66556603773585,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3521.7340000000377,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.387000000000002,
"layouts": 60,
"layoutDurationMs": 14.522,
"taskDurationMs": 1574.7880000000002,
"heapDeltaBytes": -261132,
"heapUsedBytes": 64727216,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 749.3649999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635071090047,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3097.1870000000195,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.552,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1821.8190000000002,
"heapDeltaBytes": 8231900,
"heapUsedBytes": 77511124,
"domNodes": 0,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 960.585,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756521739130434,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3056.7729999999074,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.751000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1817.1999999999998,
"heapDeltaBytes": 5688356,
"heapUsedBytes": 73198324,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 979.2760000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75769230769231,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2030.5970000000002,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0809999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.64399999999995,
"heapDeltaBytes": 10374668,
"heapUsedBytes": 73995936,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.975999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2007.9020000000583,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8120000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.93200000000013,
"heapDeltaBytes": -10271600,
"heapUsedBytes": 78607484,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.317,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.064999999986,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.053999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.268,
"heapDeltaBytes": 8887096,
"heapUsedBytes": 63115184,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.99599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.9820000000773,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.380000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.44,
"heapDeltaBytes": 9205396,
"heapUsedBytes": 63382572,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.91,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.8460000000387,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.706,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.15600000000006,
"heapDeltaBytes": 21948352,
"heapUsedBytes": 76171884,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.84,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.3249999999707,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.326,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.986,
"heapDeltaBytes": 21981384,
"heapUsedBytes": 76227084,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.65,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.403999999964,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.365,
"layouts": 16,
"layoutDurationMs": 5.351,
"taskDurationMs": 699.616,
"heapDeltaBytes": -6252536,
"heapUsedBytes": 63246040,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 101.09800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.5139999999374,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.992,
"layouts": 16,
"layoutDurationMs": 6.039999999999999,
"taskDurationMs": 709.186,
"heapDeltaBytes": 15258548,
"heapUsedBytes": 69414580,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 101.70499999999998,
"eventListeners": -121,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.6889999999844,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.679999999999996,
"layouts": 5,
"layoutDurationMs": 11.899,
"taskDurationMs": 880.809,
"heapDeltaBytes": 23930520,
"heapUsedBytes": 109526936,
"domNodes": 13747,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 28.664999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 119,
"frameDurationMs": 19.21249999999999,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8191.686000000004,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.907999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5226.119000000001,
"heapDeltaBytes": -34362276,
"heapUsedBytes": 91420976,
"domNodes": -328,
"jsHeapTotalBytes": -1216512,
"scriptDurationMs": 2553.864,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665987780040734,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8207.088,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5146.945,
"heapDeltaBytes": -33938244,
"heapUsedBytes": 91672868,
"domNodes": -328,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 2514.221,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598778004073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17585.117999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16849.252,
"heapDeltaBytes": -30477260,
"heapUsedBytes": 178964588,
"domNodes": -3045,
"jsHeapTotalBytes": 9601024,
"scriptDurationMs": 278.40700000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.5784347826087,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 17537.68200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16691.531000000003,
"heapDeltaBytes": -32043820,
"heapUsedBytes": 179109080,
"domNodes": -3045,
"jsHeapTotalBytes": 8212480,
"scriptDurationMs": 280.492,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.766723259762312,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 22067.470999999954,
"styleRecalcs": 178,
"styleRecalcDurationMs": 21.682000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21672.784,
"heapDeltaBytes": -28873048,
"heapUsedBytes": 183702652,
"domNodes": -3045,
"jsHeapTotalBytes": 6893568,
"scriptDurationMs": 891.616,
"eventListeners": -14915,
"totalBlockingTimeMs": 16,
"frameDurationMs": 41.47706766917293,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 21284.23299999997,
"styleRecalcs": 174,
"styleRecalcDurationMs": 19.24299999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20796.879999999997,
"heapDeltaBytes": -6858120,
"heapUsedBytes": 195327180,
"domNodes": -3045,
"jsHeapTotalBytes": 8658944,
"scriptDurationMs": 846.595,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.080037664783426,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6298.203999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.11399999999999,
"layouts": 20,
"layoutDurationMs": 24.452,
"taskDurationMs": 6213.883,
"heapDeltaBytes": -5881404,
"heapUsedBytes": 205328600,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 108.183,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.887654320987664,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6321.339999999964,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.51700000000002,
"layouts": 20,
"layoutDurationMs": 26.396000000000004,
"taskDurationMs": 6205.955999999999,
"heapDeltaBytes": 15299996,
"heapUsedBytes": 224607104,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 107.722,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.922754491017955,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8769.261000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8521.425999999998,
"heapDeltaBytes": -35114512,
"heapUsedBytes": 178611312,
"domNodes": -3045,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 135.79200000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.021575342465752,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8496.353,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8191.331,
"heapDeltaBytes": 1807964,
"heapUsedBytes": 199935936,
"domNodes": -3045,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 129.11300000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.208247422680408,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 487.54800000000387,
"styleRecalcs": 22,
"styleRecalcDurationMs": 17.549000000000003,
"layouts": 4,
"layoutDurationMs": 2.088,
"taskDurationMs": 132.71400000000003,
"heapDeltaBytes": 5894952,
"heapUsedBytes": 63833808,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.928999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 125.78099999996084,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.058,
"layouts": 3,
"layoutDurationMs": 1.7389999999999999,
"taskDurationMs": 80.72900000000003,
"heapDeltaBytes": 3773280,
"heapUsedBytes": 57506680,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.653,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 879.7590000000355,
"styleRecalcs": 78,
"styleRecalcDurationMs": 109.128,
"layouts": 76,
"layoutDurationMs": 25.643,
"taskDurationMs": 829.48,
"heapDeltaBytes": -8225524,
"heapUsedBytes": 81300984,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 331.659,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664150943396223,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 966.1059999999679,
"styleRecalcs": 78,
"styleRecalcDurationMs": 112.792,
"layouts": 76,
"layoutDurationMs": 27.759,
"taskDurationMs": 931.255,
"heapDeltaBytes": 18786100,
"heapUsedBytes": 85720708,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 376.11899999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1386.7370000000392,
"styleRecalcs": 78,
"styleRecalcDurationMs": 272.929,
"layouts": 76,
"layoutDurationMs": 29.01,
"taskDurationMs": 1360.396,
"heapDeltaBytes": -13191284,
"heapUsedBytes": 107474188,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 433.659,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.508860759493658,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1435.3059999999687,
"styleRecalcs": 78,
"styleRecalcDurationMs": 300.988,
"layouts": 76,
"layoutDurationMs": 30.643,
"taskDurationMs": 1402.674,
"heapDeltaBytes": 7810600,
"heapUsedBytes": 114682932,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 436.40799999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.85921052631578,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 436f1122b27584c438edbacccd7e79bd110a5ad6
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2191 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe billing context now propagates routing timeouts from cancellation and resubscription actions. Tests cover the timeout errors, toast behavior, and the cancellation dialog’s failure state. ChangesBilling routing timeout handling
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Billing actions should now report a routing timeout as failure rather than success. No actionable issue remains identified before merge. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to Cancellation and reactivation now report routing timeouts as failures instead of successes. No new billing permissions or request paths were identified. Remaining uncertainty concerns unchanged workspace-switch handling and server-side ownership and duplicate-request guarantees. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20039 +/- ##
==========================================
+ Coverage 84.90% 85.70% +0.80%
==========================================
Files 3450 2422 -1028
Lines 165773 138339 -27434
Branches 43298 35518 -7780
==========================================
- Hits 140745 118564 -22181
+ Misses 23060 19399 -3661
+ Partials 1968 376 -1592
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1039 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed exact head 9987bee64a2f430fe2068b83d972ad70753ea046 against FE-3193. This head contains the regression tests but not the implementation described in the PR body. cancelSubscription and resubscribe still call whenRoutingKnown(), whose timeout is caught/toasted and converted to false; each action then returns normally, so callers can still report success before routing is ready.
The proof is correctly red on this head: CI unit shard 2 reports both new cases received "resolved", and playwright-video-new-tests receives the old "Error — We couldn't reach your account…" toast instead of "Failed to cancel subscription"; the unit and E2E aggregate gates are red. Please push the implementation commit described in the body (including the timeout rejection/caller-owned failure path), then rerun these exact unit and black-box cases. Failure/timeout must remain visible, with no success toast and the cancel dialog still open. I did not assess the separate workspace-switch path noted in the body, and this verdict does not cover #20036.
|
@christian-byrne The implementation is pushed in 9e2bf15 (head). The test commit stays below it, unchanged, so the red run above remains the AS IS proof.
Green on the exact cases, run https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/37162438781:
The workspace-switch path is unchanged. If the user switches workspace during the wait, |
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at 9e2bf1587d6bcfe7e1ae928cb4b1ea97eebe205a. The routing-timeout implementation now rejects cancel and resubscribe, exact-head CI is settled green, and no unresolved review threads remain.
Full context for agent readers
Both actions now await the rejecting routing path, preventing false success when a workspace never loads. The tests cover rejection, absence of internal and success toasts, and the dialog remaining open. The same-tab workspace-change guard remains local to the action and does not persist or synchronize selection, so two tabs may intentionally use different workspaces.
…when the workspace changes during the wait (Comfy-Org#20060) ## Why If the active workspace changes while "Cancel subscription" waits for the workspace type, the dialog shows "Subscription cancelled successfully" and closes. Nothing was cancelled. Reactivating a plan from the billing panel does the same with the resubscribe success toast. - Fixes [FE-3196](https://linear.app/comfyorg/issue/FE-3196) ## Root cause The billing facade (`useBillingContext`) waits for the workspace type before routing an action (Comfy-Org#19921). Comfy-Org#20039 made `waitForRouting` reject on timeout, but it still resolves `false` when the active workspace changed during the wait. `cancelSubscription` and `resubscribe` then return `undefined`, so they resolve, and `CancelSubscriptionDialogContent` and `useResubscribe` treat a resolve as success. Comfy-Org#20039 listed this path as left unchanged. ## How - `cancelSubscription` and `resubscribe` now throw a `BillingWorkspaceChangedError` when the workspace changed during the wait, instead of returning. - The message reuses `subscription.cancelDialog.workspaceChanged` ("Your active workspace changed. Switch back and try again."). No new copy. - The caller is the only toast owner. The cancel dialog shows one "Failed to cancel subscription" toast with that detail and stays open. `useResubscribe` shows its own error toast with that detail. No success toast. - Every other facade action still drops silently on a workspace switch, as before (the existing "drops an action silently" test still passes). E2E: not extended. In the `cancelSubscriptionDialog` e2e environment no workspace loads, so the wait captures no workspace id and a switch cannot be detected. The dialog is also modal over the workspace switcher. Reaching a mid-wait switch there means writing store state from the test, which the facade unit tests already cover more directly. ## AS IS / TO BE Real-app capture is pending. Proof is local; CI did not run on the test-only commit. AS IS (`cecdf7d798`, tests only): ``` × rejects cancelSubscription for its caller to show if the workspace changed during the wait × rejects resubscribe for its caller to show if the workspace changed during the wait AssertionError: expected 'resolved' to match object { Object (message) } Tests 2 failed | 59 passed (61) ``` TO BE (`049f8a3a19`, fix), `src/composables/billing`, `useResubscribe.test.ts` and the subscription dialog tests: ``` Test Files 11 passed (11) Tests 182 passed (182) ``` ## Where this sits | PR | Change | Status | | --- | --- | --- | | Comfy-Org#19921 | Facade waits for the workspace type before routing | Merged | | Comfy-Org#20039 (FE-3193) | Cancel and resubscribe reject when the wait times out | Merged | | **This PR (FE-3196)** | **Cancel and resubscribe reject when the workspace changes during the wait** | **Open** | ```mermaid graph LR A["PR 19921 routing wait"] --> B["PR 20039 FE-3193 timeout rejects"] B --> C["FE-3196 workspace switch rejects"] style C fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ``` No backport labels: Comfy-Org#19921 and Comfy-Org#20039 were not backported.
Why
When the workspace type never loads, confirming "Cancel subscription" shows an error toast, then "Subscription cancelled successfully", and closes the dialog. Nothing was cancelled. Reactivating a plan from the billing panel does the same with the resubscribe success toast.
Root cause
#19921 made the billing facade (
useBillingContext) wait up to 10s for the workspace type before routing an action. On timeout,whenRoutingKnowntoasts the routing error and resolvesfalse.cancelSubscriptionandresubscribethen returnundefined, so they resolve.CancelSubscriptionDialogContentanduseResubscribetreat a resolve as success.The
cancelSubscriptionDialoge2e already reaches this path, because no billing workspace loads there. It only asserted that some error toast appeared, so it passed.Context for @wei-hai, since #19921 added the routing wait.
How
waitForRoutingrejects with the routing error on timeout. It still resolvesfalsewhen the user switched workspace during the wait.whenRoutingKnownwraps it, toasts the rejection, and resolvesfalse, so every other action behaves as before.cancelSubscriptionandresubscribecallwaitForRouting. One toast owner: the caller. The dialog shows "Failed to cancel subscription" with the routing message as detail and stays open.useResubscribeshows its own failure toast. The facade does not toast for these two, so there is no double toast.ROUTING_WAIT_TIMEOUT_MSmoves to module scope. The immediate workspace watcher callsinitialize()before the in-functionconstwas declared, a temporal dead zone. OnmainthatReferenceErrorwas caught synchronously and toasted as the routing error whenever the facade was created for a workspace with an id but no type yet. The existing "drops an action silently when the workspace changed" test hid it, because itsvi.clearAllMocks()ran after the synchronous toast. With the toast now one microtask later, that test catches it.Other facade actions that wait, checked:
subscribeundefinedmissing_checkout_response).previewSubscribenullnullpreview, so the flow fails.topupundefinedvoidas failure (per #20018).manageSubscription,requireActiveSubscription,showSubscriptionDialoginitialize,reconcileSubscriptionSuccess,readCheckoutOperationFound, not fixed here: if the user switches workspace during the wait,
cancelSubscriptionandresubscribestill resolve silently, so the caller shows success. That path needs its own copy (the dialog already has a "workspace changed" warning) and is unchanged from #19921.AS IS / TO BE
Real-app capture is pending.
AS IS (
9987bee64a, tests only):TO BE (
9e2bf1587d, fix):E2E:
cancelSubscriptionDialog.spec.tsnow asserts one error toast reading "Failed to cancel subscription" with the routing message, no success toast, and the dialog still open. Before the fix the only error toast is the facade's "Error" toast and the dialog closes with a success toast.CI on the test-only head
9987bee64awas red on exactly these cases (run):CI on the fix head
9e2bf1587dis green (run):useBillingContext.test.ts59/59 in unit shard 2, andcancelSubscriptionDialog.spec.ts4 passed inplaywright-video-new-tests.Where this sits
No backport labels: #19921 and #20018 were not backported.