Repository navigation
[backport cloud/1.55] feat(telemetry): send client_message_id on the turn POST so the activation funnel joins - #19996
Conversation
…ation funnel joins (#18970) `app:agent_message_sent` already carries a per-send `client_message_id`, but it never left the browser. The doc comment said so outright: > Minted client-side … **The backend does not receive it yet** — the turn POST contract carries no client id — so it dedups within the frontend stream rather than joining to the backend turn; `thread_id` is the join today. That is the reason the activation funnel's **message → turn** step is countable but not attributable. 606 frontend sends against 470 backend turn-starts on 2026-09-25 is a real gap as a count, but no individual message can be tied to the turn it started, so the gap cannot be explained and send latency has no instrument at all. Send the id on the turn POST. The server echoes it onto its own `agent_turn_started` event (Comfy-Org/cloud#10781), which then carries both that id and its `turn_id` — so the two event streams join at the step the funnel actually loses people at. **No new id is minted.** This is the value already reported on the analytics event, passed through to the request body. `AgentPanelRoot` hands the same `meta.clientMessageId` to both sinks. - **`thread_id`** is on the event already, but it is `null` for the first message in a thread — exactly the send that matters most to activation, and ~38% of sends on the current build. - **`turn_id`** cannot be used: the server mints it after the POST arrives, so it can never appear on a send-site event. The analytics event and the request body must carry the **same** value. If they ever diverge the join silently returns zero rows and nothing else fails — no error, no failed send, just an empty funnel. So there is a test that asserts equality across the two sinks in one send, which neither side's own test would catch. - `AgentPostMessageRequest` is widened locally at its one construction site, because the generated type is published from the cloud repo's `openapi.yaml`. One line to delete once the published type carries the field. - `postMessage`'s optional-field copying becomes a single `withoutUndefined()` build rather than a tenth sequential `if (x !== undefined)`. Same wire output — keys whose value is `undefined` are omitted, and `false`/`0` survive, so `current_tab_unbound: false` still sends. This keeps the added field from pushing the function past the repo's complexity gate, and two existing tests pin the omit-absent-optionals behaviour. - The stale doc comment on `AgentMessageSentMetadata.client_message_id` is corrected, since it asserted the opposite of what now happens. ``` pnpm typecheck # clean npx vitest run src/workbench/extensions/agent/ src/platform/telemetry/ pnpm knip && pnpm fallow:audit # clean, no new findings ``` New coverage: `client_message_id` reaches the wire; it is omitted when the caller has none; and the posted value equals the reported one. Additive and independently shippable in either order. An older server ignores the field (ingest proxies the body verbatim; Echo's `Bind` drops unknown keys), and an older client simply sends nothing — which reads as *unknown* for that turn, never as a failed send.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2147 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1ee55e907aa28aac18a0998fbbf5015d6660a63d
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-03T11:26:42.387Z",
"gitSha": "c87c4d76c4616d503b61bab382d1e80f155e21bd",
"branch": "backport-18970-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1990.6159999999318,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.250999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.612,
"heapDeltaBytes": 3091088,
"heapUsedBytes": 71903240,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.315,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.041000000021,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.9129999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.837,
"heapDeltaBytes": 5543852,
"heapUsedBytes": 74534520,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.507999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.5910000000003,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.273,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 715.355,
"heapDeltaBytes": 507336,
"heapUsedBytes": 69377332,
"domNodes": -261,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 149.56,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.820999999798,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.351999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 733.676,
"heapDeltaBytes": 6846488,
"heapUsedBytes": 75829548,
"domNodes": -246,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 153.74599999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.4100000001108,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.253000000000004,
"layouts": 6,
"layoutDurationMs": 1.2349999999999999,
"taskDurationMs": 363.52000000000004,
"heapDeltaBytes": 3242388,
"heapUsedBytes": 72221148,
"domNodes": 79,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.000000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1663.8499999999112,
"styleRecalcs": 29,
"styleRecalcDurationMs": 12.918999999999999,
"layouts": 6,
"layoutDurationMs": 1.069,
"taskDurationMs": 324.528,
"heapDeltaBytes": 2944440,
"heapUsedBytes": 71932964,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.209,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 628.4919999999374,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.487999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.32700000000006,
"heapDeltaBytes": 17502756,
"heapUsedBytes": 86601208,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 156.496,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 638.0710000000818,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.030000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.906,
"heapDeltaBytes": 18126136,
"heapUsedBytes": 86871708,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 159.01900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1156.3180000000557,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 842.244,
"heapDeltaBytes": 35482464,
"heapUsedBytes": 104662028,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 69.95700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 537,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1194.723999999951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 871.3460000000001,
"heapDeltaBytes": -18198140,
"heapUsedBytes": 73218268,
"domNodes": -295,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 60.750000000000014,
"eventListeners": -217,
"totalBlockingTimeMs": 518,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.4649999999901,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.1470000000002,
"heapDeltaBytes": 15141548,
"heapUsedBytes": 90747800,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.071,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 840.0650000000951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.75700000000006,
"heapDeltaBytes": 14866040,
"heapUsedBytes": 91752164,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 142.069,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9156.70399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8303.233,
"heapDeltaBytes": 17545460,
"heapUsedBytes": 93353428,
"domNodes": -10,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 6989.652999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 743,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8399.16100000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7558.590999999999,
"heapDeltaBytes": -12259728,
"heapUsedBytes": 68920536,
"domNodes": -16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6401.077,
"eventListeners": 0,
"totalBlockingTimeMs": 168,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9482.373000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8621.805,
"heapDeltaBytes": 3295996,
"heapUsedBytes": 84821016,
"domNodes": -14,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 7062.967,
"eventListeners": 0,
"totalBlockingTimeMs": 467,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8515.803000000005,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.09599999999999886,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7773.991000000001,
"heapDeltaBytes": 14727060,
"heapUsedBytes": 93575696,
"domNodes": -274,
"jsHeapTotalBytes": 3137536,
"scriptDurationMs": 6288.286999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 202,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2008.8519999999335,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.329000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.036,
"heapDeltaBytes": 2244544,
"heapUsedBytes": 85127264,
"domNodes": -259,
"jsHeapTotalBytes": 2912256,
"scriptDurationMs": 31.436000000000007,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.7139999998235,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.54,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.4590000000002,
"heapDeltaBytes": -23915148,
"heapUsedBytes": 65630952,
"domNodes": -258,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 33.641999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2189.740000000029,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.628,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1556.0439999999999,
"heapDeltaBytes": -1671964,
"heapUsedBytes": 88161024,
"domNodes": -256,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 795.424,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2245.5019999999877,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1564.253,
"heapDeltaBytes": 2094728,
"heapUsedBytes": 92244288,
"domNodes": -254,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 812.614,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3586.3979999999174,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.213999999999999,
"layouts": 60,
"layoutDurationMs": 15.657,
"taskDurationMs": 1714.7109999999998,
"heapDeltaBytes": 1035664,
"heapUsedBytes": 66169152,
"domNodes": -231,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 829.314,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3559.287999999924,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.187,
"layouts": 60,
"layoutDurationMs": 14.768999999999998,
"taskDurationMs": 1683.499,
"heapDeltaBytes": -26031228,
"heapUsedBytes": 64813272,
"domNodes": -240,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 787.385,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3129.597999999987,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.016999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1879.8690000000001,
"heapDeltaBytes": 8283224,
"heapUsedBytes": 74264452,
"domNodes": 6,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 994.543,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3160.4590000001735,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.938,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1852.7830000000001,
"heapDeltaBytes": -18418788,
"heapUsedBytes": 74146316,
"domNodes": 14,
"jsHeapTotalBytes": 6320128,
"scriptDurationMs": 984.5519999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 19,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.9720000001198,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.141000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.993,
"heapDeltaBytes": -22072992,
"heapUsedBytes": 68703544,
"domNodes": -257,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 39.876,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.4579999999532,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.163000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.1359999999999,
"heapDeltaBytes": -16333480,
"heapUsedBytes": 73754752,
"domNodes": -244,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.847,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.6570000000174,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.127,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.48100000000005,
"heapDeltaBytes": 13810980,
"heapUsedBytes": 83746876,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 153.998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 602.6609999998982,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.511999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.54900000000004,
"heapDeltaBytes": 13790796,
"heapUsedBytes": 84151412,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 151.841,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2000.810999999885,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.401,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.816,
"heapDeltaBytes": -6951224,
"heapUsedBytes": 63792440,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.662000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1991.3990000000013,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.293,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.6910000000001,
"heapDeltaBytes": 8897980,
"heapUsedBytes": 79858352,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.492,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.6890000000203,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.219,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 694.613,
"heapDeltaBytes": -11760572,
"heapUsedBytes": 58318716,
"domNodes": -274,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 92.677,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1788.7060000000474,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.354,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 764.566,
"heapDeltaBytes": 5915640,
"heapUsedBytes": 76664088,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 103.59899999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.4750000000658,
"styleRecalcs": 16,
"styleRecalcDurationMs": 27.172999999999995,
"layouts": 5,
"layoutDurationMs": 11.957999999999998,
"taskDurationMs": 888.4989999999999,
"heapDeltaBytes": -6286524,
"heapUsedBytes": 82249636,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.630000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 128,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8350.550000000112,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.964999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5675.419,
"heapDeltaBytes": 3159092,
"heapUsedBytes": 92470676,
"domNodes": -243,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2760.523,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8188.005000000203,
"styleRecalcs": 251,
"styleRecalcDurationMs": 42.678999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4758.411,
"heapDeltaBytes": 2936460,
"heapUsedBytes": 91864884,
"domNodes": -238,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2639.0200000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18064.701000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17872.387000000002,
"heapDeltaBytes": -44365400,
"heapUsedBytes": 182865224,
"domNodes": -8061,
"jsHeapTotalBytes": -12910592,
"scriptDurationMs": 285.54200000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17257.26800000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16833.100000000002,
"heapDeltaBytes": -50668060,
"heapUsedBytes": 176609824,
"domNodes": -8062,
"jsHeapTotalBytes": -18677760,
"scriptDurationMs": 300.987,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23008.97000000009,
"styleRecalcs": 171,
"styleRecalcDurationMs": 25.30500000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22854.12,
"heapDeltaBytes": -39956284,
"heapUsedBytes": 181511660,
"domNodes": -8061,
"jsHeapTotalBytes": -19337216,
"scriptDurationMs": 949.0179999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 205,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 21393.428999999967,
"styleRecalcs": 159,
"styleRecalcDurationMs": 19.852000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21181.989999999998,
"heapDeltaBytes": -55858728,
"heapUsedBytes": 179476636,
"domNodes": -8061,
"jsHeapTotalBytes": -12181504,
"scriptDurationMs": 887.5020000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 34,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6463.8199999999415,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.89999999999999,
"layouts": 20,
"layoutDurationMs": 25.654999999999998,
"taskDurationMs": 6410.721,
"heapDeltaBytes": -59859156,
"heapUsedBytes": 175536336,
"domNodes": -8061,
"jsHeapTotalBytes": 14557184,
"scriptDurationMs": 125.89800000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 439,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6277.10100000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.89399999999996,
"layouts": 20,
"layoutDurationMs": 26.363999999999997,
"taskDurationMs": 6251.3060000000005,
"heapDeltaBytes": -58808472,
"heapUsedBytes": 181977616,
"domNodes": -8061,
"jsHeapTotalBytes": 8364032,
"scriptDurationMs": 116.509,
"eventListeners": -14928,
"totalBlockingTimeMs": 448,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9001.244999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8876.261999999999,
"heapDeltaBytes": 777304,
"heapUsedBytes": 185809428,
"domNodes": 0,
"jsHeapTotalBytes": -8126464,
"scriptDurationMs": 144.78599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8616.954999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8432.119,
"heapDeltaBytes": -1895696,
"heapUsedBytes": 192562048,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 134.35799999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 113.67300000006253,
"styleRecalcs": 7,
"styleRecalcDurationMs": 19.570000000000004,
"layouts": 4,
"layoutDurationMs": 2.112,
"taskDurationMs": 89.05499999999999,
"heapDeltaBytes": 3243368,
"heapUsedBytes": 64625512,
"domNodes": 110,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.299,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 458.6340000000746,
"styleRecalcs": 16,
"styleRecalcDurationMs": 23.611000000000004,
"layouts": 4,
"layoutDurationMs": 2.249,
"taskDurationMs": 123.534,
"heapDeltaBytes": 5102284,
"heapUsedBytes": 71784204,
"domNodes": 146,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.538,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19996 +/- ##
=============================================
Coverage ? 84.94%
=============================================
Files ? 2327
Lines ? 133215
Branches ? 35985
=============================================
Hits ? 113153
Misses ? 19700
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Review of 766284d5e4a2dd070f830f3922a6a7b97f6d4537 against cloud/1.55@1ee55e907aa28aac18a0998fbbf5015d6660a63d. Posted as a COMMENT, not an approval: I am this PR's author and GitHub will not accept an author's own approval. The authority to merge this is the recorded Agent release-backport grant (Christian, September 16 and 20, extended September 27 to both the 1.54 and 1.55 lines), which permits self-merge after this program's own gates pass. It does not permit manufacturing an approval record, so none is being manufactured here. Under that grant REVIEW_REQUIRED alone is not a human-approval requirement; an unresolved human objection still is, and there are none — zero reviews and zero review threads, resolved or otherwise, on this PR.
What I actually checked, not just that CI is green:
Source applicability. #18970 is MERGED to main (merge commit 3b07da0b8d8ca0c030c93153364d801a0317708f, 2026-10-03T07:05:13Z). Its backend counterpart, cloud #10781, is already shipped, so the server can echo the field; this carrier does not depend on anything unlanded.
Faithfulness of the carry. The postMessage region of agentRestClient.ts at this head is identical to the same region at the source merge commit. The file as a whole is not, and that is expected and pre-existing: cloud/1.55 does not carry PM-1658's ANSWER_ASK_TIMEOUT_MS or the empty-message fallback in AgentApiError. Neither is in this diff. The one place the carry genuinely diverged from the source is telemetry/types.ts: on main the source replaced an older doc comment that said the backend does not receive the id; on cloud/1.55 that older comment does not exist, so the carry is a pure 14-line addition. Same documented contract, no dropped hunk.
The behavioural rewrite inside postMessage. The sequence of if (x !== undefined) body.y = x assignments became one withoutUndefined object literal. I checked this for an accidental falsiness bug, because that is the obvious way for it to go wrong: it filters on value !== undefined exactly, so current_tab_unbound: false still reaches the wire. The two rewrites that are not mechanical are open_tabs: req.tabs?.open_tabs (previously assigned only inside if (req.tabs !== undefined)) and draft: req.draft && {...} — both land undefined in exactly the cases the old code skipped, and JSON.stringify drops undefined values, so the emitted body is unchanged. There is a test asserting the no-id body is ['content'] only, which pins this.
Acceptance, not just unit tests. browser_tests/tests/agent/agentActivationConsent.spec.ts is tagged @cloud and is not in testIgnore, so the cloud Playwright project's grep: /@cloud/ selects it — the new client_message_id uuid-shape assertion on the posted body really does execute in the playwright-tests (cloud, frontend-dist-cloud) shard rather than being collected and skipped. The PR body's note that a local isolated run did not reach that assertion is a harness artifact, not missing coverage. The AgentPanelRoot.test.ts case is the one that matters for the actual failure mode: it asserts the id on the wire and the id on app:agent_message_sent are the same value, which is the only thing that would catch a silent divergence — a divergence returns zero funnel rows and breaks nothing else.
No weakened tests. +152/-25 across 7 files; nothing is skipped, relaxed, or deleted, and the 25 deletions are the replaced assignment block and the two reflowed call sites.
Refresh hygiene. Byte-identical payload before and after the refresh (git diff bd42f172fcee...00ffb87461b4 equals git diff 1ee55e907aa2...766284d5e4a2), zero file overlap with the merged-in #19956 delta, no force-push, no AI co-author trailer in the range.
Merging at this exact head with --match-head-commit once the fresh hosted checks at it are terminal-green.
Summary
Backports merged #18970 so the existing per-send client_message_id reaches the turn POST and can join frontend sends to backend turns.
Changes
Review Focus
The two target conflicts were resolved by retaining cloud/1.55 immediate telemetry emission and adding only meta.clientMessageId as the final sendMessage argument. No telemetry timing, starter prompt, consent, billing, or backend behavior changes.
Verification:
Refresh onto the live release target
Refreshed from
00ffb87461b4dbc33908950d38053825f3528689ontocloud/1.55@1ee55e907aa28aac18a0998fbbf5015d6660a63dwith an exact lease (expected_head_sha), producing766284d5e4a2dd070f830f3922a6a7b97f6d4537. The refresh was a merge, not a rewrite: the original commit is still in the branch and no history was force-pushed.The delta that was merged in is #19956 (
FE-3174 fix(cloud): read the login free-runs offer from the server), which touchespackages/ingest-types/src/types.gen.ts,packages/ingest-types/src/zod.gen.ts,src/locales/en/main.json,src/platform/cloud/onboarding/CloudLoginView.vueandsrc/platform/cloud/onboarding/CloudLoginView.test.ts— zero overlap with this carrier's seven files.The refreshed payload is byte-identical to the pre-refresh payload:
git diff bd42f172fcee...00ffb87461b4andgit diff 1ee55e907aa2...766284d5e4a2are the same diff, 7 files, +152/-25. The refresh contributed no conflict resolution and no content of its own.Justification: Agent release-backport carrier merged under Christian's recorded September 16/20 release-backport authority, extended on September 27 to the 1.54 and 1.55 lines, which permits self-merge once this program's own gates pass; GitHub cannot accept an approval from a PR's own author, so no pre-merge approval record can exist for an author-owned carrier — risk is limited by the payload being byte-identical to already-merged source #18970, zero file overlap with the release-target delta, an additive optional wire field whose absence is a gap in a funnel read rather than a failed send, and a green
playwright-tests (cloud, frontend-dist-cloud)shard that actually executes the new@cloudwire-body assertion.