Repository navigation
[backport core/1.55] feat(telemetry): send client_message_id on the turn POST so the activation funnel joins (#18970) - #19995
Conversation
…ation funnel joins (#18970) `app:agent_message_sent` already carries a per-send `client_message_id`, but it never left the browser. The doc comment said so outright: > Minted client-side … **The backend does not receive it yet** — the turn POST contract carries no client id — so it dedups within the frontend stream rather than joining to the backend turn; `thread_id` is the join today. That is the reason the activation funnel's **message → turn** step is countable but not attributable. 606 frontend sends against 470 backend turn-starts on 2026-09-25 is a real gap as a count, but no individual message can be tied to the turn it started, so the gap cannot be explained and send latency has no instrument at all. Send the id on the turn POST. The server echoes it onto its own `agent_turn_started` event (Comfy-Org/cloud#10781), which then carries both that id and its `turn_id` — so the two event streams join at the step the funnel actually loses people at. **No new id is minted.** This is the value already reported on the analytics event, passed through to the request body. `AgentPanelRoot` hands the same `meta.clientMessageId` to both sinks. - **`thread_id`** is on the event already, but it is `null` for the first message in a thread — exactly the send that matters most to activation, and ~38% of sends on the current build. - **`turn_id`** cannot be used: the server mints it after the POST arrives, so it can never appear on a send-site event. The analytics event and the request body must carry the **same** value. If they ever diverge the join silently returns zero rows and nothing else fails — no error, no failed send, just an empty funnel. So there is a test that asserts equality across the two sinks in one send, which neither side's own test would catch. - `AgentPostMessageRequest` is widened locally at its one construction site, because the generated type is published from the cloud repo's `openapi.yaml`. One line to delete once the published type carries the field. - `postMessage`'s optional-field copying becomes a single `withoutUndefined()` build rather than a tenth sequential `if (x !== undefined)`. Same wire output — keys whose value is `undefined` are omitted, and `false`/`0` survive, so `current_tab_unbound: false` still sends. This keeps the added field from pushing the function past the repo's complexity gate, and two existing tests pin the omit-absent-optionals behaviour. - The stale doc comment on `AgentMessageSentMetadata.client_message_id` is corrected, since it asserted the opposite of what now happens. ``` pnpm typecheck # clean npx vitest run src/workbench/extensions/agent/ src/platform/telemetry/ pnpm knip && pnpm fallow:audit # clean, no new findings ``` New coverage: `client_message_id` reaches the wire; it is omitted when the caller has none; and the posted value equals the reported one. Additive and independently shippable in either order. An older server ignores the field (ingest proxies the body verbatim; Echo's `Bind` drops unknown keys), and an older client simply sends nothing — which reads as *unknown* for that turn, never as a failed send.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2148 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3d205e5ebf8dc59e7ee9986fbef916bfa969b422
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-03T20:29:40.506Z",
"gitSha": "eac90daa4571585561024f65a4bf607f0b412dc3",
"branch": "backport-18970-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2019.738000000018,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.996000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.41800000000006,
"heapDeltaBytes": -8479100,
"heapUsedBytes": 60100632,
"domNodes": -255,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.456999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1990.82999999996,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.941999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.959,
"heapDeltaBytes": -2022280,
"heapUsedBytes": 66540036,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.326,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.94600000002,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.054000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.698,
"heapDeltaBytes": -6992600,
"heapUsedBytes": 61752648,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 104.66300000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.7690000000803,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.909,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 630.788,
"heapDeltaBytes": 9190228,
"heapUsedBytes": 77898568,
"domNodes": -260,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 108.21,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1696.570999999949,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.938999999999998,
"layouts": 6,
"layoutDurationMs": 1.0639999999999998,
"taskDurationMs": 278.539,
"heapDeltaBytes": 3014756,
"heapUsedBytes": 71518268,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.169,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.9710000000568,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.030999999999999,
"layouts": 6,
"layoutDurationMs": 1.183,
"taskDurationMs": 276.393,
"heapDeltaBytes": 3009000,
"heapUsedBytes": 71977332,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.135000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 543.9099999999826,
"styleRecalcs": 16,
"styleRecalcDurationMs": 7.017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.802,
"heapDeltaBytes": -7934404,
"heapUsedBytes": 60960208,
"domNodes": 24,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 120.78300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 536.0150000000203,
"styleRecalcs": 16,
"styleRecalcDurationMs": 7.186000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.543,
"heapDeltaBytes": 17807348,
"heapUsedBytes": 86494436,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 118.967,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1047.963999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 705.4209999999999,
"heapDeltaBytes": -13303604,
"heapUsedBytes": 73113264,
"domNodes": -295,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 42.272000000000006,
"eventListeners": -217,
"totalBlockingTimeMs": 402,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1066.2980000000744,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.2809999999998,
"heapDeltaBytes": -17791396,
"heapUsedBytes": 72881336,
"domNodes": -290,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 48.624,
"eventListeners": -217,
"totalBlockingTimeMs": 420,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 731.8490000000111,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.13899999999995,
"heapDeltaBytes": 14817992,
"heapUsedBytes": 90558860,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.68400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 114,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 749.0060000000085,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.79299999999967,
"heapDeltaBytes": 14805260,
"heapUsedBytes": 90133516,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.462,
"eventListeners": 0,
"totalBlockingTimeMs": 116,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7393.24700000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6531.6939999999995,
"heapDeltaBytes": 6937316,
"heapUsedBytes": 86813768,
"domNodes": -276,
"jsHeapTotalBytes": 9691136,
"scriptDurationMs": 5194.452,
"eventListeners": -174,
"totalBlockingTimeMs": 82,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6159.9200000000565,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.10999999999999899,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5356.384,
"heapDeltaBytes": -10981548,
"heapUsedBytes": 70003364,
"domNodes": 2,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 4326.169,
"eventListeners": 0,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6504.1319999999705,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5749.7119999999995,
"heapDeltaBytes": -780056,
"heapUsedBytes": 72872172,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 4501.713,
"eventListeners": 0,
"totalBlockingTimeMs": 21,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6303.14999999996,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.805000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5657.532,
"heapDeltaBytes": -2003924,
"heapUsedBytes": 76590740,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 4433.923,
"eventListeners": -174,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2009.8890000000438,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.265,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.947,
"heapDeltaBytes": -23818640,
"heapUsedBytes": 65419364,
"domNodes": -255,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 29.334000000000007,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.539999999949,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.880999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.01899999999995,
"heapDeltaBytes": 4169172,
"heapUsedBytes": 87125188,
"domNodes": -258,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 28.708,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2153.5880000000134,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.07,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1266.2230000000002,
"heapDeltaBytes": -1885272,
"heapUsedBytes": 88316412,
"domNodes": -250,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 627.199,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2154.6560000000454,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.918,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1253.9009999999998,
"heapDeltaBytes": -3555312,
"heapUsedBytes": 79861960,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 626.9030000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3216.107000000079,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.031,
"layouts": 60,
"layoutDurationMs": 13.947000000000001,
"taskDurationMs": 1336.589,
"heapDeltaBytes": -223132,
"heapUsedBytes": 65437200,
"domNodes": 32,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 609.592,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3255.478000000039,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.071,
"layouts": 60,
"layoutDurationMs": 14.305,
"taskDurationMs": 1268.2579999999998,
"heapDeltaBytes": 661664,
"heapUsedBytes": 65935980,
"domNodes": 38,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 622.4390000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2201.44700000003,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.511999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1371.0370000000003,
"heapDeltaBytes": 4469064,
"heapUsedBytes": 72361676,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 699.707,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2283.093000000008,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.651000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1457.294,
"heapDeltaBytes": 12863548,
"heapUsedBytes": 98998640,
"domNodes": 16,
"jsHeapTotalBytes": 6221824,
"scriptDurationMs": 739.144,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2023.8400000000638,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.1659999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.50400000000013,
"heapDeltaBytes": -23844832,
"heapUsedBytes": 65939504,
"domNodes": -256,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 32.129999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2003.9890000000469,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.983000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.096,
"heapDeltaBytes": 9497152,
"heapUsedBytes": 73999852,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.245,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 500.92499999993834,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.885,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.5330000000001,
"heapDeltaBytes": 13547300,
"heapUsedBytes": 84125992,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 106.64,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 521.4330000000018,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.07,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.54400000000004,
"heapDeltaBytes": 13218400,
"heapUsedBytes": 83773712,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 104.568,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.8310000000238,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.319000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.70599999999996,
"heapDeltaBytes": -4258064,
"heapUsedBytes": 59751792,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.7509999999999994,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1991.4679999999407,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.735999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.954,
"heapDeltaBytes": -14823540,
"heapUsedBytes": 55552664,
"domNodes": -273,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.151,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.9349999999677,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.031,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.841,
"heapDeltaBytes": 8222432,
"heapUsedBytes": 78642484,
"domNodes": -271,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 74.066,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.0570000000962,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.081,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.2429999999999,
"heapDeltaBytes": 4360944,
"heapUsedBytes": 75141932,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 75.683,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 883.0070000000205,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.927999999999997,
"layouts": 5,
"layoutDurationMs": 13.318999999999999,
"taskDurationMs": 694.9799999999999,
"heapDeltaBytes": 20180068,
"heapUsedBytes": 103197512,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 22.365999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 117,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8147.800999999959,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.711999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4386.035,
"heapDeltaBytes": -4090760,
"heapUsedBytes": 84378880,
"domNodes": -245,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 2131.1270000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8147.869000000014,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.638999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4284.308999999999,
"heapDeltaBytes": -16087224,
"heapUsedBytes": 66517456,
"domNodes": -258,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 2060.958,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12572.185999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11994.548000000003,
"heapDeltaBytes": -60162280,
"heapUsedBytes": 169234628,
"domNodes": -8062,
"jsHeapTotalBytes": -21991424,
"scriptDurationMs": 183.347,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12617.350999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12092.607999999998,
"heapDeltaBytes": -52148748,
"heapUsedBytes": 182892656,
"domNodes": -8062,
"jsHeapTotalBytes": -16637952,
"scriptDurationMs": 207.90400000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15388.305000000058,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.53299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15027.098,
"heapDeltaBytes": -45007980,
"heapUsedBytes": 167718092,
"domNodes": -8062,
"jsHeapTotalBytes": -9420800,
"scriptDurationMs": 794.978,
"eventListeners": -14928,
"totalBlockingTimeMs": 69,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15305.659999999989,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.724999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14888.175000000001,
"heapDeltaBytes": -67511540,
"heapUsedBytes": 167695132,
"domNodes": -8062,
"jsHeapTotalBytes": -14540800,
"scriptDurationMs": 768.6729999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4535.963000000038,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.87599999999999,
"layouts": 20,
"layoutDurationMs": 23.13,
"taskDurationMs": 4456.554999999999,
"heapDeltaBytes": -44975376,
"heapUsedBytes": 190327964,
"domNodes": -8062,
"jsHeapTotalBytes": 8265728,
"scriptDurationMs": 96.304,
"eventListeners": -14928,
"totalBlockingTimeMs": 178,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4583.04099999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.46100000000001,
"layouts": 20,
"layoutDurationMs": 22.169000000000008,
"taskDurationMs": 4484.259,
"heapDeltaBytes": -46148720,
"heapUsedBytes": 189083864,
"domNodes": -8062,
"jsHeapTotalBytes": 13508608,
"scriptDurationMs": 80.258,
"eventListeners": -14928,
"totalBlockingTimeMs": 54,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6353.946999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6042.3369999999995,
"heapDeltaBytes": -28384816,
"heapUsedBytes": 164145608,
"domNodes": 0,
"jsHeapTotalBytes": -17039360,
"scriptDurationMs": 103.03499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6328.988999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5998.486000000002,
"heapDeltaBytes": -1787908,
"heapUsedBytes": 182680220,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 92.23500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 85.4340000000775,
"styleRecalcs": 5,
"styleRecalcDurationMs": 12.494,
"layouts": 3,
"layoutDurationMs": 2.3899999999999997,
"taskDurationMs": 66.187,
"heapDeltaBytes": 3123812,
"heapUsedBytes": 69093192,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.450999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 80.9479999999212,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.754000000000001,
"layouts": 3,
"layoutDurationMs": 1.249,
"taskDurationMs": 54.166000000000004,
"heapDeltaBytes": 2978788,
"heapUsedBytes": 69248604,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.478999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #19995 +/- ##
============================================
Coverage 84.79% 84.79%
============================================
Files 2327 2327
Lines 132681 132672 -9
Branches 33590 35480 +1890
============================================
- Hits 112503 112499 -4
+ Misses 19818 19813 -5
Partials 360 360
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the exact refreshed backport head 046b5cd against source #18970 and core/1.55. The binding target-aware gate reports the target tip as an ancestor, 104 completed checks with success/neutral/skipped outcomes only, fresh receipts after the target tip, and no unresolved review threads or later human objections. Landing under the standing Agent 1.55 backport grant recorded in program/release-backport-authority.md; this is an honest COMMENT review, not a manufactured self-approval.
Backports #18970 to
core/1.55after the canonical cherry-pick conflicted.Preserves the target branch’s direct send telemetry, abort-error handling, and existing request behavior while transporting the already-minted
client_message_idthrough the session to the turn POST.Validation:
pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts src/workbench/extensions/agent/services/agent/agentRestClient.test.ts --testTimeout=30000(396 passed)NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheckpnpm knippnpm exec fallow audit --root . --quiet --format json --changed-since comfyorg/core/1.55(pass; zero introduced findings)The focused browser spec was attempted through
pnpm test:browser:local, but this lane has no Comfy backend/dev server on ports 8188/5173; all cases stopped in fixture setup withECONNREFUSEDbefore application code. PR CI is the browser proof.