Skip to content

[backport cloud/1.54] feat(telemetry): send client_message_id on the turn POST so the activation funnel joins - #19992

Merged
christian-byrne merged 2 commits into
cloud/1.54from
backport-18970-to-cloud-1.54
Oct 3, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
backport-18970-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #18970 to cloud/1.54

Automatically created by backport workflow.

…ation funnel joins (#18970)

## Why

`app:agent_message_sent` already carries a per-send `client_message_id`,
but it never left the browser. The doc comment said so outright:

> Minted client-side … **The backend does not receive it yet** — the
turn POST contract carries no client id — so it dedups within the
frontend stream rather than joining to the backend turn; `thread_id` is
the join today.

That is the reason the activation funnel's **message → turn** step is
countable but not attributable. 606 frontend sends against 470 backend
turn-starts on 2026-09-25 is a real gap as a count, but no individual
message can be tied to the turn it started, so the gap cannot be
explained and send latency has no instrument at all.

## What

Send the id on the turn POST. The server echoes it onto its own
`agent_turn_started` event (Comfy-Org/cloud#10781), which then carries
both that id and its `turn_id` — so the two event streams join at the
step the funnel actually loses people at.

**No new id is minted.** This is the value already reported on the
analytics event, passed through to the request body. `AgentPanelRoot`
hands the same `meta.clientMessageId` to both sinks.

## Why this id, and not the two that already exist

- **`thread_id`** is on the event already, but it is `null` for the
first message in a thread — exactly the send that matters most to
activation, and ~38% of sends on the current build.
- **`turn_id`** cannot be used: the server mints it after the POST
arrives, so it can never appear on a send-site event.

## The invariant worth a test

The analytics event and the request body must carry the **same** value.
If they ever diverge the join silently returns zero rows and nothing
else fails — no error, no failed send, just an empty funnel. So there is
a test that asserts equality across the two sinks in one send, which
neither side's own test would catch.

## Notes for review

- `AgentPostMessageRequest` is widened locally at its one construction
site, because the generated type is published from the cloud repo's
`openapi.yaml`. One line to delete once the published type carries the
field.
- `postMessage`'s optional-field copying becomes a single
`withoutUndefined()` build rather than a tenth sequential `if (x !==
undefined)`. Same wire output — keys whose value is `undefined` are
omitted, and `false`/`0` survive, so `current_tab_unbound: false` still
sends. This keeps the added field from pushing the function past the
repo's complexity gate, and two existing tests pin the
omit-absent-optionals behaviour.
- The stale doc comment on `AgentMessageSentMetadata.client_message_id`
is corrected, since it asserted the opposite of what now happens.

## Tests

```
pnpm typecheck                                         # clean
npx vitest run src/workbench/extensions/agent/ src/platform/telemetry/
#  176 files · 2895 passed · 17 expected fail
pnpm knip && pnpm fallow:audit                         # clean, no new findings
```

New coverage: `client_message_id` reaches the wire; it is omitted when
the caller has none; and the posted value equals the reported one.

## Compatibility

Additive and independently shippable in either order. An older server
ignores the field (ingest proxies the body verbatim; Echo's `Bind` drops
unknown keys), and an older client simply sends nothing — which reads as
*unknown* for that turn, never as a failed send.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Oct 3, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) October 3, 2026 07:06
@vercel

vercel Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 3, 2026 8:55am UTC
billing-web-test Ignored Ignored Oct 3, 2026 8:55am UTC

Request Review

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/03/2026, 08:57:32 AM UTC

Links

🎭 Playwright: ✅ 1988 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1967 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 140ms TBT · 82.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.8 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 118ms TBT · 176.4 MB heap
vue-node-resize-workload: · 52.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 495ms TBT · 181.2 MB heap
vue-zoom-out-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 178.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 581ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.8 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -196
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 917ms
canvas-mouse-sweep: script duration 170ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.7 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 359ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.9 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 463ms
dom-widget-clipping: script duration 169ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 61.1 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 590ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 85.8 MB
large-graph-idle: DOM nodes -282
large-graph-idle: event listeners -194
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1664ms
large-graph-pan: script duration 864ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.8 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 1691ms
large-graph-zoom: script duration 804ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 64.3 MB
large-graph-zoom: DOM nodes -120
large-graph-zoom: event listeners -94
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1965ms
legacy-node-drag: script duration 1031ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 75.8 MB
legacy-node-drag: DOM nodes -145
legacy-node-drag: event listeners -4
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 568ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 79.7 MB
minimap-idle: DOM nodes -279
minimap-idle: event listeners -178
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 416ms
subgraph-dom-widget-clipping: script duration 144ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 85.2 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 535ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.1 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 26ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 817ms
subgraph-mouse-sweep: script duration 111ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.9 MB
subgraph-mouse-sweep: DOM nodes -298
subgraph-mouse-sweep: event listeners -210
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 909ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 140ms
subgraph-transition-enter: heap used 82.3 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5560ms
viewport-pan-sweep: script duration 2769ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 69.2 MB
viewport-pan-sweep: DOM nodes -278
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16501ms
vue-large-graph-idle: script duration 288ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 173.8 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14930
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 22ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 174
vue-large-graph-pan: task duration 21814ms
vue-large-graph-pan: script duration 985ms
vue-large-graph-pan: TBT 118ms
vue-large-graph-pan: heap used 176.4 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14926
vue-node-resize-workload: avg frame time 19ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 28ms
vue-node-resize-workload: style recalc duration 87ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6427ms
vue-node-resize-workload: script duration 121ms
vue-node-resize-workload: TBT 495ms
vue-node-resize-workload: heap used 181.2 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8672ms
vue-zoom-out-idle: script duration 146ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 178.6 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 3
workflow-execution: style recalc count 12
workflow-execution: task duration 105ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.2 MB
workflow-execution: DOM nodes 136
workflow-execution: event listeners 41
Raw data
{
  "timestamp": "2026-10-03T09:07:17.087Z",
  "gitSha": "0cb305d5753e51196a0770d44975243528b30df9",
  "branch": "backport-18970-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2188.1340000000478,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.299,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 654.749,
      "heapDeltaBytes": -9170880,
      "heapUsedBytes": 64070540,
      "domNodes": -281,
      "jsHeapTotalBytes": 4231168,
      "scriptDurationMs": 12.671999999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2080.7060000000774,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.599,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 506.71600000000007,
      "heapDeltaBytes": -5952168,
      "heapUsedBytes": 65538568,
      "domNodes": -282,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 8.097999999999997,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1922.8370000000155,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 35.488,
      "layouts": 14,
      "layoutDurationMs": 4.1,
      "taskDurationMs": 970.6469999999999,
      "heapDeltaBytes": 7789052,
      "heapUsedBytes": 79379352,
      "domNodes": -279,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 176.06900000000002,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1819.439999999986,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 25.999000000000002,
      "layouts": 14,
      "layoutDurationMs": 3.9960000000000004,
      "taskDurationMs": 864.0360000000001,
      "heapDeltaBytes": -8800660,
      "heapUsedBytes": 62555636,
      "domNodes": -281,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 163.926,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1720.2580000000012,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.282999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.009,
      "taskDurationMs": 371.459,
      "heapDeltaBytes": 4933128,
      "heapUsedBytes": 79104396,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.56,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1682.068000000072,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.402,
      "layouts": 6,
      "layoutDurationMs": 1.0830000000000002,
      "taskDurationMs": 347.071,
      "heapDeltaBytes": 4468172,
      "heapUsedBytes": 75971908,
      "domNodes": 79,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 9.672,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 695.2180000000112,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.809000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 470.341,
      "heapDeltaBytes": -7079156,
      "heapUsedBytes": 64991036,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 170.89,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 658.9620000000878,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.627999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.094,
      "heapDeltaBytes": -7737220,
      "heapUsedBytes": 63056600,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 166.44799999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.0580000000155,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.425000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 585.6080000000002,
      "heapDeltaBytes": 11714544,
      "heapUsedBytes": 89044784,
      "domNodes": -281,
      "jsHeapTotalBytes": -364544,
      "scriptDurationMs": 32.711000000000006,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.8649999999634,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.824000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 594.6740000000001,
      "heapDeltaBytes": 13298396,
      "heapUsedBytes": 90908040,
      "domNodes": -282,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 34.702,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2380.3680000000327,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.501999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1662.0759999999998,
      "heapDeltaBytes": 10878488,
      "heapUsedBytes": 89681280,
      "domNodes": -281,
      "jsHeapTotalBytes": 385024,
      "scriptDurationMs": 864.206,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2382.8929999999673,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.521,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1665.1419999999998,
      "heapDeltaBytes": -562332,
      "heapUsedBytes": 77736856,
      "domNodes": -285,
      "jsHeapTotalBytes": 3530752,
      "scriptDurationMs": 862.943,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3543.0470000000014,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.783000000000001,
      "layouts": 60,
      "layoutDurationMs": 11.716,
      "taskDurationMs": 1667.3939999999998,
      "heapDeltaBytes": 173024,
      "heapUsedBytes": 67977984,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 801.608,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3590.440000000058,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.37,
      "layouts": 60,
      "layoutDurationMs": 12.325,
      "taskDurationMs": 1714.387,
      "heapDeltaBytes": -13192024,
      "heapUsedBytes": 66848548,
      "domNodes": -264,
      "jsHeapTotalBytes": 3567616,
      "scriptDurationMs": 805.61,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3186.419000000001,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.177000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1929.7019999999998,
      "heapDeltaBytes": 3829836,
      "heapUsedBytes": 73896004,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 1037.304,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3232.8509999999824,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 9.384,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2000.2489999999998,
      "heapDeltaBytes": 2469284,
      "heapUsedBytes": 85068280,
      "domNodes": -289,
      "jsHeapTotalBytes": 3985408,
      "scriptDurationMs": 1024.497,
      "eventListeners": -195,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.2189999999932,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.7399999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 605.1410000000001,
      "heapDeltaBytes": 10133716,
      "heapUsedBytes": 90010388,
      "domNodes": -283,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 37.928000000000004,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.28599999998,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.5020000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.7080000000001,
      "heapDeltaBytes": -5643844,
      "heapUsedBytes": 77084080,
      "domNodes": -275,
      "jsHeapTotalBytes": -2322432,
      "scriptDurationMs": 30.108000000000004,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 606.5580000000068,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.093,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.613,
      "heapDeltaBytes": 14184152,
      "heapUsedBytes": 89951288,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 141.234,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.1950000000234,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.591999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.697,
      "heapDeltaBytes": 15182656,
      "heapUsedBytes": 88650116,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 146.91400000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.448999999985,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.754,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 554.123,
      "heapDeltaBytes": -9824620,
      "heapUsedBytes": 63684716,
      "domNodes": -297,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 10.982000000000001,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.1299999999947,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 11.211999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 516.4,
      "heapDeltaBytes": -8805640,
      "heapUsedBytes": 66593412,
      "domNodes": -295,
      "jsHeapTotalBytes": 3706880,
      "scriptDurationMs": 7.980000000000001,
      "eventListeners": -208,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1788.786000000016,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 26.722,
      "layouts": 18,
      "layoutDurationMs": 4.606,
      "taskDurationMs": 843.927,
      "heapDeltaBytes": -7558840,
      "heapUsedBytes": 65800944,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 113.99599999999998,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1691.915999999992,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 24.298000000000002,
      "layouts": 18,
      "layoutDurationMs": 4.686999999999999,
      "taskDurationMs": 790.3849999999999,
      "heapDeltaBytes": -13863860,
      "heapUsedBytes": 61890020,
      "domNodes": -299,
      "jsHeapTotalBytes": 5017600,
      "scriptDurationMs": 107.956,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.6329999999707,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 31.955,
      "layouts": 14,
      "layoutDurationMs": 15.480000000000004,
      "taskDurationMs": 908.7350000000001,
      "heapDeltaBytes": -5150264,
      "heapUsedBytes": 86312936,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 31.116999999999997,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8321.36399999996,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.58,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5607.505,
      "heapDeltaBytes": 581520,
      "heapUsedBytes": 77968180,
      "domNodes": -283,
      "jsHeapTotalBytes": 3792896,
      "scriptDurationMs": 2785.949,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8302.70299999995,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 32.641,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5512.616999999999,
      "heapDeltaBytes": 1503960,
      "heapUsedBytes": 67110444,
      "domNodes": -273,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 2753.006,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17999.537000000033,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17173.770999999997,
      "heapDeltaBytes": -40068348,
      "heapUsedBytes": 182462296,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9183232,
      "scriptDurationMs": 298.912,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16705.041000000052,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15827.369999999999,
      "heapDeltaBytes": -36657180,
      "heapUsedBytes": 181978024,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11808768,
      "scriptDurationMs": 276.77000000000004,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20996.034000000007,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 18.220000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20581.926,
      "heapDeltaBytes": -38034180,
      "heapUsedBytes": 184667160,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16592896,
      "scriptDurationMs": 912.6410000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 80,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23325.404999999933,
      "styleRecalcs": 178,
      "styleRecalcDurationMs": 25.886999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23046.151,
      "heapDeltaBytes": -32463472,
      "heapUsedBytes": 185260852,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9490432,
      "scriptDurationMs": 1056.458,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 155,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6262.76699999994,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 86.50199999999997,
      "layouts": 20,
      "layoutDurationMs": 24.493000000000002,
      "taskDurationMs": 6123.244,
      "heapDeltaBytes": -39663752,
      "heapUsedBytes": 183028744,
      "domNodes": -8068,
      "jsHeapTotalBytes": 13361152,
      "scriptDurationMs": 110.91299999999998,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 509,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6810.284000000024,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 86.52299999999997,
      "layouts": 20,
      "layoutDurationMs": 30.74199999999999,
      "taskDurationMs": 6731.168000000001,
      "heapDeltaBytes": -9865240,
      "heapUsedBytes": 197044716,
      "domNodes": -8068,
      "jsHeapTotalBytes": 15978496,
      "scriptDurationMs": 130.64199999999997,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 480,
      "frameDurationMs": 18.886666666666617,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8373.841000000084,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7993.815999999999,
      "heapDeltaBytes": 16011944,
      "heapUsedBytes": 180625940,
      "domNodes": 0,
      "jsHeapTotalBytes": -7340032,
      "scriptDurationMs": 125.59600000000005,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9555.862000000048,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9349.743,
      "heapDeltaBytes": 25084884,
      "heapUsedBytes": 193838192,
      "domNodes": 0,
      "jsHeapTotalBytes": -3145728,
      "scriptDurationMs": 166.65099999999998,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 488.7820000000147,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 21.822999999999997,
      "layouts": 4,
      "layoutDurationMs": 1.94,
      "taskDurationMs": 122.025,
      "heapDeltaBytes": 5049552,
      "heapUsedBytes": 74654728,
      "domNodes": 143,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.781999999999998,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 125.49200000000837,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 17.833,
      "layouts": 2,
      "layoutDurationMs": 1.563,
      "taskDurationMs": 87.74100000000001,
      "heapDeltaBytes": 3001576,
      "heapUsedBytes": 72638228,
      "domNodes": 128,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.655000000000002,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51043 76357 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from ryan-di October 3, 2026 07:07
@christian-byrne
christian-byrne removed the request for review from benceruleanlu October 3, 2026 07:07
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 3, 2026
@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19992   +/-   ##
=============================================
  Coverage              ?   84.25%           
=============================================
  Files                 ?     2131           
  Lines                 ?   127962           
  Branches              ?    34455           
=============================================
  Hits                  ?   107809           
  Misses                ?    19972           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.90% <ø> (?)
unit 79.54% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/telemetry/types.ts 92.59% <ø> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 92.30% <100.00%> (ø)
...ensions/agent/composables/agent/useAgentSession.ts 98.68% <ø> (ø)
...extensions/agent/services/agent/agentRestClient.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne removed the request for review from ryan-di October 3, 2026 08:32
@github-actions
github-actions Bot requested a review from ryan-di October 3, 2026 08:37
@christian-byrne

Copy link
Copy Markdown
Contributor

Taking over this inactive bot-owned release carrier under the Agent backport authority to refresh it onto the current cloud/1.54 tip, rerun target-native acceptance and the exact-head gate, and land it only if every gate remains satisfied. Canonical row and PR lease: op356-fe19992-refreshrepair.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete refreshed diff at 25706b0ca8fc75508f6bab3efc20b255417a56b6 under the Agent cloud/1.54 backport grant. The merge-only refresh incorporates target tip 0818279 without changing the seven-file source patch. Verified locally at this exact head: NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts src/workbench/extensions/agent/services/agent/agentRestClient.test.ts (434/434 passed), and the target-native cloud Playwright case browser_tests/tests/agent/agentActivationConsent.spec.ts (7/7 passed, isolated backend/frontend ports). No defect or unresolved objection found. Hosted exact-head checks and the target-aware merge gate remain required before landing.

@christian-byrne
christian-byrne merged commit 26404a6 into cloud/1.54 Oct 3, 2026
96 checks passed
@christian-byrne
christian-byrne deleted the backport-18970-to-cloud-1.54 branch October 3, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants