Repository navigation
fix(settings): keep the Settings dialog inside the workspace inset #19972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2026bc8
fix(settings): keep the Settings dialog inside the workspace inset
Glary-Bot 2335fd9
test(settings): lock the sm: max-width cap against tailwind-merge
Glary-Bot fc46385
fix(settings): correct the sm: cap note and pin the base cap in tests
Glary-Bot 7e52e65
test(settings): pin the workspace-aware centering the cap depends on
Glary-Bot 7ebcb86
test(settings): fold the raw-class cap checks into the resolved asser…
Glary-Bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix this more fundamentally when I get to this section of the design system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed — this is a per-call-site patch, not a structural fix. Left the code as-is.
I filed FE-3189 for exactly that structural work, with the two root causes already pinned down so you don't have to re-derive them:
The variant caps have no lower bound.
dialog.variants.ts:8-12sizes every dialog asmax-w-[min(<size>,calc(100vw-var(--workspace-inset-right,0px)-1rem))], and thatcalctracks the workspace all the way to zero. Load3D, Asset Browser, Share and now Settings all inherit it.The dialog interior is keyed to the window, not the dialog.
BaseModalLayout.vue:185resolvesBREAKPOINTS = { md: 880 }throughwindow.matchMedia, and the left nav is a fixed14remtrack. Before the inset cap, box width and window width agreed; now the box tracks100vw − insetand the two can diverge by the full panel width, so the nav stays open inside a much narrower dialog.Worst case I measured: viewport 1200, panel maximized to 960, sidebar closed —
isOverlaydoesn't trigger (reservedWorkspaceWidthfloors at 56 when the sidebar is closed), so the workspace is 240px and the content column collapses behind the 224px nav.Two things worth folding into that pass while you're in there:
w-[90vw] max-w-[1400px] sm:max-w-[1400px]andmax-w-[1724px]respectively.useWorkflowTemplateSelectorDialog.tseven comments "Size it like the other large dialogs (Settings/Manager)", so it propagated by imitation. A variant-level fix covers all three at once.For the record on this PR: I did try a lower bound here (
min(1280px,max(20rem,calc(…)))) and backed it out — it bought ~33px of content column but reintroduced a 10px overflow on both sides, which is the defect this PR exists to remove. Seemed better to keep the call site consistent with the shared pattern and let the fix land at the variant level.