Repository navigation
test: flag redundant per-mock cleanup in Vitest hooks #19969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f0a78b8
b216fe0
8ec554b
e5530ed
9f0feb1
ac62d39
cb4ae91
65e45ae
af3b526
51a15c1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,7 +75,6 @@ describe('reportAshbyOutcome', () => { | |
| }) | ||
|
|
||
| afterEach(() => { | ||
| writeSpy.mockRestore() | ||
| rmSync(summaryDir, { recursive: true, force: true }) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟢 Low — |
||
| if (originalSummary === undefined) delete process.env.GITHUB_STEP_SUMMARY | ||
| else process.env.GITHUB_STEP_SUMMARY = originalSummary | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ Nit —
vitest.*.mtsis the only pattern in this override without a**/prefix, so unlike its**/vite.config.*and**/vitest.config.*siblings it matches root-level files only. A package- or app-level Vitest config fragment declaringmockReset: truewould then fail the repo-wideno-vitest-mock-method-nameserror. Raised by 2 of 8 reviewers (kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).