Repository navigation
refactor(i18n): resolve generated namespaces in no-missing-keys instead of exempting call sites - #19961
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (2)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe ESLint configuration now uses the English main locale and generated messages, and removes missing-key suppressions. Settings switches now receive tooltip translation keys directly instead of computed values. Changesi18n lint configuration
Settings tooltip bindings
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to The changes preserve the settings tooltips and make generated English namespaces available to the missing-key rule. No merge-blocking issue was identified. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0b7c7f4291b93459c78e82935152f00292e532aa
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2186 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 10.1 MB gzipDetailsSummary
Category Glance App Entry Points — 3.89 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.47 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 135 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 646 kBConfiguration panels, inspectors, and settings screens
Status: 28 added User & Accounts — 53.6 kBAuthentication, profile, and account management bundles
Status: 15 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 184 kBReusable component library chunks
Status: 18 added Data & Services — 4.15 MBStores, services, APIs, and repositories
Status: 14 added Utilities & Hooks — 586 kBHelpers, composables, and utility bundles
Status: 38 added Vendor & Third-Party — 17.2 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 18.3 MBBundles that do not match a named category
Status: 305 added ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-02T23:28:29.544Z",
"gitSha": "81bfba848db4f6315b453f6d793a8cec61f78f8c",
"branch": "drjkl/i18n-no-missing-keys-namespaces",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.3140000000135,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.005999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.054,
"heapDeltaBytes": -27630500,
"heapUsedBytes": 75160828,
"domNodes": -232,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 12.033999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2010.5399999999918,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.862,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.498,
"heapDeltaBytes": 22360656,
"heapUsedBytes": 76208496,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.305000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1761.6989999999646,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.395000000000003,
"layouts": 12,
"layoutDurationMs": 4.8950000000000005,
"taskDurationMs": 778.328,
"heapDeltaBytes": -2977044,
"heapUsedBytes": 65137280,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 154.932,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1753.467999999998,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.72,
"layouts": 12,
"layoutDurationMs": 4.375,
"taskDurationMs": 809.45,
"heapDeltaBytes": 20030244,
"heapUsedBytes": 79670472,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 154.462,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.3080000000173,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.506,
"layouts": 6,
"layoutDurationMs": 1.237,
"taskDurationMs": 354.569,
"heapDeltaBytes": 3275012,
"heapUsedBytes": 71753788,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.322000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.805999999934,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.14,
"layouts": 6,
"layoutDurationMs": 1.3250000000000002,
"taskDurationMs": 341.83400000000006,
"heapDeltaBytes": 25370496,
"heapUsedBytes": 78561120,
"domNodes": -179,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.142999999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 699.4540000000029,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8249999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.98300000000006,
"heapDeltaBytes": 15205548,
"heapUsedBytes": 69049320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.159,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 740.976000000046,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.947000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.257,
"heapDeltaBytes": -8062684,
"heapUsedBytes": 59127672,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.61499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1116.5960000000155,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 741.561,
"heapDeltaBytes": 38706536,
"heapUsedBytes": 107831668,
"domNodes": 0,
"jsHeapTotalBytes": 6979584,
"scriptDurationMs": 64.98599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 503,
"frameDurationMs": 33.839393939393965,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1133.1149999999752,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 789.3710000000001,
"heapDeltaBytes": 15235004,
"heapUsedBytes": 83871176,
"domNodes": 0,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 63.167,
"eventListeners": 0,
"totalBlockingTimeMs": 505,
"frameDurationMs": 33.3294117647059,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.2069999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.63299999999987,
"heapDeltaBytes": 17641072,
"heapUsedBytes": 104792932,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 147.21200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.1310000000904,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.0400000000005,
"heapDeltaBytes": -6374656,
"heapUsedBytes": 91795220,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 152.099,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9092.775999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8185.765,
"heapDeltaBytes": -9706220,
"heapUsedBytes": 68312644,
"domNodes": -142,
"jsHeapTotalBytes": -4067328,
"scriptDurationMs": 6665.647,
"eventListeners": -78,
"totalBlockingTimeMs": 458,
"frameDurationMs": 31.869824561403508,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8574.790000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7749.916,
"heapDeltaBytes": 18614980,
"heapUsedBytes": 93300440,
"domNodes": 0,
"jsHeapTotalBytes": -11010048,
"scriptDurationMs": 6271.602000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 152,
"frameDurationMs": 30.057192982456144,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8738.239000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8036.961999999999,
"heapDeltaBytes": 13562228,
"heapUsedBytes": 94005504,
"domNodes": 0,
"jsHeapTotalBytes": -7864320,
"scriptDurationMs": 6479.337,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 31.872262773722635,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8648.072999999953,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8489999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7952.94,
"heapDeltaBytes": 25681460,
"heapUsedBytes": 94298884,
"domNodes": -142,
"jsHeapTotalBytes": -4591616,
"scriptDurationMs": 6469.323,
"eventListeners": -70,
"totalBlockingTimeMs": 178,
"frameDurationMs": 31.278623188405795,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2065.127000000018,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.343999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.1179999999999,
"heapDeltaBytes": -52419640,
"heapUsedBytes": 72471152,
"domNodes": -328,
"jsHeapTotalBytes": -1933312,
"scriptDurationMs": 34.452000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.7469999999948,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.720000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.09999999999997,
"heapDeltaBytes": 14706920,
"heapUsedBytes": 92587736,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 35.038000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2177.5499999999965,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.012999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1468.185,
"heapDeltaBytes": 1124316,
"heapUsedBytes": 64187776,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 765.206,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615384615385,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2216.7480000000523,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.135,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1466.803,
"heapDeltaBytes": 1491216,
"heapUsedBytes": 64239820,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 763.967,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79097744360902,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3594.9130000000196,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.142999999999999,
"layouts": 60,
"layoutDurationMs": 14.897999999999998,
"taskDurationMs": 1648.9389999999999,
"heapDeltaBytes": 1013900,
"heapUsedBytes": 65876052,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 809.881,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3658.4699999999657,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.41,
"layouts": 60,
"layoutDurationMs": 15.873000000000001,
"taskDurationMs": 1731.9260000000002,
"heapDeltaBytes": -19687072,
"heapUsedBytes": 70548596,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 854.6969999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662100456621,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3120.830999999953,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.252000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1939.362,
"heapDeltaBytes": 11341056,
"heapUsedBytes": 76782120,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 1074.468,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75675675675676,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3139.0460000000076,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.840999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1889.446,
"heapDeltaBytes": 3647600,
"heapUsedBytes": 68853976,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1013.4699999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84438502673797,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.8590000000013,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8270000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.02,
"heapDeltaBytes": 10189488,
"heapUsedBytes": 76152240,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.696,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.745000000019,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.882,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.8670000000001,
"heapDeltaBytes": -10245412,
"heapUsedBytes": 78799408,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.554,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.9019999999805,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.8420000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.322,
"heapDeltaBytes": -11962636,
"heapUsedBytes": 57634024,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 147.064,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.7490000000207,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.0489999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.035,
"heapDeltaBytes": 9677080,
"heapUsedBytes": 63924920,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 142.537,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.0339999999624,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.687000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.317,
"heapDeltaBytes": 674800,
"heapUsedBytes": 70283580,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.825,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.2100000000291,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.7999999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.34700000000004,
"heapDeltaBytes": 421164,
"heapUsedBytes": 69593468,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.456000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1745.471000000009,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.867,
"layouts": 16,
"layoutDurationMs": 6.276,
"taskDurationMs": 770.2639999999999,
"heapDeltaBytes": -36319728,
"heapUsedBytes": 68505312,
"domNodes": -249,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 108.70900000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.1899999999396,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.554000000000002,
"layouts": 16,
"layoutDurationMs": 6.081,
"taskDurationMs": 733.9830000000001,
"heapDeltaBytes": -6621368,
"heapUsedBytes": 62775068,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 112.032,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.771000000038,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.85100000000001,
"layouts": 5,
"layoutDurationMs": 11.899,
"taskDurationMs": 909.716,
"heapDeltaBytes": 24046056,
"heapUsedBytes": 109678036,
"domNodes": 13747,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 30.025999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 124,
"frameDurationMs": 19.21111111111111,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8215.430000000026,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.68299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5225.926,
"heapDeltaBytes": 1914460,
"heapUsedBytes": 64551088,
"domNodes": -328,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 2553.864,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.700000000000003,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8338.496999999961,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.757000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5394.178,
"heapDeltaBytes": 3009584,
"heapUsedBytes": 82185852,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 2692.28,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66613226452906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17919.048999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17174.908000000003,
"heapDeltaBytes": -22162228,
"heapUsedBytes": 177198964,
"domNodes": -3045,
"jsHeapTotalBytes": 12169216,
"scriptDurationMs": 285.86699999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.94300518134715,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-idle",
"durationMs": 17681.271000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17131.062,
"heapDeltaBytes": -19479728,
"heapUsedBytes": 187805976,
"domNodes": -3045,
"jsHeapTotalBytes": 7131136,
"scriptDurationMs": 289.91100000000006,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.022105263157894,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 21362.997000000007,
"styleRecalcs": 165,
"styleRecalcDurationMs": 20.000000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21009.836,
"heapDeltaBytes": -17460024,
"heapUsedBytes": 191507060,
"domNodes": -3045,
"jsHeapTotalBytes": 5980160,
"scriptDurationMs": 852.015,
"eventListeners": -14915,
"totalBlockingTimeMs": 21,
"frameDurationMs": 39.63970315398887,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 21670.18900000005,
"styleRecalcs": 166,
"styleRecalcDurationMs": 23.055999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21257.299,
"heapDeltaBytes": -30511596,
"heapUsedBytes": 179860384,
"domNodes": -3045,
"jsHeapTotalBytes": 7815168,
"scriptDurationMs": 891.077,
"eventListeners": -14915,
"totalBlockingTimeMs": 39,
"frameDurationMs": 40.30185873605948,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6617.271999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.10600000000001,
"layouts": 20,
"layoutDurationMs": 25.883000000000003,
"taskDurationMs": 6478.187000000001,
"heapDeltaBytes": -4559652,
"heapUsedBytes": 207702328,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 118.03199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.96312849162011,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6329.928000000109,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.81299999999999,
"layouts": 20,
"layoutDurationMs": 25.820999999999998,
"taskDurationMs": 6203.114000000001,
"heapDeltaBytes": 1165036,
"heapUsedBytes": 207909992,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 111.40099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.25352941176471,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9230.310999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8834.508,
"heapDeltaBytes": -64884360,
"heapUsedBytes": 176806880,
"domNodes": -3045,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 172.05699999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.671134020618553,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9011.58799999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8749.622000000001,
"heapDeltaBytes": -37978048,
"heapUsedBytes": 186369420,
"domNodes": -3045,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 151.55200000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.09899665551839,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 141.93500000004633,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.404000000000003,
"layouts": 4,
"layoutDurationMs": 2.9889999999999994,
"taskDurationMs": 101.53700000000002,
"heapDeltaBytes": 4015256,
"heapUsedBytes": 69094860,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.074,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.655555555555615,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 130.14000000009673,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.301,
"layouts": 4,
"layoutDurationMs": 1.859,
"taskDurationMs": 96.15499999999999,
"heapDeltaBytes": 3774640,
"heapUsedBytes": 57491576,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.321,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.674999999999955,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1003.0679999999847,
"styleRecalcs": 78,
"styleRecalcDurationMs": 115.069,
"layouts": 76,
"layoutDurationMs": 29.763,
"taskDurationMs": 970.6850000000001,
"heapDeltaBytes": 18950668,
"heapUsedBytes": 89388100,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 392.521,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999996,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 997.5490000000491,
"styleRecalcs": 78,
"styleRecalcDurationMs": 116.788,
"layouts": 76,
"layoutDurationMs": 28.684,
"taskDurationMs": 970.0459999999999,
"heapDeltaBytes": 18979824,
"heapUsedBytes": 85946604,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 393.41700000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1439.8449999999912,
"styleRecalcs": 78,
"styleRecalcDurationMs": 281.447,
"layouts": 76,
"layoutDurationMs": 30.341,
"taskDurationMs": 1412.745,
"heapDeltaBytes": -19202808,
"heapUsedBytes": 108062116,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 451.44399999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.14177215189872,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1477.0239999999148,
"styleRecalcs": 78,
"styleRecalcDurationMs": 288.417,
"layouts": 76,
"layoutDurationMs": 31.219,
"taskDurationMs": 1443.203,
"heapDeltaBytes": -19590848,
"heapUsedBytes": 107301936,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 472.05600000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.0153846153846,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## glary/enable-i18n-no-missing-keys #19961 +/- ##
=====================================================================
+ Coverage 85.52% 85.54% +0.01%
=====================================================================
Files 2409 2409
Lines 137580 137570 -10
Branches 37200 35274 -1926
=====================================================================
+ Hits 117665 117678 +13
+ Misses 19539 19516 -23
Partials 376 376
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Generated namespace resolution is sound: the lint rule now recognizes the generated locale imports while preserving missing-key enforcement at call sites. The exact head is thread-free and all hosted checks are settled green.
Summary
Resolves generated locale namespaces the way
src/i18n.tsdoes, so #19939 needs noeslint-disabledirectives or file exemptions.Changes
localeDirnow loadssrc/locales/en/main.jsonplusscripts/i18n/eslint-generated-messages.js, which exportsen = { commands, nodeDefs, settings }(mirroringbuildLocale). The plugin flat-merged everysrc/locales/**/*.json, which is why staticcommands.*/settings.*refs never resolved. Removes the 7-fileselectionToolbox/exemption and reverts theHelpCenterMenuContent.vuedisable and theTabGlobalSettings.vuetooltip hoisting.Review Focus
.jsbecause the plugin's file loader only accepts.json/.yaml/.js;localeKey: 'key'reads theenexport.encounts (a key present only in another locale renders raw in theenfallback), and flat refs liket('Comfy_Onboarding_Replay.label'), previously accepted by the flat merge, now fail.collect-i18nonly runs onversion-bump-*branches, so a statict('commands.NewCmd.label')for a brand-new command fails lint until regeneration, matching the raw-key render it would produce at runtime.main.jsonis a separate entry and stays live.Verified: previously exempted/disabled files lint clean; rule-only lint over all of
srcreports 0no-missing-keys; a seeded file passes validcommands.*/settings.*/nodeDefs.*/g.*keys and failsactionbar.share,commands.Comfy_Nope.label, and flat generated keys.Stacked on #19939.