Repository navigation
[backport cloud/1.55] refactor(canvas): centralize viewport lifecycle and framing - #19960
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2147 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a9968daf959f722c7461c3a48efee1d8b5404d91
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-03T00:38:48.215Z",
"gitSha": "05d248c30e99b8339610f2f8c834a7f5014afd98",
"branch": "backport-11420-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.3129999999874,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.164999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.312,
"heapDeltaBytes": -7968684,
"heapUsedBytes": 60774672,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.987000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2012.269999999944,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.725,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.72700000000003,
"heapDeltaBytes": -7241316,
"heapUsedBytes": 61230980,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.566,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1739.1629999999623,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.912999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 779.779,
"heapDeltaBytes": 12432484,
"heapUsedBytes": 80936252,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 155.164,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1702.8260000000728,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.472000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 784.5960000000001,
"heapDeltaBytes": -6592028,
"heapUsedBytes": 62287492,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 158.12,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.5100000001066,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.769,
"layouts": 6,
"layoutDurationMs": 1.0939999999999999,
"taskDurationMs": 257.942,
"heapDeltaBytes": 2935824,
"heapUsedBytes": 71711916,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.151,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.0960000000787,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.551999999999998,
"layouts": 6,
"layoutDurationMs": 0.965,
"taskDurationMs": 328.10800000000006,
"heapDeltaBytes": 2963600,
"heapUsedBytes": 71791860,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.263000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 645.6329999999753,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.4460000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.427,
"heapDeltaBytes": 18189324,
"heapUsedBytes": 86837892,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 163.605,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 651.8690000000333,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.731000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.184,
"heapDeltaBytes": 18511188,
"heapUsedBytes": 87056472,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 172.669,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1207.2410000000673,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 873.386,
"heapDeltaBytes": 12902020,
"heapUsedBytes": 104009848,
"domNodes": -296,
"jsHeapTotalBytes": 24006656,
"scriptDurationMs": 68.403,
"eventListeners": -195,
"totalBlockingTimeMs": 583,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1226.6950000000634,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 907.6800000000001,
"heapDeltaBytes": -18309824,
"heapUsedBytes": 73257388,
"domNodes": -294,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 72.04000000000002,
"eventListeners": -217,
"totalBlockingTimeMs": 558,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.2759999999698,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.464,
"heapDeltaBytes": 15251404,
"heapUsedBytes": 92127864,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.33399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.8310000000229,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.92799999999966,
"heapDeltaBytes": 15326580,
"heapUsedBytes": 91845632,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.756,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10363.036999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9448.318000000001,
"heapDeltaBytes": 11923684,
"heapUsedBytes": 93400920,
"domNodes": -16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7940.165999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1223,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10091.926999999941,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9189.037,
"heapDeltaBytes": -10981652,
"heapUsedBytes": 70395212,
"domNodes": -14,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 7966.391999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1349,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9875.468999999954,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.0739999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8955.783,
"heapDeltaBytes": -2921584,
"heapUsedBytes": 75647044,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7479.4839999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 928,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10579.886999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9701.747000000001,
"heapDeltaBytes": -11392288,
"heapUsedBytes": 70365020,
"domNodes": -14,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 8159.147000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1260,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2024.6329999999944,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.399999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.1890000000001,
"heapDeltaBytes": -15225536,
"heapUsedBytes": 73610604,
"domNodes": -249,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.103,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2039.4400000000132,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.487000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.708,
"heapDeltaBytes": -24093900,
"heapUsedBytes": 64928688,
"domNodes": -257,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 31.98,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2293.0790000000343,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.500999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1615.5280000000002,
"heapDeltaBytes": 33368792,
"heapUsedBytes": 97554280,
"domNodes": -248,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 908.9959999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2261.812999999961,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.454,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1606.835,
"heapDeltaBytes": -2020832,
"heapUsedBytes": 88124048,
"domNodes": -255,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 849.452,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3507.847999999967,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.569,
"layouts": 60,
"layoutDurationMs": 12.72,
"taskDurationMs": 1590.903,
"heapDeltaBytes": 31384,
"heapUsedBytes": 65910448,
"domNodes": 32,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 783.0820000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3520.0700000000325,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.582999999999997,
"layouts": 60,
"layoutDurationMs": 12.806,
"taskDurationMs": 1614.5029999999997,
"heapDeltaBytes": 656592,
"heapUsedBytes": 65937052,
"domNodes": -224,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 783.141,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3038.7419999999565,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.59,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1867.8790000000001,
"heapDeltaBytes": 3565344,
"heapUsedBytes": 69204676,
"domNodes": -250,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 1005.8310000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3049.5110000000523,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.459999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1893.971,
"heapDeltaBytes": 13520976,
"heapUsedBytes": 106524232,
"domNodes": 14,
"jsHeapTotalBytes": 6483968,
"scriptDurationMs": 1024.6950000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.8529999999355,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.486999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.7580000000001,
"heapDeltaBytes": 9516808,
"heapUsedBytes": 73949604,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.916,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2029.9539999999752,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.056000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.53900000000004,
"heapDeltaBytes": -16591228,
"heapUsedBytes": 73761980,
"domNodes": -246,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 33.518,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.428999999981,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.175,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.453,
"heapDeltaBytes": 13573160,
"heapUsedBytes": 84110756,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.858,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.0759999999436,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.964999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.521,
"heapDeltaBytes": 13579528,
"heapUsedBytes": 83650148,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 145.71,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.5350000000226,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.203,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.76899999999995,
"heapDeltaBytes": -5959964,
"heapUsedBytes": 63873936,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.289000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.5090000000273,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.578,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.06199999999995,
"heapDeltaBytes": 8667108,
"heapUsedBytes": 78467348,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.471999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.888000000039,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.277,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.9979999999999,
"heapDeltaBytes": 9847672,
"heapUsedBytes": 80296388,
"domNodes": -274,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 103.309,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.2920000000431,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.911,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 726.9870000000001,
"heapDeltaBytes": 2032532,
"heapUsedBytes": 72611884,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 104.38,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.6659999999483,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.398999999999994,
"layouts": 5,
"layoutDurationMs": 13.247000000000002,
"taskDurationMs": 877.6170000000001,
"heapDeltaBytes": -6292540,
"heapUsedBytes": 82955432,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.198999999999998,
"eventListeners": 2383,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8271.034999999983,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.662,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5420.579999999999,
"heapDeltaBytes": -8993660,
"heapUsedBytes": 79984584,
"domNodes": -257,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 2758.408,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8417.729000000008,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.96,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5622.893,
"heapDeltaBytes": 5049256,
"heapUsedBytes": 94344508,
"domNodes": -242,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2898.529,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16897.349999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16464.587,
"heapDeltaBytes": -68845468,
"heapUsedBytes": 172284632,
"domNodes": -8061,
"jsHeapTotalBytes": -15142912,
"scriptDurationMs": 259.37,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16846.393000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16395.392,
"heapDeltaBytes": -49387356,
"heapUsedBytes": 165586280,
"domNodes": -8061,
"jsHeapTotalBytes": -11132928,
"scriptDurationMs": 260.033,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20516.840000000004,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.56100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20156.873,
"heapDeltaBytes": -53914788,
"heapUsedBytes": 181514664,
"domNodes": -8061,
"jsHeapTotalBytes": -14278656,
"scriptDurationMs": 940.7200000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 75,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15534.852,
"styleRecalcs": 78,
"styleRecalcDurationMs": 11.692000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15042.351999999997,
"heapDeltaBytes": -45051300,
"heapUsedBytes": 168983796,
"domNodes": -8061,
"jsHeapTotalBytes": -13119488,
"scriptDurationMs": 824.5029999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6038.398000000029,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.18499999999997,
"layouts": 20,
"layoutDurationMs": 22.87600000000001,
"taskDurationMs": 5974.078,
"heapDeltaBytes": -51231804,
"heapUsedBytes": 183990260,
"domNodes": -8061,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 100.682,
"eventListeners": -14928,
"totalBlockingTimeMs": 439,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6078.368000000182,
"styleRecalcs": 20,
"styleRecalcDurationMs": 97.137,
"layouts": 20,
"layoutDurationMs": 30.656000000000002,
"taskDurationMs": 5986.898999999999,
"heapDeltaBytes": -51659032,
"heapUsedBytes": 176029432,
"domNodes": -8061,
"jsHeapTotalBytes": 3207168,
"scriptDurationMs": 104.387,
"eventListeners": -14928,
"totalBlockingTimeMs": 619,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6353.248000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6049.494,
"heapDeltaBytes": 30098664,
"heapUsedBytes": 194099128,
"domNodes": 0,
"jsHeapTotalBytes": -17563648,
"scriptDurationMs": 94.12100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8475.480000000061,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8270.498000000001,
"heapDeltaBytes": 9946436,
"heapUsedBytes": 172055004,
"domNodes": 0,
"jsHeapTotalBytes": -13107200,
"scriptDurationMs": 132.09199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 122.50200000005407,
"styleRecalcs": 8,
"styleRecalcDurationMs": 20.453,
"layouts": 3,
"layoutDurationMs": 1.7910000000000001,
"taskDurationMs": 100.08500000000001,
"heapDeltaBytes": 3217784,
"heapUsedBytes": 69591472,
"domNodes": 111,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.448,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 451.680000000124,
"styleRecalcs": 16,
"styleRecalcDurationMs": 25.569000000000003,
"layouts": 3,
"layoutDurationMs": 1.5410000000000001,
"taskDurationMs": 127.52100000000003,
"heapDeltaBytes": 4986948,
"heapUsedBytes": 71251512,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.454,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.55 #19960 +/- ##
=============================================
Coverage ? 84.93%
=============================================
Files ? 2326
Lines ? 133178
Branches ? 33789
=============================================
Hits ? 113121
Misses ? 19695
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
- make CanvasViewport the authority for CSS size, backing-store size, and DPR - serialize visibility-sensitive camera work through an identity-aware CanvasScheduler - reject malformed saved camera state and stale graph/subgraph operations - use one visible viewport rectangle for immediate and animated panel-aware framing - migrate litegraph, minimap, layout, hit testing, and canvas-center consumers to the applied DPR - cover the real App Mode template-loading product path This incorporates the viewport migration from [merged PR supersedes the remaining work in [PR [PR #19095](#19095). Those two fallback PRs will be closed after this PR merges. The panel work is adapted to the existing `visibleCanvasViewport` contract rather than introducing a second inset API. Related to #11154: Fit View now excludes the docked agent panel, but it still does not subtract the right-side parameters panel, so that issue stays open. - application and browser-test typechecks passed - ADR validation, formatting, and changed-file lint passed - production build passed - pre-commit and pre-push formatting, lint, knip, and changed-file fallow gates passed - [exact-head CI](https://github.com/Comfy-Org/ComfyUI_frontend/commit/a558de2719aff8b5546cb25f2b2ad413420928a5/checks) passed with 105 successful checks, 19 expected skips, and no failures - Playwright product-path and 0.5x DPR regressions passed in the hosted browser matrix The lifecycle is measure, apply atomically to both canvases, then frame and draw. Scheduled operations carry both a semantic key and an ownership predicate, so stale loads cannot clear or replace current camera work. Panel-aware fitting consumes a usable rectangle in CSS pixels, shared by immediate and animated paths. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
d39d03c to
b8e1def
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Release backport exact-head review: the cloud/1.55 carrier faithfully preserves merged source #11420, the conflict repair retains release-native fixtures, focused unit proof passed 59/59, both black-box cases passed with the superseded assertion failing before correction, all required hosted checks are green, no review thread remains open, and the current two-commit target delta has zero file overlap. Under program/release-backport-authority.md this COMMENT records the honest author review; REVIEW_REQUIRED alone is not an additional approval requirement.
Backports PR #11420 to
cloud/1.55after the automatic cherry-pick conflicted with release-branch test infrastructure.This applies the validated core/1.55 conflict resolution on top of the cloud release branch, preserving cloud-specific changes while carrying the production viewport fix and regression coverage.
Validation:
Justification: Agent release-backport authority permits operator review and merge without an additional approval; exact head 3846737 was independently reviewed with focused unit and black-box mutation proof, every required check is green, no review thread or objection remains open, and the two-commit target delta has zero file overlap.