Repository navigation
[backport cloud/1.55] fix: keep the graph camera usable when a template loads from App Mode - #19954
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2144 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 40a0284774e393b4718cfe8e7c2b92096ee57855
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-02T23:35:57.877Z",
"gitSha": "5773a7f886fd4db53e37922ac64aa22b3f2f1fde",
"branch": "christian-byrne/backport-19095-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.689000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.6000000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.05099999999993,
"heapDeltaBytes": 8959096,
"heapUsedBytes": 76977916,
"domNodes": -263,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.496,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2005.5929999999762,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.53,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.70000000000005,
"heapDeltaBytes": 7764568,
"heapUsedBytes": 75520156,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.523000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1773.7790000000473,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.109000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 803.022,
"heapDeltaBytes": -6399664,
"heapUsedBytes": 61444500,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 149.955,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1752.4079999999458,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.445,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 829.8290000000001,
"heapDeltaBytes": 3694176,
"heapUsedBytes": 71546032,
"domNodes": -263,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 154.51500000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.0740000000096,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.725,
"layouts": 6,
"layoutDurationMs": 1.327,
"taskDurationMs": 383.7149999999999,
"heapDeltaBytes": 2982832,
"heapUsedBytes": 71099432,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 14.393999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.5070000000542,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.744000000000002,
"layouts": 6,
"layoutDurationMs": 1.2670000000000001,
"taskDurationMs": 386.44,
"heapDeltaBytes": 2813324,
"heapUsedBytes": 70761908,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 15.057999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 692.1540000000164,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.387000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.38100000000003,
"heapDeltaBytes": 18999956,
"heapUsedBytes": 86851760,
"domNodes": 20,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 162.814,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 703.7939999999026,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.664000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.332,
"heapDeltaBytes": 18660736,
"heapUsedBytes": 86700876,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 164.187,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1204.878000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 895.1669999999999,
"heapDeltaBytes": -16559888,
"heapUsedBytes": 72917776,
"domNodes": -293,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 62.83600000000002,
"eventListeners": -217,
"totalBlockingTimeMs": 536,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1158.6340000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 816.611,
"heapDeltaBytes": 12228108,
"heapUsedBytes": 83204300,
"domNodes": 0,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 63.025999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 536,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.1069999999704,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.8319999999999,
"heapDeltaBytes": 15107944,
"heapUsedBytes": 91807960,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.38000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 229,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.1550000000243,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.5189999999999,
"heapDeltaBytes": 14966976,
"heapUsedBytes": 92296364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 143.605,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9866.555000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8953.527000000002,
"heapDeltaBytes": 4085084,
"heapUsedBytes": 86802236,
"domNodes": -16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7234.669,
"eventListeners": 0,
"totalBlockingTimeMs": 498,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9447.702999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8634.944999999998,
"heapDeltaBytes": 3190316,
"heapUsedBytes": 85621416,
"domNodes": -16,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 6977.0109999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 363,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9197.851000000013,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.1060000000000028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8441.071,
"heapDeltaBytes": 8971848,
"heapUsedBytes": 87290416,
"domNodes": -270,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 6727.95,
"eventListeners": -174,
"totalBlockingTimeMs": 354,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8672.71500000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7954.125999999999,
"heapDeltaBytes": 33117020,
"heapUsedBytes": 97480416,
"domNodes": -270,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 6371.499,
"eventListeners": -174,
"totalBlockingTimeMs": 257,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2051.858999999979,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.258000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.167,
"heapDeltaBytes": -3823636,
"heapUsedBytes": 83122188,
"domNodes": -244,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 36.504999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.7520000000977,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.728,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 651.6840000000001,
"heapDeltaBytes": -7174116,
"heapUsedBytes": 80140816,
"domNodes": -251,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 36.477,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2291.6910000000144,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.873999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1615.718,
"heapDeltaBytes": 19408908,
"heapUsedBytes": 84329140,
"domNodes": -5,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 833.787,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2302.193999999986,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1675.5200000000002,
"heapDeltaBytes": -1524888,
"heapUsedBytes": 79866476,
"domNodes": -220,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 842.914,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3534.185999999977,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.633000000000001,
"layouts": 60,
"layoutDurationMs": 15.019000000000002,
"taskDurationMs": 1596.9009999999998,
"heapDeltaBytes": 9352612,
"heapUsedBytes": 74936452,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 821.8770000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3621.1700000000064,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.827999999999996,
"layouts": 60,
"layoutDurationMs": 15.296999999999999,
"taskDurationMs": 1848.5219999999997,
"heapDeltaBytes": -19666200,
"heapUsedBytes": 70264044,
"domNodes": -224,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 818.547,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3166.432000000043,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.856999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1953.0990000000004,
"heapDeltaBytes": 514872,
"heapUsedBytes": 66743152,
"domNodes": 8,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 1016.006,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3125.3840000000537,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.565000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1993.6469999999997,
"heapDeltaBytes": 26003812,
"heapUsedBytes": 92586988,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1043.2100000000003,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.7480000000405,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.464000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 678.519,
"heapDeltaBytes": -4739016,
"heapUsedBytes": 84314804,
"domNodes": -246,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 36.781000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.0209999999906,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.9380000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.0469999999999,
"heapDeltaBytes": 20145652,
"heapUsedBytes": 84546992,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.60999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.4539999999852,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.900999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.02599999999995,
"heapDeltaBytes": 13753224,
"heapUsedBytes": 83657772,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 149.43200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 602.5620000000345,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.037999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.455,
"heapDeltaBytes": 13779148,
"heapUsedBytes": 83755188,
"domNodes": 18,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 145.186,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2006.4309999999637,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.061000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.449,
"heapDeltaBytes": 5787408,
"heapUsedBytes": 75875004,
"domNodes": -272,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.866999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2007.5740000000906,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.540000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.76800000000003,
"heapDeltaBytes": -13508564,
"heapUsedBytes": 56682536,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.026000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.692999999997,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.624,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 739.1170000000001,
"heapDeltaBytes": -7810572,
"heapUsedBytes": 62406096,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 102.787,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.5719999999665,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.52,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 769.54,
"heapDeltaBytes": 7073888,
"heapUsedBytes": 77431452,
"domNodes": -275,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 107.80400000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.9309999999377,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.300000000000004,
"layouts": 5,
"layoutDurationMs": 11.772000000000002,
"taskDurationMs": 884.7239999999998,
"heapDeltaBytes": -6290932,
"heapUsedBytes": 81374936,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.209,
"eventListeners": 2383,
"totalBlockingTimeMs": 125,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8358.082000000024,
"styleRecalcs": 250,
"styleRecalcDurationMs": 42.823,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5765.411,
"heapDeltaBytes": -6044840,
"heapUsedBytes": 80824940,
"domNodes": -221,
"jsHeapTotalBytes": 1269760,
"scriptDurationMs": 2704.062,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8349.199999999997,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.063,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5914.960000000001,
"heapDeltaBytes": -6518416,
"heapUsedBytes": 80668720,
"domNodes": -224,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 2774.971,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18021.89499999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17773.54,
"heapDeltaBytes": -51534544,
"heapUsedBytes": 170600616,
"domNodes": -8061,
"jsHeapTotalBytes": -9768960,
"scriptDurationMs": 300.615,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17512.860000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17402.312,
"heapDeltaBytes": -24880072,
"heapUsedBytes": 189260512,
"domNodes": -8061,
"jsHeapTotalBytes": -13164544,
"scriptDurationMs": 293.945,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21858.787000000008,
"styleRecalcs": 148,
"styleRecalcDurationMs": 22.36300000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21818.872,
"heapDeltaBytes": -33987164,
"heapUsedBytes": 188384424,
"domNodes": -8061,
"jsHeapTotalBytes": -19406848,
"scriptDurationMs": 917.2009999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 132,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 21901.757999999973,
"styleRecalcs": 153,
"styleRecalcDurationMs": 23.545000000000037,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21844.351000000002,
"heapDeltaBytes": -50687288,
"heapUsedBytes": 168590236,
"domNodes": -8061,
"jsHeapTotalBytes": -18096128,
"scriptDurationMs": 934.345,
"eventListeners": -14928,
"totalBlockingTimeMs": 117,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6376.291999999921,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.42300000000002,
"layouts": 20,
"layoutDurationMs": 24.62700000000001,
"taskDurationMs": 6342.653,
"heapDeltaBytes": -77708816,
"heapUsedBytes": 163867152,
"domNodes": -8061,
"jsHeapTotalBytes": 4960256,
"scriptDurationMs": 113.15899999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 399,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5175.840999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.36200000000004,
"layouts": 20,
"layoutDurationMs": 28.09600000000001,
"taskDurationMs": 5146.736,
"heapDeltaBytes": -31916500,
"heapUsedBytes": 187133156,
"domNodes": -8061,
"jsHeapTotalBytes": 22536192,
"scriptDurationMs": 104.719,
"eventListeners": -14928,
"totalBlockingTimeMs": 330,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8988.847999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8791.239,
"heapDeltaBytes": -19465164,
"heapUsedBytes": 165696160,
"domNodes": 0,
"jsHeapTotalBytes": -24117248,
"scriptDurationMs": 137.11800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9014.473999999951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8929.21,
"heapDeltaBytes": -26990892,
"heapUsedBytes": 165378820,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 146.55699999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 495.38699999993696,
"styleRecalcs": 22,
"styleRecalcDurationMs": 34.852999999999994,
"layouts": 6,
"layoutDurationMs": 3.0940000000000003,
"taskDurationMs": 159.68699999999998,
"heapDeltaBytes": 5453996,
"heapUsedBytes": 71327012,
"domNodes": 155,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 18.887,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 102.47900000001664,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.915000000000001,
"layouts": 3,
"layoutDurationMs": 1.477,
"taskDurationMs": 74.95100000000002,
"heapDeltaBytes": 3039528,
"heapUsedBytes": 68879452,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.862000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Comment. I cannot verify this as a backport, because its named source, #19095, was closed without merging.
#19095 was closed unmerged at 2026-10-02T22:48Z. Its own successor, #11420 (33095f7, "refactor(canvas): centralize viewport lifecycle and framing"), merged to main and states that it supersedes #19095. So there is no merged source diff for this PR to be faithful to.
What I could check:
- Against its merge base 40a0284 (the current
cloud/1.55tip), this branch carries exactly the added and removed lines of #19095's final head, d837dda, in all seven files. That includes thefitToBoundszero-size guard inDragAndScale.ts,DragAndScale.fitToBounds.test.ts, the App Mode template fixture and helpers, andgraphCameraSurvivesTemplateLoad.spec.ts. - What is on
mainis not this code. #11420 places the equivalent guard asif (!(vw > 0) || !(vh > 0)) returnagainst a viewport rectangle produced by its newCanvasViewportlifecycle.mainhas nographCameraSurvivesTemplateLoad.spec.ts; #11420 covers the App Mode template path in its own browser tests.
This PR is therefore a release-only fix derived from an unmerged PR, not a carry of what shipped on main. Whether that is acceptable for cloud/1.55 in place of #11420 is a release-owner decision I cannot settle by diffing. If it lands, I think the description should name #11420 as the merged change it stands in for and state that it intentionally diverges from it.
Hosted checks had no failures when I posted, and the Playwright shards and test were still running.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 3 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19954 +/- ##
=============================================
Coverage ? 84.92%
=============================================
Files ? 2321
Lines ? 132998
Branches ? 35607
=============================================
Hits ? 112951
Misses ? 19685
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Comment. The named source #19095 is closed unmerged, so I cannot verify this against a merged source diff.
I re-checked at 000bca9.
- #19095 is still closed without merging. The change that shipped on
mainis #11420 (33095f79ee5b438021e7e9d5509d5590b9229355). The description now says this PR substitutes for #11420 and deliberately carries the smaller #19095 behavior instead of #11420's viewport lifecycle refactor. That answers the question I raised on the previous head, but it also means there is no merged diff to compare hunk by hunk. - The only new commit since my last review is 000bca9 ("test(canvas): harden app mode camera regression"). It touches only
CanvasHelper.ts,WorkflowHelper.tsandgraphCameraSurvivesTemplateLoad.spec.ts. The readiness poll now requires both backing-store axes, the workflow-mode helper returns null when there is no active workflow, and the spec reads the camera in a single evaluation and waits for it to settle before comparing. None of this is in #19095's final patch (d837ddaa42). It was added in response to review comments on this PR. - The production change in
DragAndScale.tsis unchanged from the previous head:fitToBoundsreturns early when either backing-store dimension is not positive. The review comments about deferring the discarded fit, the 300x150 substitution andanimateToBoundsare not addressed in production code. - CI at this head:
lint-and-formatpassed.testand the e2e jobs were still running when I posted.
Whether to ship an unmerged substitute on cloud/1.55 is the release owner's call. I have not approved or rejected it as a backport.
This is a targeted release-native substitute for the App Mode camera fix that shipped on
mainin #11420 (33095f79ee). The complete #11420 viewport-lifecycle refactor does not cherry-pick cleanly tocloud/1.55, so this PR intentionally diverges from its implementation and carries the smaller, already-proven #19095 behavior instead.The production change makes
fitToBoundsa no-op for a zero-size canvas, preventing a hidden App Mode canvas from poisoning the camera with scale0and non-finite offsets. The focused unit cases and the product-level App Mode template browser regression are carried with it.This intentionally does not backport #11420's broader viewport lifecycle refactor.
Validation on
cloud/1.55:Release fallback for #11420, derived from the final unmerged #19095 patch.