Repository navigation
FE-3180 feat(telemetry): report session_bootstrap and session_signed_out_remotely - #19936
Conversation
…tely Cloud, website and billing-web now pass the web-session identity's onBootstrap and onSignedOutRemotely hooks to their existing sinks: Cloud to Datadog RUM and PostHog, website to PostHog, billing-web to RUM and PostHog. The names and payloads live once in account-core.
…rough the interface
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 02413d948c9b72c6b03eeebf2d1edd292d989e47
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19936.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-kiujdagf2-comfyui.vercel.app Last updated: 2026-10-02T21:31:34Z for 🎭 Playwright: ✅ 2188 passed, 0 failed📊 Browser Reports
📦 Bundle: 10.1 MB gzip 🟢 -200 BDetailsSummary
Category Glance App Entry Points — 3.89 kB (baseline 3.89 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.47 MB (baseline 1.47 MB) • 🟢 -23 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 135 kB (baseline 135 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 646 kB (baseline 646 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 53.6 kB (baseline 53.6 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 7 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 184 kB (baseline 184 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 10 unchanged Data & Services — 4.15 MB (baseline 4.15 MB) • 🟢 -1.23 kBStores, services, APIs, and repositories
Status: 11 added / 11 removed / 3 unchanged Utilities & Hooks — 586 kB (baseline 586 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 17 unchanged Vendor & Third-Party — 17.2 MB (baseline 17.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.3 MB (baseline 18.3 MB) • 🔴 +348 BBundles that do not match a named category
Status: 86 added / 86 removed / 219 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-02T21:43:40.478Z",
"gitSha": "90a13c608b1da4cf528e2ab3d5b4bda642120c00",
"branch": "jaewon/fe-3180-feattelemetry-report-session_bootstrap-and",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.786999999984,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.210999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.938,
"heapDeltaBytes": 539720,
"heapUsedBytes": 67234896,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.744000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.2060000002002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.736999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.32500000000005,
"heapDeltaBytes": 487956,
"heapUsedBytes": 67240476,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.742000000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1789.683999999852,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.075,
"layouts": 12,
"layoutDurationMs": 4.805999999999999,
"taskDurationMs": 832.067,
"heapDeltaBytes": 19508588,
"heapUsedBytes": 73453508,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.90300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018691,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.643999999982,
"styleRecalcs": 76,
"styleRecalcDurationMs": 21.639,
"layouts": 12,
"layoutDurationMs": 4.736,
"taskDurationMs": 881.6970000000001,
"heapDeltaBytes": -2604024,
"heapUsedBytes": 64603164,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 176.843,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.9780000000355,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.288,
"layouts": 6,
"layoutDurationMs": 1.165,
"taskDurationMs": 396.11599999999993,
"heapDeltaBytes": 3369972,
"heapUsedBytes": 71131068,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.916000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.9589999998752,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.136999999999999,
"layouts": 6,
"layoutDurationMs": 1.09,
"taskDurationMs": 383.4649999999999,
"heapDeltaBytes": 3433440,
"heapUsedBytes": 70860388,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.380999999999995,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 698.1390000000829,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.6279999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.48599999999993,
"heapDeltaBytes": -8100592,
"heapUsedBytes": 59177828,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 169.827,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 740.5069999999796,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.288000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.591,
"heapDeltaBytes": 14533268,
"heapUsedBytes": 68322992,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 181.197,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1137.1630000001005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 817.926,
"heapDeltaBytes": 11809420,
"heapUsedBytes": 80861356,
"domNodes": 0,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 67.72600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 520,
"frameDurationMs": 34.34242424242425,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1186.5540000001147,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 860.741,
"heapDeltaBytes": 15421236,
"heapUsedBytes": 83961296,
"domNodes": 0,
"jsHeapTotalBytes": 7766016,
"scriptDurationMs": 69.528,
"eventListeners": 0,
"totalBlockingTimeMs": 544,
"frameDurationMs": 34.8,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.2499999999509,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.6680000000006,
"heapDeltaBytes": -8257184,
"heapUsedBytes": 89699256,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 170.518,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 889.5310000000336,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.5450000000003,
"heapDeltaBytes": 16420384,
"heapUsedBytes": 105162336,
"domNodes": 0,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 174.57399999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 244,
"frameDurationMs": 25.979411764705915,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10124.09300000013,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.5229999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9236.781,
"heapDeltaBytes": -6440840,
"heapUsedBytes": 70995420,
"domNodes": -142,
"jsHeapTotalBytes": -7475200,
"scriptDurationMs": 7704.812,
"eventListeners": -78,
"totalBlockingTimeMs": 1239,
"frameDurationMs": 35.371678321678324,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10451.115999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9565.597,
"heapDeltaBytes": 16960848,
"heapUsedBytes": 91953436,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 7893.496999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1374,
"frameDurationMs": 34.54602649006623,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9811.13500000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9051.061000000002,
"heapDeltaBytes": -8723188,
"heapUsedBytes": 71732688,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 7427.414,
"eventListeners": 0,
"totalBlockingTimeMs": 1048,
"frameDurationMs": 34.02638888888889,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10595.557999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9817.608,
"heapDeltaBytes": -2105092,
"heapUsedBytes": 82269584,
"domNodes": -142,
"jsHeapTotalBytes": -3805184,
"scriptDurationMs": 8151.079,
"eventListeners": -78,
"totalBlockingTimeMs": 1553,
"frameDurationMs": 35.68888888888889,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2045.5120000001443,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.573000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.634,
"heapDeltaBytes": -50976712,
"heapUsedBytes": 73001552,
"domNodes": -328,
"jsHeapTotalBytes": -2457600,
"scriptDurationMs": 35.455999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2021.97799999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.554000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.0840000000001,
"heapDeltaBytes": -10977728,
"heapUsedBytes": 76676240,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.56900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2646.788000000015,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.156,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1628.5829999999999,
"heapDeltaBytes": 10270608,
"heapUsedBytes": 89708284,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 891.531,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77151898734177,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2983.2229999999527,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.920000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1723.2549999999999,
"heapDeltaBytes": -18682176,
"heapUsedBytes": 69852728,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 920.4760000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665921787709497,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3706.4050000001316,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.077,
"layouts": 60,
"layoutDurationMs": 13.915000000000001,
"taskDurationMs": 1691.8899999999999,
"heapDeltaBytes": 1277376,
"heapUsedBytes": 64706112,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 844.1469999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665919282511215,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 4052.3349999998572,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.684000000000001,
"layouts": 60,
"layoutDurationMs": 15.134,
"taskDurationMs": 1860.7920000000001,
"heapDeltaBytes": 1366944,
"heapUsedBytes": 69254724,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 921.6339999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665843621399173,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3138.535000000047,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.753999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1919.34,
"heapDeltaBytes": 8424860,
"heapUsedBytes": 73059436,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 1034.6280000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755614973262027,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3131.8610000000717,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.325000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1946.4540000000002,
"heapDeltaBytes": 3666700,
"heapUsedBytes": 68747800,
"domNodes": -167,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1017.5940000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.845698924731188,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.9050000000043,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.419,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.1809999999999,
"heapDeltaBytes": -53356112,
"heapUsedBytes": 72501564,
"domNodes": -328,
"jsHeapTotalBytes": -2195456,
"scriptDurationMs": 40.333999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.1260000001712,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.032000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.9380000000001,
"heapDeltaBytes": -53001828,
"heapUsedBytes": 72996804,
"domNodes": -328,
"jsHeapTotalBytes": -2719744,
"scriptDurationMs": 36.418,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 616.6249999998854,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.131000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.367,
"heapDeltaBytes": -11953628,
"heapUsedBytes": 57626336,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 147.368,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.2100000000046,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.077000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.64000000000004,
"heapDeltaBytes": 9201220,
"heapUsedBytes": 63277856,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 142.168,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2037.1399999999085,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.154000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.82399999999996,
"heapDeltaBytes": -29661404,
"heapUsedBytes": 74557852,
"domNodes": -250,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 7.851,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2031.9390000001931,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.612000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.8399999999999,
"heapDeltaBytes": -28957104,
"heapUsedBytes": 75612528,
"domNodes": -248,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 9.235,
"eventListeners": -206,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.0330000000286,
"styleRecalcs": 78,
"styleRecalcDurationMs": 17.765,
"layouts": 16,
"layoutDurationMs": 6.172000000000001,
"taskDurationMs": 759.1439999999999,
"heapDeltaBytes": -6574084,
"heapUsedBytes": 63279880,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.22000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.1839999999938,
"styleRecalcs": 77,
"styleRecalcDurationMs": 21.229,
"layouts": 16,
"layoutDurationMs": 6.839999999999999,
"taskDurationMs": 829.1740000000001,
"heapDeltaBytes": -6295676,
"heapUsedBytes": 63488868,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 122.92199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.3350000000937,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.919000000000004,
"layouts": 5,
"layoutDurationMs": 14.49,
"taskDurationMs": 1033.658,
"heapDeltaBytes": -4528228,
"heapUsedBytes": 85492632,
"domNodes": 13747,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 35.343999999999994,
"eventListeners": 2383,
"totalBlockingTimeMs": 148,
"frameDurationMs": 19.634246575342456,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8999.731999999995,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.094,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5719.15,
"heapDeltaBytes": -59363240,
"heapUsedBytes": 64593416,
"domNodes": -328,
"jsHeapTotalBytes": -1671168,
"scriptDurationMs": 2801.8399999999997,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66604823747681,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9682.974999999942,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.89099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6030.821,
"heapDeltaBytes": 6622788,
"heapUsedBytes": 91217288,
"domNodes": 0,
"jsHeapTotalBytes": 1540096,
"scriptDurationMs": 3053.142,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.694827586206898,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16942.978999999923,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16390.339,
"heapDeltaBytes": -20788740,
"heapUsedBytes": 188057728,
"domNodes": -3045,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 315.198,
"eventListeners": -14915,
"totalBlockingTimeMs": 3,
"frameDurationMs": 28.506228956228952,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 17189.83800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16405.871,
"heapDeltaBytes": -52495468,
"heapUsedBytes": 177641372,
"domNodes": -3045,
"jsHeapTotalBytes": 5079040,
"scriptDurationMs": 276.14099999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.371965811965808,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 21215.13299999992,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.409999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20845.811999999998,
"heapDeltaBytes": -16918040,
"heapUsedBytes": 191850348,
"domNodes": -3045,
"jsHeapTotalBytes": 6242304,
"scriptDurationMs": 909.6560000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 2,
"frameDurationMs": 38.43442028985507,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20957.488999999896,
"styleRecalcs": 177,
"styleRecalcDurationMs": 19.010000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20464.954999999998,
"heapDeltaBytes": -37081704,
"heapUsedBytes": 169889524,
"domNodes": -3045,
"jsHeapTotalBytes": 7655424,
"scriptDurationMs": 908.296,
"eventListeners": -14915,
"totalBlockingTimeMs": 6,
"frameDurationMs": 37.47620751341682,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6314.284000000043,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.51599999999998,
"layouts": 20,
"layoutDurationMs": 24.914000000000005,
"taskDurationMs": 6144.597,
"heapDeltaBytes": 901344,
"heapUsedBytes": 216726896,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 113.429,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.19441340782122,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6292.644000000109,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.005,
"layouts": 20,
"layoutDurationMs": 25.290000000000006,
"taskDurationMs": 6155.393,
"heapDeltaBytes": 777992,
"heapUsedBytes": 208033496,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 110.78999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.62674418604651,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9182.374999999865,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8751.152000000002,
"heapDeltaBytes": -62497904,
"heapUsedBytes": 173905816,
"domNodes": -3045,
"jsHeapTotalBytes": 9797632,
"scriptDurationMs": 145.99499999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.207236842105264,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8500.045999999884,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8182.868000000001,
"heapDeltaBytes": -46985580,
"heapUsedBytes": 181886092,
"domNodes": -3045,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 125.42799999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.108219178082198,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 514.2479999999523,
"styleRecalcs": 24,
"styleRecalcDurationMs": 21.796999999999997,
"layouts": 6,
"layoutDurationMs": 3.2520000000000007,
"taskDurationMs": 163.41400000000002,
"heapDeltaBytes": 5950300,
"heapUsedBytes": 59864628,
"domNodes": -102,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.452,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 103.99099999995087,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.431,
"layouts": 2,
"layoutDurationMs": 1.357,
"taskDurationMs": 69.07799999999997,
"heapDeltaBytes": 3707496,
"heapUsedBytes": 68910896,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.137999999999997,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1102.1009999999478,
"styleRecalcs": 78,
"styleRecalcDurationMs": 119.988,
"layouts": 76,
"layoutDurationMs": 29.009,
"taskDurationMs": 1081.4840000000002,
"heapDeltaBytes": 19566236,
"heapUsedBytes": 90826636,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 462.924,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.923076923076923,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1060.7199999999466,
"styleRecalcs": 78,
"styleRecalcDurationMs": 114.648,
"layouts": 76,
"layoutDurationMs": 29.871000000000002,
"taskDurationMs": 1040.514,
"heapDeltaBytes": 19476008,
"heapUsedBytes": 90544500,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 435.61499999999995,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1533.610999999837,
"styleRecalcs": 78,
"styleRecalcDurationMs": 289.57500000000005,
"layouts": 76,
"layoutDurationMs": 32.30800000000001,
"taskDurationMs": 1515.447,
"heapDeltaBytes": 8260248,
"heapUsedBytes": 113225016,
"domNodes": 76,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 519.777,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.620253164556964,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1477.5160000001506,
"styleRecalcs": 78,
"styleRecalcDurationMs": 266.902,
"layouts": 76,
"layoutDurationMs": 30.276,
"taskDurationMs": 1448.242,
"heapDeltaBytes": 8806532,
"heapUsedBytes": 113923240,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 502.83299999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.3111111111111,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (4)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (20)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThis change adds shared telemetry events for web-session bootstrap and remote sign-out. Session identity integrations forward these events through billing, website, and platform telemetry paths to analytics providers. ChangesWeb Session Telemetry
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant SessionIdentity
participant WebSessionTelemetryHooks
participant TelemetryRegistry
participant DatadogRumTelemetryProvider
participant PostHogTelemetryProvider
SessionIdentity->>WebSessionTelemetryHooks: Emit bootstrap or remote sign-out event
WebSessionTelemetryHooks->>TelemetryRegistry: Track event and properties
TelemetryRegistry->>DatadogRumTelemetryProvider: Dispatch event
TelemetryRegistry->>PostHogTelemetryProvider: Dispatch event
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The new session events appear ready to merge after normal checks. No concrete issue requiring a change before merge was established. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The added event properties contain only a session outcome and page origin and use existing analytics destinations. No new authentication authority or credential exposure was identified. Production delivery and rollback-alert behavior have not been verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #19936 +/- ##
==========================================
- Coverage 84.82% 84.82% -0.01%
==========================================
Files 3435 3435
Lines 164619 164631 +12
Branches 44956 43027 -1929
==========================================
+ Hits 139643 139645 +2
- Misses 23020 23031 +11
+ Partials 1956 1955 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the exact head. The implementation and focused coverage match the stated contract; CI is settled green and no current review threads remain.
…cookie alone (Comfy-Org#19966) ## Why A Cloud tab signed in by the shared web session alone, with no Firebase user, cannot sign out of all devices. FE-3181 (PR Comfy-Org#19935) hid the "Sign out of all devices" button on those tabs because `revokeAllWebSessions` needed a Firebase ID token. This PR makes revoke-all work on the cookie and shows the button there too. ## Root cause `revokeAllWebSessions` in `@comfyorg/account-core` always took a Firebase identity proof and sent `Authorization: Bearer`, and it never sent `X-Comfy-Client`. The backend (cloud#10896, `services/ingest/server/server.go`, `ProtectedRevokeAll`) admits either a Firebase ID token or the web session cookie under the session guard. The cookie path needs a trusted Origin, the session's `X-CSRF-Token` and `X-Comfy-Client`, and no `Authorization`: any other credential presented beside the cookie makes ingest ignore the cookie (`tryAuthenticate`, "a bearer wins over the cookie it rides with"). A session-only tab had no bearer to send and the client never built the cookie request. ## How - `revokeAllWebSessions(options, csrfToken)` drops the identity-proof argument and sends `X-Comfy-Client: COMFY_CLIENT` plus `X-CSRF-Token`, no bearer. One path for every tab. The route is behind the same `web_session_enabled` gate for both credentials (flag off: the cookie gets 403 and a bearer gets 404), so the cookie path covers every tab that holds a session, and it also revokes the user's Firebase refresh tokens. - `X-Comfy-Client` reuses `COMFY_CLIENT` from `requestAuth`, the value every other session request already sends. - `cloudWebSessionStore.revokeAllSessions` needs only the session. The `.catch` that guarded the Firebase token call is gone: `send` already turns every throw into a result. - `SignOutEverywhereButton` drops the `needsFirebaseSignIn` check. - The `@comfyorg/account-core/testing` fake now serves revoke-all as the cookie path (CSRF token and `X-Comfy-Client` required). - Signature change: the only caller (`cloudWebSessionStore`) is migrated here. No version bump, following PR Comfy-Org#19797, which changed account-core without one; the bump ships in its own release PR as PR Comfy-Org#19812 did. - `unified_web_session` off is unchanged: there is no session, so `revokeAllSessions` returns `NO_SESSION` and sends nothing, and the button does not render. A new flag-off test pins this for `unified_cloud_auth` on and off. ## AS IS / TO BE Real-app capture is pending: it needs a signed-in Cloud browser, which was not available. Request evidence from the tests: | | Session-only tab (no Firebase user) | `POST /api/auth/sessions/revoke-all` headers | | --- | --- | --- | | AS IS | Button hidden; `revokeAllSessions()` returns `NO_SESSION`, no request | Firebase tab: `Authorization: Bearer <id token>`, `X-CSRF-Token` | | TO BE | Button shown; one request, `{ status: 'ok' }` | every tab: `X-Comfy-Client: @comfyorg/account-core/<version>`, `X-CSRF-Token`, no `Authorization`, `credentials: include` | Each behavior was removed in turn to check the tests catch it: - Dropping `X-Comfy-Client` from the request fails 2 tests in `webSession.test.ts` and 3 in `webSessionFlagOn.test.ts`. - Restoring the Firebase-user guard in the store fails "revoke-all works on a session-only tab with no Firebase login". - Restoring `needsFirebaseSignIn` on the button fails "asks about unsaved work, then revokes once, on a session-only tab". - Letting the store send without a session fails both new flag-off cases. ## Where this sits | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Web session follow-up | FE-3178 | PR Comfy-Org#19932 | merged | | Web session follow-up | FE-3179 | PR Comfy-Org#19934 | merged | | Web session follow-up | FE-3180 | PR Comfy-Org#19936 | merged | | Sign out of all devices on the web session | FE-3181 | PR Comfy-Org#19935 | merged | | **Revoke-all on the session cookie alone** | **FE-3182** | **this PR** | **open** | | E2E harness | FE-2906 | | next | | Ramp | FE-2907 | | after harness | ```mermaid graph LR A["FE-3178 (PR 19932) merged"] B["FE-3179 (PR 19934) merged"] C["FE-3180 (PR 19936) merged"] D["FE-3181 (PR 19935) merged"] --> E["FE-3182 this PR"] E --> F["FE-2906 harness"] F --> G["FE-2907 ramp"] style E fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:3px ``` - Linear: [FE-3182](https://linear.app/comfyorg/issue/FE-3182) - TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b - Action items: https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3 Fixes FE-3182
Why
TDD §19 and the ramp plan depend on two SDK events:
session_bootstrap(outcome, origin) to read boot outcomes during the ramp, andsession_signed_out_remotely(origin), the rollback signal ("if it moves when a step ships, the step rolls back"). The web-session identity in@comfyorg/account-corealready exposesonBootstrapandonSignedOutRemotely, but no app passed them, so neither event reached any sink.How
@comfyorg/account-core/telemetryadds both names toSESSION_TELEMETRY_EVENTand exportswebSessionTelemetryHooks(track). The helper returns the two identity options and maps each one to{ name, properties }. Its properties carry onlyoutcomeandorigin, so every host sends the same name and payload.cloudWebSessionStorespreads the hooks intocreateWebSessionIdentity, routed touseTelemetry()?.trackWebSessionEvent. The new dispatcher method fans out to Datadog RUM (addAction) and PostHog, liketrackUnifiedAuthRefreshdoes. Datadog is where the TDD's alert lives.workshop-web-session-identitysends the events to the existing PostHogcaptureEvent. The shared refresh events already go there, and the site has no other general sink.unifiedBillingSessionsends the events tobillingWebTelemetry.trackWebSessionEvent, which goes to RUM and PostHog through the existingsend(PostHogtelemetryDisabledEventsstill applies).window.location.origin, and each sink keeps whatever identity it already attaches.unified_web_sessionoff no identity is created, so nothing is emitted. The flag-off suite asserts this.TelemetryRegistry.trackWebSessionEventhas a caller, because callers hold theTelemetryDispatcherinterface rather than the class. It carries the samefallow-ignore-next-line unused-class-memberastrackAgentFreeUseNoticeandtrackAgentError.AS IS / TO BE
This change has no UI. The evidence is the event each host's sink receives, captured in tests against the real identity and a fake
/auth/sessionendpoint. Each line below was checked red with the one-line wiring removed, then green with it in place.webSessionFlagOn.test.ts)5 failed,trackWebSessionEventnever called{ name: 'session_bootstrap', properties: { outcome: 'signed_in' | 'revoked' | 'restored', origin } }, and{ name: 'session_signed_out_remotely', properties: { origin } }after a heartbeat reads a revoked sessionworkshop-web-session-identity.test.ts)5 failed,captureWebSessionEventnever calledsession_bootstrapwithsigned_in,signed_out,restoredunifiedBillingSession.test.ts)5 failed, no event trackedsession_bootstrapwithsigned_in,signed_out,restored,revokedSink tests: Datadog RUM
addAction(name, properties), Cloud PostHogcapture(name, properties), website PostHogcapture, billing-web RUM and PostHog. Each forwards both events unchanged.Where this sits
Remaining unified web session follow-ups. This PR is in bold.
identity.refreshon csrf_invalidsession_bootstrapandsession_signed_out_remotelyunified_web_session