Repository navigation
feat: classify image compositor domain - #19856
Conversation
📦 Bundle: 9.35 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 4.84 kB (baseline 4.84 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.15 MB (baseline 2.15 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 146 kB (baseline 146 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 669 kB (baseline 669 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 54.3 kB (baseline 54.3 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 14 unchanged Editors & Dialogs — 340 kB (baseline 340 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 211 kB (baseline 211 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 3.07 MB (baseline 3.07 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 22 unchanged Utilities & Hooks — 822 kB (baseline 822 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 55 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.8 MB (baseline 18.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 345 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-10T09:36:23.571Z",
"gitSha": "0093604a8d2b91ba8a0c9fa825a6795f038efaaa",
"branch": "feat/ddd-classify-compositor",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2063.5350000000017,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.213000000000001,
"layouts": 12,
"layoutDurationMs": 3.1809999999999996,
"taskDurationMs": 533.9240000000001,
"heapDeltaBytes": -36728208,
"heapUsedBytes": 68579768,
"domNodes": -162,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.489,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666935483870965,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2058.92300000005,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.992,
"layouts": 11,
"layoutDurationMs": 4.997,
"taskDurationMs": 556.4050000000001,
"heapDeltaBytes": -36327428,
"heapUsedBytes": 68602016,
"domNodes": -162,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.029,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1763.2960000000253,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.553,
"layouts": 12,
"layoutDurationMs": 3.082,
"taskDurationMs": 872.363,
"heapDeltaBytes": -42136808,
"heapUsedBytes": 62948408,
"domNodes": -162,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 138.55100000000002,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66698113207547,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.6800000000576,
"styleRecalcs": 79,
"styleRecalcDurationMs": 19.195999999999998,
"layouts": 12,
"layoutDurationMs": 3.4450000000000003,
"taskDurationMs": 927.5559999999999,
"heapDeltaBytes": -42447576,
"heapUsedBytes": 62969476,
"domNodes": -162,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 148.46800000000002,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1780.417,
"styleRecalcs": 18,
"styleRecalcDurationMs": 7.866000000000001,
"layouts": 14,
"layoutDurationMs": 3.9050000000000002,
"taskDurationMs": 462.635,
"heapDeltaBytes": -38301828,
"heapUsedBytes": 67102404,
"domNodes": -115,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 12.799999999999999,
"eventListeners": -31,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1690.0490000000445,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.522999999999999,
"layouts": 10,
"layoutDurationMs": 2.2839999999999994,
"taskDurationMs": 270.751,
"heapDeltaBytes": 13538288,
"heapUsedBytes": 71691816,
"domNodes": 47,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.873999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 655.7640000000333,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.3229999999999995,
"layouts": 10,
"layoutDurationMs": 2.592,
"taskDurationMs": 485.043,
"heapDeltaBytes": 5396532,
"heapUsedBytes": 110420776,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 160.61899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 663.9930000000049,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.0310000000000006,
"layouts": 9,
"layoutDurationMs": 2.3979999999999997,
"taskDurationMs": 503.9320000000001,
"heapDeltaBytes": -13375416,
"heapUsedBytes": 76388420,
"domNodes": -162,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 157.786,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.092307692307703,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1127.2969999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 800.622,
"heapDeltaBytes": 18795532,
"heapUsedBytes": 101812444,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 58.890000000000015,
"eventListeners": 0,
"totalBlockingTimeMs": 493,
"frameDurationMs": 33.332352941176474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1158.1049999999777,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 838.9670000000001,
"heapDeltaBytes": 17468840,
"heapUsedBytes": 99599084,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 58.158,
"eventListeners": 0,
"totalBlockingTimeMs": 514,
"frameDurationMs": 33.82058823529413,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 856.1300000000074,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.9310000000002,
"heapDeltaBytes": 21561728,
"heapUsedBytes": 117256208,
"domNodes": 0,
"jsHeapTotalBytes": 2887680,
"scriptDurationMs": 142.45200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.3580000000329,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.75900000000007,
"heapDeltaBytes": 22671968,
"heapUsedBytes": 93913920,
"domNodes": 0,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 142.53900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9385.646000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8481.409,
"heapDeltaBytes": 3630896,
"heapUsedBytes": 88501328,
"domNodes": 0,
"jsHeapTotalBytes": -13893632,
"scriptDurationMs": 6806.829000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 28.69388379204893,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9022.955000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8092.699999999999,
"heapDeltaBytes": -12978484,
"heapUsedBytes": 71784016,
"domNodes": 0,
"jsHeapTotalBytes": -14942208,
"scriptDurationMs": 6445.006,
"eventListeners": 0,
"totalBlockingTimeMs": 88,
"frameDurationMs": 27.488719512195118,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8341.162999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7348.506,
"heapDeltaBytes": -1694796,
"heapUsedBytes": 82829132,
"domNodes": 0,
"jsHeapTotalBytes": -17301504,
"scriptDurationMs": 6092.923,
"eventListeners": 0,
"totalBlockingTimeMs": 106,
"frameDurationMs": 28.018791946308728,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9580.171000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8619.223,
"heapDeltaBytes": -11480948,
"heapUsedBytes": 73308744,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 6962.673,
"eventListeners": 0,
"totalBlockingTimeMs": 88,
"frameDurationMs": 27.809011627906976,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 217.20399999998108,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.196000000000002,
"layouts": 12,
"layoutDurationMs": 3.1879999999999997,
"taskDurationMs": 156.86400000000003,
"heapDeltaBytes": 12943180,
"heapUsedBytes": 80805604,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.868999999999998,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.660000000000036,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 184.09500000007029,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.232999999999999,
"layouts": 11,
"layoutDurationMs": 3.0550000000000006,
"taskDurationMs": 142.59500000000003,
"heapDeltaBytes": 12921384,
"heapUsedBytes": 83459092,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.054,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.925000000000068,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2047.4159999999983,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.254999999999999,
"layouts": 8,
"layoutDurationMs": 2.0239999999999996,
"taskDurationMs": 589.492,
"heapDeltaBytes": -58265928,
"heapUsedBytes": 69248800,
"domNodes": -258,
"jsHeapTotalBytes": -3506176,
"scriptDurationMs": 33.005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.643000000031,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.3480000000000003,
"layouts": 8,
"layoutDurationMs": 2.198,
"taskDurationMs": 638.3939999999999,
"heapDeltaBytes": -58655024,
"heapUsedBytes": 69295184,
"domNodes": -258,
"jsHeapTotalBytes": -3244032,
"scriptDurationMs": 35.337,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2203.0279999999607,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.6610000000000005,
"layouts": 8,
"layoutDurationMs": 1.7070000000000003,
"taskDurationMs": 1550.5729999999999,
"heapDeltaBytes": -62400500,
"heapUsedBytes": 67401072,
"domNodes": -258,
"jsHeapTotalBytes": -4816896,
"scriptDurationMs": 761.3380000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615384615385,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2488.531999999964,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.496999999999999,
"layouts": 6,
"layoutDurationMs": 1.323,
"taskDurationMs": 1607.963,
"heapDeltaBytes": 699608,
"heapUsedBytes": 67067576,
"domNodes": -258,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 784.517,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.778378378378385,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3507.896999999957,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.311999999999998,
"layouts": 63,
"layoutDurationMs": 11.357000000000001,
"taskDurationMs": 1550.5610000000001,
"heapDeltaBytes": 18798428,
"heapUsedBytes": 86561416,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 774.471,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3458.520999999905,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.700999999999999,
"layouts": 62,
"layoutDurationMs": 10.016,
"taskDurationMs": 1617.2120000000002,
"heapDeltaBytes": 19097820,
"heapUsedBytes": 86844640,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 741.5090000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665700483091783,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2967.1160000000327,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.276000000000001,
"layouts": 3,
"layoutDurationMs": 0.7510000000000008,
"taskDurationMs": 1898.548,
"heapDeltaBytes": 1239996,
"heapUsedBytes": 69981236,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 954.459,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760227272727274,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2817.9979999999887,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.5489999999999995,
"layouts": 3,
"layoutDurationMs": 0.6069999999999999,
"taskDurationMs": 1830.4300000000003,
"heapDeltaBytes": 456932,
"heapUsedBytes": 68866220,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 929.7739999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.765476190476186,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2048.226999999997,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.531,
"layouts": 7,
"layoutDurationMs": 1.6520000000000004,
"taskDurationMs": 587.3100000000001,
"heapDeltaBytes": -60227500,
"heapUsedBytes": 69496132,
"domNodes": -258,
"jsHeapTotalBytes": -2457600,
"scriptDurationMs": 35.963,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2051.7360000000053,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.0460000000000003,
"layouts": 7,
"layoutDurationMs": 1.662,
"taskDurationMs": 607.365,
"heapDeltaBytes": -60446156,
"heapUsedBytes": 69710940,
"domNodes": -258,
"jsHeapTotalBytes": -2195456,
"scriptDurationMs": 38.779,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 682.3660000000018,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.297999999999998,
"layouts": 11,
"layoutDurationMs": 3.302,
"taskDurationMs": 526.953,
"heapDeltaBytes": -36934972,
"heapUsedBytes": 70738008,
"domNodes": -180,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 150.585,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.6570000000402,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.904,
"layouts": 12,
"layoutDurationMs": 2.887,
"taskDurationMs": 413.19300000000004,
"heapDeltaBytes": 16728344,
"heapUsedBytes": 82924832,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 142.754,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.7140000000122,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3650000000000007,
"layouts": 9,
"layoutDurationMs": 1.744,
"taskDurationMs": 322.325,
"heapDeltaBytes": 15644128,
"heapUsedBytes": 73564820,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.927999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.834000000008,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.192,
"layouts": 8,
"layoutDurationMs": 2.1780000000000004,
"taskDurationMs": 496.779,
"heapDeltaBytes": 15658816,
"heapUsedBytes": 73434480,
"domNodes": -180,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.504000000000001,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.1370000000325,
"styleRecalcs": 80,
"styleRecalcDurationMs": 15.741000000000001,
"layouts": 11,
"layoutDurationMs": 2.921,
"taskDurationMs": 784.869,
"heapDeltaBytes": -29511300,
"heapUsedBytes": 62680352,
"domNodes": -180,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 95.919,
"eventListeners": -108,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1766.0590000000411,
"styleRecalcs": 58,
"styleRecalcDurationMs": 15.112,
"layouts": 9,
"layoutDurationMs": 2.3330000000000006,
"taskDurationMs": 828.741,
"heapDeltaBytes": -28985776,
"heapUsedBytes": 60610676,
"domNodes": -180,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 100.705,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.824761904761907,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1421.3909999999714,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.209,
"layouts": 5,
"layoutDurationMs": 15.303999999999998,
"taskDurationMs": 1099.655,
"heapDeltaBytes": 35811752,
"heapUsedBytes": 126086552,
"domNodes": 15956,
"jsHeapTotalBytes": 12455936,
"scriptDurationMs": 42.35,
"eventListeners": 3244,
"totalBlockingTimeMs": 138,
"frameDurationMs": 19.368918918918908,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8319.715000000031,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.705000000000002,
"layouts": 8,
"layoutDurationMs": 2.085,
"taskDurationMs": 5502.722000000001,
"heapDeltaBytes": -49523828,
"heapUsedBytes": 77637992,
"domNodes": -258,
"jsHeapTotalBytes": -2527232,
"scriptDurationMs": 2533.9269999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699597585513075,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8250.630999999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.639,
"layouts": 9,
"layoutDurationMs": 2.379,
"taskDurationMs": 5512.8279999999995,
"heapDeltaBytes": -50159984,
"heapUsedBytes": 77930376,
"domNodes": -258,
"jsHeapTotalBytes": -3313664,
"scriptDurationMs": 2517.7630000000004,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665858585858583,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24802.876000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24091.995,
"heapDeltaBytes": -25839544,
"heapUsedBytes": 286764540,
"domNodes": -3232,
"jsHeapTotalBytes": 17600512,
"scriptDurationMs": 354.822,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.8307426597582,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 17653.369,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16975.606,
"heapDeltaBytes": -5952864,
"heapUsedBytes": 280041576,
"domNodes": -3232,
"jsHeapTotalBytes": 20783104,
"scriptDurationMs": 277.41499999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.67013888888889,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 28964.53500000001,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28603.337000000003,
"heapDeltaBytes": -26472352,
"heapUsedBytes": 269490592,
"domNodes": -3036,
"jsHeapTotalBytes": 16572416,
"scriptDurationMs": 923.753,
"eventListeners": -648,
"totalBlockingTimeMs": 29,
"frameDurationMs": 55.140571428571434,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 29165.228999999956,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.97099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28853.051000000003,
"heapDeltaBytes": -25157376,
"heapUsedBytes": 274138924,
"domNodes": -3232,
"jsHeapTotalBytes": 16330752,
"scriptDurationMs": 912.115,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 55.979846449136275,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8516.871999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.15300000000002,
"layouts": 20,
"layoutDurationMs": 24.07799999999999,
"taskDurationMs": 8387.978000000001,
"heapDeltaBytes": -3574252,
"heapUsedBytes": 295829480,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 140.374,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 51.8268292682927,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 6412.646999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.91999999999999,
"layouts": 20,
"layoutDurationMs": 25.394,
"taskDurationMs": 6285.491,
"heapDeltaBytes": 4778768,
"heapUsedBytes": 306596852,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 115.642,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.65301204819278,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12506.767999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12235.018,
"heapDeltaBytes": -7640724,
"heapUsedBytes": 275108992,
"domNodes": -209,
"jsHeapTotalBytes": 13668352,
"scriptDurationMs": 241.05600000000004,
"eventListeners": -7,
"totalBlockingTimeMs": 10,
"frameDurationMs": 44.54128113879003,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9201.724000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8880.812999999998,
"heapDeltaBytes": -14232964,
"heapUsedBytes": 260823628,
"domNodes": -3232,
"jsHeapTotalBytes": 27152384,
"scriptDurationMs": 144.50799999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.94340277777778,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 141.55800000003183,
"styleRecalcs": 11,
"styleRecalcDurationMs": 14.14,
"layouts": 9,
"layoutDurationMs": 6.811999999999999,
"taskDurationMs": 106.38099999999997,
"heapDeltaBytes": 4739232,
"heapUsedBytes": 61834040,
"domNodes": -40,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.678999999999998,
"eventListeners": -63,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.655555555555516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 180.53699999995843,
"styleRecalcs": 10,
"styleRecalcDurationMs": 14.870000000000001,
"layouts": 10,
"layoutDurationMs": 5.677,
"taskDurationMs": 170.58999999999997,
"heapDeltaBytes": -46303288,
"heapUsedBytes": 56615756,
"domNodes": 94,
"jsHeapTotalBytes": -4718592,
"scriptDurationMs": 7.319000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 478.3630000000585,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.0939999999999999,
"layouts": 76,
"layoutDurationMs": 15.431000000000001,
"taskDurationMs": 422.377,
"heapDeltaBytes": -13196648,
"heapUsedBytes": 80369352,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 194.302,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 457.66199999991386,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.0230000000000001,
"layouts": 76,
"layoutDurationMs": 15.315999999999999,
"taskDurationMs": 415.447,
"heapDeltaBytes": -13304048,
"heapUsedBytes": 79418948,
"domNodes": 4,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 194.383,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 626.5210000000252,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.439,
"layouts": 76,
"layoutDurationMs": 15.235,
"taskDurationMs": 597.248,
"heapDeltaBytes": 723988,
"heapUsedBytes": 122613448,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 222.136,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.105263157894736,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 637.9399999999578,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.261,
"layouts": 76,
"layoutDurationMs": 15.270000000000001,
"taskDurationMs": 592.859,
"heapDeltaBytes": -3767764,
"heapUsedBytes": 109632696,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 224.83899999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2257 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 312fa2a9682443320546a92cd9191abf93cb3412
Full docs: ADR-DEVEX-LINT-0015 |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
259c205 to
6b6db3f
Compare
2372978 to
210ec4f
Compare
6b6db3f to
efd6a15
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19856 +/- ##
==========================================
+ Coverage 86.07% 86.86% +0.79%
==========================================
Files 3632 2583 -1049
Lines 173371 145167 -28204
Branches 45785 37749 -8036
==========================================
- Hits 149221 126106 -23115
+ Misses 22144 18675 -3469
+ Partials 2006 386 -1620
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: comment. The record matches the code and the gate passes, but the components/** glob from efd6a15 adds two forbidden edges and DDD-EX-013 that the explicit classification avoided, and the PR description no longer matches the head.
I left 9 inline comments: three P2 comments that together undo the types.ts relabeling (record, exceptions.json, baseline.json), and six P3 or nit items on the record prose, the characterization checks, DDD-EX-012's removal criterion and CODEOWNERS alignment.
Pre-merge blockers: none.
Findings without an anchorable line (1)
- P3. The PR description is stale after efd6a15, and it becomes the squash commit message.
- It says 24 files. The record says
expectedFileCount: 25, and the six module paths match 25 tracked files. - "Ten of the 13 external declarations originate in layer editor" is 8 at both commits: 4 from
LayerEditorContent.test.ts, 3 fromLayerEditorContent.vue, 1 fromuseLayerEditorSession.test.ts. - The deep-import count is still 13, but the set changed:
useCompositorWidget.ts -> components/types.tsleft andscripts/widgets.ts -> useCompositorWidget.tsarrived. - The two forbidden-edge fingerprints, DDD-EX-012, DDD-EX-013, the
useCompositorWidget.tsenrollment and the new CODEOWNERS line (which makes @jtydhr88 a code owner of that file) are not mentioned. Because the forbidden edges go unmentioned, "no dependency permission change" reads as if no role-direction debt was accepted. - "10 characterization tests in its core path" matches neither record version: 4 check files at 29cfafc, 5 files with 62 tests at the head. It does match the 10 test files under
compositor/. - "Review commit
259c205here" names a SHA that is not one of this PR's commits (29cfafc and efd6a15). - The body uses its own headings instead of
.github/pull_request_template.md's Changes and Review Focus. That may be the convention for this stack.
- It says 24 files. The record says
Earlier findings confirmed or contested (4)
- Confirmed fixed:
useCompositorWidget.tsnot enrolled. It is enrolled as integration at record lines 17-20, with CODEOWNERS line 52 matching. CODEOWNERS uses last match, and no later line matches the file, sovalidateDomainModuleFilessees the record's owners.architecture:checkpasses. - Contested: per-file
components/entries let new files escape the count. With the explicit entries restored, a newcomponents/LayerList.vuethat importscompositorLayerStatefailsarchitecture:checkas an uncovered deep import. Only a new file that imports nothing from the domain would slip through. The glob that fixed this concern created the debt described in the record comment on lines 9-12. - Confirmed fixed:
compositorLayerState.test.tsmissing from checks. It is listed at record line 44. Three more tests have the same gap; see the inline comment on lines 42-46. - Confirmed fixed: removal criterion could not retire the LiteGraph edge. DDD-EX-012 now covers that fingerprint alone and names a relocation. The inline comment on line 209 notes that the relocation also has to move
CompositorLayerState.
Checked and cleared (6)
- The first commit 29cfafc fails
architecture:checkbecause it adds baseline lines without exceptions. The repository allows only squash merges, so that commit never lands on its own. - Layer editor is not enrolled, although most DDD-EX-011 fingerprints come from it. The PR body says classifying compositor first is deliberate, so the later layer-editor boundary can be measured on its own.
check.tsdoes not test that referenced check files exist, and does not flag exceptions whose fingerprints have left the baseline. Both are gate behavior from the base branch, which this PR does not change. The second one is why DDD-EX-013 has to be deleted by hand.isCompositorWidgetValueaccepts any non-array object.types.tsis unchanged by this PR.- A wider vitest run outside the listed checks printed
ECONNREFUSED 127.0.0.1:3000and still exited 0. No test file changed in this PR. - Open PRs: I fetched the changed files of all open PRs. Only this stack (#19768, #19855, #19856) touches the domain records, ledger or gate, so DDD-EX-011 to 013 collide with nothing. None of the compositor or layer-editor PRs I read adds or removes an import crossing into the domain.
Also verified with no finding: all 15 baseline fingerprints are real imports at the head and map one to one onto exception fingerprints; expectedFileCount: 25 is exact (3 components, 18 composables, 4 integration files); both schemas accept the record and the new exceptions; catalog.json and catalog.md are generator output; splitting into EX-011, 012 and 013 follows the one-exception-per-violation-kind pattern of DDD-EX-003 to 010.
Coverage
Depth standard, reviewed at efd6a15 against feat/ddd-classify-media-tools (210ec4f) with that branch's dependencies installed. I ran the correctness, maintainability, idiomaticity, tests and documentation lanes over all six changed files. The diff is JSON and CODEOWNERS only, with 0 added comment blocks; I checked the 10 added prose strings for accuracy. Fallow was not run because the diff has no source code.
Checks at this head:
pnpm architecture:check: passed.pnpm architecture:updatefollowed bygit status: clean, so the update is idempotent.vitest run scripts/architecture/check.test.ts: 31 passed.- The five listed characterization checks: 62 tests passed.
oxfmt --checkon the changed JSON and Markdown: clean.- CI on this SHA: 101 success, 23 skipped, 0 failing.
Experiments on scratch copies: the explicit-entries suggestion with both deletions (update and check pass, baseline loses the two forbidden-edge lines), the new-component tripwire, the widget-seam mutation, and the unlisted-tests mutation.
210ec4f to
fc26336
Compare
efd6a15 to
2d75a01
Compare
There was a problem hiding this comment.
Verdict: comment. At 2d75a01 the P2 relabeling of components/types.ts is fixed and seven of my nine inline findings are addressed; the widget-integration claim, the PR description and one CODEOWNERS nit remain, all P3.
components/types.ts is listed explicitly as application again, DDD-EX-013 and both forbidden-edge baseline lines are gone, DDD-EX-012's removal criterion names the CompositorLayerState move, the record's description and first promise name the Vue-node adapter, and the three extra tests are listed. On this head against the restacked base (fc26336): architecture:check passes, architecture:update leaves the tree clean, scripts/architecture/check.test.ts passes 38 tests, the eight listed checks pass 86 tests, and oxfmt --check is clean on docs/architecture/domains/.
Pre-merge blockers: none.
Still open (2, plus one inline nit)
- P3, carried from my comment on the scenario name, unanswered. The scenario is still named "...and widget integration", and promise 1 still lists the LiteGraph widget, but no listed check imports
CompositorWidget.ts,useCompositorWidget.ts, thecompositorcase inwidgetMap.tsor theCOMPOSITORentry inscripts/widgets.ts. The three tests added this round cover autosave, the layer cache and the state widgets, not that seam. Either add auseCompositorWidget.test.tsbuilt on a realLGraphNodeand list it, or narrow the scenario name so it stops claiming the widget seam is characterized. - P3, carried from my first review: the PR description has not changed.
- It says 24 files; the record says 25.
- "Ten of the 13 external declarations originate in layer editor" is 8: 4 from
LayerEditorContent.test.ts, 3 fromLayerEditorContent.vue, 1 fromuseLayerEditorSession.test.ts. - "Review commit
259c205here" names a SHA outside this PR, whose commits are now a7dd146, 59c5c09 and 2d75a01. - "10 characterization tests" matches neither the 8 listed check files nor their 86 tests.
- DDD-EX-012, the
useCompositorWidget.tsenrollment and its new CODEOWNERS line are not mentioned. - The forbidden-edge part of my earlier item no longer applies: the 13 deep imports and "no dependency permission change" are now accurate.
The inline comment on CODEOWNERS carries my earlier alignment nit: the realigned block still leaves the useCompositorWidget.ts line past the owner column.
Earlier findings addressed at 2d75a01 (7)
Each of these already has an author reply in its thread.
- P2
components/**relabeledtypes.tsas presentation: explicit entries withtypes.tsas application. - P2 delete DDD-EX-013: removed.
- P2 delete the two forbidden-edge baseline lines: removed.
- P3 DDD-EX-012 removal criterion: now names
CompositorLayerStateandsrc/lib/orsrc/base/. - P3 promise 1 adapter: applied.
- Nit description adapter: applied.
- P3 three unlisted tests: listed; all eight checks pass.
Checked and cleared (1)
- The restacked base fc26336 removed the
expectedFileCountcomparison and the exception-expiry check fromscripts/architecture/check.ts. The field is still required bydomain.schema.json, and 25 is still the exact count, so this record is correct; the unenforced field is a question for #19855, not this PR. It also settles the earlier bot concern about newcomponents/files escaping the count: the count no longer gates anything, while an unclassified file importing compositor internals still fails as a new deep import.
Coverage
Follow-up round at 2d75a01 against feat/ddd-classify-media-tools (fc26336) with that branch's dependencies installed. I reviewed the full PR diff and the base delta in scripts/architecture/check.ts, docs/architecture/domains/AGENTS.md and README.md (210ec4f to fc26336), and reran the repository-prohibition and vocabulary checks over the whole PR. No DrJKL comments are on the PR.
Addresses review feedback: #19856 (comment)
Addresses review feedback: #19856 (comment)
There was a problem hiding this comment.
Verdict: comment. At 7befe94 the CODEOWNERS nit and the scenario-name overclaim are fixed; the reworded first promise now calls the Vue-node adapter characterized, which no check covers, and the PR description is still stale. Both are P3.
b4d639c renamed the scenario to "Compositor sessions preserve layer state and save behavior", and 7befe94 applied the CODEOWNERS alignment as suggested. I replied in both threads. On this head, architecture:check passes, architecture:update leaves the tree clean, and oxfmt --check is clean on docs/architecture/domains/. No test file changed since 2d75a01, where the eight listed checks passed 86 tests. CI at 7befe94 shows 101 success, 24 skipped and 2 still running, with none failing.
Pre-merge blockers: none.
Open findings (2)
- P3, new this round, inline on record line 63: "The core extension and Vue-node adapter remain the characterized host integration seams" claims characterization for
useCompositorWidget.ts, which no test imports. The suggestion restores the plain seam wording that sibling records use. - P3, carried from my first two reviews: the PR description has not changed since it was written for the first commit.
- It says 24 files; the record says 25.
- "Ten of the 13 external declarations originate in layer editor" is 8: 4 from
LayerEditorContent.test.ts, 3 fromLayerEditorContent.vue, 1 fromuseLayerEditorSession.test.ts. - "Review commit
259c205here" names a SHA outside this PR, whose commits are now a7dd146, 59c5c09, 2d75a01, b4d639c and 7befe94. - "10 characterization tests" matches neither the 8 listed check files nor their 86 tests.
- DDD-EX-012, the
useCompositorWidget.tsenrollment and its new CODEOWNERS line are not mentioned.
Addressed since my last review (2)
- Nit CODEOWNERS alignment: applied in 7befe94; reply.
- P3 widget integration not characterized: the scenario name no longer claims it (b4d639c); reply. The promise wording it left behind is open item 1.
The seven findings addressed at 2d75a01 stay addressed: types.ts is still application, DDD-EX-013 and the forbidden-edge lines are still absent, and the record prose and checks list are unchanged apart from the two lines above.
Coverage
Follow-up round at 7befe94 against feat/ddd-classify-media-tools (fc26336, unchanged since my last review) with that branch's dependencies installed. The delta from 2d75a01 touches only CODEOWNERS, the record's scenario name and promise 1, and the regenerated catalog.json. There are no DrJKL comments on the PR.
Addresses review feedback: #19856 (comment)
Addresses review feedback: #19856 (comment)
Addresses review feedback: #19856 (comment)
d198005 to
8279da8
Compare
234181d to
6ec584b
Compare
Addresses review feedback: #19856 (comment)
Addresses review feedback: #19856 (comment)
8279da8 to
1e17c76
Compare
There was a problem hiding this comment.
Verdict: comment. At 1e17c76 every inline finding from my four reviews is addressed; the only open item is the PR description, which still describes the first commit (P3).
1e17c76 restores promise 1 to "The core extension, Vue-node adapter, and LiteGraph widget remain the host integration seams.", so the record no longer claims the adapter is characterized. The other five commits are the same patches restacked onto the new base (6ec584b); git range-diff shows them unchanged. On this head, architecture:check passes, architecture:update leaves the tree clean, oxfmt --check is clean on docs/architecture/domains/, and the eight listed checks pass 86 tests. CI at 1e17c76 has no failures so far; 10 jobs were still running when I checked.
Pre-merge blockers: none.
Open finding (1)
- P3, carried from my first review: the PR description has not changed.
- It says 24 files; the record says 25.
- "Ten of the 13 external declarations originate in layer editor" is 8: 4 from
LayerEditorContent.test.ts, 3 fromLayerEditorContent.vue, 1 fromuseLayerEditorSession.test.ts. - "Review commit
259c205here" names a SHA outside this PR. - "10 characterization tests" matches neither the 8 listed check files nor their 86 tests.
- DDD-EX-012, the
useCompositorWidget.tsenrollment and its CODEOWNERS line are not mentioned.
Status of every earlier finding
Mine, all addressed and answered in their threads:
- P2
components/**relabeledtypes.tsas presentation, with its companions delete DDD-EX-013 and delete the forbidden-edge baseline lines: fixed in the "address compositor classification review" commit. - P3 DDD-EX-012 removal criterion, P3 promise 1 adapter, Nit description adapter, P3 three unlisted tests: fixed in the same commit.
- P3 widget integration not characterized: scenario name narrowed in "narrow compositor characterization claims".
- Nit CODEOWNERS alignment and its carry-over: applied in "align compositor CODEOWNERS entries".
- P3 promise 1 called the adapter characterized: fixed in 1e17c76.
Other reviewers: the four github-actions findings (1, 2, 3, 4) all have author replies. Findings 1, 3 and 4 are fixed at this head. Finding 2's concern is moot: the record lists components/ files explicitly, and the base no longer enforces expectedFileCount. No other review threads exist on the PR.
6ec584b to
a44a012
Compare
Addresses review feedback: #19856 (comment)
Addresses review feedback: #19856 (comment)
1e17c76 to
4b0a030
Compare
dffd90c to
6e36d7e
Compare
The base branch was changed.
afcc41d to
cd837b1
Compare
There was a problem hiding this comment.
Verdict: comment. The restack onto main at cd837b1 carries every fix from earlier rounds into the Fallow-based model, and the record checks out; the PR description now misdescribes how the deep-import debt is handled (P2).
#19855 merged as 312fa2a, and this PR is now one commit on main. It adds the record, the generated zones and rules in boundaries.json, and the CODEOWNERS block, and drops baseline.json and DDD-EX-011/012 because main no longer has a baseline or deep-import exceptions. The record keeps everything settled in earlier rounds: components/types.ts as application, the eight listed checks, the narrowed scenario name and the plain seam promise. Its keys match the five sibling records.
On this head:
architecture:checkpasses.- The eight listed checks pass 86 tests.
oxfmt --checkis clean ondocs/architecture/domains/.- CI so far has 33 success, 21 skipped, 4 running, and none failing;
fallow / fallowpassed. pnpm exec fallow dead-code --boundary-violationsreports no violation that starts inside the compositor zones, so role direction holds.- It does report 12 inherited violations into them, all from unclassified callers. That matches the siblings: image-compare has 4, image-crop 5, mask-editor 14 and painter 4.
- No open PR touches CODEOWNERS,
docs/architecture/domains/ortools/architecture/.
Pre-merge blockers: none.
Open finding (1)
- P2, carried from my first review and now worse after the restack. The PR description still describes the first commit on the old stack, and it becomes the squash commit message on
main.- "13 existing deep-imports recorded as exact, owned, expiring debt" is no longer true. The PR adds no exception and no baseline. Those imports become 12 inherited Fallow boundary violations under
deepImports: "enforced", with no owner or sunset. - "Stacked on #19855; review commit
259c205here" is stale. #19855 is merged, the base ismain, and the only commit is cd837b1. - The Verification list names
architecture:accept-baseline, whichmainno longer has. - "24 files" should be 25.
- "Ten of the 13 external declarations originate in layer editor" is 7 of the 12 distinct violations (8 of 13 import occurrences).
- "10 characterization tests" is 8 check files with 86 tests.
- The new
boundaries.jsonzones and rules are not mentioned.
- "13 existing deep-imports recorded as exact, owned, expiring debt" is no longer true. The PR adds no exception and no baseline. Those imports become 12 inherited Fallow boundary violations under
A body that matches this head:
Classifies the image compositor as a domain record on the Fallow boundary model.
- 25 files in presentation, application and integration roles;
components/types.tsis application.boundaries.jsongains the three compositor zones and their role-direction rules.deepImports: "enforced"with no public entry points: the 12 existing imports from unclassified code (7 from layer editor) are inherited Fallow boundary violations, listed byfallow dead-code --boundary-violations.- Characterization: 8 listed checks covering sessions, save, autosave, layer state, the layer cache, state widgets, the widget component and the core extension.
- No product code, public entry point or allowed dependency changes.
Verification:
architecture:check, the 8 listed checks,oxfmt --check.
Status of earlier findings
The 11 inline findings from my earlier reviews are fixed at this head, and each thread has an author reply or mine. The four github-actions findings have author replies. Their exception and file-count subjects no longer exist on the Fallow model, and the rest are fixed in the record.
Summary
Classifies image compositor as the final bounded Wave 1 slice on top of the merged architecture package.
Verification
pnpm architecture:update(second run byte-idempotent)pnpm architecture:checkgit diff --checkReview notes
mainafter tool: add domain architecture census and ratchet #19768 and feat: classify image crop, compare, and painter domains #19855 merged.cd837b15c44accd28cf8e085323c71e3bcf5e21f.Program: https://github.com/christian-byrne/domain-driven-design-program