Repository navigation
[backport cloud/1.55] test agent turn across panel remount - #19844
Conversation
Minimizing the agent panel mid-turn unmounts AgentPanelRoot, whose onBeforeUnmount runs useAgentSession.stop(). The queued abortActiveTurn() is spared only when a remount bumps sessionGeneration first, so a minimize -- which never remounts -- destroys the live turn locally while the server keeps streaming and keeps answering posts with 409. Reopening hydrates from REST, but applyAssistantRow only returns a pending entry for a streaming row that also carries a pending_ask, so a plain mid-build row restores no active turn and no indicator returns. Adds minimizePanel/restorePanel to the turn-lock harness and a spec pinning the three symptoms. Test-only -- the fix is deliberately out of scope. (cherry picked from commit 59cb692)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2146 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 372683f651901c46661f5ca72c9347d1b5971bdd
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-02T01:31:30.237Z",
"gitSha": "c71f8b84a69889f51fb8bbb77d2f33ac79ed5e0f",
"branch": "backport/19053-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.6700000000146,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.928,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.51,
"heapDeltaBytes": -8680764,
"heapUsedBytes": 58427892,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.68,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1992.3760000000357,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.906000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.23300000000006,
"heapDeltaBytes": -8353956,
"heapUsedBytes": 59405808,
"domNodes": -260,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.889,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.9570000000076,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.008000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.7520000000001,
"heapDeltaBytes": 6201512,
"heapUsedBytes": 73864176,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 121.472,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.2699999999622,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.860000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 764.359,
"heapDeltaBytes": 9556224,
"heapUsedBytes": 77651272,
"domNodes": -259,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 137.416,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.1500000000283,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.63,
"layouts": 6,
"layoutDurationMs": 1.111,
"taskDurationMs": 375.15400000000005,
"heapDeltaBytes": 2716228,
"heapUsedBytes": 70478632,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 16.082000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.8739999999843,
"styleRecalcs": 28,
"styleRecalcDurationMs": 14.219,
"layouts": 6,
"layoutDurationMs": 1.0379999999999998,
"taskDurationMs": 300.06300000000005,
"heapDeltaBytes": 3086956,
"heapUsedBytes": 71069648,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.56,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 611.3369999999918,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.936,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.874,
"heapDeltaBytes": 18669100,
"heapUsedBytes": 86424512,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 144.50000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 561.1669999999549,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.410999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.31999999999994,
"heapDeltaBytes": 18624688,
"heapUsedBytes": 86241428,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 137.187,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1143.7760000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.77,
"heapDeltaBytes": -17711036,
"heapUsedBytes": 73008932,
"domNodes": -294,
"jsHeapTotalBytes": 21889024,
"scriptDurationMs": 58.13400000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 473,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1175.9539999999333,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 857.385,
"heapDeltaBytes": -17335076,
"heapUsedBytes": 73091692,
"domNodes": -297,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 54.867,
"eventListeners": -217,
"totalBlockingTimeMs": 504,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 762.3199999999883,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.5400000000003,
"heapDeltaBytes": 14362664,
"heapUsedBytes": 90205060,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.14700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 779.8090000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.7260000000004,
"heapDeltaBytes": 14273908,
"heapUsedBytes": 91018204,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.37199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 153,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9292.659000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8185.138,
"heapDeltaBytes": -10031800,
"heapUsedBytes": 71930944,
"domNodes": -12,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 6381.518000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7055.960000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6344.738,
"heapDeltaBytes": 11104788,
"heapUsedBytes": 93381504,
"domNodes": -18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 5129.964999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9036.124000000029,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.0680000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7980.211,
"heapDeltaBytes": -1197124,
"heapUsedBytes": 76067064,
"domNodes": -268,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6297.477000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 267,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9413.397999999916,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8393.028,
"heapDeltaBytes": 4110832,
"heapUsedBytes": 86408788,
"domNodes": -14,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 6642.176,
"eventListeners": 0,
"totalBlockingTimeMs": 133,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2030.7020000000193,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.855999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.469,
"heapDeltaBytes": -3464588,
"heapUsedBytes": 83680216,
"domNodes": -242,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 27.591000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2068.657999999914,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.654999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 727.616,
"heapDeltaBytes": -7374040,
"heapUsedBytes": 80091048,
"domNodes": -254,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 45.821,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2159.318999999982,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.858999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1235.362,
"heapDeltaBytes": -11292544,
"heapUsedBytes": 76499404,
"domNodes": -239,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 665.883,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2151.172000000088,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.352,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1281.6940000000002,
"heapDeltaBytes": -7048004,
"heapUsedBytes": 81139852,
"domNodes": -245,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 691.714,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3700.9219999999914,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.550999999999997,
"layouts": 60,
"layoutDurationMs": 15.722,
"taskDurationMs": 1625.4019999999998,
"heapDeltaBytes": 7542244,
"heapUsedBytes": 73993860,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 711.607,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3665.695000000028,
"styleRecalcs": 67,
"styleRecalcDurationMs": 16.439,
"layouts": 60,
"layoutDurationMs": 15.396,
"taskDurationMs": 1698.8940000000002,
"heapDeltaBytes": -18613520,
"heapUsedBytes": 70874828,
"domNodes": -215,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 715.8090000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3435.3020000000356,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.667,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2237.526,
"heapDeltaBytes": -15413640,
"heapUsedBytes": 68595156,
"domNodes": -265,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 1043.3659999999998,
"eventListeners": -159,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2920.8189999999377,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.238999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1799.5260000000003,
"heapDeltaBytes": -9566876,
"heapUsedBytes": 81830176,
"domNodes": -257,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 869.49,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2052.489000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.331999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 664.0149999999999,
"heapDeltaBytes": -6789080,
"heapUsedBytes": 82003960,
"domNodes": -248,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 39.746,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.00900000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.2589999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.6110000000001,
"heapDeltaBytes": -5537124,
"heapUsedBytes": 84073112,
"domNodes": -246,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 26.437,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.0089999999832,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.882,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.07599999999996,
"heapDeltaBytes": 14022556,
"heapUsedBytes": 83353416,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 120.66,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.8540000000357,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.52,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.779,
"heapDeltaBytes": 13757864,
"heapUsedBytes": 83992312,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 133.462,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.9680000000199,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.483,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.122,
"heapDeltaBytes": 5084428,
"heapUsedBytes": 75203144,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.248999999999995,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.0750000000235,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.879999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.88100000000003,
"heapDeltaBytes": 6260836,
"heapUsedBytes": 76438296,
"domNodes": -273,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 10.755,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.0970000000052,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.885,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 776.497,
"heapDeltaBytes": 5167428,
"heapUsedBytes": 75321340,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 104.725,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1790.2780000000575,
"styleRecalcs": 45,
"styleRecalcDurationMs": 20.490000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 976.9219999999999,
"heapDeltaBytes": 3387516,
"heapUsedBytes": 73775856,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 131.927,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1335.1560000000973,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.240000000000006,
"layouts": 5,
"layoutDurationMs": 9.522,
"taskDurationMs": 876.9159999999998,
"heapDeltaBytes": 18450280,
"heapUsedBytes": 101834816,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 30.058,
"eventListeners": 2383,
"totalBlockingTimeMs": 127,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9433.573000000024,
"styleRecalcs": 249,
"styleRecalcDurationMs": 46.353,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5915.169000000001,
"heapDeltaBytes": 1997508,
"heapUsedBytes": 83552700,
"domNodes": -224,
"jsHeapTotalBytes": 1531904,
"scriptDurationMs": 2702.871,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8219.468000000006,
"styleRecalcs": 251,
"styleRecalcDurationMs": 32.285999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5071.048999999999,
"heapDeltaBytes": 328288,
"heapUsedBytes": 88084124,
"domNodes": -239,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2368.527,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14156.27699999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13697.682999999999,
"heapDeltaBytes": -50249140,
"heapUsedBytes": 170242216,
"domNodes": -8061,
"jsHeapTotalBytes": -17891328,
"scriptDurationMs": 212.91500000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13023.769000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12235.497000000001,
"heapDeltaBytes": -24398088,
"heapUsedBytes": 189110600,
"domNodes": -8061,
"jsHeapTotalBytes": -12115968,
"scriptDurationMs": 186.849,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16144.403000000011,
"styleRecalcs": 94,
"styleRecalcDurationMs": 15.030999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15714.434000000001,
"heapDeltaBytes": -65761784,
"heapUsedBytes": 168437424,
"domNodes": -8061,
"jsHeapTotalBytes": -9711616,
"scriptDurationMs": 744.749,
"eventListeners": -14928,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16490.009999999984,
"styleRecalcs": 99,
"styleRecalcDurationMs": 16.134999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16080.677999999998,
"heapDeltaBytes": -37776956,
"heapUsedBytes": 180341896,
"domNodes": -8062,
"jsHeapTotalBytes": -17571840,
"scriptDurationMs": 771.6800000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 16,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4776.292000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.28400000000003,
"layouts": 20,
"layoutDurationMs": 21.985000000000003,
"taskDurationMs": 4698.5740000000005,
"heapDeltaBytes": -36018912,
"heapUsedBytes": 182957608,
"domNodes": -8062,
"jsHeapTotalBytes": 14409728,
"scriptDurationMs": 76.99000000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 129,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5291.506000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.49099999999999,
"layouts": 20,
"layoutDurationMs": 38.620000000000005,
"taskDurationMs": 5233.822000000001,
"heapDeltaBytes": -64427252,
"heapUsedBytes": 169914564,
"domNodes": -8062,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 125.57000000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 308,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6674.625999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6388.276999999998,
"heapDeltaBytes": 12534752,
"heapUsedBytes": 191399016,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 113.761,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6893.737999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6661.616,
"heapDeltaBytes": 4390056,
"heapUsedBytes": 184235568,
"domNodes": 0,
"jsHeapTotalBytes": -24117248,
"scriptDurationMs": 107.85,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 99.46200000001681,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.902,
"layouts": 6,
"layoutDurationMs": 2.0280000000000005,
"taskDurationMs": 78.33999999999999,
"heapDeltaBytes": 3298188,
"heapUsedBytes": 69121820,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.508000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 453.47800000001826,
"styleRecalcs": 16,
"styleRecalcDurationMs": 21.515000000000004,
"layouts": 3,
"layoutDurationMs": 1.117,
"taskDurationMs": 120.254,
"heapDeltaBytes": 5031080,
"heapUsedBytes": 71160216,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.736,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
@coderabbitai review |
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 1 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19844 +/- ##
=============================================
Coverage ? 84.91%
=============================================
Files ? 2318
Lines ? 132711
Branches ? 35778
=============================================
Hits ? 112689
Misses ? 19661
Partials ? 361
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Summary
Adds the black-box panel minimize/restore regression coverage from #19053 to
cloud/1.55. The release branch already contains the equivalent production recovery behavior through the intervening Agent recovery backports, so the original four scenarios pass without a production-code delta.Covers a live turn remaining locked and visible after remount, accepting later socket frames, and rejecting no second send while the first turn remains active.
Related: PM-1776, PM-1682.
Validation
pnpm typecheck:browserknip --cache