Repository navigation
[backport cloud/1.54] test agent turn across panel remount - #19843
Conversation
Minimizing the agent panel mid-turn unmounts AgentPanelRoot, whose onBeforeUnmount runs useAgentSession.stop(). The queued abortActiveTurn() is spared only when a remount bumps sessionGeneration first, so a minimize -- which never remounts -- destroys the live turn locally while the server keeps streaming and keeps answering posts with 409. Reopening hydrates from REST, but applyAssistantRow only returns a pending entry for a streaming row that also carries a pending_ask, so a plain mid-build row restores no active turn and no indicator returns. Adds minimizePanel/restorePanel to the turn-lock harness and a spec pinning the three symptoms. Test-only -- the fix is deliberately out of scope. (cherry picked from commit 59cb692)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1978 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-02T01:30:44.872Z",
"gitSha": "1bc3acb7b1a66ebd7418ea0f0a103d9c7f9ee281",
"branch": "backport/19053-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2043.1239999999775,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.986999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.041,
"heapDeltaBytes": 1696628,
"heapUsedBytes": 71684320,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 9.386000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.925000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.517,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.939,
"heapDeltaBytes": -8537648,
"heapUsedBytes": 62911040,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.009,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1996.058000000005,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.644999999999996,
"layouts": 14,
"layoutDurationMs": 4.0809999999999995,
"taskDurationMs": 982.637,
"heapDeltaBytes": 7553780,
"heapUsedBytes": 78038180,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 177.411,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.3040000000146,
"styleRecalcs": 74,
"styleRecalcDurationMs": 29.096000000000004,
"layouts": 14,
"layoutDurationMs": 3.8859999999999997,
"taskDurationMs": 914.478,
"heapDeltaBytes": 5784700,
"heapUsedBytes": 77170332,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 169.94799999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1685.3989999999612,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.733999999999998,
"layouts": 6,
"layoutDurationMs": 1.0280000000000002,
"taskDurationMs": 363.27,
"heapDeltaBytes": 4581600,
"heapUsedBytes": 75954832,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.858999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.926999999937,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.799,
"layouts": 6,
"layoutDurationMs": 1.0929999999999997,
"taskDurationMs": 370.533,
"heapDeltaBytes": 4261856,
"heapUsedBytes": 74548204,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.758000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 682.2190000000319,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.378,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.7180000000001,
"heapDeltaBytes": 18620200,
"heapUsedBytes": 89198260,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 162.48600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 676.1139999999841,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.716000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.963,
"heapDeltaBytes": -6517988,
"heapUsedBytes": 64776536,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 164.75400000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2050.2710000000093,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.958000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.522,
"heapDeltaBytes": 7539164,
"heapUsedBytes": 83771788,
"domNodes": -277,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 39.327,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2077.4009999998952,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.9770000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 633.7280000000001,
"heapDeltaBytes": 10406672,
"heapUsedBytes": 87185284,
"domNodes": -274,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 34.41100000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2387.0729999999867,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.627,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1669.1989999999998,
"heapDeltaBytes": 27425080,
"heapUsedBytes": 93541324,
"domNodes": -279,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 835.495,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2358.7079999999787,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.384000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1656.7160000000001,
"heapDeltaBytes": 24482472,
"heapUsedBytes": 90646792,
"domNodes": -272,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 813.8209999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3619.991999999968,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.551999999999998,
"layouts": 60,
"layoutDurationMs": 11.548,
"taskDurationMs": 1731.122,
"heapDeltaBytes": 9091020,
"heapUsedBytes": 76654488,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 787.544,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3643.112999999971,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.736000000000002,
"layouts": 60,
"layoutDurationMs": 11.631000000000002,
"taskDurationMs": 1734.5189999999998,
"heapDeltaBytes": 9157944,
"heapUsedBytes": 76700632,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 785.207,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3241.9340000000147,
"styleRecalcs": 44,
"styleRecalcDurationMs": 11.494000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2055.2380000000003,
"heapDeltaBytes": 11160960,
"heapUsedBytes": 92242844,
"domNodes": -257,
"jsHeapTotalBytes": -208896,
"scriptDurationMs": 1013.849,
"eventListeners": -12,
"totalBlockingTimeMs": 8,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3011.940999999979,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.918000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1822.0550000000003,
"heapDeltaBytes": 25181392,
"heapUsedBytes": 92943804,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 989.913,
"eventListeners": 188,
"totalBlockingTimeMs": 4,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.0529999999721,
"styleRecalcs": 3,
"styleRecalcDurationMs": 5.2379999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.4999999999999,
"heapDeltaBytes": 8936288,
"heapUsedBytes": 87542088,
"domNodes": -273,
"jsHeapTotalBytes": -2723840,
"scriptDurationMs": 38.144999999999996,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2012.2920000000022,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.0299999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.956,
"heapDeltaBytes": 21784500,
"heapUsedBytes": 88714020,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.576999999999995,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.0430000000129,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.725,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.946,
"heapDeltaBytes": 14878572,
"heapUsedBytes": 88302016,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 140.63899999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.4610000000239,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.97799999999995,
"heapDeltaBytes": 15187176,
"heapUsedBytes": 88316908,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.487,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.1169999999802,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.735,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.0249999999999,
"heapDeltaBytes": -5164924,
"heapUsedBytes": 68333872,
"domNodes": -298,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 8.007,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2020.7979999998997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.448000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.606,
"heapDeltaBytes": -5754084,
"heapUsedBytes": 67709408,
"domNodes": -297,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 8.233999999999998,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1749.5470000000068,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.822,
"layouts": 18,
"layoutDurationMs": 4.638,
"taskDurationMs": 852.3040000000001,
"heapDeltaBytes": -6596324,
"heapUsedBytes": 66661204,
"domNodes": -296,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 114.50800000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1789.6400000000767,
"styleRecalcs": 79,
"styleRecalcDurationMs": 35.371,
"layouts": 18,
"layoutDurationMs": 5,
"taskDurationMs": 878.235,
"heapDeltaBytes": 1658680,
"heapUsedBytes": 74889676,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 116.956,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.582000000019,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.661,
"layouts": 15,
"layoutDurationMs": 15.829999999999997,
"taskDurationMs": 1009.6939999999998,
"heapDeltaBytes": 19633100,
"heapUsedBytes": 105157540,
"domNodes": 13831,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 32.144999999999996,
"eventListeners": 2385,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8600.856000000022,
"styleRecalcs": 246,
"styleRecalcDurationMs": 33.692,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5870.73,
"heapDeltaBytes": 24964280,
"heapUsedBytes": 90704080,
"domNodes": -272,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 2702.2350000000006,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8577.725999999984,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.261,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5964.179999999999,
"heapDeltaBytes": 13773488,
"heapUsedBytes": 90255148,
"domNodes": -271,
"jsHeapTotalBytes": -1187840,
"scriptDurationMs": 2739.056,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17637.584000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16926.341999999997,
"heapDeltaBytes": -55782132,
"heapUsedBytes": 182804168,
"domNodes": -8068,
"jsHeapTotalBytes": -13533184,
"scriptDurationMs": 297.39799999999997,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17292.97000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16774.505,
"heapDeltaBytes": -56703744,
"heapUsedBytes": 182078728,
"domNodes": -8068,
"jsHeapTotalBytes": -18264064,
"scriptDurationMs": 282.86400000000003,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21448.013000000003,
"styleRecalcs": 173,
"styleRecalcDurationMs": 19.13999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21022.564,
"heapDeltaBytes": -23840868,
"heapUsedBytes": 194171628,
"domNodes": -8068,
"jsHeapTotalBytes": -8470528,
"scriptDurationMs": 954.913,
"eventListeners": -14927,
"totalBlockingTimeMs": 13,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21030.23200000007,
"styleRecalcs": 176,
"styleRecalcDurationMs": 18.88999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20737.874,
"heapDeltaBytes": -38960108,
"heapUsedBytes": 180892912,
"domNodes": -8068,
"jsHeapTotalBytes": -10543104,
"scriptDurationMs": 984.093,
"eventListeners": -14927,
"totalBlockingTimeMs": 115,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6370.479999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.51100000000001,
"layouts": 20,
"layoutDurationMs": 35.31799999999999,
"taskDurationMs": 6265.7480000000005,
"heapDeltaBytes": -45553064,
"heapUsedBytes": 177420796,
"domNodes": -8068,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 117.74600000000002,
"eventListeners": -14929,
"totalBlockingTimeMs": 395,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6299.545999999964,
"styleRecalcs": 20,
"styleRecalcDurationMs": 99.408,
"layouts": 20,
"layoutDurationMs": 28.942999999999984,
"taskDurationMs": 6156.906,
"heapDeltaBytes": -41634784,
"heapUsedBytes": 177454444,
"domNodes": -8068,
"jsHeapTotalBytes": 10166272,
"scriptDurationMs": 111.895,
"eventListeners": -14931,
"totalBlockingTimeMs": 597,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8922.380999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8475.814999999999,
"heapDeltaBytes": -6826396,
"heapUsedBytes": 177241632,
"domNodes": 0,
"jsHeapTotalBytes": -13107200,
"scriptDurationMs": 172.96,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8774.621000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8496.487999999998,
"heapDeltaBytes": 7005728,
"heapUsedBytes": 177766236,
"domNodes": 0,
"jsHeapTotalBytes": -15990784,
"scriptDurationMs": 147.01699999999994,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 99.92399999998725,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.432999999999998,
"layouts": 2,
"layoutDurationMs": 0.8080000000000002,
"taskDurationMs": 73.21,
"heapDeltaBytes": 3025908,
"heapUsedBytes": 71256500,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.711000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 99.5909999999185,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.976999999999999,
"layouts": 2,
"layoutDurationMs": 1.1320000000000001,
"taskDurationMs": 71.529,
"heapDeltaBytes": 2990940,
"heapUsedBytes": 71342448,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.5360000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
@coderabbitai review |
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 4 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19843 +/- ##
=============================================
Coverage ? 84.05%
=============================================
Files ? 2123
Lines ? 127507
Branches ? 34281
=============================================
Hits ? 107172
Misses ? 20156
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Adds the black-box panel minimize/restore regression coverage from #19053 to
cloud/1.54. The release branch already contains the equivalent production recovery behavior through the intervening Agent recovery backports, so the original four scenarios pass without a production-code delta.Covers a live turn remaining locked and visible after remount, accepting later socket frames, and rejecting no second send while the first turn remains active.
Related: PM-1776, PM-1682.
Validation
pnpm typecheck:browserknip --cache