Skip to content

[backport cloud/1.54] test agent turn across panel remount - #19843

Merged
christian-byrne merged 3 commits into
cloud/1.54from
backport/19053-cloud-1.54
Oct 2, 2026
Merged

christian-byrne merged 3 commits into
cloud/1.54from
backport/19053-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Adds the black-box panel minimize/restore regression coverage from #19053 to cloud/1.54. The release branch already contains the equivalent production recovery behavior through the intervening Agent recovery backports, so the original four scenarios pass without a production-code delta.

Covers a live turn remaining locked and visible after remount, accepting later socket frames, and rejecting no second send while the first turn remains active.

Related: PM-1776, PM-1682.

Validation

  • pnpm typecheck:browser
  • focused Playwright cloud project: 4 passed
  • pre-push knip --cache

Glary-Bot and others added 2 commits October 2, 2026 00:43
Minimizing the agent panel mid-turn unmounts AgentPanelRoot, whose
onBeforeUnmount runs useAgentSession.stop(). The queued abortActiveTurn()
is spared only when a remount bumps sessionGeneration first, so a
minimize -- which never remounts -- destroys the live turn locally while
the server keeps streaming and keeps answering posts with 409.

Reopening hydrates from REST, but applyAssistantRow only returns a
pending entry for a streaming row that also carries a pending_ask, so a
plain mid-build row restores no active turn and no indicator returns.

Adds minimizePanel/restorePanel to the turn-lock harness and a spec
pinning the three symptoms. Test-only -- the fix is deliberately out of
scope.

(cherry picked from commit 59cb692)
@vercel

vercel Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 2, 2026 1:19am UTC
billing-web-test Ignored Ignored Oct 2, 2026 1:19am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 83871b28-5f28-4891-924f-a38386cd1a30

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cloud/1.54 Backport PRs for cloud 1.54 cursor-review Trigger multi-model Cursor agent review on this PR greenlight labels Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1978 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1957 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 6ms TBT · 88.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 144ms TBT · 100.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.3 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 174.0 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 64ms TBT · 178.8 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 496ms TBT · 169.2 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 545ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 64.2 MB
canvas-idle: DOM nodes -132
canvas-idle: event listeners -95
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 949ms
canvas-mouse-sweep: script duration 174ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 74.0 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -165
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 367ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.8 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 460ms
dom-widget-clipping: script duration 164ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 73.4 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 637ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.5 MB
large-graph-idle: DOM nodes -276
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1663ms
large-graph-pan: script duration 825ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 87.8 MB
large-graph-pan: DOM nodes -276
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1733ms
large-graph-zoom: script duration 786ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.1 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1939ms
legacy-node-drag: script duration 1002ms
legacy-node-drag: TBT 6ms
legacy-node-drag: heap used 88.3 MB
legacy-node-drag: DOM nodes -129
legacy-node-drag: event listeners 88
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 2
minimap-idle: task duration 571ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.0 MB
minimap-idle: DOM nodes -275
minimap-idle: event listeners -78
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 415ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.2 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 504ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.9 MB
subgraph-idle: DOM nodes -298
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 32ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 865ms
subgraph-mouse-sweep: script duration 116ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 67.5 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1010ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 144ms
subgraph-transition-enter: heap used 100.3 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5917ms
viewport-pan-sweep: script duration 2721ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 86.3 MB
viewport-pan-sweep: DOM nodes -272
viewport-pan-sweep: event listeners -146
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16850ms
vue-large-graph-idle: script duration 290ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 174.0 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 175
vue-large-graph-pan: task duration 20880ms
vue-large-graph-pan: script duration 970ms
vue-large-graph-pan: TBT 64ms
vue-large-graph-pan: heap used 178.8 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 32ms
vue-node-resize-workload: style recalc duration 94ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6211ms
vue-node-resize-workload: script duration 115ms
vue-node-resize-workload: TBT 496ms
vue-node-resize-workload: heap used 169.2 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8486ms
vue-zoom-out-idle: script duration 160ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.3 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 2
workflow-execution: style recalc count 7
workflow-execution: task duration 72ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.0 MB
workflow-execution: DOM nodes 116
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-10-02T01:30:44.872Z",
  "gitSha": "1bc3acb7b1a66ebd7418ea0f0a103d9c7f9ee281",
  "branch": "backport/19053-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2043.1239999999775,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.986999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 566.041,
      "heapDeltaBytes": 1696628,
      "heapUsedBytes": 71684320,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 9.386000000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.925000000006,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.517,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 524.939,
      "heapDeltaBytes": -8537648,
      "heapUsedBytes": 62911040,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.009,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1996.058000000005,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 32.644999999999996,
      "layouts": 14,
      "layoutDurationMs": 4.0809999999999995,
      "taskDurationMs": 982.637,
      "heapDeltaBytes": 7553780,
      "heapUsedBytes": 78038180,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 177.411,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1890.3040000000146,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 29.096000000000004,
      "layouts": 14,
      "layoutDurationMs": 3.8859999999999997,
      "taskDurationMs": 914.478,
      "heapDeltaBytes": 5784700,
      "heapUsedBytes": 77170332,
      "domNodes": -282,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 169.94799999999998,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1685.3989999999612,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.733999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.0280000000000002,
      "taskDurationMs": 363.27,
      "heapDeltaBytes": 4581600,
      "heapUsedBytes": 75954832,
      "domNodes": 77,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 10.858999999999996,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.926999999937,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.799,
      "layouts": 6,
      "layoutDurationMs": 1.0929999999999997,
      "taskDurationMs": 370.533,
      "heapDeltaBytes": 4261856,
      "heapUsedBytes": 74548204,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.758000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 682.2190000000319,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 10.378,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 459.7180000000001,
      "heapDeltaBytes": 18620200,
      "heapUsedBytes": 89198260,
      "domNodes": 22,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 162.48600000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 676.1139999999841,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.716000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 459.963,
      "heapDeltaBytes": -6517988,
      "heapUsedBytes": 64776536,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 164.75400000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2050.2710000000093,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.958000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 640.522,
      "heapDeltaBytes": 7539164,
      "heapUsedBytes": 83771788,
      "domNodes": -277,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 39.327,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2077.4009999998952,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.9770000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 633.7280000000001,
      "heapDeltaBytes": 10406672,
      "heapUsedBytes": 87185284,
      "domNodes": -274,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 34.41100000000001,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2387.0729999999867,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.627,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1669.1989999999998,
      "heapDeltaBytes": 27425080,
      "heapUsedBytes": 93541324,
      "domNodes": -279,
      "jsHeapTotalBytes": 1798144,
      "scriptDurationMs": 835.495,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2358.7079999999787,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.384000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1656.7160000000001,
      "heapDeltaBytes": 24482472,
      "heapUsedBytes": 90646792,
      "domNodes": -272,
      "jsHeapTotalBytes": 1011712,
      "scriptDurationMs": 813.8209999999999,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3619.991999999968,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.551999999999998,
      "layouts": 60,
      "layoutDurationMs": 11.548,
      "taskDurationMs": 1731.122,
      "heapDeltaBytes": 9091020,
      "heapUsedBytes": 76654488,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 787.544,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3643.112999999971,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.736000000000002,
      "layouts": 60,
      "layoutDurationMs": 11.631000000000002,
      "taskDurationMs": 1734.5189999999998,
      "heapDeltaBytes": 9157944,
      "heapUsedBytes": 76700632,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 785.207,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3241.9340000000147,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 11.494000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2055.2380000000003,
      "heapDeltaBytes": 11160960,
      "heapUsedBytes": 92242844,
      "domNodes": -257,
      "jsHeapTotalBytes": -208896,
      "scriptDurationMs": 1013.849,
      "eventListeners": -12,
      "totalBlockingTimeMs": 8,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3011.940999999979,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.918000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1822.0550000000003,
      "heapDeltaBytes": 25181392,
      "heapUsedBytes": 92943804,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 989.913,
      "eventListeners": 188,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.0529999999721,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 5.2379999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 593.4999999999999,
      "heapDeltaBytes": 8936288,
      "heapUsedBytes": 87542088,
      "domNodes": -273,
      "jsHeapTotalBytes": -2723840,
      "scriptDurationMs": 38.144999999999996,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2012.2920000000022,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 1.0299999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 547.956,
      "heapDeltaBytes": 21784500,
      "heapUsedBytes": 88714020,
      "domNodes": -277,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 30.576999999999995,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 579.0430000000129,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.725,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 410.946,
      "heapDeltaBytes": 14878572,
      "heapUsedBytes": 88302016,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 140.63899999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 594.4610000000239,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.033,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.97799999999995,
      "heapDeltaBytes": 15187176,
      "heapUsedBytes": 88316908,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 143.487,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.1169999999802,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.735,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 497.0249999999999,
      "heapDeltaBytes": -5164924,
      "heapUsedBytes": 68333872,
      "domNodes": -298,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 8.007,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.7979999998997,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.448000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.606,
      "heapDeltaBytes": -5754084,
      "heapUsedBytes": 67709408,
      "domNodes": -297,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 8.233999999999998,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1749.5470000000068,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.822,
      "layouts": 18,
      "layoutDurationMs": 4.638,
      "taskDurationMs": 852.3040000000001,
      "heapDeltaBytes": -6596324,
      "heapUsedBytes": 66661204,
      "domNodes": -296,
      "jsHeapTotalBytes": 7331840,
      "scriptDurationMs": 114.50800000000001,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1789.6400000000767,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 35.371,
      "layouts": 18,
      "layoutDurationMs": 5,
      "taskDurationMs": 878.235,
      "heapDeltaBytes": 1658680,
      "heapUsedBytes": 74889676,
      "domNodes": -294,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 116.956,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.582000000019,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.661,
      "layouts": 15,
      "layoutDurationMs": 15.829999999999997,
      "taskDurationMs": 1009.6939999999998,
      "heapDeltaBytes": 19633100,
      "heapUsedBytes": 105157540,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 32.144999999999996,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 144,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8600.856000000022,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 33.692,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5870.73,
      "heapDeltaBytes": 24964280,
      "heapUsedBytes": 90704080,
      "domNodes": -272,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 2702.2350000000006,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8577.725999999984,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.261,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5964.179999999999,
      "heapDeltaBytes": 13773488,
      "heapUsedBytes": 90255148,
      "domNodes": -271,
      "jsHeapTotalBytes": -1187840,
      "scriptDurationMs": 2739.056,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17637.584000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16926.341999999997,
      "heapDeltaBytes": -55782132,
      "heapUsedBytes": 182804168,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13533184,
      "scriptDurationMs": 297.39799999999997,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17292.97000000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16774.505,
      "heapDeltaBytes": -56703744,
      "heapUsedBytes": 182078728,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18264064,
      "scriptDurationMs": 282.86400000000003,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21448.013000000003,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 19.13999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21022.564,
      "heapDeltaBytes": -23840868,
      "heapUsedBytes": 194171628,
      "domNodes": -8068,
      "jsHeapTotalBytes": -8470528,
      "scriptDurationMs": 954.913,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 13,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21030.23200000007,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 18.88999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20737.874,
      "heapDeltaBytes": -38960108,
      "heapUsedBytes": 180892912,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10543104,
      "scriptDurationMs": 984.093,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 115,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6370.479999999987,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 88.51100000000001,
      "layouts": 20,
      "layoutDurationMs": 35.31799999999999,
      "taskDurationMs": 6265.7480000000005,
      "heapDeltaBytes": -45553064,
      "heapUsedBytes": 177420796,
      "domNodes": -8068,
      "jsHeapTotalBytes": 5263360,
      "scriptDurationMs": 117.74600000000002,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 395,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6299.545999999964,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 99.408,
      "layouts": 20,
      "layoutDurationMs": 28.942999999999984,
      "taskDurationMs": 6156.906,
      "heapDeltaBytes": -41634784,
      "heapUsedBytes": 177454444,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10166272,
      "scriptDurationMs": 111.895,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 597,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8922.380999999972,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8475.814999999999,
      "heapDeltaBytes": -6826396,
      "heapUsedBytes": 177241632,
      "domNodes": 0,
      "jsHeapTotalBytes": -13107200,
      "scriptDurationMs": 172.96,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8774.621000000025,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8496.487999999998,
      "heapDeltaBytes": 7005728,
      "heapUsedBytes": 177766236,
      "domNodes": 0,
      "jsHeapTotalBytes": -15990784,
      "scriptDurationMs": 147.01699999999994,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 99.92399999998725,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.432999999999998,
      "layouts": 2,
      "layoutDurationMs": 0.8080000000000002,
      "taskDurationMs": 73.21,
      "heapDeltaBytes": 3025908,
      "heapUsedBytes": 71256500,
      "domNodes": 106,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.711000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 99.5909999999185,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.976999999999999,
      "layouts": 2,
      "layoutDurationMs": 1.1320000000000001,
      "taskDurationMs": 71.529,
      "heapDeltaBytes": 2990940,
      "heapUsedBytes": 71342448,
      "domNodes": 126,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.5360000000000005,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50809 76114 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@christian-byrne

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 8 finding(s).

Severity Count
🟡 Medium 4
🟢 Low 3
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19843   +/-   ##
=============================================
  Coverage              ?   84.05%           
=============================================
  Files                 ?     2123           
  Lines                 ?   127507           
  Branches              ?    34281           
=============================================
  Hits                  ?   107172           
  Misses                ?    20156           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.81% <ø> (?)
unit 79.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 2, 2026
@christian-byrne
christian-byrne merged commit 17e8cb2 into cloud/1.54 Oct 2, 2026
99 checks passed
@christian-byrne
christian-byrne deleted the backport/19053-cloud-1.54 branch October 2, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cloud/1.54 Backport PRs for cloud 1.54 cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants