Repository navigation
test(agent): fix free-use placement typecheck - #19842
christian-byrne wants to merge 5 commits into
Conversation
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 10.1 MB gzip 🔴 +44.7 kBDetailsSummary
Category Glance App Entry Points — 3.89 kB (baseline 3.77 kB) • 🔴 +114 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.47 MB (baseline 1.45 MB) • 🔴 +20.6 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 135 kB (baseline 132 kB) • 🔴 +3.04 kBTop-level views, pages, and routed surfaces
Status: 16 added / 16 removed / 2 unchanged Panels & Settings — 646 kB (baseline 637 kB) • 🔴 +8.26 kBConfiguration panels, inspectors, and settings screens
Status: 12 added / 11 removed / 16 unchanged User & Accounts — 53.6 kB (baseline 37.9 kB) • 🔴 +15.7 kBAuthentication, profile, and account management bundles
Status: 13 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🟢 -92 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 184 kB (baseline 124 kB) • 🔴 +59.8 kBReusable component library chunks
Status: 18 added / 16 removed Data & Services — 4.13 MB (baseline 3.85 MB) • 🔴 +288 kBStores, services, APIs, and repositories
Status: 12 added / 14 removed / 2 unchanged Utilities & Hooks — 586 kB (baseline 563 kB) • 🔴 +22.5 kBHelpers, composables, and utility bundles
Status: 32 added / 32 removed / 6 unchanged Vendor & Third-Party — 17.2 MB (baseline 18.2 MB) • 🟢 -1 MBExternal libraries and shared vendor chunks
Status: 11 added / 11 removed / 7 unchanged Other — 18.3 MB (baseline 17.7 MB) • 🔴 +594 kBBundles that do not match a named category
Status: 180 added / 172 removed / 125 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-02T02:14:11.462Z",
"gitSha": "744b52340a308fa2daeac0fed45a4565939336ea",
"branch": "christian-byrne/fix-free-use-placement-test",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.0860000000057,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6549999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 236.85899999999998,
"heapDeltaBytes": 22306068,
"heapUsedBytes": 76111128,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.617000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2005.8870000000297,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.186,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.853,
"heapDeltaBytes": 367440,
"heapUsedBytes": 67887972,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.765999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1690.6130000000417,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.794000000000004,
"layouts": 12,
"layoutDurationMs": 4.487,
"taskDurationMs": 579.729,
"heapDeltaBytes": 19132092,
"heapUsedBytes": 72714624,
"domNodes": -231,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.708,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1674.5339999999942,
"styleRecalcs": 71,
"styleRecalcDurationMs": 17.161,
"layouts": 12,
"layoutDurationMs": 4.609999999999999,
"taskDurationMs": 582.4689999999999,
"heapDeltaBytes": 19533200,
"heapUsedBytes": 73349920,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.494,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.2570000000364,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.311000000000002,
"layouts": 6,
"layoutDurationMs": 1.2920000000000003,
"taskDurationMs": 261.831,
"heapDeltaBytes": 25282572,
"heapUsedBytes": 79482180,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.071999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1700.3690000000233,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.093,
"layouts": 6,
"layoutDurationMs": 1.492,
"taskDurationMs": 262.95199999999994,
"heapDeltaBytes": 25286048,
"heapUsedBytes": 79131132,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.182,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 544.8429999999576,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.4300000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.596,
"heapDeltaBytes": 14262684,
"heapUsedBytes": 68022600,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.857,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 530.0579999999968,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.4479999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.008,
"heapDeltaBytes": 13955004,
"heapUsedBytes": 67852492,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.53900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 858.395999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.248,
"heapDeltaBytes": 38752632,
"heapUsedBytes": 108041204,
"domNodes": 0,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 39.58600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 261,
"frameDurationMs": 26.260606060606044,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 902.0949999999743,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.317,
"heapDeltaBytes": 11638524,
"heapUsedBytes": 90607468,
"domNodes": 0,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 43.635000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 285,
"frameDurationMs": 27.275757575757588,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 703.7990000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 278.6430000000002,
"heapDeltaBytes": 17272968,
"heapUsedBytes": 103679380,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 96.60600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 92,
"frameDurationMs": 20.591176470588245,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.5720000000224,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.76200000000006,
"heapDeltaBytes": -14192412,
"heapUsedBytes": 80231508,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 104.73300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 20.58529411764705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5905.997000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4937.78,
"heapDeltaBytes": -10378504,
"heapUsedBytes": 71031860,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 3772.7209999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.556445993031357,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6303.560000000005,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.4540000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5147.805,
"heapDeltaBytes": -11248188,
"heapUsedBytes": 72252752,
"domNodes": -142,
"jsHeapTotalBytes": -7737344,
"scriptDurationMs": 3934.2580000000003,
"eventListeners": -74,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.600327868852457,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6137.047999999993,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7430000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5170.5830000000005,
"heapDeltaBytes": 8694480,
"heapUsedBytes": 81289396,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 4003.66,
"eventListeners": 0,
"totalBlockingTimeMs": 18,
"frameDurationMs": 20.790169491525425,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6287.992999999971,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.4220000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5353.271000000001,
"heapDeltaBytes": -5106140,
"heapUsedBytes": 85433720,
"domNodes": -142,
"jsHeapTotalBytes": -1445888,
"scriptDurationMs": 4130.324,
"eventListeners": -52,
"totalBlockingTimeMs": 18,
"frameDurationMs": 22.2017667844523,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2045.4640000000381,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.26,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.28700000000003,
"heapDeltaBytes": -40902620,
"heapUsedBytes": 82386640,
"domNodes": -328,
"jsHeapTotalBytes": -3506176,
"scriptDurationMs": 32.675,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.8220000000147,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.2759999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.50500000000005,
"heapDeltaBytes": 20767976,
"heapUsedBytes": 82972672,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.762000000000004,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2135.673000000054,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.422,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1160.2590000000002,
"heapDeltaBytes": -7165556,
"heapUsedBytes": 70576396,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 588.471,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283464,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2142.310000000009,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.730999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1236.5159999999998,
"heapDeltaBytes": -5097988,
"heapUsedBytes": 82492836,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 613.224,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666406249999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3186.0169999999925,
"styleRecalcs": 63,
"styleRecalcDurationMs": 16.128999999999998,
"layouts": 60,
"layoutDurationMs": 18.486,
"taskDurationMs": 1366.0800000000002,
"heapDeltaBytes": 8904168,
"heapUsedBytes": 73894592,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 610.239,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.842857142857145,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3147.9889999999955,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.530999999999999,
"layouts": 60,
"layoutDurationMs": 16.316,
"taskDurationMs": 1308.009,
"heapDeltaBytes": 9851704,
"heapUsedBytes": 76836788,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 574.09,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137564,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2211.5210000000047,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.745,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1321.228,
"heapDeltaBytes": 17278268,
"heapUsedBytes": 82087832,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 640.5690000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2276.2349999999856,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.806000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1481.2369999999996,
"heapDeltaBytes": 21216560,
"heapUsedBytes": 96935048,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 744.9019999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.789629629629633,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.6850000000286,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.149000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.47200000000004,
"heapDeltaBytes": -347004,
"heapUsedBytes": 87043004,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.661999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2021.8679999999836,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6239999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.6840000000001,
"heapDeltaBytes": 20671992,
"heapUsedBytes": 83574980,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.811999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 467.54400000003216,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.176000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.029,
"heapDeltaBytes": -41463024,
"heapUsedBytes": 63368376,
"domNodes": -249,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 100.151,
"eventListeners": -204,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 488.6769999999956,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.114000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.541,
"heapDeltaBytes": 9715756,
"heapUsedBytes": 63752652,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 103.38300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241382,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.163000000001,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.581999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 302.47,
"heapDeltaBytes": 847920,
"heapUsedBytes": 69997424,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.014999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2010.3019999999674,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.3119999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.353,
"heapDeltaBytes": 933660,
"heapUsedBytes": 69981716,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.512,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.528999999979,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.152,
"layouts": 16,
"layoutDurationMs": 5.274,
"taskDurationMs": 582.391,
"heapDeltaBytes": -6434900,
"heapUsedBytes": 62724292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 92.43100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.4260000000254,
"styleRecalcs": 75,
"styleRecalcDurationMs": 19.380000000000003,
"layouts": 16,
"layoutDurationMs": 5.777,
"taskDurationMs": 584.9140000000001,
"heapDeltaBytes": -6404128,
"heapUsedBytes": 63014968,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 97.66399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 850.4530000000159,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.768000000000004,
"layouts": 5,
"layoutDurationMs": 8.933,
"taskDurationMs": 678.2719999999999,
"heapDeltaBytes": 22056028,
"heapUsedBytes": 108104492,
"domNodes": 13747,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 22.708000000000006,
"eventListeners": 2383,
"totalBlockingTimeMs": 71,
"frameDurationMs": 19.315909090909102,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8190.451999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.91,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4418.662,
"heapDeltaBytes": -37777712,
"heapUsedBytes": 85679244,
"domNodes": -328,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 2020.353,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666122448979593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8209.265000000016,
"styleRecalcs": 250,
"styleRecalcDurationMs": 45.330000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4357.338000000001,
"heapDeltaBytes": -4170832,
"heapUsedBytes": 69481016,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 2014.364,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12464.837999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11690.963,
"heapDeltaBytes": -16034236,
"heapUsedBytes": 190969744,
"domNodes": -3045,
"jsHeapTotalBytes": 7294976,
"scriptDurationMs": 178.592,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.09340101522843,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 12547.71500000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11664.039,
"heapDeltaBytes": -44871152,
"heapUsedBytes": 164185720,
"domNodes": -3045,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 189.005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.379045996592847,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 14197.941999999955,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.103000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13595.258,
"heapDeltaBytes": -28606408,
"heapUsedBytes": 172986476,
"domNodes": -3045,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 661.479,
"eventListeners": -14915,
"totalBlockingTimeMs": 83,
"frameDurationMs": 25.28010657193606,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 15091.169000000036,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.18900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14537.177,
"heapDeltaBytes": -35516820,
"heapUsedBytes": 176607876,
"domNodes": -3046,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 725.083,
"eventListeners": -14915,
"totalBlockingTimeMs": 58,
"frameDurationMs": 27.041323792486587,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-node-resize-workload",
"durationMs": 4563.542000000041,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.897000000000006,
"layouts": 20,
"layoutDurationMs": 26.538000000000007,
"taskDurationMs": 4421.186000000001,
"heapDeltaBytes": 14345640,
"heapUsedBytes": 222791232,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 80.814,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.18095238095238,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4308.983000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.38600000000002,
"layouts": 20,
"layoutDurationMs": 22.159000000000006,
"taskDurationMs": 4214.344000000001,
"heapDeltaBytes": 13940104,
"heapUsedBytes": 227145872,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 73.187,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.540828402366863,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6292.971999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5775.488000000001,
"heapDeltaBytes": -30946876,
"heapUsedBytes": 172604476,
"domNodes": -3045,
"jsHeapTotalBytes": 9195520,
"scriptDurationMs": 88.576,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.282770270270273,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5990.406000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5479.494000000001,
"heapDeltaBytes": -41171152,
"heapUsedBytes": 179064564,
"domNodes": -3045,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 79.27499999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.21283783783783,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 122.52599999999347,
"styleRecalcs": 11,
"styleRecalcDurationMs": 16.355999999999998,
"layouts": 5,
"layoutDurationMs": 2.424,
"taskDurationMs": 99.882,
"heapDeltaBytes": 4149000,
"heapUsedBytes": 57464580,
"domNodes": -111,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.132999999999997,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 463.91700000003766,
"styleRecalcs": 15,
"styleRecalcDurationMs": 11.223000000000003,
"layouts": 3,
"layoutDurationMs": 0.9029999999999999,
"taskDurationMs": 107.473,
"heapDeltaBytes": -41238104,
"heapUsedBytes": 58196300,
"domNodes": -131,
"jsHeapTotalBytes": -2097152,
"scriptDurationMs": 7.582999999999999,
"eventListeners": -74,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 391.1320000000842,
"styleRecalcs": 78,
"styleRecalcDurationMs": 72.328,
"layouts": 76,
"layoutDurationMs": 18.121000000000002,
"taskDurationMs": 359.531,
"heapDeltaBytes": -11699960,
"heapUsedBytes": 76869468,
"domNodes": 76,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 113.423,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 360.45400000000427,
"styleRecalcs": 78,
"styleRecalcDurationMs": 67.873,
"layouts": 76,
"layoutDurationMs": 16.679,
"taskDurationMs": 321.44700000000006,
"heapDeltaBytes": -11299328,
"heapUsedBytes": 75977176,
"domNodes": 76,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 98.85,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 768.0210000000898,
"styleRecalcs": 78,
"styleRecalcDurationMs": 200.079,
"layouts": 76,
"layoutDurationMs": 23.820999999999998,
"taskDurationMs": 742.71,
"heapDeltaBytes": 9544192,
"heapUsedBytes": 128441176,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 191.063,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808495,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 741.237999999953,
"styleRecalcs": 78,
"styleRecalcDurationMs": 194.397,
"layouts": 76,
"layoutDurationMs": 23.942,
"taskDurationMs": 724.283,
"heapDeltaBytes": 9329836,
"heapUsedBytes": 128575828,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 182.565,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444435,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8148f20d57db3bd594684325629d694043dce8e9
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🎭 Playwright: ✅ 2183 passed, 0 failed · 2 flaky📊 Browser Reports
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (3)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe change exports the free-use placement flag and uses it in the related tests. It also narrows the optional keys included in ChangesFree-use placement configuration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The changed test covers the placement fallback, and no user-visible regression was established. The change is ready for normal checks. 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR contains bug-fix language: the title uses “fix” and a commit subject uses “fix”. It changes files under
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 2 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
Exercise the mocked ref setter so the test retains reactive triggering and cleanup semantics. Review: #19842 (comment)
Keep the remote-config key checked against the schema while narrowing the assertion to the intentionally invalid runtime value under test. Review: #19842 (comment)
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19842 +/- ##
==========================================
+ Coverage 84.74% 85.49% +0.74%
==========================================
Files 3412 2401 -1011
Lines 163766 137062 -26704
Branches 44657 35115 -9542
==========================================
- Hits 138783 117177 -21606
+ Misses 23036 19518 -3518
+ Partials 1947 367 -1580
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1051 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 2 prior finding(s) across 1 round(s) (0 never answered).
Found 1 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
Panel: 7/8 reviewers contributed findings.
Reviewers that did not contribute: gemini-3.1-pro:edge-case (error)
Export the production flag key for the test and constrain the invalid runtime fixture's escape hatch to the explicit placement union. Review: #19842 (comment)
Exercise the mocked ref setter so the test retains reactive triggering and cleanup semantics. Review: #19842 (comment)
Keep the remote-config key checked against the schema while narrowing the assertion to the intentionally invalid runtime value under test. Review: #19842 (comment)
Export the production flag key for the test and constrain the invalid runtime fixture's escape hatch to the explicit placement union. Review: #19842 (comment)
f9428c3 to
fd1b180
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 3 — ledger: 3 prior finding(s) across 2 round(s) (0 never answered).
Found 2 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
|
Superseded by the narrower exact-head-green #19839, which fixes the same post-merge placement typecheck without changing the shared RemoteConfig model and is now under explicit human review ownership. |
Summary
Fix the current
maintypecheck failure infreeUsePlacement.test.tsby injecting the intentionally invalidunknownserver value at runtime withReflect.set. This keeps the runtime fallback coverage without claiming that the invalid value satisfies the generated remote-config literal union.Validation
vitest run src/workbench/extensions/agent/experiments/freeUsePlacement.test.ts— 4 passedfreeUsePlacement.test.ts:44; the reused local dependency tree reports unrelated package-version errors, so CI is the authoritative clean-install typecheck