Repository navigation
account-core 1.0.0-alpha.1 - #19795
Conversation
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3c33aff1389a0ce5f673e8aa455de3d4b7fb7b58
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2187 passed, 0 failed📊 Browser Reports
📦 Bundle: 10.1 MB gzip 🔴 +2.04 MBDetailsSummary
Category Glance App Entry Points — 3.89 kB (baseline 3.64 kB) • 🔴 +251 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.47 MB (baseline 1.25 MB) • 🔴 +220 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 1 removed / 1 shrank Views & Navigation — 135 kB (baseline 112 kB) • 🔴 +23.1 kBTop-level views, pages, and routed surfaces
Status: 17 added / 15 removed / 1 shrank Panels & Settings — 646 kB (baseline 551 kB) • 🔴 +94.8 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 26 removed User & Accounts — 53.6 kB (baseline 29.1 kB) • 🔴 +24.5 kBAuthentication, profile, and account management bundles
Status: 15 added / 10 removed Editors & Dialogs — 126 kB (baseline 121 kB) • 🔴 +4.87 kBModals, dialogs, drawers, and in-app editors
Status: 8 added / 6 removed UI Components — 184 kB (baseline 64.7 kB) • 🔴 +119 kBReusable component library chunks
Status: 18 added / 14 removed Data & Services — 4.13 MB (baseline 3.37 MB) • 🔴 +755 kBStores, services, APIs, and repositories
Status: 14 added / 17 removed Utilities & Hooks — 586 kB (baseline 357 kB) • 🔴 +228 kBHelpers, composables, and utility bundles
Status: 38 added / 35 removed Vendor & Third-Party — 17.2 MB (baseline 15.7 MB) • 🔴 +1.51 MBExternal libraries and shared vendor chunks
Status: 18 added / 16 removed Other — 18.3 MB (baseline 12.4 MB) • 🔴 +5.91 MBBundles that do not match a named category
Status: 194 added / 164 removed / 110 shrank / 1 unchanged ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-01T19:28:23.333Z",
"gitSha": "b5da2dbbac57b9a83d096c36ed58417b6521acd6",
"branch": "account-core-version-bump-1.0.0-alpha.1",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2057.7330000000416,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.992999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.512,
"heapDeltaBytes": -28094904,
"heapUsedBytes": 74163868,
"domNodes": -252,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 9.046999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2019.9670000000651,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6419999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.502,
"heapDeltaBytes": 22335824,
"heapUsedBytes": 75911804,
"domNodes": -230,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.611,
"eventListeners": -119,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1780.4360000000088,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.155,
"layouts": 12,
"layoutDurationMs": 3.9090000000000003,
"taskDurationMs": 762.888,
"heapDeltaBytes": 19518248,
"heapUsedBytes": 73234016,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.417,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667289719626165,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1761.5039999999453,
"styleRecalcs": 53,
"styleRecalcDurationMs": 16.43,
"layouts": 12,
"layoutDurationMs": 4.191000000000001,
"taskDurationMs": 748.1640000000001,
"heapDeltaBytes": 19483832,
"heapUsedBytes": 73138528,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 154.69299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.2560000000058,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.438,
"layouts": 6,
"layoutDurationMs": 1.271,
"taskDurationMs": 329.49399999999997,
"heapDeltaBytes": 3432504,
"heapUsedBytes": 70533108,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.557999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1697.2939999999426,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.233,
"layouts": 6,
"layoutDurationMs": 1.1789999999999998,
"taskDurationMs": 326.608,
"heapDeltaBytes": 25258360,
"heapUsedBytes": 78825740,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.030999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 676.4610000000175,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.639,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.63100000000003,
"heapDeltaBytes": -7305516,
"heapUsedBytes": 59087728,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 165.598,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 709.344000000101,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.5700000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.16299999999995,
"heapDeltaBytes": -7915316,
"heapUsedBytes": 59345520,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 166.643,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667441860465132,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1130.741999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 780.8069999999999,
"heapDeltaBytes": 15082968,
"heapUsedBytes": 93003168,
"domNodes": 0,
"jsHeapTotalBytes": 8290304,
"scriptDurationMs": 64.923,
"eventListeners": 0,
"totalBlockingTimeMs": 500,
"frameDurationMs": 33.332352941176474,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1136.3629999999603,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 799.6759999999999,
"heapDeltaBytes": 15431608,
"heapUsedBytes": 84096140,
"domNodes": 0,
"jsHeapTotalBytes": 6717440,
"scriptDurationMs": 70.518,
"eventListeners": 0,
"totalBlockingTimeMs": 521,
"frameDurationMs": 34.339393939393936,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.8119999999763,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.7630000000004,
"heapDeltaBytes": 17683864,
"heapUsedBytes": 104333204,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 166.94000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.7809999999408,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.5389999999998,
"heapDeltaBytes": 18380132,
"heapUsedBytes": 103832952,
"domNodes": 0,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 163.34699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10519.475999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9582.321,
"heapDeltaBytes": 9661176,
"heapUsedBytes": 86262888,
"domNodes": -142,
"jsHeapTotalBytes": -4853760,
"scriptDurationMs": 7894.527,
"eventListeners": -78,
"totalBlockingTimeMs": 1199,
"frameDurationMs": 32.65900621118013,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9707.120000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8863.77,
"heapDeltaBytes": -10188520,
"heapUsedBytes": 70689260,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 7212.441,
"eventListeners": 0,
"totalBlockingTimeMs": 724,
"frameDurationMs": 32.011881188118814,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9789.64099999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8943.446999999998,
"heapDeltaBytes": -14075908,
"heapUsedBytes": 66996724,
"domNodes": 0,
"jsHeapTotalBytes": -13369344,
"scriptDurationMs": 7285.504000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 699,
"frameDurationMs": 32.075081967213116,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9945.560000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9116.946,
"heapDeltaBytes": 10501060,
"heapUsedBytes": 86564764,
"domNodes": -142,
"jsHeapTotalBytes": -5902336,
"scriptDurationMs": 7463.579000000001,
"eventListeners": -74,
"totalBlockingTimeMs": 961,
"frameDurationMs": 32.145307443365695,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "large-graph-idle",
"durationMs": 2048.1890000000362,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.3220000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.6739999999999,
"heapDeltaBytes": -39732064,
"heapUsedBytes": 82628168,
"domNodes": -328,
"jsHeapTotalBytes": -2981888,
"scriptDurationMs": 35.704,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2013.7809999999945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.8720000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.615,
"heapDeltaBytes": -1520476,
"heapUsedBytes": 84316932,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.672999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2326.833000000022,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.674000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1604.119,
"heapDeltaBytes": -5127340,
"heapUsedBytes": 78795436,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 825.23,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786956521739125,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2191.4199999999937,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.991999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1438.526,
"heapDeltaBytes": -4820460,
"heapUsedBytes": 82092264,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 828.102,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66641221374046,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3756.0679999999707,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.709000000000001,
"layouts": 60,
"layoutDurationMs": 14.37,
"taskDurationMs": 1754.359,
"heapDeltaBytes": -11715232,
"heapUsedBytes": 76459724,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 803.218,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592920353983,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3587.2399999999516,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.104000000000001,
"layouts": 60,
"layoutDurationMs": 14.139,
"taskDurationMs": 1656.6190000000001,
"heapDeltaBytes": -11542140,
"heapUsedBytes": 76917996,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 761.7579999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6660465116279,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3116.1749999999984,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.420999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1919.523,
"heapDeltaBytes": 4435276,
"heapUsedBytes": 91287820,
"domNodes": 0,
"jsHeapTotalBytes": 1765376,
"scriptDurationMs": 973.2280000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755675675675672,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3052.640999999994,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.108000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1895.646,
"heapDeltaBytes": 17174088,
"heapUsedBytes": 83760964,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 973.9119999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75769230769231,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2019.4480000000112,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.384000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.1100000000001,
"heapDeltaBytes": 21124964,
"heapUsedBytes": 83945200,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.818000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.0920000000724,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.7529999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.436,
"heapDeltaBytes": -40586200,
"heapUsedBytes": 83657156,
"domNodes": -334,
"jsHeapTotalBytes": -1671168,
"scriptDurationMs": 31.721,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.8250000000189,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.429999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.03999999999996,
"heapDeltaBytes": 9717748,
"heapUsedBytes": 63687320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.375,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.9500000000162,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.717,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.236,
"heapDeltaBytes": -11781980,
"heapUsedBytes": 57528956,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.92499999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.037999999999,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.641000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.182,
"heapDeltaBytes": 21972376,
"heapUsedBytes": 75858920,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.441,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2003.2170000000633,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.531999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 299.18100000000004,
"heapDeltaBytes": 532488,
"heapUsedBytes": 70122896,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.144999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.8500000000358,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.943,
"layouts": 16,
"layoutDurationMs": 5.645,
"taskDurationMs": 607.734,
"heapDeltaBytes": 15006616,
"heapUsedBytes": 69279532,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 108.88300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.642000000078,
"styleRecalcs": 61,
"styleRecalcDurationMs": 17.225,
"layouts": 16,
"layoutDurationMs": 5.7059999999999995,
"taskDurationMs": 734.202,
"heapDeltaBytes": -6435728,
"heapUsedBytes": 62531308,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.207,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.51800000001,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.599000000000007,
"layouts": 5,
"layoutDurationMs": 13.023999999999997,
"taskDurationMs": 874.8559999999999,
"heapDeltaBytes": 23929016,
"heapUsedBytes": 109922184,
"domNodes": 13747,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 29.445000000000014,
"eventListeners": 2383,
"totalBlockingTimeMs": 133,
"frameDurationMs": 19.4054794520548,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8458.562000000029,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.5,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5765.969999999999,
"heapDeltaBytes": -23210464,
"heapUsedBytes": 62867812,
"domNodes": -142,
"jsHeapTotalBytes": -11370496,
"scriptDurationMs": 2735.8599999999997,
"eventListeners": -78,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666074950690337,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8408.623000000034,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.678,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5635.06,
"heapDeltaBytes": -39043348,
"heapUsedBytes": 83443160,
"domNodes": -328,
"jsHeapTotalBytes": -2789376,
"scriptDurationMs": 2641.899,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69920634920635,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16678.239000000074,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16096.659,
"heapDeltaBytes": -36289160,
"heapUsedBytes": 170294300,
"domNodes": -3045,
"jsHeapTotalBytes": 8966144,
"scriptDurationMs": 254.89300000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.180067567567573,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 16713.628999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16083.796,
"heapDeltaBytes": -19481036,
"heapUsedBytes": 189317712,
"domNodes": -3044,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 248.23499999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.505451448040887,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 20645.712000000003,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.536999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20221.185999999998,
"heapDeltaBytes": -31382212,
"heapUsedBytes": 191547808,
"domNodes": -3045,
"jsHeapTotalBytes": 5615616,
"scriptDurationMs": 848.711,
"eventListeners": -14915,
"totalBlockingTimeMs": 35,
"frameDurationMs": 36.41834215167549,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 20492.467000000033,
"styleRecalcs": 174,
"styleRecalcDurationMs": 17.414999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20142.412,
"heapDeltaBytes": -16198320,
"heapUsedBytes": 192182868,
"domNodes": -3045,
"jsHeapTotalBytes": 6766592,
"scriptDurationMs": 818.246,
"eventListeners": -14915,
"totalBlockingTimeMs": 6,
"frameDurationMs": 37.51373626373626,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6079.70499999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.35399999999998,
"layouts": 20,
"layoutDurationMs": 23.84800000000001,
"taskDurationMs": 5942.474000000001,
"heapDeltaBytes": 846500,
"heapUsedBytes": 212859796,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 102.97700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.864942528735625,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6186.496000000034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.80600000000001,
"layouts": 20,
"layoutDurationMs": 23.579000000000004,
"taskDurationMs": 6018.634999999999,
"heapDeltaBytes": -6446612,
"heapUsedBytes": 206473764,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 105.18900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.635195530726264,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8571.582000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8247.767,
"heapDeltaBytes": -37722536,
"heapUsedBytes": 175832980,
"domNodes": -3045,
"jsHeapTotalBytes": 7131136,
"scriptDurationMs": 128.94299999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.538965517241376,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8596.760000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8309.856000000002,
"heapDeltaBytes": -31683756,
"heapUsedBytes": 183545896,
"domNodes": -3045,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 127.42400000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.193877551020407,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 493.22000000006483,
"styleRecalcs": 21,
"styleRecalcDurationMs": 16.2,
"layouts": 4,
"layoutDurationMs": 1.775,
"taskDurationMs": 153.21599999999995,
"heapDeltaBytes": 6098540,
"heapUsedBytes": 59436312,
"domNodes": -101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.229000000000003,
"eventListeners": -38,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 94.62299999995594,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.977000000000002,
"layouts": 2,
"layoutDurationMs": 1.3259999999999998,
"taskDurationMs": 72.385,
"heapDeltaBytes": 3736660,
"heapUsedBytes": 68354308,
"domNodes": 114,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.810999999999996,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 793.9270000000533,
"styleRecalcs": 78,
"styleRecalcDurationMs": 98.25,
"layouts": 76,
"layoutDurationMs": 23.836,
"taskDurationMs": 756.418,
"heapDeltaBytes": 16493204,
"heapUsedBytes": 86194624,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 309.035,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 885.7370000000628,
"styleRecalcs": 78,
"styleRecalcDurationMs": 101.64399999999999,
"layouts": 76,
"layoutDurationMs": 24.826,
"taskDurationMs": 854.4280000000001,
"heapDeltaBytes": 17715700,
"heapUsedBytes": 87424712,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 355.19700000000006,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1408.7519999999358,
"styleRecalcs": 78,
"styleRecalcDurationMs": 252.224,
"layouts": 76,
"layoutDurationMs": 28.951999999999998,
"taskDurationMs": 1391.999,
"heapDeltaBytes": -18884644,
"heapUsedBytes": 109098572,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 477.939,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.70625,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1348.3609999999544,
"styleRecalcs": 78,
"styleRecalcDurationMs": 253.515,
"layouts": 76,
"layoutDurationMs": 27.816,
"taskDurationMs": 1326.1080000000002,
"heapDeltaBytes": -19125840,
"heapUsedBytes": 109010092,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 443.27500000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.087341772151895,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md Publish jobs finished successfully:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19795 +/- ##
==========================================
- Coverage 84.73% 84.72% -0.01%
==========================================
Files 3405 3405
Lines 163468 163468
Branches 42632 42632
==========================================
- Hits 138512 138505 -7
- Misses 23013 23020 +7
Partials 1943 1943
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at exact head ef41582fcee1f35d9ffbde387f0711888f5f6a89.
Full context for agent readers
The prerelease increment is consistent: the registry currently contains 1.0.0-alpha.0, this change advances only @comfyorg/account-core to 1.0.0-alpha.1, and the published export map retains the existing surface while including the newly landed session and workspace entries. The account-core pack-content check and clean-consumer smoke check pass, all review threads are clear, and remote CI is settled with no genuine failures. The two cancelled preview jobs are superseded-run debris.
…d around (Comfy-Org#19797) ## Why platform.comfy.org is joining the shared web session (FE-2902, Comfy-Org/platform Comfy-Org#1274–Comfy-Org#1285). It builds on `@comfyorg/account-core`, but had to work around four gaps in the SDK. Our Cloud app works around the same gap for the session re-read. This PR closes those gaps in the SDK, so platform can delete about 150 lines of workarounds once alpha.2 is published (FE-3146). ## Root cause | Gap | platform workaround | |---|---| | No way to make the identity read the session again | Fires a fake `visible=true` so the identity heartbeat runs (`platformSession.ts:486-536`) | | No timeout on the mint or the session read | Its own `AbortController` wrapper (`withMintTimeout`) | | A mint 404 (unknown, deleted, or not-a-member workspace) maps to `SESSION_REQUEST_REFUSED`+404 | Its own classifier falls back to the default workspace. Cloud kept the dead workspace selected. | | The mint's 401 rules lack `TOKEN_REVOKED`, which `webSession.ts` already maps to `SESSION_REVOKED` | Unaffected, but the SDK is inconsistent | ## How **`identity.refresh(expectedUserId?)`** reads the session now, the same way a heartbeat does: - the same user swaps the session in quietly; - another user goes through `onAccountChanged`; - sibling tabs are told; - it waits for any restore the read starts, then resolves with the settled state. It reads nothing when the tab is signed out, or is signed in as someone other than `expectedUserId`. **`timeoutMs`** (default: none, so behaviour is unchanged): - it is available on `createSessionTokenMint` and on `WebSessionOptions` (read, create, delete, revoke-all); - it uses a new internal `requestTimeout.ts`, modelled on `webSessionFlag`; - the response body is read inside the timed window; - a timeout is `SESSION_UNAVAILABLE`, the only retryable code, so it can never look like a sign-out. **Mint 404 `NOT_FOUND` → `WORKSPACE_ACCESS_DENIED`**: - The backend `ExchangeToken` returns that one answer for a bad ID, a deleted workspace, and a user who isn't a member. One remedy covers all three: drop the workspace. - A new code was rejected because it would break exhaustive `Record<WebSessionErrorCode, …>` maps in Cloud, and likely in platform. `httpStatus` and `serverCode` still carry the 404. - A 404 without that code (a router default, for example) is unchanged. - **Cloud:** when a team-workspace mint is refused with this code (404 or 403), `cloudWebSessionStore` calls `dropDeniedWorkspace`. This matches what it already does on an ingest 403. **Mint 401 `TOKEN_REVOKED` → `SESSION_REVOKED`.** **Docs** (`packages/account-core/docs/web-session.md`): - `refresh` and `timeoutMs`; - the error table now lists `TOKEN_REVOKED`, the mint 404 and timeouts; - a platform.comfy.org row; - a note that the server freezes `email_verified` per session, so call `signedIn()` again after verification. It also removes the stale "probe not served yet" comment in `webSessionFlag.ts`. All changes are additive. Flag-off behaviour is unchanged, and `webSessionFlagOff.test.ts` is untouched. **Deferred:** - Switching Cloud's `reread` overlay to `identity.refresh` changes what the `csrf_invalid` retry does on a revoked, missing or different user, so it gets its own PR. - (Done after Comfy-Org#19757 merged: `workspaceToken` and `remintWorkspaceToken` share `settleScopedToken`. A refused team mint or re-mint drops the workspace, but only while the scope is still current, so a mint that resolves after an account change never drops the new user's workspace.) ## Tests - **account-core:** - a `refresh` block in `webSessionIdentity.lifecycle.test.ts`; - timeout, caller-abort, no-timeout-default and body-timeout rows for both the mint and `webSession`; - mint 404 and `TOKEN_REVOKED` rows. - **Cloud (`webSessionFlagOn.test.ts`):** - the 404 copy; - a table showing that 404 and 403 drop the team workspace and a 503 keeps it. - **Mutation check:** 21 mutants across the five items. All were killed. ## AS IS / TO BE The SDK change has no UI. The Cloud-visible part is a refused team-workspace mint: - AS IS: the tab stays on the dead workspace and shows "refused" copy. - TO BE: the workspace is dropped and the tab falls back to personal. This is pinned by the 404/403/503 table above. ## Plan position | Item | PR | Status | |---|---|---| | F2c billing SDK rails + `remint()` | Comfy-Org#19757 | merged | | ingest-types 1.1.0 | Comfy-Org#19796 | in review | | account-core 1.0.0-alpha.1 | Comfy-Org#19795 | in review | | **SDK gaps for platform** | **this PR** | **in review** | | account-core alpha.2 | — | after this PR | | platform FE-2902 drafts | Comfy-Org/platform Comfy-Org#1280–Comfy-Org#1285 | blocked on alpha.1 / alpha.2 | ```mermaid graph LR IT["ingest-types 1.1.0 Comfy-Org#19796"] --> A1["account-core alpha.1 Comfy-Org#19795"] F2c["Comfy-Org#19757 remint()"] --> A1 A1 --> P["platform FE-2902 drafts"] H["SDK gaps (this PR)"] --> A2["account-core alpha.2"] A2 --> P style H fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ``` Part of FE-3146.
prerelease version increment for @comfyorg/account-core to 1.0.0-alpha.1