Repository navigation
FE-2893 docs(website): describe how the website signs in on the shared web session - #19756
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4d6f2a21f324d2ed19522934dfe33a3778a7415f
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19756.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-7jbq9k9ov-comfyui.vercel.app Last updated: 2026-10-01T13:35:05Z for 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe website README adds an Authentication section. It documents browser account-source selection, Firebase and shared-session flows, fallback behavior, the current Run authentication path, and unaffected clients. ChangesBrowser authentication documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to This change documents existing authentication behavior without changing runtime behavior. No actionable merge-blocking risk is established by the supplied evidence. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to This documentation does not change authentication behavior. However, its assurance about preview and localhost session isolation depends on origin controls whose deployed behavior has not been verified. No new exposure or exploitable vulnerability was established. Retained concerns Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Hardening Proposals
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19756 +/- ##
==========================================
- Coverage 84.71% 84.60% -0.12%
==========================================
Files 3397 3319 -78
Lines 163004 160641 -2363
Branches 42486 41689 -797
==========================================
- Hits 138084 135905 -2179
+ Misses 22996 22929 -67
+ Partials 1924 1807 -117
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified at 21e7e07e4c4e25ed2664c56522b40ae1bb5eab1e.
- The website authentication documentation matches the current flag, cookie, balance, and Firebase fallback behavior.
- It correctly states that Run remains on the tab-local Firebase token path for now.
- Exact-head CI is settled green and all review threads are resolved.
Full context for agent readers
The description accurately separates the anonymous rollout probe from the credentialed feature read, documents the host-only session cookie and read-only personal balance path, and preserves CLI, MCP, Desktop, API-key, localhost, and preview-host behavior.
Why
FE-2893 asks for an auth section in each README the shared web session touches. The account-core doc (
packages/account-core/docs/web-session.md) and the billing-web README are already merged (#19449). The website README is the last one: it doesn't yet say where the website gets its account, what changes withunified_web_sessionon, or why Run still uses the comfy.org login.How
A new
## Authenticationsection inapps/website/README.md, after "Which Cloud the Workshop talks to". It records what a maintainer can't read off the code quickly:/api/auth/token, plus the one anonymous/api/featuresprobe the flag costs.X-Comfy-Client;GET /api/auth/sessionidentity read on the host-only__Host-comfy_sessioncookie;POST /api/auth/session;X-CSRF-Tokenor callsDELETE.credentials: 'omit'. It's blocked on the backend: the Router must accept session tokens, and comfy.org must be trusted for credentialed POST.It links the ADR and the account-core doc instead of restating them. Every relative link resolves.
The docs.comfy.org suggestion (one sign-in across comfy.org, Cloud and billing; Desktop, CLI and API keys unchanged) is drafted separately for the docs team. It holds back "sign out everywhere" until that has a button: today only the account-core
revokeAllWebSessionscall exists, with no UI.AS IS / TO BE
Docs only, no UI change.
Plan position
Fixes FE-2893