Repository navigation
perf(website): load credits checkout on first request - #19718
benceruleanlu wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughHeaderMain now mounts the buy-credits dialog when a credit purchase starts. BuyCreditsDialog prepares its state when it mounts open. Tests cover checkout mounting and receipts aged 60,000 ms and 60,001 ms. ChangesCredits dialog opening behavior
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to Checkout remains deferred until an eligible purchase, while close/reopen and mount-time receipt behavior are preserved. No merge-blocking risk remains. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change defers checkout initialization while preserving existing account and workspace checks. Retaining checkout links across account changes already existed; this PR does not establish broader payment authority. Server-side invalidation of those links and account-switch recovery remain unverified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Hardening Proposals
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (6 passed)
Full details: Website End-To-End Regression CoverageExplanation The PR changes website runtime behavior in
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19718.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-2an3kycjg-comfyui.vercel.app Last updated: 2026-10-01T06:39:48Z for 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e1fe2a5a4cf9eb8b404cb6b8750eac0b1359a144
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #19718 +/- ##
==========================================
- Coverage 84.62% 84.52% -0.11%
==========================================
Files 3390 3317 -73
Lines 162437 160219 -2218
Branches 42298 41562 -736
==========================================
- Hits 137470 135431 -2039
+ Misses 23048 22982 -66
+ Partials 1919 1806 -113
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 73 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
42dfa42 to
aeea4af
Compare
Summary
Load the credits checkout when a visitor first requests it, avoiding its download and initialization during ordinary browsing.
Changes
Review Focus
Prior validation covered 39 header/checkout unit tests and five checkout browser tests for deferred mounting, close/reopen behavior, account gating, and retained-receipt age boundaries. CI has not been checked after rebasing this PR onto current main.
Supersedes #19597 with the same checkout change on the corrected prerequisite branch.