Repository navigation
[backport core/1.55] test: restore abandoned-slice browser coverage (#18840) - #19702
Conversation
`browser_tests` carried 10 tests parked behind `test.fixme(true, 'Activates after slice PR 1618x merges')`. All four gating PRs were closed unmerged on 2026-09-14, so their activation condition could never be met. | File | Tests | Gate | |---|---:|---| | `browser_tests/tests/topbar/workflowTabs.spec.ts` | 4 | #16184 — closed unmerged | | `browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts` | 4 | | `browser_tests/tests/billingFacadeConsumers.spec.ts` | 1 | #16185 — closed unmerged | | `browser_tests/tests/load3d/load3dViewer.spec.ts` | 1 | #16187 — closed unmerged | - Remove all 10 gates and the stale slice-PR comments. - Rename `slice03CanvasPrimitives.spec.ts` to `agentCanvasPrimitives.spec.ts` and remove slice numbering from its suite names. - Move reusable canvas operations into their fixture owners and make the centering and fit tests establish that a viewport change is required before checking the result. - Make the full-screen Load3D viewer respect the right workspace inset published by the Agent panel. - Preserve the widest active inset publisher during graph/linear host switches. - Keep Agent usable as a viewport-width overlay when the dock cannot fit, while publishing zero workspace inset so portaled dialogs retain positive width. Production changes span `ViewerControls.vue`, `load3dViewerDialog.ts`, `useWorkspaceInset.ts`, `load3d.ts`, `DockedAgentPanel.vue`, and `agentPanelStore.ts`, with focused component/composable and cloud browser coverage. 8 of the 10 tests passed on their first run. The two failures were fixed rather than pinned: - **Load3D workspace geometry:** the full-screen viewer was centered and sized against the whole viewport, so it rendered beneath the Agent dock. The cloud case now opens the real Agent panel and checks both docked and 400px overlay geometry in `load3dAgentUpdate.spec.ts` through `load3dAgentFixture`. - **Canvas primitive oracle:** `graph.serialize()` includes viewport state in `extra.ds`, so comparing the whole serialization incorrectly treated `centerOnNode()` doing its job as graph mutation. The test now compares graph data without viewport state. The centering test first shifts the viewport 400×250 away and proves the node is off-center. The fit test first zooms to 3× and proves a node is outside the canvas. Both then assert the requested operation changes the viewport; the centering test also verifies that graph data is unchanged. - Fixes #18918 --------- Co-authored-by: Amp <amp@ampcode.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2138 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 138fd1fe279426c66fd9eafdc6d56b0ccad2b71f
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T08:08:43.335Z",
"gitSha": "14356aee9526e831a843ebd2abbf5b6e7414f23e",
"branch": "christian-byrne/backport-18840-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2000.6079999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.7059999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.898,
"heapDeltaBytes": 7420300,
"heapUsedBytes": 75024448,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.591,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2003.6470000000008,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.738,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.588,
"heapDeltaBytes": 9302984,
"heapUsedBytes": 76889328,
"domNodes": -259,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.413000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.0190000000453,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.699000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 701.527,
"heapDeltaBytes": 2136608,
"heapUsedBytes": 64810892,
"domNodes": -260,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 165.32,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1719.184999999925,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.831999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 788.827,
"heapDeltaBytes": -6408740,
"heapUsedBytes": 61356100,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 160.024,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.1779999999644,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.807,
"layouts": 6,
"layoutDurationMs": 1.0759999999999998,
"taskDurationMs": 335.746,
"heapDeltaBytes": 3055548,
"heapUsedBytes": 70783640,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.533000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.4240000000227,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.767000000000001,
"layouts": 6,
"layoutDurationMs": 1.222,
"taskDurationMs": 340.99800000000005,
"heapDeltaBytes": 2814316,
"heapUsedBytes": 70486396,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.649000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 628.4040000000459,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.504,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.81899999999996,
"heapDeltaBytes": 18883672,
"heapUsedBytes": 86214932,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 165.351,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 624.2839999999887,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.346,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.649,
"heapDeltaBytes": 18582820,
"heapUsedBytes": 86289040,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 166.475,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1229.202999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 894.512,
"heapDeltaBytes": 14026896,
"heapUsedBytes": 104462860,
"domNodes": -296,
"jsHeapTotalBytes": 24006656,
"scriptDurationMs": 69.41699999999999,
"eventListeners": -195,
"totalBlockingTimeMs": 600,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.830999999951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 846.9319999999999,
"heapDeltaBytes": 9741004,
"heapUsedBytes": 99762192,
"domNodes": -265,
"jsHeapTotalBytes": 17453056,
"scriptDurationMs": 72.55799999999999,
"eventListeners": -195,
"totalBlockingTimeMs": 551,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.064000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.7720000000003,
"heapDeltaBytes": 14378848,
"heapUsedBytes": 91113916,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.52500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 839.4980000000487,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.8439999999997,
"heapDeltaBytes": 14249168,
"heapUsedBytes": 90897364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.13899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10644.686999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9773.881,
"heapDeltaBytes": 9356788,
"heapUsedBytes": 91866256,
"domNodes": -16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8050.3769999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 1253,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9805.368000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8934.955,
"heapDeltaBytes": -13779352,
"heapUsedBytes": 68179404,
"domNodes": -14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7619.163,
"eventListeners": 0,
"totalBlockingTimeMs": 1010,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11435.449000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10565.29,
"heapDeltaBytes": 21716088,
"heapUsedBytes": 98204032,
"domNodes": -10,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 8864.860999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1755,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11598.465000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10615.625,
"heapDeltaBytes": -3126272,
"heapUsedBytes": 71481912,
"domNodes": -4,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 8975.818000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1730,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2041.6950000000043,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.8999999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.0009999999999,
"heapDeltaBytes": -3087672,
"heapUsedBytes": 83688472,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 35.437999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2038.2530000000543,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.677999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.3969999999999,
"heapDeltaBytes": -4289696,
"heapUsedBytes": 83340980,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.37100000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2299.6609999999578,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.181999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1654.6970000000001,
"heapDeltaBytes": -11916628,
"heapUsedBytes": 76076156,
"domNodes": -220,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 876.7579999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2268.485999999939,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.292,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1637.102,
"heapDeltaBytes": -7434236,
"heapUsedBytes": 80589168,
"domNodes": -242,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 843.715,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3584.243000000015,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.063,
"layouts": 60,
"layoutDurationMs": 12.772000000000002,
"taskDurationMs": 1704.211,
"heapDeltaBytes": 9988660,
"heapUsedBytes": 75719756,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 837.0490000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3490.0670000000673,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.687999999999999,
"layouts": 60,
"layoutDurationMs": 12.656,
"taskDurationMs": 1668.4150000000002,
"heapDeltaBytes": 8436836,
"heapUsedBytes": 74543548,
"domNodes": -254,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 797.8349999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3120.890999999972,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.315999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1949.404,
"heapDeltaBytes": 26348936,
"heapUsedBytes": 92425100,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1029.8639999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3150.985999999989,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.125000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1972.239,
"heapDeltaBytes": -7523632,
"heapUsedBytes": 82792452,
"domNodes": -254,
"jsHeapTotalBytes": 1232896,
"scriptDurationMs": 996.092,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2011.1099999999738,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.014999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.489,
"heapDeltaBytes": 20185684,
"heapUsedBytes": 84333268,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.654,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2046.8720000000076,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.057999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.985,
"heapDeltaBytes": -5955792,
"heapUsedBytes": 83142452,
"domNodes": -248,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.06800000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 548.9140000000248,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.071,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.83700000000005,
"heapDeltaBytes": 13793960,
"heapUsedBytes": 77122028,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 150.379,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.5199999999786,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.395999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.05,
"heapDeltaBytes": 13345836,
"heapUsedBytes": 77411696,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 148.174,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.7730000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.194999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.30899999999997,
"heapDeltaBytes": -13845560,
"heapUsedBytes": 55952336,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.1850000000000005,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.1480000001002,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.838,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.63000000000005,
"heapDeltaBytes": 10496344,
"heapUsedBytes": 80318604,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.8999999999999995,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.9359999999888,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.05,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.174,
"heapDeltaBytes": 5340128,
"heapUsedBytes": 75238700,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 101.62,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.3469999999288,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.436,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 767.551,
"heapDeltaBytes": 1295476,
"heapUsedBytes": 71171620,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 105.71300000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.075999999989,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.604,
"layouts": 5,
"layoutDurationMs": 13.024000000000001,
"taskDurationMs": 883.7300000000001,
"heapDeltaBytes": -6140836,
"heapUsedBytes": 82335280,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.546000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8271.09200000001,
"styleRecalcs": 248,
"styleRecalcDurationMs": 33.204,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5604.049,
"heapDeltaBytes": -6561536,
"heapUsedBytes": 80276016,
"domNodes": -246,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2713.076,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8337.041,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.794,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5660.057,
"heapDeltaBytes": -10627864,
"heapUsedBytes": 76473684,
"domNodes": -240,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2745.4039999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16732.297000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16106.679,
"heapDeltaBytes": -41287152,
"heapUsedBytes": 184361304,
"domNodes": -8061,
"jsHeapTotalBytes": -13115392,
"scriptDurationMs": 258.639,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16755.35400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16246.143,
"heapDeltaBytes": -38129600,
"heapUsedBytes": 176400004,
"domNodes": -8061,
"jsHeapTotalBytes": -10731520,
"scriptDurationMs": 267.14899999999994,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19756.763000000035,
"styleRecalcs": 157,
"styleRecalcDurationMs": 15.941000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19544.104,
"heapDeltaBytes": 7208936,
"heapUsedBytes": 170329688,
"domNodes": -8061,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 861.885,
"eventListeners": -14928,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20749.12500000005,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.322000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20472.294,
"heapDeltaBytes": -36762092,
"heapUsedBytes": 181097856,
"domNodes": -8061,
"jsHeapTotalBytes": -17235968,
"scriptDurationMs": 928.89,
"eventListeners": -14928,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6097.305000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.13699999999996,
"layouts": 20,
"layoutDurationMs": 24.260999999999992,
"taskDurationMs": 6025.447999999999,
"heapDeltaBytes": -59210556,
"heapUsedBytes": 182008744,
"domNodes": -8090,
"jsHeapTotalBytes": 10022912,
"scriptDurationMs": 112.46799999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 495,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6032.60499999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.89399999999999,
"layouts": 20,
"layoutDurationMs": 23.687,
"taskDurationMs": 5964.393999999999,
"heapDeltaBytes": -39277752,
"heapUsedBytes": 182652348,
"domNodes": -8061,
"jsHeapTotalBytes": 15343616,
"scriptDurationMs": 107.135,
"eventListeners": -14928,
"totalBlockingTimeMs": 419,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8343.103000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8120.611,
"heapDeltaBytes": -17585776,
"heapUsedBytes": 171307664,
"domNodes": 0,
"jsHeapTotalBytes": -6291456,
"scriptDurationMs": 130.14800000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8514.136000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8262.171000000002,
"heapDeltaBytes": 8020860,
"heapUsedBytes": 191804140,
"domNodes": 0,
"jsHeapTotalBytes": -11796480,
"scriptDurationMs": 124.70900000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 501.78600000003826,
"styleRecalcs": 23,
"styleRecalcDurationMs": 32.295,
"layouts": 5,
"layoutDurationMs": 3.0460000000000003,
"taskDurationMs": 147.79200000000003,
"heapDeltaBytes": 5256152,
"heapUsedBytes": 71009152,
"domNodes": 151,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.607999999999997,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 109.55899999999019,
"styleRecalcs": 10,
"styleRecalcDurationMs": 17.812,
"layouts": 2,
"layoutDurationMs": 1.441,
"taskDurationMs": 82.872,
"heapDeltaBytes": 3028708,
"heapUsedBytes": 68868148,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.886999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 5 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
| > | ||
| <div | ||
| class="size-full overflow-hidden rounded-lg border border-interface-stroke" | ||
| v-if="!isOverlay" |
There was a problem hiding this comment.
🟠 High — isOverlay is derived from requestedWidth, which this very drag mutates, so widening the panel past windowWidth - reservedWorkspaceWidth flips isOverlay mid-drag and this v-if unmounts the capturing handle, releasing pointer capture and ending the drag. The user is then left with a viewport-covering overlay that has no resize affordance, recoverable only through the maximize toggle or by closing the panel. Consider keeping the handle mounted in overlay mode, or freezing isOverlay while isResizing is true. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| const { width: viewportWidth } = useWindowSize() | ||
| const panelWidth = computed(() => | ||
| Math.min( | ||
| isOverlay.value ? requestedWidth.value : width.value, |
There was a problem hiding this comment.
🟡 Medium — In overlay mode the panel paints at requestedWidth (up to the full viewport) while the store's public width stays dock-clamped, so width no longer matches what is rendered — a 900px overlay is reported as 844px. Consumers that reserve space from panel.width, such as visibleCanvasViewport(), then frame fit/focus/selection into area the overlay covers; expose the rendered width (or 0) for overlay mode instead. Raised by 1 of 8 reviewers (gpt-5.6-sol-max adversarial).
| 'border-l border-interface-stroke bg-base-background' | ||
| 'docked-agent-panel pointer-events-auto shrink-0 overflow-hidden [anchor-name:--docked-agent-panel]', | ||
| isOverlay | ||
| ? 'fixed inset-y-0 right-0 z-1100 max-w-full bg-base-background shadow-lg' |
There was a problem hiding this comment.
🟡 Medium — The teleported overlay sits at z-1100, below canvas chrome that stays mounted behind it: GraphCanvasMenu (z-1200), ComfyActionbar and ZoomControlsModal (z-1300), and PartnerNodesEducationCard (z-1500). Docked in flow the panel never overlapped those layers, but once teleported to <body> they paint over it and intercept pointer events in the region they cover. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| @@ -0,0 +1,2 @@ | |||
| export const LOAD3D_VIEWER_CONTENT_CLASS = | |||
| 'w-[80vw] max-w-[min(80vw,calc(100vw-var(--workspace-inset-right,0px)-1rem))] h-[80vh] max-h-[80vh]' | |||
There was a problem hiding this comment.
🟡 Medium — max-w-[min(80vw,calc(100vw-var(--workspace-inset-right,0px)-1rem))] has no lower bound, so the viewer shrinks in lockstep with the docked panel: a 420px panel in a 500px window leaves roughly 40-64px of usable dialog width. Add a floor (e.g. min(80vw, max(320px, calc(...)))); the new 500px e2e step only asserts the dialog sits left of the panel, never that it stays usably wide, so the collapse passes CI. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| 'size-full p-2', | ||
| hasOpaqueNeighbor && | ||
| 'border-l border-interface-stroke bg-base-background' | ||
| 'docked-agent-panel pointer-events-auto shrink-0 overflow-hidden [anchor-name:--docked-agent-panel]', |
There was a problem hiding this comment.
🟡 Medium — The [anchor-name:--docked-agent-panel] anchor stays on the element after it teleports, so consumers positioning against it receive overlay coordinates. In linear mode the graph anchor is unavailable and GlobalToast falls back to this panel's left edge, which is 0 for a viewport-filling overlay, pushing left: calc(anchor(...) - 25.5rem) toasts off-screen and hiding error notifications. Raised by 1 of 8 reviewers (gpt-5.6-sol-max adversarial).
| } | ||
|
|
||
| useEventListener(document, 'pointerup', stopResizing) | ||
| useEventListener(document, 'pointercancel', stopResizing) |
There was a problem hiding this comment.
🟢 Low — stopResizing is bound to document pointerup/pointercancel without comparing event.pointerId to the pointer captured in onResizeStart, so with multi-touch or pen-plus-touch input an unrelated pointer lifting anywhere on the document aborts an in-progress resize while the initiating pointer is still down. Store the initiating pointerId and only stop when the terminating event matches it. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).
| ) | ||
| const isOverlay = computed( | ||
| () => | ||
| windowWidth.value <= requestedWidth.value + reservedWorkspaceWidth.value |
There was a problem hiding this comment.
🟢 Low — At windowWidth === requestedWidth + reservedWorkspaceWidth the requested panel and the reserved workspace fit exactly, yet <= switches to overlay mode — teleporting the panel and dropping its layout reservation one pixel early. Use < for the non-fitting condition. Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).
| exact: true | ||
| }) | ||
| this.closeButton = this.root | ||
| .getByRole('button', { name: enMessages.g.close, exact: true }) |
There was a problem hiding this comment.
🟢 Low — closeButton matches on g.close, but the panel's close button is labelled with agent.close (PanelHeader.vue:70); it resolves today only because the two keys happen to hold identical strings in both locales. Rewording agent.close would turn every close() call into a no-match timeout instead of a clear failure — key the locator off agent.close. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| document.documentElement.style.removeProperty(WORKSPACE_INSET_RIGHT) | ||
| return | ||
| } | ||
| const width = Math.max(...widths) |
There was a problem hiding this comment.
🟢 Low — Math.max(...widths) is correct for the mount/unmount handoff of a single surface across two hosts (the case this change targets), but the exported composable's doc comment describes docked surfaces in the plural. Two genuinely distinct right-docked surfaces would need the sum, and max silently under-reports the inset so portaled dialogs render under the outer one; document the single-surface assumption or make the API distinguish the two cases. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
This comment has been minimized.
This comment has been minimized.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #19702 +/- ##
=============================================
- Coverage 84.66% 84.65% -0.01%
=============================================
Files 2314 2315 +1
Lines 131658 131694 +36
Branches 35139 33266 -1873
=============================================
+ Hits 111464 111490 +26
- Misses 19835 19845 +10
Partials 359 359
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #18840 to core/1.55, with two adaptations, each accounted for by the target.
I compared this branch, at 7829f8f against its merge base d173dc6, with #18840's merged diff (3f266cb). Nineteen of the source's 21 files carry exactly the source's added and removed lines. That includes the production changes, their unit tests, load3dAgentFixture.ts, and the load3dAgentUpdate.spec.ts case that the source moves out of load3dViewer.spec.ts.
Adaptations:
agentPanelViewportDrag.spec.tsdoes not exist oncore/1.55, so the source's twotest.failremovals there have no target.- In
browser_tests/fixtures/components/AgentPanel.ts,closeButtonis scoped to the panelheader. With the source's unscoped locator, the cloud run ofagentConsent.spec.ts"keeps the docs link and actions fully visible and in keyboard order" (fr, widths 608 and 672) failed at 2e1c595 with a strict-mode violation: two "Fermer" buttons inside#agent-panel-rooton this branch.PanelHeader.vuerenders the panel's own close control inside its<header>, so scoping there selects the intended button. It is the smallest change that lets the source's switch tonew AgentPanel(page).close()inrequestConsentFromOpenPanelpass on this branch.
Checks:
- At 7829f8f:
vitest runoveruseWorkspaceInset.test.ts,DockedAgentPanel.test.ts,stores/agent/, andsrc/components/load3d/passed 452/452 across 46 files, andpnpm typecheck:browserpassed. - Hosted checks passed at this head, including
playwright-tests (cloud, frontend-dist-cloud)andplaywright-video-new-tests, which had failed on the unscoped locator. Only the previewdeploy-and-commentwas still running when I posted.
## Summary - route every Load3D and HDR viewer through one inset-aware dialog configuration - remove raw-viewport centering overrides that let the docked Agent panel cover viewer content - keep the responsive 80vw cap paired with the full-size dialog variant This follows up on findings from the merged [core/1.55 backport](Comfy-Org#19702 (comment)) and [cloud/1.55 backport](Comfy-Org#19703 (comment)). ## Changes - apply the shared configuration to HDR, Agent reply, Assets, Job History, node, and viewer-control entry points - centralize `renderer`, `size`, `contentClass`, and `maximizable` so responsive geometry cannot drift across callers - remove brittle class-token assertions; browser coverage measures the visible viewer geometry ## Review Focus - confirm the shared `sm:max-w` override remains paired with `size: full` - confirm viewers with custom `onClose` behavior preserve it when spreading the shared configuration ## Validation - `oxfmt --check` passed for all nine changed files - `git diff --check` passed - the focused Vitest runner stalled before producing output in this workspace; CI is rerunning the affected suites
## Summary - route every Load3D and HDR viewer through one inset-aware dialog configuration - remove raw-viewport centering overrides that let the docked Agent panel cover viewer content - keep the responsive 80vw cap paired with the full-size dialog variant This follows up on findings from the merged [core/1.55 backport](#19702 (comment)) and [cloud/1.55 backport](#19703 (comment)). ## Changes - apply the shared configuration to HDR, Agent reply, Assets, Job History, node, and viewer-control entry points - centralize `renderer`, `size`, `contentClass`, and `maximizable` so responsive geometry cannot drift across callers - remove brittle class-token assertions; browser coverage measures the visible viewer geometry ## Review Focus - confirm the shared `sm:max-w` override remains paired with `size: full` - confirm viewers with custom `onClose` behavior preserve it when spreading the shared configuration ## Validation - `oxfmt --check` passed for all nine changed files - `git diff --check` passed - the focused Vitest runner stalled before producing output in this workspace; CI is rerunning the affected suites (cherry picked from commit 3c4030d)
Summary
Manual backport of #18840 to
core/1.55. The change restores ten browser tests stranded behind abandoned slice pull requests and carries the Agent panel and Load3D workspace-inset fixes into the 1.55 core release line.agentPanelViewportDrag.spec.tswas already removed from the target branch, so that modify/delete conflict was resolved by keeping it absent. The full Agent/Load3D integration scenario and focused composable/component regressions are retained.Validation
git diff --checkcore/1.55Backport of #18840.