Repository navigation
[backport cloud/1.54] test: restore abandoned-slice browser coverage (#18840) - #19701
Conversation
`browser_tests` carried 10 tests parked behind `test.fixme(true, 'Activates after slice PR 1618x merges')`. All four gating PRs were closed unmerged on 2026-09-14, so their activation condition could never be met. | File | Tests | Gate | |---|---:|---| | `browser_tests/tests/topbar/workflowTabs.spec.ts` | 4 | #16184 — closed unmerged | | `browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts` | 4 | | `browser_tests/tests/billingFacadeConsumers.spec.ts` | 1 | #16185 — closed unmerged | | `browser_tests/tests/load3d/load3dViewer.spec.ts` | 1 | #16187 — closed unmerged | - Remove all 10 gates and the stale slice-PR comments. - Rename `slice03CanvasPrimitives.spec.ts` to `agentCanvasPrimitives.spec.ts` and remove slice numbering from its suite names. - Move reusable canvas operations into their fixture owners and make the centering and fit tests establish that a viewport change is required before checking the result. - Make the full-screen Load3D viewer respect the right workspace inset published by the Agent panel. - Preserve the widest active inset publisher during graph/linear host switches. - Keep Agent usable as a viewport-width overlay when the dock cannot fit, while publishing zero workspace inset so portaled dialogs retain positive width. Production changes span `ViewerControls.vue`, `load3dViewerDialog.ts`, `useWorkspaceInset.ts`, `load3d.ts`, `DockedAgentPanel.vue`, and `agentPanelStore.ts`, with focused component/composable and cloud browser coverage. 8 of the 10 tests passed on their first run. The two failures were fixed rather than pinned: - **Load3D workspace geometry:** the full-screen viewer was centered and sized against the whole viewport, so it rendered beneath the Agent dock. The cloud case now opens the real Agent panel and checks both docked and 400px overlay geometry in `load3dAgentUpdate.spec.ts` through `load3dAgentFixture`. - **Canvas primitive oracle:** `graph.serialize()` includes viewport state in `extra.ds`, so comparing the whole serialization incorrectly treated `centerOnNode()` doing its job as graph mutation. The test now compares graph data without viewport state. The centering test first shifts the viewport 400×250 away and proves the node is off-center. The fit test first zooms to 3× and proves a node is outside the canvas. Both then assert the requested operation changes the viewport; the centering test also verifies that graph data is unchanged. - Fixes #18918 --------- Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1976 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-01T08:46:16.197Z",
"gitSha": "d3cc99cb73c46a82e1b10330ea4d659ee07fcb6a",
"branch": "christian-byrne/backport-18840-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2175.5490000000464,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.668000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 694.716,
"heapDeltaBytes": -10685784,
"heapUsedBytes": 59848128,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.542000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2053.2760000000962,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.406999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.204,
"heapDeltaBytes": -9429604,
"heapUsedBytes": 61587764,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.219000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1989.157999999975,
"styleRecalcs": 79,
"styleRecalcDurationMs": 36.043,
"layouts": 14,
"layoutDurationMs": 4.879,
"taskDurationMs": 981.8030000000001,
"heapDeltaBytes": 12357484,
"heapUsedBytes": 83638504,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 179.574,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1883.7609999999358,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.099,
"layouts": 14,
"layoutDurationMs": 4.2170000000000005,
"taskDurationMs": 937.196,
"heapDeltaBytes": -3790936,
"heapUsedBytes": 67254088,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 164.92100000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1771.3219999999978,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.99,
"layouts": 6,
"layoutDurationMs": 1.259,
"taskDurationMs": 406.17,
"heapDeltaBytes": 4595648,
"heapUsedBytes": 75624352,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.523999999999997,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.775999999967,
"styleRecalcs": 29,
"styleRecalcDurationMs": 17.756,
"layouts": 6,
"layoutDurationMs": 1.1189999999999998,
"taskDurationMs": 422.49099999999993,
"heapDeltaBytes": 4582632,
"heapUsedBytes": 76024412,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.624999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 737.431000000015,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.941999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.1720000000001,
"heapDeltaBytes": -7561008,
"heapUsedBytes": 63726860,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 175.39200000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 731.1600000000453,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.718000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.85699999999997,
"heapDeltaBytes": -7521372,
"heapUsedBytes": 63421776,
"domNodes": 22,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 164.11399999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.7120000000323,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.947999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 669.1720000000001,
"heapDeltaBytes": 10762028,
"heapUsedBytes": 87550384,
"domNodes": -277,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 33.205999999999996,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2037.117999999964,
"styleRecalcs": 5,
"styleRecalcDurationMs": 8.281,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.873,
"heapDeltaBytes": -16564860,
"heapUsedBytes": 87394048,
"domNodes": -269,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 32.766000000000005,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2681.8190000000186,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.281000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1849.618,
"heapDeltaBytes": 11654052,
"heapUsedBytes": 89503444,
"domNodes": -251,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 926.487,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2368.9699999999903,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.430000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1731.313,
"heapDeltaBytes": 10112632,
"heapUsedBytes": 86984392,
"domNodes": -272,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 851.457,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3779.236000000026,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.240000000000002,
"layouts": 60,
"layoutDurationMs": 12.411999999999999,
"taskDurationMs": 1770.5769999999998,
"heapDeltaBytes": 8185040,
"heapUsedBytes": 76235216,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 800.9730000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3549.1180000000213,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.758999999999997,
"layouts": 60,
"layoutDurationMs": 11.812,
"taskDurationMs": 1713.2580000000003,
"heapDeltaBytes": 7991300,
"heapUsedBytes": 76246080,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 775.802,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3254.604000000029,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.428999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2090.3750000000005,
"heapDeltaBytes": 27835016,
"heapUsedBytes": 95549836,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1046.92,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3224.7019999999793,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.131,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2043.5949999999998,
"heapDeltaBytes": 24396204,
"heapUsedBytes": 92556328,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1028.996,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.705999999976,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.9690000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.8,
"heapDeltaBytes": 9539036,
"heapUsedBytes": 87896008,
"domNodes": -272,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 34.90800000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2035.086999999976,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.015999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 677.422,
"heapDeltaBytes": 22164512,
"heapUsedBytes": 88390256,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.861000000000004,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 680.8540000000107,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.078000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.285,
"heapDeltaBytes": 14309888,
"heapUsedBytes": 86960332,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 151.26700000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.5909999999467,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.943999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.26700000000005,
"heapDeltaBytes": 15172388,
"heapUsedBytes": 88257496,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 147.494,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.840999999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.725,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.3269999999999,
"heapDeltaBytes": 2473248,
"heapUsedBytes": 76027780,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.058,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2005.0340000000233,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.6659999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.072,
"heapDeltaBytes": 1299956,
"heapUsedBytes": 67817820,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.774,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.2400000000134,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.432000000000002,
"layouts": 18,
"layoutDurationMs": 4.841,
"taskDurationMs": 869.826,
"heapDeltaBytes": -10396600,
"heapUsedBytes": 62544784,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 120.175,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.798000000017,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.284000000000002,
"layouts": 18,
"layoutDurationMs": 4.867,
"taskDurationMs": 832.426,
"heapDeltaBytes": -2382904,
"heapUsedBytes": 71152432,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 118.148,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.154999999956,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.092999999999996,
"layouts": 15,
"layoutDurationMs": 15.614000000000003,
"taskDurationMs": 973.772,
"heapDeltaBytes": -5249720,
"heapUsedBytes": 88547424,
"domNodes": 13831,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 31.771,
"eventListeners": 2385,
"totalBlockingTimeMs": 150,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9372.95899999998,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.152,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6402.999,
"heapDeltaBytes": 1160732,
"heapUsedBytes": 77736164,
"domNodes": -287,
"jsHeapTotalBytes": 876544,
"scriptDurationMs": 2897.809,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8478.452999999945,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.34799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5899.945000000001,
"heapDeltaBytes": 10039576,
"heapUsedBytes": 86293440,
"domNodes": -245,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 2738.7460000000005,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18223.55700000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17450.797000000002,
"heapDeltaBytes": -42048044,
"heapUsedBytes": 176981120,
"domNodes": -8068,
"jsHeapTotalBytes": -12902400,
"scriptDurationMs": 317.627,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17655.569000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17009.968,
"heapDeltaBytes": -54814516,
"heapUsedBytes": 179028984,
"domNodes": -8068,
"jsHeapTotalBytes": -9355264,
"scriptDurationMs": 297.53499999999997,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21871.64100000001,
"styleRecalcs": 175,
"styleRecalcDurationMs": 20.345000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21529.225,
"heapDeltaBytes": -65702588,
"heapUsedBytes": 167566996,
"domNodes": -8068,
"jsHeapTotalBytes": -19836928,
"scriptDurationMs": 927.745,
"eventListeners": -14929,
"totalBlockingTimeMs": 107,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21449.832999999897,
"styleRecalcs": 168,
"styleRecalcDurationMs": 18.757000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21080.892,
"heapDeltaBytes": -72281704,
"heapUsedBytes": 166694940,
"domNodes": -8068,
"jsHeapTotalBytes": -18513920,
"scriptDurationMs": 916.969,
"eventListeners": -14927,
"totalBlockingTimeMs": 66,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6521.262000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.553,
"layouts": 20,
"layoutDurationMs": 31.080999999999996,
"taskDurationMs": 6425.571000000001,
"heapDeltaBytes": -57254956,
"heapUsedBytes": 176021548,
"domNodes": -8068,
"jsHeapTotalBytes": 4542464,
"scriptDurationMs": 117.393,
"eventListeners": -14922,
"totalBlockingTimeMs": 433,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6436.13199999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 93.696,
"layouts": 20,
"layoutDurationMs": 31.980999999999995,
"taskDurationMs": 6321.128,
"heapDeltaBytes": -36693224,
"heapUsedBytes": 176726496,
"domNodes": -8068,
"jsHeapTotalBytes": 2969600,
"scriptDurationMs": 115.767,
"eventListeners": -14931,
"totalBlockingTimeMs": 617,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9055.638999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8743.443,
"heapDeltaBytes": 21395400,
"heapUsedBytes": 179035480,
"domNodes": 0,
"jsHeapTotalBytes": -9175040,
"scriptDurationMs": 142.401,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9006.428000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8669.631999999998,
"heapDeltaBytes": 11940548,
"heapUsedBytes": 180027948,
"domNodes": 0,
"jsHeapTotalBytes": -23330816,
"scriptDurationMs": 152.61,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 100.29999999994743,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.544,
"layouts": 2,
"layoutDurationMs": 0.6819999999999999,
"taskDurationMs": 69.28999999999999,
"heapDeltaBytes": 3022564,
"heapUsedBytes": 71530120,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.687000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 124.30300000005445,
"styleRecalcs": 7,
"styleRecalcDurationMs": 17.571,
"layouts": 2,
"layoutDurationMs": 1.2260000000000002,
"taskDurationMs": 80.67300000000002,
"heapDeltaBytes": 2944464,
"heapUsedBytes": 72021336,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.641999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19701 +/- ##
=============================================
Coverage ? 84.01%
=============================================
Files ? 2122
Lines ? 127083
Branches ? 34117
=============================================
Hits ? 106763
Misses ? 20141
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 6 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
| const requestedWidth = computed(() => | ||
| maximized.value ? PANEL_MAX_WIDTH : draggedWidth.value | ||
| ) | ||
| const isOverlay = computed( |
There was a problem hiding this comment.
🟡 Medium — isOverlay compares the window against the unclamped requestedWidth plus reservedWorkspaceWidth, so with a sidebar open (reserved = 56 + 312 = 368) and the panel maximized (960) any window ≤ 1328px — a common laptop width — turns the panel into a full-bleed fixed overlay floating over the sidebar, even though the width clamp directly above would have docked it at 932px. Compare against the clamped width so the store's own fit calculation decides whether the dock fits. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| > | ||
| <div | ||
| class="size-full overflow-hidden rounded-lg border border-interface-stroke" | ||
| v-if="!isOverlay" |
There was a problem hiding this comment.
🟡 Medium — Overlay mode renders no resize handle, and overlay mode is reachable by dragging: widening past windowWidth - reservedWorkspaceWidth (≈1016px window with the sidebar closed, ≈1328px with it open) flips isOverlay true mid-gesture and unmounts the handle under the pointer, leaving no affordance to drag back. Recovery requires widening the window or a maximize round trip that resets draggedWidth to the minimum. Removing the capture element mid-drag also tears down its @lostpointercapture listener, so keep the handle mounted in overlay mode (hidden via CSS) or reset isResizing when isOverlay changes. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| const { width: viewportWidth } = useWindowSize() | ||
| const panelWidth = computed(() => | ||
| Math.min( | ||
| isOverlay.value ? requestedWidth.value : width.value, |
There was a problem hiding this comment.
🟡 Medium — In overlay mode the panel is fixed inset-y-0 right-0 at up to the full viewport width, so it covers the workflow tab bar and the Agent entry button that toggles it, and there is no backdrop or Escape handling — the panel's own close button is the only exit. If the async AgentPanelRoot chunk fails to load, the AgentPanelLoadError fallback has no close control, so the overlay is undismissable and the open state is restored on reload. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
| 'border-l border-interface-stroke bg-base-background' | ||
| 'docked-agent-panel pointer-events-auto shrink-0 overflow-hidden [anchor-name:--docked-agent-panel]', | ||
| isOverlay | ||
| ? 'fixed inset-y-0 right-0 z-1100 max-w-full bg-base-background shadow-lg' |
There was a problem hiding this comment.
🟡 Medium — z-1100 sits below the workspace chrome the overlay now covers: GraphCanvasMenu's fixed inset-0 z-1200 click-catcher and its z-1200 toolbar, ZoomControlsModal at z-1300, and an undocked ComfyActionbar at z-1300. Those will paint over the overlay, and while the canvas popup is open its full-viewport backdrop swallows every pointer event across the panel, leaving the agent UI visible but unclickable. z-1100 also ties with the panel's own body-portaled popovers (Composer, RunModePopover, WorkflowSelectorChip, MessageFeedback), so their stacking falls back to DOM insertion order — give the overlay a distinct layer above both. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| @@ -0,0 +1,2 @@ | |||
| export const LOAD3D_VIEWER_CONTENT_CLASS = | |||
| 'w-[80vw] max-w-[min(80vw,calc(100vw-var(--workspace-inset-right,0px)-1rem))] h-[80vh] max-h-[80vh]' | |||
There was a problem hiding this comment.
🟡 Medium — The shared constant is adopted at only 2 of 6 call sites: hdrViewerService.ts:24, ReplyAssetGroup.vue:130, AssetsSidebarTab.vue:588 and JobHistorySidebarTab.vue:194 still pass the old left-1/2 w-[80vw] sm:max-w-[80vw] h-[80vh] max-h-[80vh] literal, whose left-1/2 and sm:max-w-[80vw] override the inset-aware base and size variant from dialog.variants.ts. Those viewers therefore still centre on the full viewport and extend under the docked agent panel — guaranteed rather than incidental for ReplyAssetGroup, which is only reachable from inside that panel. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| class="docked-agent-panel pointer-events-auto relative h-full shrink-0 overflow-hidden [anchor-name:--docked-agent-panel]" | ||
| :style="{ width: `${width}px` }" | ||
| > | ||
| <Teleport to="body" :disabled="!isOverlay"> |
There was a problem hiding this comment.
🟡 Medium — Toggling Teleport's disabled reparents the live panel DOM between its layout host and <body>, and moving a focused node in the DOM drops focus and text selection. Crossing the overlay threshold by resizing the window or opening a sidebar while composing will therefore interrupt keyboard input; preserve and restore focus/selection across the transition, or keep the panel in a single host and switch only its positioning. Raised by 1 of 8 reviewers (gpt-5.6-sol-max adversarial).
| ) | ||
| const isOverlay = computed( | ||
| () => | ||
| windowWidth.value <= requestedWidth.value + reservedWorkspaceWidth.value |
There was a problem hiding this comment.
🟢 Low — At exact equality the dock does fit — windowWidth - reservedWorkspaceWidth === requestedWidth resolves width to the full requestedWidth — yet <= still flips to overlay and drops the workspace inset to zero, causing a needless teleport/layout jump at the boundary. The comparison should be strict <. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
| const width = Math.max(...widths) | ||
| document.documentElement.style.setProperty( | ||
| WORKSPACE_INSET_RIGHT, | ||
| `${width}px` |
There was a problem hiding this comment.
🟢 Low — The width is interpolated with no finite check, so a non-finite value publishes --workspace-inset-right: NaNpx; since var(--workspace-inset-right, 0px) only falls back when the property is unset, every calc(100vw - var(...) - 1rem) in dialog.variants.ts, dialogService and the share/asset-browser dialogs becomes invalid at computed-value time and loses its max-width app-wide. The path is reachable: setReservedWorkspaceWidth(NaN) survives Math.max(0, NaN) and clamp propagates NaN into width. Guard with Number.isFinite and remove the property otherwise. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).
| insetPublishers.set(publisher, widthPx()) | ||
| publishCurrentInset() | ||
| }) | ||
| onScopeDispose(() => { |
There was a problem hiding this comment.
🟢 Low — insetPublishers is module-global but pruned only by onScopeDispose, which silently no-ops (dev-only warning) when there is no active effect scope — and the watchEffect is never stopped either. A future call from a plain function or long-lived store would strand an entry whose stale width keeps winning Math.max, pinning --workspace-inset-right for the life of the page and shrinking every inset-aware dialog; the old implementation self-healed on the next publish. Accept an explicit scope or throw when getCurrentScope() is undefined so the misuse is loud. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. The port of #18840 is faithful except that the Load3D workspace-inset browser test is deleted without a replacement, so the Load3D viewer fix lands on cloud/1.54 with no coverage.
I compared this branch, against its merge base 327e65b (the current cloud/1.54 tip), with #18840's merged diff (3f266cb).
What matches:
- 18 of the source's 21 files carry exactly the source's added and removed lines. These include the
DockedAgentPanel.vue,agentPanelStore.ts,useWorkspaceInset.ts,ViewerControls.vue,load3dViewerDialog.ts, andload3d.tsproduction changes, their unit tests, the fixture helpers, theagentCanvasPrimitives.spec.tsrename, and the un-gatedworkflowTabs,billingFacadeConsumers,agentConsent, andagentPanelLifecyclecases. load3dAgentFixture.tsandagentPanelViewportDrag.spec.tsdo not exist oncloud/1.54. Leaving out their hunks (one fixture setting, and twotest.failremovals) is a justified adaptation.- At 44e2168:
vitest runoveruseWorkspaceInset.test.ts,DockedAgentPanel.test.ts,stores/agent/, andsrc/components/load3d/passed 456/456 across 44 files. Hosted checks passed, apart from the cancelledpr-riskpublish step.
What diverges is inline. #18840 does not drop this test; it moves it. The source deletes the gated case from load3dViewer.spec.ts and re-adds it, un-gated, in load3dAgentUpdate.spec.ts, where it checks docked and 400px overlay geometry against the real Agent panel. This branch takes the deletion but has nowhere to land the addition, because load3dAgentUpdate.spec.ts and its fixture do not exist on this branch. ViewerControls.test.ts does not cover the dialog content class either.
| } | ||
| ) | ||
|
|
||
| test('keeps the full-screen viewer inside the visible workspace inset', async ({ |
There was a problem hiding this comment.
#18840 moves this case into load3dAgentUpdate.spec.ts rather than deleting it, and that is the only browser coverage for the LOAD3D_VIEWER_CONTENT_CLASS change in ViewerControls.vue and load3d.ts. cloud/1.54 does not have load3dAgentUpdate.spec.ts or load3dAgentFixture, so with this hunk the coverage disappears entirely. The smallest adaptation I can see is to keep this case here, drop only the test.fixme(...) gate, and leave the manual --workspace-inset-right: 420px setup, which needs nothing missing from this branch. That carries the source's intent of un-gating the case and pinning the viewer inside the inset. If it cannot pass on 1.54, please say why in the description. I have not run it myself, because the Load3D browser suite needs the backend.
There was a problem hiding this comment.
✅ Fixed in 512231f. The inset coverage remains in load3dViewer.spec.ts on the 1.54 branch.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #18840 to cloud/1.54, with three adaptations, each accounted for by the target.
I compared this branch, at 512231f against its merge base 327e65b (the current cloud/1.54 tip), with #18840's merged diff (3f266cb). Seventeen of the source's 21 files carry exactly the source's added and removed lines: every production change (DockedAgentPanel.vue, agentPanelStore.ts, useWorkspaceInset.ts, ViewerControls.vue, load3dViewerDialog.ts, load3d.ts), their unit tests, the fixture helpers, the agentCanvasPrimitives.spec.ts rename, and the un-gated workflowTabs, billingFacadeConsumers, agentConsent, and agentPanelLifecycle cases.
Adaptations:
load3dAgentFixture.tsdoes not exist oncloud/1.54, so its one-setting hunk has no target.agentPanelViewportDrag.spec.tsdoes not exist oncloud/1.54, so its twotest.failremovals have no target.- The source moves "keeps the full-screen viewer inside the visible workspace inset" from
load3dViewer.spec.tsintoload3dAgentUpdate.spec.ts, which needs the missing Agent fixture. Here the case stays inload3dViewer.spec.tswith only itstest.fixme(...)gate removed, so it still coversLOAD3D_VIEWER_CONTENT_CLASSagainst a 420px inset. That is the smallest way to carry the source's un-gating, and its coverage of the Load3D viewer fix, onto a branch without that fixture. 512231f resolves my earlier comment on this.
Checks:
- At 512231f:
vitest runoveruseWorkspaceInset.test.ts,DockedAgentPanel.test.ts,stores/agent/, andsrc/components/load3d/passed 456/456 across 44 files, andpnpm typecheck:browserpassed. - All hosted checks at this head passed, including the chromium shards, the cloud project, and
playwright-video-new-tests.
Summary
Manual backport of #18840 to
cloud/1.54. The change restores the compatible abandoned-slice browser tests and carries the Agent panel and Load3D workspace-inset fixes into the 1.54 cloud release line.The 1.54 branch predates
load3dAgentFixture,load3dAgentUpdate.spec.ts, andagentPanelViewportDrag.spec.ts, so those modify/delete conflicts were resolved by keeping them absent. The production fix and focused composable/component regressions are retained.Validation
git diff --checkcloud/1.54Backport of #18840.