Repository navigation
[backport core/1.54] test: restore abandoned-slice browser coverage (#18840) - #19700
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1978 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T08:48:14.716Z",
"gitSha": "3946abf88c9c1c3a757e1ec8002ce19def7493c1",
"branch": "christian-byrne/backport-18840-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2122.1269999999777,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.768999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 662.415,
"heapDeltaBytes": -9509296,
"heapUsedBytes": 60845548,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 15.315999999999995,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2037.7539999999499,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.552999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.438,
"heapDeltaBytes": -7785372,
"heapUsedBytes": 63484696,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.938,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2148.2590000000528,
"styleRecalcs": 84,
"styleRecalcDurationMs": 40.854,
"layouts": 14,
"layoutDurationMs": 4.751,
"taskDurationMs": 1146.7669999999998,
"heapDeltaBytes": -227320,
"heapUsedBytes": 70175832,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 197.232,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1858.069999999998,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.953000000000003,
"layouts": 14,
"layoutDurationMs": 4.215,
"taskDurationMs": 931.541,
"heapDeltaBytes": 6784652,
"heapUsedBytes": 78182320,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 171.489,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.5669999999986,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.685,
"layouts": 6,
"layoutDurationMs": 1.0159999999999998,
"taskDurationMs": 429.918,
"heapDeltaBytes": 4356060,
"heapUsedBytes": 74775980,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.124000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.2750000000206,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.939999999999998,
"layouts": 6,
"layoutDurationMs": 1.0290000000000001,
"taskDurationMs": 399.46099999999996,
"heapDeltaBytes": 4552952,
"heapUsedBytes": 75770380,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.410000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 722.2949999999742,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.274000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.2240000000001,
"heapDeltaBytes": 18637252,
"heapUsedBytes": 88184800,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 173.405,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 698.7010000000282,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.403000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.50499999999994,
"heapDeltaBytes": 18169272,
"heapUsedBytes": 83151672,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 171.112,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2072.2810000000322,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.6480000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 793.8580000000001,
"heapDeltaBytes": 7258392,
"heapUsedBytes": 83523856,
"domNodes": -277,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 41.242000000000004,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2054.427999999916,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.748000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 716.553,
"heapDeltaBytes": 66228,
"heapUsedBytes": 76933308,
"domNodes": -282,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 37.629999999999995,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3075.464000000011,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.581000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1961.84,
"heapDeltaBytes": 17216568,
"heapUsedBytes": 94477084,
"domNodes": -274,
"jsHeapTotalBytes": -2236416,
"scriptDurationMs": 968.671,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2623.303999999962,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.296000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1823.9150000000002,
"heapDeltaBytes": -1206252,
"heapUsedBytes": 76367000,
"domNodes": -283,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 891.5770000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3913.7890000000084,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.862999999999998,
"layouts": 60,
"layoutDurationMs": 12.940999999999997,
"taskDurationMs": 1904.238,
"heapDeltaBytes": 12077640,
"heapUsedBytes": 80304872,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 854.9449999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3687.1039999999766,
"styleRecalcs": 61,
"styleRecalcDurationMs": 12.245000000000003,
"layouts": 60,
"layoutDurationMs": 12.386999999999999,
"taskDurationMs": 1823.7040000000002,
"heapDeltaBytes": -2620228,
"heapUsedBytes": 76206356,
"domNodes": -282,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 799.3840000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3141.0599999999818,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.936999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2090.042,
"heapDeltaBytes": 18347084,
"heapUsedBytes": 86270888,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1023.9609999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3093.3310000000347,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.969999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1985.464,
"heapDeltaBytes": 22145676,
"heapUsedBytes": 90572068,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 974.029,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.5870000000214,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.391,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 770.832,
"heapDeltaBytes": 3849288,
"heapUsedBytes": 80899056,
"domNodes": -286,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 44.93900000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.9920000000166,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.336000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 665.846,
"heapDeltaBytes": 9052360,
"heapUsedBytes": 87901936,
"domNodes": -275,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 35.81300000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 711.1409999999978,
"styleRecalcs": 47,
"styleRecalcDurationMs": 18.946000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.252,
"heapDeltaBytes": 14609816,
"heapUsedBytes": 86770932,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 160.45499999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 645.0449999999819,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.366999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.09999999999997,
"heapDeltaBytes": 15026572,
"heapUsedBytes": 88227828,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2030.7520000000068,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.594,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.027,
"heapDeltaBytes": 364132,
"heapUsedBytes": 73495692,
"domNodes": -293,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 12.230999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.6709999999503,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.572999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.887,
"heapDeltaBytes": -1812584,
"heapUsedBytes": 70846716,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.657999999999998,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.7509999999652,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.367000000000004,
"layouts": 18,
"layoutDurationMs": 5.733,
"taskDurationMs": 924.555,
"heapDeltaBytes": 9984176,
"heapUsedBytes": 82995100,
"domNodes": -297,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 126.84500000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.2930000000042,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.901000000000003,
"layouts": 18,
"layoutDurationMs": 5.286,
"taskDurationMs": 882.3530000000001,
"heapDeltaBytes": 9372692,
"heapUsedBytes": 82591912,
"domNodes": -295,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 123.74499999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.2270000000017,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.33899999999999,
"layouts": 15,
"layoutDurationMs": 16.171000000000003,
"taskDurationMs": 1025.8090000000002,
"heapDeltaBytes": -5123064,
"heapUsedBytes": 85114900,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 32.601000000000006,
"eventListeners": 2387,
"totalBlockingTimeMs": 159,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10157.013000000006,
"styleRecalcs": 246,
"styleRecalcDurationMs": 38.431,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6571.299,
"heapDeltaBytes": 4764488,
"heapUsedBytes": 81204020,
"domNodes": -274,
"jsHeapTotalBytes": -696320,
"scriptDurationMs": 2957.542,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9482.384000000024,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.821000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6310.899,
"heapDeltaBytes": 13034264,
"heapUsedBytes": 89483244,
"domNodes": -272,
"jsHeapTotalBytes": -434176,
"scriptDurationMs": 2843.0240000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 18271.747000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17553.115999999998,
"heapDeltaBytes": -59501764,
"heapUsedBytes": 179381524,
"domNodes": -8068,
"jsHeapTotalBytes": -19312640,
"scriptDurationMs": 302.71799999999996,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18247.08099999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17404.84,
"heapDeltaBytes": -56625256,
"heapUsedBytes": 182218508,
"domNodes": -8068,
"jsHeapTotalBytes": -12496896,
"scriptDurationMs": 302.906,
"eventListeners": -14934,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22191.71899999998,
"styleRecalcs": 169,
"styleRecalcDurationMs": 22.769999999999957,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21915.379,
"heapDeltaBytes": -60498144,
"heapUsedBytes": 179453724,
"domNodes": -8068,
"jsHeapTotalBytes": -19599360,
"scriptDurationMs": 939.2729999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 124,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21689.075000000004,
"styleRecalcs": 170,
"styleRecalcDurationMs": 21.969999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21424.638000000003,
"heapDeltaBytes": -48707924,
"heapUsedBytes": 169684364,
"domNodes": -8068,
"jsHeapTotalBytes": -8925184,
"scriptDurationMs": 958.376,
"eventListeners": -14929,
"totalBlockingTimeMs": 51,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6521.844999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.74900000000002,
"layouts": 20,
"layoutDurationMs": 25.393,
"taskDurationMs": 6416.260000000001,
"heapDeltaBytes": -36684308,
"heapUsedBytes": 182663656,
"domNodes": -8068,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 114.23500000000003,
"eventListeners": -14929,
"totalBlockingTimeMs": 422,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6532.377999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 89.02799999999999,
"layouts": 20,
"layoutDurationMs": 26.581999999999994,
"taskDurationMs": 6444.948000000001,
"heapDeltaBytes": -36808828,
"heapUsedBytes": 191537032,
"domNodes": -8068,
"jsHeapTotalBytes": 11452416,
"scriptDurationMs": 122.735,
"eventListeners": -14929,
"totalBlockingTimeMs": 533,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7088.090999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6656.526000000002,
"heapDeltaBytes": 4680276,
"heapUsedBytes": 182379184,
"domNodes": 0,
"jsHeapTotalBytes": -19136512,
"scriptDurationMs": 119.35300000000004,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9230.140000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8880.065,
"heapDeltaBytes": 18670464,
"heapUsedBytes": 178170352,
"domNodes": 0,
"jsHeapTotalBytes": -13369344,
"scriptDurationMs": 153.12399999999994,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 109.31300000004285,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.166999999999998,
"layouts": 2,
"layoutDurationMs": 1.368,
"taskDurationMs": 83.40599999999998,
"heapDeltaBytes": 2997788,
"heapUsedBytes": 72350164,
"domNodes": 130,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.7459999999999996,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 453.6430000000564,
"styleRecalcs": 13,
"styleRecalcDurationMs": 21.294,
"layouts": 3,
"layoutDurationMs": 1.514,
"taskDurationMs": 104.66799999999998,
"heapDeltaBytes": 4761800,
"heapUsedBytes": 73335280,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.681000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #19700 +/- ##
=============================================
- Coverage 84.17% 84.17% -0.01%
=============================================
Files 2112 2113 +1
Lines 126575 126608 +33
Branches 34051 32190 -1861
=============================================
+ Hits 106547 106571 +24
- Misses 19842 19851 +9
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 4 |
| 🟢 Low | 5 |
Panel: 8/8 reviewers contributed findings.
| const { width: viewportWidth } = useWindowSize() | ||
| const panelWidth = computed(() => | ||
| Math.min( | ||
| isOverlay.value ? requestedWidth.value : width.value, |
There was a problem hiding this comment.
🟠 High — In overlay mode this renders requestedWidth (capped only by the viewport) while agentPanelStore.width stays clamped to windowWidth - reservedWorkspaceWidth, and visibleCanvasViewport() still subtracts the clamped width. On the 900px viewport the new e2e test pins, the panel covers all 900px while fit-view, focus-node and node-picking believe ~368px of canvas is visible, so they frame content into a region hidden behind the panel. Expose the effective rendered width from the store so those consumers agree with what is drawn. Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial).
| > | ||
| <div | ||
| class="size-full overflow-hidden rounded-lg border border-interface-stroke" | ||
| v-if="!isOverlay" |
There was a problem hiding this comment.
🟡 Medium — Dragging this handle raises draggedWidth, which feeds requestedWidth and therefore isOverlay, so crossing the threshold mid-drag unmounts the element holding pointer capture: lostpointercapture never fires on the removed node, and if the button is released outside the window no pointerup reaches document either, leaving isResizing stuck true so later moves keep resizing. After release there is also no handle left to drag back, stranding the panel as a full-viewport overlay until the user toggles maximize or resizes the window. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial, claude-opus-5-thinking-max edge-case).
| @@ -0,0 +1,2 @@ | |||
| export const LOAD3D_VIEWER_CONTENT_CLASS = | |||
| 'w-[80vw] max-w-[min(80vw,calc(100vw-var(--workspace-inset-right,0px)-1rem))] h-[80vh] max-h-[80vh]' | |||
There was a problem hiding this comment.
🟡 Medium — Only ViewerControls.vue and extensions/core/load3d.ts adopt this constant; ReplyAssetGroup.vue, AssetsSidebarTab.vue and JobHistorySidebarTab.vue still pass 'left-1/2 w-[80vw] sm:max-w-[80vw] …', whose left-1/2 and sm:max-w-[80vw] override the inset-aware left-[calc(50%-var(--workspace-inset-right,0px)/2)] and sm:max-w from the dialog variants. ReplyAssetGroup opens its 3D viewer from inside the docked agent panel, so that dialog still centres on the raw viewport and lands partly under the panel. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| 'border-l border-interface-stroke bg-base-background' | ||
| 'docked-agent-panel pointer-events-auto shrink-0 overflow-hidden [anchor-name:--docked-agent-panel]', | ||
| isOverlay | ||
| ? 'fixed inset-y-0 right-0 z-1100 max-w-full bg-base-background shadow-lg' |
There was a problem hiding this comment.
🟡 Medium — z-1100 is the same band the agent's own body-portaled popovers already use (Composer, RunModePopover, WorkflowSelectorChip, MessageFeedback), so paint order falls back to DOM order and the teleported panel — re-appended last to <body> — covers any dropdown that was already open. It also sits below floating workspace chrome at z-1200/z-1300 (GraphCanvasMenu's backdrop, ZoomControlsModal, undocked ComfyActionbar), which can now paint over the panel and swallow clicks that could not overlap it while the panel was in flow. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| ) | ||
| const isOverlay = computed( | ||
| () => | ||
| windowWidth.value <= requestedWidth.value + reservedWorkspaceWidth.value |
There was a problem hiding this comment.
🟢 Low — At windowWidth === requestedWidth + reservedWorkspaceWidth the docked layout still fits exactly — width resolves to requestedWidth with the whole reserved workspace intact — yet <= flips to overlay. Use <. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| class="docked-agent-panel pointer-events-auto relative h-full shrink-0 overflow-hidden [anchor-name:--docked-agent-panel]" | ||
| :style="{ width: `${width}px` }" | ||
| > | ||
| <Teleport to="body" :disabled="!isOverlay"> |
There was a problem hiding this comment.
🟢 Low — The teleport moves the element carrying [anchor-name:--docked-agent-panel] to the end of <body>, after the teleported toast container. CSS anchor positioning only accepts an anchor laid out before the positioned element, so GlobalToast.vue's anchor(--docked-agent-panel_left, …) silently falls back to calc(100vw-0.75rem) in overlay mode, putting the toast under the panel in linear mode where the --graph-canvas-panel anchor does not exist. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| isResizing.value = false | ||
| } | ||
|
|
||
| useEventListener(document, 'pointerup', stopResizing) |
There was a problem hiding this comment.
🟢 Low — These document-level terminators (and the pointermove handler above) ignore pointerId, so during a multi-pointer interaction lifting or cancelling a second finger/pen silently ends the resize while the captured pointer is still down. Record the initiating pointerId in onResizeStart and ignore events from other pointers. Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).
| 'path-backed-second' | ||
| ] as const | ||
|
|
||
| test.afterEach(async ({ comfyPage }) => { |
There was a problem hiding this comment.
🟢 Low — This afterEach deletes two fixed-name workflows after every test in the block although only one test creates them, and playwright.config.ts sets fullyParallel against the same backend user data — so a sibling test's cleanup can delete path-backed-first/path-backed-second while the owning test is still using them, and a leftover file from an aborted run pushes topbar.saveWorkflow into the overwrite path where the save dialog never hides. Prefix the names with Date.now() as other specs do and scope cleanup to the creating test. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| insetPublishers.set(publisher, widthPx()) | ||
| publishCurrentInset() | ||
| }) | ||
| onScopeDispose(() => { |
There was a problem hiding this comment.
🟢 Low — insetPublishers is now module-global and its only cleanup path is onScopeDispose, which merely warns and no-ops when useWorkspaceInsetRight is called outside an effect scope — the watchEffect is never stopped in that case either, so the stale width pins --workspace-inset-right through Math.max for the rest of the session and mis-sizes every inset-aware surface. Guard with getCurrentScope() or return a stop handle. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. The port of #18840 is faithful except that the Load3D workspace-inset browser test is deleted without a replacement, so the Load3D viewer fix lands on core/1.54 with no coverage.
I compared this branch, against its merge base 74934bd (the current core/1.54 tip), with #18840's merged diff (3f266cb).
What matches:
- 18 of the source's 21 files carry exactly the source's added and removed lines. These include the
DockedAgentPanel.vue,agentPanelStore.ts,useWorkspaceInset.ts,ViewerControls.vue,load3dViewerDialog.ts, andload3d.tsproduction changes, their unit tests, the fixture helpers, theagentCanvasPrimitives.spec.tsrename, and the un-gatedworkflowTabs,billingFacadeConsumers,agentConsent, andagentPanelLifecyclecases. load3dAgentFixture.tsandagentPanelViewportDrag.spec.tsdo not exist oncore/1.54. Leaving out their hunks (one fixture setting, and twotest.failremovals) is a justified adaptation.- At f3f92dc:
vitest runoveruseWorkspaceInset.test.ts,DockedAgentPanel.test.ts, andstores/agent/passed 202/202 across 12 files. Hosted checks passed. The two cancelled runs arepr-riskpublishing andmerge-and-commit.
What diverges is inline. #18840 does not drop this test; it moves it. The source deletes the gated case from load3dViewer.spec.ts and re-adds it, un-gated, in load3dAgentUpdate.spec.ts, where it checks docked and 400px overlay geometry against the real Agent panel. This branch takes the deletion but has nowhere to land the addition, because load3dAgentUpdate.spec.ts and its fixture do not exist on this branch. ViewerControls.test.ts does not cover the dialog content class either.
| } | ||
| ) | ||
|
|
||
| test('keeps the full-screen viewer inside the visible workspace inset', async ({ |
There was a problem hiding this comment.
#18840 moves this case into load3dAgentUpdate.spec.ts rather than deleting it, and that is the only browser coverage for the LOAD3D_VIEWER_CONTENT_CLASS change in ViewerControls.vue and load3d.ts. core/1.54 does not have load3dAgentUpdate.spec.ts or load3dAgentFixture, so with this hunk the coverage disappears entirely. The smallest adaptation I can see is to keep this case here, drop only the test.fixme(...) gate, and leave the manual --workspace-inset-right: 420px setup, which needs nothing missing from this branch. That carries the source's intent of un-gating the case and pinning the viewer inside the inset. If it cannot pass on 1.54, please say why in the description. I have not run it myself, because the Load3D browser suite needs the backend.
There was a problem hiding this comment.
✅ Fixed in 00ef0e9. The inset coverage remains in load3dViewer.spec.ts on the 1.54 branch.
`browser_tests` carried 10 tests parked behind `test.fixme(true, 'Activates after slice PR 1618x merges')`. All four gating PRs were closed unmerged on 2026-09-14, so their activation condition could never be met. | File | Tests | Gate | |---|---:|---| | `browser_tests/tests/topbar/workflowTabs.spec.ts` | 4 | #16184 — closed unmerged | | `browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts` | 4 | | `browser_tests/tests/billingFacadeConsumers.spec.ts` | 1 | #16185 — closed unmerged | | `browser_tests/tests/load3d/load3dViewer.spec.ts` | 1 | #16187 — closed unmerged | - Remove all 10 gates and the stale slice-PR comments. - Rename `slice03CanvasPrimitives.spec.ts` to `agentCanvasPrimitives.spec.ts` and remove slice numbering from its suite names. - Move reusable canvas operations into their fixture owners and make the centering and fit tests establish that a viewport change is required before checking the result. - Make the full-screen Load3D viewer respect the right workspace inset published by the Agent panel. - Preserve the widest active inset publisher during graph/linear host switches. - Keep Agent usable as a viewport-width overlay when the dock cannot fit, while publishing zero workspace inset so portaled dialogs retain positive width. Production changes span `ViewerControls.vue`, `load3dViewerDialog.ts`, `useWorkspaceInset.ts`, `load3d.ts`, `DockedAgentPanel.vue`, and `agentPanelStore.ts`, with focused component/composable and cloud browser coverage. 8 of the 10 tests passed on their first run. The two failures were fixed rather than pinned: - **Load3D workspace geometry:** the full-screen viewer was centered and sized against the whole viewport, so it rendered beneath the Agent dock. The cloud case now opens the real Agent panel and checks both docked and 400px overlay geometry in `load3dAgentUpdate.spec.ts` through `load3dAgentFixture`. - **Canvas primitive oracle:** `graph.serialize()` includes viewport state in `extra.ds`, so comparing the whole serialization incorrectly treated `centerOnNode()` doing its job as graph mutation. The test now compares graph data without viewport state. The centering test first shifts the viewport 400×250 away and proves the node is off-center. The fit test first zooms to 3× and proves a node is outside the canvas. Both then assert the requested operation changes the viewport; the centering test also verifies that graph data is unchanged. - Fixes #18918
Addresses review feedback: #19700 (comment)
f3f92dc to
00ef0e9
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #18840 to core/1.54, with three adaptations, each accounted for by the target.
I compared this branch, at 00ef0e9 against its merge base 74934bd (the current core/1.54 tip), with #18840's merged diff (3f266cb). Seventeen of the source's 21 files carry exactly the source's added and removed lines: every production change (DockedAgentPanel.vue, agentPanelStore.ts, useWorkspaceInset.ts, ViewerControls.vue, load3dViewerDialog.ts, load3d.ts), their unit tests, the fixture helpers, the agentCanvasPrimitives.spec.ts rename, and the un-gated workflowTabs, billingFacadeConsumers, agentConsent, and agentPanelLifecycle cases.
Adaptations:
load3dAgentFixture.tsdoes not exist oncore/1.54, so its one-setting hunk has no target.agentPanelViewportDrag.spec.tsdoes not exist oncore/1.54, so its twotest.failremovals have no target.- The source moves "keeps the full-screen viewer inside the visible workspace inset" from
load3dViewer.spec.tsintoload3dAgentUpdate.spec.ts, which needs the missing Agent fixture. Here the case stays inload3dViewer.spec.tswith only itstest.fixme(...)gate removed, so it still coversLOAD3D_VIEWER_CONTENT_CLASSagainst a 420px inset. That is the smallest way to carry the source's un-gating, and its coverage of the Load3D viewer fix, onto a branch without that fixture. 00ef0e9 resolves my earlier comment on this.
Checks:
- At 00ef0e9:
vitest runoveruseWorkspaceInset.test.ts,DockedAgentPanel.test.ts,stores/agent/, andsrc/components/load3d/passed 440/440 across 43 files, andpnpm typecheck:browserpassed. - All hosted checks at this head passed, including all 16 chromium shards, the cloud project, and
playwright-video-new-tests.
Summary
Manual backport of #18840 to
core/1.54. The change restores the compatible abandoned-slice browser tests and carries the Agent panel and Load3D workspace-inset fixes into the 1.54 core release line.The 1.54 branch predates
load3dAgentFixture,load3dAgentUpdate.spec.ts, andagentPanelViewportDrag.spec.ts, so those modify/delete conflicts were resolved by keeping them absent. The production fix and focused composable/component regressions are retained.Validation
git diff --checkcore/1.54Backport of #18840.