Skip to content

refactor(website): use vue-i18n directly - #19666

Merged
DrJKL merged 10 commits into
bl/pr17244-review-04-catalogsfrom
drjkl/pr18013-use-vue-i18n-directly
Oct 2, 2026
Merged

DrJKL merged 10 commits into
bl/pr17244-review-04-catalogsfrom
drjkl/pr18013-use-vue-i18n-directly

Conversation

@DrJKL

@DrJKL DrJKL commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Stacks on #18013 to remove the custom website translation adapter and use vue-i18n's native API directly.

Changes

  • What: Deletes contentSections.test.ts and adapter-specific translation tests, replaces the adapter with native vue-i18n calls, and keeps focused catalog compilation, locale fallback, completeness, and plural coverage.
  • What: Merges the Cinematic Studio and re-shoot catalogs into one studio.json catalog per locale.
  • Breaking: Website-internal translation calls now use vue-i18n argument order; there is no compatibility adapter.

Review Focus

Please check that the reduced catalog tests cover owned behavior without pinning legal-copy structure, and that the direct vue-i18n migration preserves explicit locale selection during static rendering.

Verification

  • pnpm test:unit apps/website/src/i18n/site.test.ts apps/website/src/components/legal/legalSections.test.ts apps/website/src/components/legal/enterpriseMsaSections.test.ts apps/website/src/lib/workshop/cinematic-studio/reshoot-engine/notes.test.ts apps/website/src/templates/platform/routerCopy.test.ts (36 passed)
  • pnpm test:unit --project website (10,604 passed, 3 skipped)
  • pnpm typecheck:website
  • pnpm lint:unstaged:fix
  • pnpm --filter @comfyorg/website build
  • pnpm knip --cache

@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 2, 2026 5:37pm UTC
billing-web-test Ignored Ignored Oct 2, 2026 5:37pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 501 files, which is 201 over the limit of 300.

To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch.

Usage-priced reviews support at most 300 files.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 27b26d94-817e-4926-b1fd-91255298b09b
📥 Commits

Reviewing files that changed from the base of the PR and between c499999 and 215349d.

📒 Files selected for processing (501)
  • apps/website/AGENTS.md
  • apps/website/README.md
  • apps/website/e2e/affiliates.spec.ts
  • apps/website/e2e/agent.spec.ts
  • apps/website/e2e/auth-live-errors.spec.ts
  • apps/website/e2e/contact.spec.ts
  • apps/website/e2e/customers-links.spec.ts
  • apps/website/e2e/customers-videos.spec.ts
  • apps/website/e2e/customers.spec.ts
  • apps/website/e2e/demos.spec.ts
  • apps/website/e2e/events.spec.ts
  • apps/website/e2e/fdct.spec.ts
  • apps/website/e2e/flux-3.spec.ts
  • apps/website/e2e/gemini-omni.spec.ts
  • apps/website/e2e/launches.spec.ts
  • apps/website/e2e/learning.spec.ts
  • apps/website/e2e/ltx-2.5.spec.ts
  • apps/website/e2e/minimax-h3.spec.ts
  • apps/website/e2e/minimax-license.spec.ts
  • apps/website/e2e/seedance.spec.ts
  • apps/website/e2e/wan-3.0.spec.ts
  • apps/website/e2e/wan-animate-2.spec.ts
  • apps/website/src/components/about/CareersSection.vue
  • apps/website/src/components/about/HeroSection.vue
  • apps/website/src/components/about/OurValuesSection.vue
  • apps/website/src/components/about/StorySection.vue
  • apps/website/src/components/agent/AgentPage.astro
  • apps/website/src/components/auth/AuthEmailForm.vue
  • apps/website/src/components/auth/AuthFlagTimeout.vue
  • apps/website/src/components/auth/AuthForgotPassword.vue
  • apps/website/src/components/auth/AuthHeroCarousel.vue
  • apps/website/src/components/auth/AuthSignIn.import-failure.test.ts
  • apps/website/src/components/auth/AuthSignIn.test.ts
  • apps/website/src/components/auth/AuthSignIn.vue
  • apps/website/src/components/auth/AuthSignInPanel.vue
  • apps/website/src/components/auth/AuthToast.vue
  • apps/website/src/components/auth/useAuthSignInController.ts
  • apps/website/src/components/blocks/AddToCalendarButton.vue
  • apps/website/src/components/blocks/HeroSplit01.vue
  • apps/website/src/components/careers/HeroSection.test.ts
  • apps/website/src/components/careers/HeroSection.vue
  • apps/website/src/components/careers/RolesSection.vue
  • apps/website/src/components/cloud-nodes/HeroSection.vue
  • apps/website/src/components/cloud-nodes/NodeList.vue
  • apps/website/src/components/cloud-nodes/PackCard.vue
  • apps/website/src/components/cloud-nodes/PackDetail.vue
  • apps/website/src/components/cloud-nodes/PackGridSection.vue
  • apps/website/src/components/common/AudioPlayer.vue
  • apps/website/src/components/common/CallToActionSection.vue
  • apps/website/src/components/common/ContentSection.test.ts
  • apps/website/src/components/common/ContentSection.vue
  • apps/website/src/components/common/FAQSection.vue
  • apps/website/src/components/common/HeaderMain/HeaderMain.vue
  • apps/website/src/components/common/HeaderMain/HeaderMainMobile.vue
  • apps/website/src/components/common/HeaderMain/LogoContextMenu.vue
  • apps/website/src/components/common/HeaderMain/NewBadge.vue
  • apps/website/src/components/common/HubspotFormEmbed.vue
  • apps/website/src/components/common/ProductCardsSection.test.ts
  • apps/website/src/components/common/ProductCardsSection.vue
  • apps/website/src/components/common/SiteFooter.vue
  • apps/website/src/components/common/SurfaceToggle.vue
  • apps/website/src/components/common/VideoPlayer.vue
  • apps/website/src/components/common/WireNodeLayout.vue
  • apps/website/src/components/contact/FormSection.vue
  • apps/website/src/components/customers/ContactSection.vue
  • apps/website/src/components/customers/CustomerVideoWatchTemplate.astro
  • apps/website/src/components/customers/CustomerWatchPage.vue
  • apps/website/src/components/customers/FeedbackSection.vue
  • apps/website/src/components/customers/HeroSection.vue
  • apps/website/src/components/customers/StoryCard.vue
  • apps/website/src/components/customers/StorySection.vue
  • apps/website/src/components/customers/VideoStoryCard.vue
  • apps/website/src/components/customers/WatchSection.vue
  • apps/website/src/components/customers/WhatsNextSection.vue
  • apps/website/src/components/customers/content/ReadMore.vue
  • apps/website/src/components/demos/ArcadeEmbed.vue
  • apps/website/src/components/demos/DemoHeroSection.vue
  • apps/website/src/components/demos/DemoNavSection.vue
  • apps/website/src/components/demos/DemoTranscript.vue
  • apps/website/src/components/gallery/ContactSection.vue
  • apps/website/src/components/gallery/GalleryDetailModal.vue
  • apps/website/src/components/gallery/GalleryItemAttribution.vue
  • apps/website/src/components/gallery/HeroSection.vue
  • apps/website/src/components/hero/HeroGraph.vue
  • apps/website/src/components/hero/HeroGraphSection.vue
  • apps/website/src/components/hero/HeroHeadline.vue
  • apps/website/src/components/home/CaseStudySpotlightSection.vue
  • apps/website/src/components/home/DeveloperPlatformSection.test.ts
  • apps/website/src/components/home/DeveloperPlatformSection.vue
  • apps/website/src/components/home/FeaturedWorkflowsSection.vue
  • apps/website/src/components/home/GetStartedSection.vue
  • apps/website/src/components/home/IndustriesSection.vue
  • apps/website/src/components/home/ModelDiscoverySection.vue
  • apps/website/src/components/home/ModelReleaseSection.vue
  • apps/website/src/components/home/ProductShowcaseSection.vue
  • apps/website/src/components/home/WorkshopSection.vue
  • apps/website/src/components/hub/HubBrowse.vue
  • apps/website/src/components/hub/HubTypeBadge.vue
  • apps/website/src/components/learning/FeaturedTutorialCard.vue
  • apps/website/src/components/learning/LearningCategoryNav.vue
  • apps/website/src/components/learning/LearningDirectoryPage.astro
  • apps/website/src/components/learning/LearningWatchPage.vue
  • apps/website/src/components/learning/TutorialRow.vue
  • apps/website/src/components/legal/LegalContentSection.vue
  • apps/website/src/components/legal/enterpriseMsaSections.test.ts
  • apps/website/src/components/legal/legalSections.test.ts
  • apps/website/src/components/models/ModelCreationsSection.vue
  • apps/website/src/components/models/ModelHeroSection.vue
  • apps/website/src/components/models/ModelsHeroSection.vue
  • apps/website/src/components/payment/PaymentStatusSection.vue
  • apps/website/src/components/pricing/ComfyApiPlanLimitsSection.vue
  • apps/website/src/components/pricing/ComfyApiPricingSection.test.ts
  • apps/website/src/components/pricing/ComfyApiPricingSection.vue
  • apps/website/src/components/pricing/MinimaxLicensePricingSection.test.ts
  • apps/website/src/components/pricing/MinimaxLicensePricingSection.vue
  • apps/website/src/components/pricing/PricingContactBand.vue
  • apps/website/src/components/pricing/PricingCredits.vue
  • apps/website/src/components/pricing/PricingFaq.astro
  • apps/website/src/components/pricing/PricingFreeBanner.vue
  • apps/website/src/components/pricing/PricingPlanFeatureList.vue
  • apps/website/src/components/pricing/PricingPrice.vue
  • apps/website/src/components/pricing/PricingSection.test.ts
  • apps/website/src/components/pricing/PricingSection.vue
  • apps/website/src/components/pricing/PricingTeamCard.vue
  • apps/website/src/components/pricing/WhatsIncludedSection.vue
  • apps/website/src/components/product/cloud/AudienceSection.vue
  • apps/website/src/components/product/cloud/HeroSection.vue
  • apps/website/src/components/product/cloud/PricingSection.vue
  • apps/website/src/components/product/cloud/ReasonSection.vue
  • apps/website/src/components/product/local/DownloadLocalButton.vue
  • apps/website/src/components/product/local/EcoSystemSection.vue
  • apps/website/src/components/product/local/HeroSection.vue
  • apps/website/src/components/product/local/InstallerMenu.vue
  • apps/website/src/components/product/local/MobileDownloadEmailForm.vue
  • apps/website/src/components/product/shared/AIModelsSection.vue
  • apps/website/src/components/product/shared/ReasonSection.vue
  • apps/website/src/components/ui/scroll-carousel/ScrollCarousel.vue
  • apps/website/src/components/workshop/ApiFacts.vue
  • apps/website/src/components/workshop/ApiTab.vue
  • apps/website/src/components/workshop/AppCatalogue.vue
  • apps/website/src/components/workshop/BuyCreditsDialog.vue
  • apps/website/src/components/workshop/CardRow.vue
  • apps/website/src/components/workshop/CatalogueBackLink.vue
  • apps/website/src/components/workshop/CatalogueTabs.vue
  • apps/website/src/components/workshop/DialogueInput.vue
  • apps/website/src/components/workshop/ExampleReplaceDialog.vue
  • apps/website/src/components/workshop/ExamplesTab.vue
  • apps/website/src/components/workshop/FeaturedBanner.vue
  • apps/website/src/components/workshop/FileSourceInput.vue
  • apps/website/src/components/workshop/FrameRatioNotice.vue
  • apps/website/src/components/workshop/HeaderAccount.vue
  • apps/website/src/components/workshop/HeaderAccountMenu.vue
  • apps/website/src/components/workshop/HeaderSessionAccount.vue
  • apps/website/src/components/workshop/HeaderWorkspaceMenu.vue
  • apps/website/src/components/workshop/ImageSourcePreview.vue
  • apps/website/src/components/workshop/ModelDetail.vue
  • apps/website/src/components/workshop/ModelStatus.vue
  • apps/website/src/components/workshop/ModelSupport.vue
  • apps/website/src/components/workshop/ModelsCatalogue.vue
  • apps/website/src/components/workshop/ModelsPage.vue
  • apps/website/src/components/workshop/OutputTransport.vue
  • apps/website/src/components/workshop/PlaygroundField.vue
  • apps/website/src/components/workshop/PlaygroundForm.vue
  • apps/website/src/components/workshop/PlaygroundOutput.vue
  • apps/website/src/components/workshop/RunLeaveDialog.vue
  • apps/website/src/components/workshop/SavedAssetPager.vue
  • apps/website/src/components/workshop/SavedAssetPreview.vue
  • apps/website/src/components/workshop/SavedAssetsStrip.vue
  • apps/website/src/components/workshop/SelectedFileRow.vue
  • apps/website/src/components/workshop/VideoSourcePreview.vue
  • apps/website/src/components/workshop/WorkflowCatalogue.vue
  • apps/website/src/components/workshop/WorkflowCreditsGuard.vue
  • apps/website/src/components/workshop/WorkflowPreview.vue
  • apps/website/src/components/workshop/WorkshopCatalog.vue
  • apps/website/src/components/workshop/WorkshopField.vue
  • apps/website/src/components/workshop/WorkshopFilterChips.vue
  • apps/website/src/components/workshop/WorkshopFilterMenu.vue
  • apps/website/src/components/workshop/WorkshopForm.vue
  • apps/website/src/components/workshop/WorkshopModelCard.vue
  • apps/website/src/components/workshop/WorkshopModelsGrid.vue
  • apps/website/src/components/workshop/WorkshopPlayground.vue
  • apps/website/src/components/workshop/WorkshopSearchField.vue
  • apps/website/src/components/workshop/WorkshopSearchPanel.vue
  • apps/website/src/components/workshop/WorkshopSections.vue
  • apps/website/src/components/workshop/WorkshopSortMenu.vue
  • apps/website/src/components/workshop/cinematic-studio/AppRepoLink.vue
  • apps/website/src/components/workshop/cinematic-studio/AppsBackLink.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicAppsHub.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicColorPicker.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicColors.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicComposer.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicCostLabel.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicCreditAction.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicCreditSummary.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicDirectionSegments.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicEnhanceSwitch.test.ts
  • apps/website/src/components/workshop/cinematic-studio/CinematicEnhanceSwitch.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicFirstRun.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicFormatSegments.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicGateButton.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicGenerateAction.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicGradeImageTile.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicModeSwitch.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicOptionGrid.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicOptionList.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicOutputControls.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicPaletteEditor.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicPanel.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicPickerTabs.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicPopover.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicReferenceButton.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicReferenceMenu.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicSceneField.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicSequence.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicShotList.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicStage.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicStageCard.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicStudio.test.ts
  • apps/website/src/components/workshop/cinematic-studio/CinematicStudio.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicStudioPage.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicStudioPanel.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicTakeActions.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicTakeBar.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicTakeFrame.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicTakeMedia.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicTakeNotice.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicTakeProgress.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicVideoControls.test.ts
  • apps/website/src/components/workshop/cinematic-studio/CinematicVideoControls.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicVideoSegments.vue
  • apps/website/src/components/workshop/cinematic-studio/picker-key.ts
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootAimRig.test.ts
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootAimRig.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootExamples.test.ts
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootExamples.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootFormat.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootGlobe.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootHeader.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootMoveControls.test.ts
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootMoveControls.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootOutputBar.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootSide.test.ts
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootSide.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootStage.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootStudio.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootTakeView.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootTakes.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootTimeline.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootUpload.test.ts
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootUpload.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootViewport.vue
  • apps/website/src/components/workshop/cinematic-studio/reshoot/take-label.ts
  • apps/website/src/components/workshop/cinematic-studio/useFormatMenus.ts
  • apps/website/src/components/workshop/cinematic-studio/useVideoMenus.ts
  • apps/website/src/composables/useReshoot.ts
  • apps/website/src/config/auth-schemas.ts
  • apps/website/src/config/auth-sign-in-state.test.ts
  • apps/website/src/config/auth-sign-in-state.ts
  • apps/website/src/config/banner.ts
  • apps/website/src/config/contentSections.test.ts
  • apps/website/src/config/contentSections.ts
  • apps/website/src/config/mcpClients.ts
  • apps/website/src/config/pricing.ts
  • apps/website/src/config/workshop-playground.ts
  • apps/website/src/data/contactFaq.ts
  • apps/website/src/data/fdct.ts
  • apps/website/src/data/learningTutorials.ts
  • apps/website/src/data/mainNavigation.test.ts
  • apps/website/src/data/mainNavigation.ts
  • apps/website/src/data/seedance.test.ts
  • apps/website/src/env.d.ts
  • apps/website/src/i18n/tPlural.test.ts
  • apps/website/src/i18n/translations.test.ts
  • apps/website/src/i18n/translations.ts
  • apps/website/src/layouts/AuthLayout.astro
  • apps/website/src/lib/workshop/cinematic-studio/copy.test.ts
  • apps/website/src/lib/workshop/cinematic-studio/copy.ts
  • apps/website/src/lib/workshop/cinematic-studio/reshoot-copy.test.ts
  • apps/website/src/lib/workshop/cinematic-studio/reshoot-copy.ts
  • apps/website/src/lib/workshop/cinematic-studio/reshoot-engine/notes.ts
  • apps/website/src/lib/workshop/model-meta-description.ts
  • apps/website/src/lib/workshop/model-title.test.ts
  • apps/website/src/lib/workshop/model-title.ts
  • apps/website/src/lib/workshop/task-label.ts
  • apps/website/src/lib/workshop/use-case-label.test.ts
  • apps/website/src/locales/en/cinematic.json
  • apps/website/src/locales/en/main.json
  • apps/website/src/locales/en/reshoot.json
  • apps/website/src/locales/en/router.json
  • apps/website/src/locales/ja/cinematic.json
  • apps/website/src/locales/ja/reshoot.json
  • apps/website/src/locales/ja/router.json
  • apps/website/src/locales/zh-CN/cinematic.json
  • apps/website/src/locales/zh-CN/main.json
  • apps/website/src/locales/zh-CN/reshoot.json
  • apps/website/src/locales/zh-CN/router.json
  • apps/website/src/middleware.ts
  • apps/website/src/pages/about.astro
  • apps/website/src/pages/affiliates/index.astro
  • apps/website/src/pages/affiliates/terms.astro
  • apps/website/src/pages/brand.astro
  • apps/website/src/pages/careers.astro
  • apps/website/src/pages/cli.astro
  • apps/website/src/pages/cloud-nodes.astro
  • apps/website/src/pages/cloud/index.astro
  • apps/website/src/pages/cloud/supported-nodes.astro
  • apps/website/src/pages/contact.astro
  • apps/website/src/pages/customers.astro
  • apps/website/src/pages/customers/[slug].astro
  • apps/website/src/pages/demos/[slug].astro
  • apps/website/src/pages/download.astro
  • apps/website/src/pages/enterprise-msa.astro
  • apps/website/src/pages/enterprise/managed-builds.astro
  • apps/website/src/pages/forgot-password.astro
  • apps/website/src/pages/forward-deployed-creatives.astro
  • apps/website/src/pages/index.astro
  • apps/website/src/pages/ja/index.astro
  • apps/website/src/pages/launches.astro
  • apps/website/src/pages/login.astro
  • apps/website/src/pages/mcp.astro
  • apps/website/src/pages/minimax/license/professional-request.astro
  • apps/website/src/pages/p/supported-models/[slug].astro
  • apps/website/src/pages/p/supported-models/index.astro
  • apps/website/src/pages/platform.astro
  • apps/website/src/pages/platform/builder.astro
  • apps/website/src/pages/platform/comfy-api.astro
  • apps/website/src/pages/platform/router.astro
  • apps/website/src/pages/pricing.astro
  • apps/website/src/pages/signup.astro
  • apps/website/src/pages/terms-of-service.astro
  • apps/website/src/pages/workshop/index.astro
  • apps/website/src/pages/workshop/models/[slug].astro
  • apps/website/src/pages/zh-CN/about.astro
  • apps/website/src/pages/zh-CN/brand.astro
  • apps/website/src/pages/zh-CN/careers.astro
  • apps/website/src/pages/zh-CN/cli.astro
  • apps/website/src/pages/zh-CN/cloud-nodes.astro
  • apps/website/src/pages/zh-CN/cloud/index.astro
  • apps/website/src/pages/zh-CN/cloud/supported-nodes.astro
  • apps/website/src/pages/zh-CN/contact.astro
  • apps/website/src/pages/zh-CN/customers.astro
  • apps/website/src/pages/zh-CN/customers/[slug].astro
  • apps/website/src/pages/zh-CN/demos/[slug].astro
  • apps/website/src/pages/zh-CN/demos/index.astro
  • apps/website/src/pages/zh-CN/download.astro
  • apps/website/src/pages/zh-CN/enterprise/managed-builds.astro
  • apps/website/src/pages/zh-CN/forward-deployed-creatives.astro
  • apps/website/src/pages/zh-CN/index.astro
  • apps/website/src/pages/zh-CN/launches.astro
  • apps/website/src/pages/zh-CN/mcp.astro
  • apps/website/src/pages/zh-CN/platform.astro
  • apps/website/src/pages/zh-CN/platform/builder.astro
  • apps/website/src/pages/zh-CN/platform/comfy-api.astro
  • apps/website/src/pages/zh-CN/platform/router.astro
  • apps/website/src/pages/zh-CN/pricing.astro
  • apps/website/src/routes/models/app.astro
  • apps/website/src/routes/models/checkout-opening.astro
  • apps/website/src/routes/models/checkout-return.astro
  • apps/website/src/routes/models/index.astro
  • apps/website/src/routes/models/model-page.ts
  • apps/website/src/routes/models/models-hub-meta.ts
  • apps/website/src/templates/affiliate/AudienceSection.vue
  • apps/website/src/templates/affiliate/BenefitsSection.vue
  • apps/website/src/templates/affiliate/BrandAssetsSection.vue
  • apps/website/src/templates/affiliate/CtaSection.vue
  • apps/website/src/templates/affiliate/FAQSection.vue
  • apps/website/src/templates/affiliate/HeroSection.vue
  • apps/website/src/templates/affiliate/HowItWorksSection.vue
  • apps/website/src/templates/brand/BrandColorSection.vue
  • apps/website/src/templates/brand/BrandHeroSection.vue
  • apps/website/src/templates/brand/BrandLogosSection.vue
  • apps/website/src/templates/brand/BrandQuestionsSection.vue
  • apps/website/src/templates/brand/BrandTrademarkSection.vue
  • apps/website/src/templates/brand/BrandVoiceSection.vue
  • apps/website/src/templates/cli/AgentsSection.vue
  • apps/website/src/templates/cli/ComfyCliTerminal.vue
  • apps/website/src/templates/cli/FAQSection.vue
  • apps/website/src/templates/cli/HeroSection.vue
  • apps/website/src/templates/cli/HowItWorksSection.vue
  • apps/website/src/templates/cli/SessionSection.vue
  • apps/website/src/templates/cli/SetupSection.vue
  • apps/website/src/templates/cli/SkillsSection.vue
  • apps/website/src/templates/cli/WhySection.vue
  • apps/website/src/templates/cli/ctas.ts
  • apps/website/src/templates/cli/faqs.ts
  • apps/website/src/templates/cli/jsonLd.ts
  • apps/website/src/templates/cloud-nodes/ClosingCtaSection.vue
  • apps/website/src/templates/cloud-nodes/FAQSection.vue
  • apps/website/src/templates/cloud-nodes/HeroSection.vue
  • apps/website/src/templates/cloud-nodes/HowItWorksSection.vue
  • apps/website/src/templates/cloud-nodes/ModelsSection.vue
  • apps/website/src/templates/cloud-nodes/PackDetailPage.astro
  • apps/website/src/templates/cloud-nodes/SetupSection.vue
  • apps/website/src/templates/cloud-nodes/WhySection.vue
  • apps/website/src/templates/cloud-nodes/copy.test.ts
  • apps/website/src/templates/cloud-nodes/ctas.ts
  • apps/website/src/templates/cloud-nodes/modelCards.test.ts
  • apps/website/src/templates/drops/AnnouncementBanner.vue
  • apps/website/src/templates/drops/CtaSection.vue
  • apps/website/src/templates/drops/DropsSection.vue
  • apps/website/src/templates/drops/HeroSection.vue
  • apps/website/src/templates/events/EventPage.astro
  • apps/website/src/templates/events/EventVideoDialog.vue
  • apps/website/src/templates/events/EventsAgendaView.vue
  • apps/website/src/templates/events/EventsCardsView.vue
  • apps/website/src/templates/events/EventsDirectoryCta.vue
  • apps/website/src/templates/events/EventsDirectoryList.vue
  • apps/website/src/templates/events/EventsDirectoryRow.vue
  • apps/website/src/templates/events/EventsDirectorySection.vue
  • apps/website/src/templates/events/EventsHeroSection.vue
  • apps/website/src/templates/events/EventsPage.astro
  • apps/website/src/templates/events/HostEventSection.test.ts
  • apps/website/src/templates/events/HostEventSection.vue
  • apps/website/src/templates/events/PastEventsSection.vue
  • apps/website/src/templates/fdct/BuildersSection.vue
  • apps/website/src/templates/fdct/ClosingCtaSection.vue
  • apps/website/src/templates/fdct/CtaBandsSection.vue
  • apps/website/src/templates/fdct/FAQSection.vue
  • apps/website/src/templates/fdct/HeroSection.test.ts
  • apps/website/src/templates/fdct/HeroSection.vue
  • apps/website/src/templates/fdct/HowItWorksSection.vue
  • apps/website/src/templates/fdct/PastProjectsSection.vue
  • apps/website/src/templates/fdct/TechnologistsSection.vue
  • apps/website/src/templates/fdct/WhatYouGetSection.vue
  • apps/website/src/templates/mcp/ComfyMcpDemo.vue
  • apps/website/src/templates/mcp/FAQSection.vue
  • apps/website/src/templates/mcp/HeroSection.vue
  • apps/website/src/templates/mcp/HowItWorksSection.vue
  • apps/website/src/templates/mcp/SetupSection.vue
  • apps/website/src/templates/mcp/ToolsSection.vue
  • apps/website/src/templates/mcp/UseCasesSection.vue
  • apps/website/src/templates/mcp/WhySection.vue
  • apps/website/src/templates/mcp/ctas.ts
  • apps/website/src/templates/model-launch/ModelLaunchAudioSampleCard.vue
  • apps/website/src/templates/model-launch/ModelLaunchComparisonSection.vue
  • apps/website/src/templates/model-launch/ModelLaunchCtaSection.vue
  • apps/website/src/templates/model-launch/ModelLaunchFaqSection.vue
  • apps/website/src/templates/model-launch/ModelLaunchGallerySection.vue
  • apps/website/src/templates/model-launch/ModelLaunchHeroCtaButtons.vue
  • apps/website/src/templates/model-launch/ModelLaunchHeroSection.vue
  • apps/website/src/templates/model-launch/ModelLaunchPage.astro
  • apps/website/src/templates/model-launch/ModelLaunchReviewsSection.vue
  • apps/website/src/templates/model-launch/ModelLaunchRunOptionsSection.vue
  • apps/website/src/templates/model-launch/ModelLaunchStepsSection.vue
  • apps/website/src/templates/model-launch/modelLaunchPages.test.ts
  • apps/website/src/templates/platform/BuilderEnterpriseSection.test.ts
  • apps/website/src/templates/platform/BuilderEnterpriseSection.vue
  • apps/website/src/templates/platform/BuilderHero.test.ts
  • apps/website/src/templates/platform/BuilderHero.vue
  • apps/website/src/templates/platform/BuilderPillarsSection.test.ts
  • apps/website/src/templates/platform/BuilderPillarsSection.vue
  • apps/website/src/templates/platform/BuilderProblemSection.vue
  • apps/website/src/templates/platform/ClosingCtaSection.vue
  • apps/website/src/templates/platform/HeroSection.test.ts
  • apps/website/src/templates/platform/HeroSection.vue
  • apps/website/src/templates/platform/ModelsApiGallery.test.ts
  • apps/website/src/templates/platform/ModelsApiGallery.vue
  • apps/website/src/templates/platform/ModelsApiHero.test.ts
  • apps/website/src/templates/platform/ModelsApiHero.vue
  • apps/website/src/templates/platform/PlatformHeroBadge.test.ts
  • apps/website/src/templates/platform/PlatformHeroBadge.vue
  • apps/website/src/templates/platform/PricingSection.test.ts
  • apps/website/src/templates/platform/PricingSection.vue
  • apps/website/src/templates/platform/ProductsSection.test.ts
  • apps/website/src/templates/platform/ProductsSection.vue
  • apps/website/src/templates/platform/RouterCapabilitiesSection.vue
  • apps/website/src/templates/platform/RouterCodeSection.vue
  • apps/website/src/templates/platform/RouterMigrationBanner.vue
  • apps/website/src/templates/platform/RouterProofStripSection.vue
  • apps/website/src/templates/platform/RouterProviderCoverageSection.vue
  • apps/website/src/templates/platform/RouterRoadmapSection.vue
  • apps/website/src/templates/platform/RouterVideoSection.test.ts
  • apps/website/src/templates/platform/RouterVideoSection.vue
  • apps/website/src/templates/platform/ServerlessCustomerProofSection.test.ts
  • apps/website/src/templates/platform/ServerlessCustomerProofSection.vue
  • apps/website/src/templates/platform/ServerlessDeploySection.test.ts
  • apps/website/src/templates/platform/ServerlessDeploySection.vue
  • apps/website/src/templates/platform/ServerlessHero.test.ts
  • apps/website/src/templates/platform/ServerlessHero.vue
  • apps/website/src/templates/platform/ServerlessHowItWorksSection.test.ts
  • apps/website/src/templates/platform/ServerlessHowItWorksSection.vue
  • apps/website/src/templates/platform/ServerlessImageHeatmapAnimation.test.ts
  • apps/website/src/templates/platform/ServerlessImageHeatmapAnimation.vue
  • apps/website/src/templates/platform/ServerlessIsometricStudy.vue
  • apps/website/src/templates/platform/ServerlessJsonApiGpuAnimation.vue
  • apps/website/src/templates/platform/ServerlessScaleSection.test.ts
  • apps/website/src/templates/platform/ServerlessScaleSection.vue
  • apps/website/src/templates/platform/ServerlessSkipSetupBanner.vue
  • apps/website/src/templates/platform/ServerlessVisual.vue
  • apps/website/src/templates/platform/ServerlessWorkerAnimation.test.ts
  • apps/website/src/templates/platform/ServerlessWorkerAnimation.vue
  • apps/website/src/templates/platform/TeamSharingChat.test.ts
  • apps/website/src/templates/platform/TeamSharingChat.vue
  • apps/website/src/templates/platform/ctas.ts
  • apps/website/src/templates/platform/routerCopy.test.ts
  • apps/website/src/templates/platform/routerCopy.ts
  • apps/website/src/utils/eventsDirectory.ts
  • apps/website/src/utils/jsonLd.test.ts
  • apps/website/src/utils/jsonLd.ts
  • apps/website/src/utils/modelFaq.ts
  • apps/website/src/utils/modelSeoCopy.ts

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (505 changed files).

Kind Finding Where Usual remedy
Complexity <template>() — cyclomatic 72, CRAP undefined apps/website/src/components/workshop/PlaygroundOutput.vue:296 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 47, CRAP undefined apps/website/src/components/workshop/PlaygroundField.vue:356 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 46, CRAP undefined apps/website/src/components/workshop/ModelDetail.vue:885 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 28, CRAP undefined apps/website/src/components/auth/AuthSignInPanel.vue:62 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 23, CRAP undefined apps/website/src/components/workshop/WorkshopField.vue:120 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 22, CRAP undefined apps/website/src/components/auth/AuthEmailForm.vue:137 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 22, CRAP undefined apps/website/src/components/common/WireNodeLayout.vue:152 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 18, CRAP undefined apps/website/src/components/blocks/HeroSplit01.vue:100 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 18, CRAP undefined apps/website/src/components/learning/LearningWatchPage.vue:57 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <arrow>() — cyclomatic 17, CRAP 79.4 apps/website/src/templates/model-launch/modelLaunchPages.test.ts:55 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 16, CRAP undefined apps/website/src/templates/model-launch/ModelLaunchGallerySection.vue:45 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity formatValue() — cyclomatic 15, CRAP 63.6 apps/website/src/components/workshop/PlaygroundField.vue:137 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 14, CRAP undefined apps/website/src/components/workshop/WorkshopCatalog.vue:73 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 14, CRAP undefined apps/website/src/templates/platform/ClosingCtaSection.vue:47 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 13, CRAP undefined apps/website/src/components/workshop/ExamplesTab.vue:81 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 13, CRAP undefined apps/website/src/templates/mcp/SetupSection.vue:86 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 13, CRAP undefined apps/website/src/templates/model-launch/ModelLaunchStepsSection.vue:32 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 9, CRAP undefined apps/website/src/templates/platform/ServerlessHowItWorksSection.vue:77 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since c499999a5c1bc2ef803bbe2d90572fc8fe24823d

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19666.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-ia5mmy7gz-comfyui.vercel.app

Last updated: 2026-10-02T17:39:30Z for 215349d

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.55911% with 153 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...bsite/src/components/legal/LegalContentSection.vue 0.00% 16 Missing ⚠️
apps/website/src/config/contentSections.ts 43.75% 5 Missing and 4 partials ⚠️
...e/src/components/learning/FeaturedTutorialCard.vue 0.00% 6 Missing ⚠️
...ps/website/src/components/learning/TutorialRow.vue 0.00% 5 Missing ⚠️
apps/website/src/data/learningTutorials.ts 61.53% 4 Missing and 1 partial ⚠️
...ite/src/components/cloud-nodes/PackGridSection.vue 0.00% 4 Missing ⚠️
...te/src/components/payment/PaymentStatusSection.vue 0.00% 4 Missing ⚠️
...kshop/cinematic-studio/reshoot/ReshootTimeline.vue 20.00% 0 Missing and 4 partials ⚠️
apps/website/src/data/fdct.ts 0.00% 4 Missing ⚠️
...ps/website/src/components/about/CareersSection.vue 0.00% 3 Missing ⚠️
... and 64 more

❌ Your patch check has failed because the patch coverage (75.55%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@                        Coverage Diff                        @@
##           bl/pr17244-review-04-catalogs   #19666      +/-   ##
=================================================================
- Coverage                          84.77%   84.62%   -0.16%     
=================================================================
  Files                               3421     3329      -92     
  Lines                             164134   161662    -2472     
  Branches                           45105    44176     -929     
=================================================================
- Hits                              139138   136799    -2339     
- Misses                             23050    23056       +6     
+ Partials                            1946     1807     -139     
Flag Coverage Δ
billing-web-unit ?
website-unit 79.70% <75.55%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/components/auth/AuthEmailForm.vue 95.45% <100.00%> (+0.06%) ⬆️
...ps/website/src/components/auth/AuthFlagTimeout.vue 92.30% <100.00%> (+0.64%) ⬆️
...s/website/src/components/auth/AuthHeroCarousel.vue 85.96% <100.00%> (+0.25%) ⬆️
apps/website/src/components/auth/AuthSignIn.vue 93.75% <100.00%> (+0.41%) ⬆️
...ps/website/src/components/auth/AuthSignInPanel.vue 100.00% <100.00%> (ø)
apps/website/src/components/auth/AuthToast.vue 100.00% <100.00%> (ø)
...ite/src/components/auth/useAuthSignInController.ts 86.81% <100.00%> (+0.07%) ⬆️
...site/src/components/blocks/AddToCalendarButton.vue 100.00% <100.00%> (ø)
apps/website/src/components/blocks/HeroSplit01.vue 92.00% <100.00%> (+0.33%) ⬆️
...pps/website/src/components/careers/HeroSection.vue 100.00% <100.00%> (ø)
... and 217 more

... and 204 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 30, 2026
@DrJKL
DrJKL force-pushed the drjkl/pr18013-use-vue-i18n-directly branch from 9af44b4 to b5362f3 Compare October 1, 2026 01:02
@DrJKL
DrJKL force-pushed the drjkl/pr18013-use-vue-i18n-directly branch from b5362f3 to c10896b Compare October 2, 2026 07:03
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

@benceruleanlu

Copy link
Copy Markdown
Member

Thanks for stacking, I'm checking now

@benceruleanlu benceruleanlu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Six scoped Opus 5.5 reviews covered all 501 changed files at this head and found no broken current translations, locale selection, or plural output. The following notes are non-blocking:

  • The direct vue-i18n API accepts arbitrary translation keys and returns the key for a missing message. Narrowing the public translator type to TranslationKey would retain the previous compile-time protection; dynamic keys could also retain a missing-key check.
  • Missing interpolation values now render empty text. The catalog test supplies every placeholder itself, so it does not check that callers supply the values each locale expects.
  • The legal-copy test now scans top-level section names only. A recursive scan would preserve detection of nested internal-only keys.
  • README, AGENTS.md, and the PR description still refer to studio.json / router.json, although the implementation merges those catalogs into main.json.
  • Consolidating the feature catalogs adds their copy to the shared translation payload. The documentation should reflect this trade-off.
  • The three newly fragmented sentences render correctly today, but full-sentence messages through vue-i18n's translation component would retain better context for future translations.

These are accepted as non-blocking follow-ups. This approval concerns this PR's reviewed code; the parent PR's merge conflicts still need separate resolution.

@benceruleanlu benceruleanlu assigned DrJKL and unassigned benceruleanlu Oct 2, 2026
@DrJKL
DrJKL removed this pull request from stack #19950 October 2, 2026 22:53
@DrJKL
DrJKL merged commit 7ade272 into bl/pr17244-review-04-catalogs Oct 2, 2026
93 checks passed
@DrJKL
DrJKL deleted the drjkl/pr18013-use-vue-i18n-directly branch October 2, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants