Repository navigation
refactor(website): use vue-i18n directly - #19666
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedToo many files! This PR contains 501 files, which is 201 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files. ⚙️ Run configuration
📒 Files selected for processing (501)
You can disable this status message by setting the
Comment |
14d0d7b to
1654e7c
Compare
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (505 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c499999a5c1bc2ef803bbe2d90572fc8fe24823d
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19666.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-ia5mmy7gz-comfyui.vercel.app Last updated: 2026-10-02T17:39:30Z for |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (75.55%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## bl/pr17244-review-04-catalogs #19666 +/- ##
=================================================================
- Coverage 84.77% 84.62% -0.16%
=================================================================
Files 3421 3329 -92
Lines 164134 161662 -2472
Branches 45105 44176 -929
=================================================================
- Hits 139138 136799 -2339
- Misses 23050 23056 +6
+ Partials 1946 1807 -139
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 204 files with indirect coverage changes 🚀 New features to boost your workflow:
|
9af44b4 to
b5362f3
Compare
b5362f3 to
c10896b
Compare
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
|
Thanks for stacking, I'm checking now |
benceruleanlu
left a comment
There was a problem hiding this comment.
LGTM. Six scoped Opus 5.5 reviews covered all 501 changed files at this head and found no broken current translations, locale selection, or plural output. The following notes are non-blocking:
- The direct vue-i18n API accepts arbitrary translation keys and returns the key for a missing message. Narrowing the public translator type to TranslationKey would retain the previous compile-time protection; dynamic keys could also retain a missing-key check.
- Missing interpolation values now render empty text. The catalog test supplies every placeholder itself, so it does not check that callers supply the values each locale expects.
- The legal-copy test now scans top-level section names only. A recursive scan would preserve detection of nested internal-only keys.
- README, AGENTS.md, and the PR description still refer to studio.json / router.json, although the implementation merges those catalogs into main.json.
- Consolidating the feature catalogs adds their copy to the shared translation payload. The documentation should reflect this trade-off.
- The three newly fragmented sentences render correctly today, but full-sentence messages through vue-i18n's translation component would retain better context for future translations.
These are accepted as non-blocking follow-ups. This approval concerns this PR's reviewed code; the parent PR's merge conflicts still need separate resolution.
Summary
Stacks on #18013 to remove the custom website translation adapter and use vue-i18n's native API directly.
Changes
contentSections.test.tsand adapter-specific translation tests, replaces the adapter with native vue-i18n calls, and keeps focused catalog compilation, locale fallback, completeness, and plural coverage.studio.jsoncatalog per locale.Review Focus
Please check that the reduced catalog tests cover owned behavior without pinning legal-copy structure, and that the direct vue-i18n migration preserves explicit locale selection during static rendering.
Verification
pnpm test:unit apps/website/src/i18n/site.test.ts apps/website/src/components/legal/legalSections.test.ts apps/website/src/components/legal/enterpriseMsaSections.test.ts apps/website/src/lib/workshop/cinematic-studio/reshoot-engine/notes.test.ts apps/website/src/templates/platform/routerCopy.test.ts(36 passed)pnpm test:unit --project website(10,604 passed, 3 skipped)pnpm typecheck:websitepnpm lint:unstaged:fixpnpm --filter @comfyorg/website buildpnpm knip --cache