Repository navigation
[backport cloud/1.54] FE-3013 feat(pricing): read the plan's raw credit grant from the catalog (#18873) - #19659
Conversation
…log (#18873) The pricing cards read the plan's raw credit grant from the backend (`Plan.credits`, added in Comfy-Org/cloud#10703) instead of the hardcoded `TIER_PRICING` figure. They fall back to the static grant only when the field is absent. - Follows #18867 (the FE-3013 hotfix). Part of FE-3013. - Comfy-Org/cloud#10703 is merged and live on test-v2. The generated `Plan.credits` type and its SDK projection landed on `main` through prod serves the field, both tables fall back to the static grant. The hotfix #18867 stops misreading `credits_cents` by going back to a static grant. A static grant cannot follow a catalog change. Converting `credits_cents` cannot produce the real grant either, because the backend rounds it to whole cents: 23,887¢ → 50,402, while the catalog grants 50,400. The backend now sends the grant itself. `Plan` exposed the grant only as `credits_cents`. The raw count the subscription actually receives, the catalog's `credit_grant`, never reached the client. - `Plan.credits` (generated types) and its safe-number projection in `billingPlansView.ts` are on `main` via #19212. - `UnifiedPricingTable.vue` / `PricingTableWorkspace.vue`: `plan.credits ?? amountForBillingCycle(static)`. The value is read straight off the server; nothing is derived. - Tests: the catalog grant wins over the static figure on the matching cycle only. The #18867 tests still pin the fallback (field absent) to the static grant. Both builds run locally against the Comfy-Org/cloud#10703 preview backend (`pr-10703.testenvs.comfy.org`). The page's own `GET /api/billing/plans` response already carries `credits`: | slug | `credits_cents` | `credits` | | --- | --- | --- | | standard-monthly | 1,991 | 4,200 | | standard-annual | 23,887 | 50,400 | | creator-monthly | 3,508 | 7,400 | | creator-annual | 42,086 | 88,800 | | pro-monthly | 10,000 | 21,100 | | pro-annual | 120,000 | 253,200 | AS IS (#18867, `86fba0349b`, static grant): Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. | Yearly | Monthly | | --- | --- | | <img width="480" alt="asis-yearly" src="https://github.com/user-attachments/assets/a790c178-0acd-4a1f-9f38-b1925ddbddc2" /> | <img width="480" alt="asis-monthly" src="https://github.com/user-attachments/assets/3dfb46e7-f7cc-486b-98af-8f49a15265ef" /> | TO BE (`a7270257f7`, reads `plan.credits`): same figures, Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. The numbers now come from the API instead of the static table. | Yearly | Monthly | | --- | --- | | <img width="480" alt="tobe-yearly" src="https://github.com/user-attachments/assets/94eafd26-f717-4d31-a6c6-8d2e861617fe" /> | <img width="480" alt="tobe-monthly" src="https://github.com/user-attachments/assets/6e7733e0-71d1-44ee-9b43-b5f318dbcbe7" /> | (cherry picked from commit efcd653)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-30T20:01:58.523Z",
"gitSha": "992329285543ae0b5c0c654c2550bff8cecec856",
"branch": "backport-18873-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2047.5470000000087,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.758999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.39,
"heapDeltaBytes": -13212504,
"heapUsedBytes": 57553876,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.434,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2007.2340000000395,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.7259999999999,
"heapDeltaBytes": -13744496,
"heapUsedBytes": 56893944,
"domNodes": -284,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.911,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2151.70599999999,
"styleRecalcs": 79,
"styleRecalcDurationMs": 34.58,
"layouts": 14,
"layoutDurationMs": 4.2909999999999995,
"taskDurationMs": 1050.919,
"heapDeltaBytes": 7451668,
"heapUsedBytes": 77866096,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 195.084,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1903.491000000031,
"styleRecalcs": 75,
"styleRecalcDurationMs": 31.308000000000003,
"layouts": 14,
"layoutDurationMs": 4.469,
"taskDurationMs": 895.1119999999999,
"heapDeltaBytes": 9375200,
"heapUsedBytes": 80761392,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 172.693,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.255999999969,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.196,
"layouts": 6,
"layoutDurationMs": 1.106,
"taskDurationMs": 376.49100000000004,
"heapDeltaBytes": 4545888,
"heapUsedBytes": 74806792,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.191000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.514000000062,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.068,
"layouts": 6,
"layoutDurationMs": 1.088,
"taskDurationMs": 400.45399999999995,
"heapDeltaBytes": 4517612,
"heapUsedBytes": 75980372,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 14.421,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 675.1439999999889,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.995000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.383,
"heapDeltaBytes": -7465996,
"heapUsedBytes": 63133304,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 167.48300000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 658.3239999999932,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.831000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.26099999999997,
"heapDeltaBytes": -7263352,
"heapUsedBytes": 63699008,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 166.19099999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2021.870999999976,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.4059999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.282,
"heapDeltaBytes": 11138820,
"heapUsedBytes": 87632444,
"domNodes": -273,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 33.406000000000006,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2050.924000000009,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.2379999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.9570000000001,
"heapDeltaBytes": 10545136,
"heapUsedBytes": 86661700,
"domNodes": -273,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 38.037,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2324.7409999999604,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.425999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1704.477,
"heapDeltaBytes": 21610588,
"heapUsedBytes": 99220292,
"domNodes": -285,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 835.8409999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2414.805000000001,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.720999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1757.1830000000002,
"heapDeltaBytes": 6165140,
"heapUsedBytes": 83482544,
"domNodes": -249,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 853.07,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3614.6140000000173,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.944,
"layouts": 60,
"layoutDurationMs": 12.353000000000002,
"taskDurationMs": 1723.9089999999999,
"heapDeltaBytes": 9934032,
"heapUsedBytes": 77044464,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 788.135,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3627.9250000000047,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.188000000000002,
"layouts": 60,
"layoutDurationMs": 12.412,
"taskDurationMs": 1735.977,
"heapDeltaBytes": 8827372,
"heapUsedBytes": 76625580,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 798.491,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3162.3370000000364,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.857999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1980.881,
"heapDeltaBytes": 465008,
"heapUsedBytes": 68710868,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 987.2129999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3181.082999999944,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.150999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2016.4780000000003,
"heapDeltaBytes": 27582204,
"heapUsedBytes": 95534324,
"domNodes": -281,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 998.484,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2046.8650000000252,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.375000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.434,
"heapDeltaBytes": 5256844,
"heapUsedBytes": 83009080,
"domNodes": -279,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 33.48100000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2057.190999999989,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.675000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 659.3780000000002,
"heapDeltaBytes": 5931180,
"heapUsedBytes": 83884476,
"domNodes": -280,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 37.814,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.6169999999724,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.302999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.1649999999999,
"heapDeltaBytes": 15280120,
"heapUsedBytes": 88284888,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.906,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.1940000000122,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.24,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.023,
"heapDeltaBytes": 15148072,
"heapUsedBytes": 88673960,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 146.63899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.7419999999938,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.826,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.505,
"heapDeltaBytes": 8447284,
"heapUsedBytes": 81906300,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.684000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2016.7199999999639,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.718,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.956,
"heapDeltaBytes": -1597840,
"heapUsedBytes": 71114312,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.386999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.982000000039,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.940999999999995,
"layouts": 18,
"layoutDurationMs": 4.522,
"taskDurationMs": 836.2379999999999,
"heapDeltaBytes": -9853976,
"heapUsedBytes": 62814180,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 112.93,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.1119999999164,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.247999999999998,
"layouts": 18,
"layoutDurationMs": 5.454,
"taskDurationMs": 865.529,
"heapDeltaBytes": 3035416,
"heapUsedBytes": 76496992,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 117.99600000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.980000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 33.99700000000001,
"layouts": 16,
"layoutDurationMs": 16.428,
"taskDurationMs": 945.1200000000002,
"heapDeltaBytes": 20260184,
"heapUsedBytes": 104676332,
"domNodes": 13831,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 31.37899999999999,
"eventListeners": 2385,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8806.38399999998,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.562,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6018.783,
"heapDeltaBytes": 14108104,
"heapUsedBytes": 90712216,
"domNodes": -271,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 2749.277,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9010.797000000024,
"styleRecalcs": 246,
"styleRecalcDurationMs": 36.916000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6231.3150000000005,
"heapDeltaBytes": -35881972,
"heapUsedBytes": 67936100,
"domNodes": -270,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 2813.259,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17774.02699999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17021.071,
"heapDeltaBytes": -59744180,
"heapUsedBytes": 179172980,
"domNodes": -8068,
"jsHeapTotalBytes": -16715776,
"scriptDurationMs": 293.088,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18130.233999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17354.236,
"heapDeltaBytes": -48465932,
"heapUsedBytes": 179842508,
"domNodes": -8068,
"jsHeapTotalBytes": -18497536,
"scriptDurationMs": 314.907,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21487.371000000054,
"styleRecalcs": 170,
"styleRecalcDurationMs": 18.750000000000043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21115.492,
"heapDeltaBytes": -51945852,
"heapUsedBytes": 170360968,
"domNodes": -8068,
"jsHeapTotalBytes": -12705792,
"scriptDurationMs": 922.9749999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 67,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21850.338999999964,
"styleRecalcs": 176,
"styleRecalcDurationMs": 20.019999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21536.892000000003,
"heapDeltaBytes": -56231764,
"heapUsedBytes": 171686952,
"domNodes": -8068,
"jsHeapTotalBytes": -18169856,
"scriptDurationMs": 975.7969999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 241,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6344.100000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.938,
"layouts": 20,
"layoutDurationMs": 22.379999999999995,
"taskDurationMs": 6249.699,
"heapDeltaBytes": -46414328,
"heapUsedBytes": 176612056,
"domNodes": -8068,
"jsHeapTotalBytes": 9674752,
"scriptDurationMs": 113.954,
"eventListeners": -14927,
"totalBlockingTimeMs": 483,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6337.8999999999905,
"styleRecalcs": 20,
"styleRecalcDurationMs": 99.65299999999999,
"layouts": 20,
"layoutDurationMs": 34.62299999999999,
"taskDurationMs": 6240.989999999999,
"heapDeltaBytes": -41840904,
"heapUsedBytes": 177279280,
"domNodes": -8068,
"jsHeapTotalBytes": 9641984,
"scriptDurationMs": 120.569,
"eventListeners": -14931,
"totalBlockingTimeMs": 555,
"frameDurationMs": 18.33666666666674,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8959.807999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8557.522,
"heapDeltaBytes": 21178036,
"heapUsedBytes": 177532708,
"domNodes": 0,
"jsHeapTotalBytes": -8912896,
"scriptDurationMs": 171.86200000000008,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9125.5799999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8651.107,
"heapDeltaBytes": 20635676,
"heapUsedBytes": 180912380,
"domNodes": 0,
"jsHeapTotalBytes": -15990784,
"scriptDurationMs": 164.92699999999994,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 109.01699999999437,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.013,
"layouts": 2,
"layoutDurationMs": 0.6370000000000001,
"taskDurationMs": 77.699,
"heapDeltaBytes": 3032964,
"heapUsedBytes": 72368728,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.089999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.21999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 107.7900000000227,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.706999999999999,
"layouts": 2,
"layoutDurationMs": 1.486,
"taskDurationMs": 77.569,
"heapDeltaBytes": 3035256,
"heapUsedBytes": 72553764,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.297999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19659 +/- ##
=============================================
Coverage ? 79.17%
=============================================
Files ? 2031
Lines ? 113990
Branches ? 34395
=============================================
Hits ? 90256
Misses ? 23554
Partials ? 180
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Manual backport of #18873 to
cloud/1.54.Why
Prod ships from
cloud/1.54. It has the #18867 hotfix (#19174) but not #18873, so the pricing cards there can only show the static grant and cannot follow the catalog.Root cause
Same as #18873:
Planexposed the grant only ascredits_cents, so the raw grant the subscription receives never reached the client.How
efcd653. The.vuechanges apply cleanly: both tables readplan.creditsand fall back to the static grant when the field is absent.Plan.creditsis already in the 1.54 ingest types.PricingTableWorkspace.test.ts: 1.54 still uses factory mocks foruseBillingContext/commandStore. Kept the branch's mock setup and added the source's catalog-grant cases.PricingTableWorkspace.test.ts+UnifiedPricingTable.test.ts: 50/50 pass.AS IS / TO BE
Personal plans, Choose a Plan dialog. AS IS = prod
cloud.comfy.org(Sep 25 release). TO BE = stagingstagingcloud.comfy.orgatcb65375(this PR merged), whose/api/billing/plansreturnscreditsfor all six personal plans.