Skip to content

fix(website): tell users Seedance blocks realistic faces - #19638

Merged
benjcooley merged 2 commits into
mainfrom
fix/seedance-real-face-block-message
Sep 30, 2026
Merged

benjcooley merged 2 commits into
mainfrom
fix/seedance-real-face-block-message

Conversation

@wealthwiselabs

Copy link
Copy Markdown
Contributor

ELI5

Seedance's video models won't accept a picture with a realistic human face — even an AI-generated one — but when they refuse, our server only passes back "blocked by content policy," so people are left guessing what to change. Now a blocked Seedance take tells them the actual rule and what to try instead.

Motivation

In Cinematic Studio, a Seedance 2.5 video with a starting frame of a photoreal (AI-generated) person comes back "Blocked by the model's content policy" with generic advice to review the prompt and reference files. BytePlus documents that Seedance 2.5 and the 2.0 series do not accept input images or videos containing real human faces (Create portrait videos with Dreamina Seedance models). The Router forwards this only as content_policy_violation ("The request was refused by the model's content policy"), dropping the provider's face code, so the site cannot say which input caused it. Without this, users cannot tell the block is about the face rather than their prompt.

Provenance

  • Authored by: interactive session
  • Verified: reproduced the block against staging from a local dev server with a previously rejected photoreal AI image as the Seedance 2.5 starting frame; the Router answered 400 error_type: content_policy_violation with the generic detail above. A different photoreal AI portrait went through (5 s clip), so the provider's classifier is per image. pnpm vitest run on PlaygroundOutput, ModelDetail, cinematic-studio (components + lib), workshop-model-restrictions and src/composables: 69 files, 808 passed; pnpm typecheck:website: 0 errors; eslint on the changed files and oxfmt --check apps/website/src: clean
  • Deviations: the new copy was not rendered in the studio after the final wording change (needs a real blocked take); screenshots not attached

Reviewer context

  • Type: bug fix — error copy for Seedance 2.x content policy blocks
  • Slots into: follows fix(website): Seedance 2.5 first frame keeps its own ratio in Cinematic Studio #19579 — fix(website): Seedance 2.5 first frame keeps its own ratio in Cinematic Studio
  • Not in scope: having the Router pass BytePlus's face code (InputImageSensitiveContentDetected.PrivacyInformation) through, which would let the site show this only when the face was the cause

Summary

  • workshop-model-restrictions.ts: records the realistic-face refusal for the seven Seedance 2.x pages that take images or video (2.5 edit / first-last-frame / reference, 2.0 image-to-video / reference, 2.0 Fast first-last-frame / reference), with its BytePlus source and review date, beside the existing frame-ratio rule. refusesRealFaces(slug) reads it. Text-to-video pages, Seedance 1.x and other providers are not covered.
  • New copy workshop.error.policyRealFaces (en + zh-CN): "Seedance blocks realistic human faces, even AI-generated ones. Try an image without one, or a stylized character." It states the documented rule without claiming this block was caused by a face, since the Router does not say.
  • Cinematic Studio: a failed take now records runSlug, the operation that ran, because a starting frame or references move a shot off the model it was directed on (Seedance 2.5 → its first/last-frame operation). CinematicTakeNotice shows the face copy on a policy block whose runSlug has the rule.
  • Model pages: PlaygroundOutput takes an optional policyMessage (same pattern as cancelledMessage); ModelDetail passes the face copy on the covered pages.

Test plan

  • On the preview, run Seedance 2.5 in Cinematic Studio with a photoreal person as the starting frame; the blocked notice shows the realistic-face copy
  • A policy block on a non-Seedance video model still shows the generic content-policy copy
  • On /models/byteplus--seedance-2-5-reference--generate-videos/, a blocked run shows the same copy; on a Seedance text-to-video page it does not
  • No feature flag: copy change on an existing failure path

Seedance 2.5 and 2.0 refuse input images and videos that show a realistic
human face, AI-generated ones included, but the Router reports that only as
a generic content policy block. Blocked takes on those operations, in
Cinematic Studio and on their model pages, now say so and suggest an image
without a realistic face or a stylized character.
@wealthwiselabs
wealthwiselabs requested a review from a team September 30, 2026 16:20
@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 30, 2026 5:21pm UTC
billing-web-test Ignored Ignored Sep 30, 2026 5:21pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (14 changed files).

Kind Finding Where Usual remedy
Complexity <template>() — cyclomatic 50, CRAP undefined apps/website/src/components/workshop/ModelDetail.vue:892 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 4f7dee93d04776604b6d1edf5614eb9574b53b75

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19638.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-ok4f05axu-comfyui.vercel.app

Last updated: 2026-09-30T17:23:58Z for b75c276

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0fdb2c2d-c829-4cc6-a33a-21b62d82a27a

📥 Commits

Reviewing files that changed from the base of the PR and between 5039ba2 and b75c276.

📒 Files selected for processing (1)
  • apps/website/src/i18n/translations.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The workshop now identifies model slugs with a documented realistic-human-face restriction and displays a localized policy message for matching policy failures. Cinematic Studio carries the failed run’s model slug into take state and uses it to select that message. Other failures retain the generic message.

Changes

Provider-specific policy messages

Layer / File(s) Summary
Define the realistic-face restriction
apps/website/src/config/workshop-model-restrictions.ts, apps/website/src/config/workshop-model-restrictions.test.ts, apps/website/src/i18n/translations.ts
A reviewed restriction record lists seven Seedance model pages, and refusesRealFaces checks whether a slug is listed. Tests cover matching and non-matching slugs. English and Simplified Chinese translations provide the policy message.
Select policy messages in model detail
apps/website/src/components/workshop/PlaygroundOutput.vue, apps/website/src/components/workshop/ModelDetail.vue, apps/website/src/components/workshop/PlaygroundOutput.test.ts
PlaygroundOutput accepts an optional policy message and uses it for policy failures when it is nonempty. ModelDetail supplies the localized message for matching model slugs. A test checks the custom failure status.
Carry model slugs into Cinematic Studio notices
apps/website/src/lib/workshop/cinematic-studio/reel.ts, apps/website/src/composables/useCinematicStudioRun.ts, apps/website/src/components/workshop/cinematic-studio/CinematicTakeNotice.vue, apps/website/src/components/workshop/cinematic-studio/CinematicTakeNotice.test.ts
Failed takes retain the run slug. The failure path supplies the model slug, and CinematicTakeNotice uses it to select the specific policy message for matching blocked takes. Tests cover BytePlus, Kling, and a missing run slug.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant renderTake
  participant takeFailure
  participant ReelReducer
  participant CinematicTakeNotice
  participant refusesRealFaces
  renderTake->>takeFailure: Pass model.slug with the failure
  takeFailure->>ReelReducer: Dispatch takeFailed with runSlug
  ReelReducer->>CinematicTakeNotice: Store failed take with runSlug
  CinematicTakeNotice->>refusesRealFaces: Check failed take runSlug
  refusesRealFaces-->>CinematicTakeNotice: Return whether slug matches
Loading

Merge Risk: ⚪ Minimal · up to b75c2

The guidance suggests checking the prompt as well as the image, reducing the chance users are directed only toward changing face content. No concrete merge-blocking risk is established.

Architecture Summary

Architecture risk: 🔵 Low · up to b75c2

The change affects 1 system.

Changed systems: apps/website

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — apps/website (service) was modified; 10 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in apps/website/src/components/workshop/ModelDetail.vue: The model-restrictions import now also includes refusesRealFaces, used to determine whether the output receives a policy message.
  • observed — Modified behavior in apps/website/src/components/workshop/ModelDetail.vue: PlaygroundOutput now receives the localized real-faces policy message when refusesRealFaces(model.slug) is true, and undefined otherwise.
  • observed — Modified behavior in apps/website/src/components/workshop/PlaygroundOutput.test.ts: Adds a test that renders a policy failure with a custom policyMessage and expects that message in the status.
  • observed — Modified behavior in apps/website/src/components/workshop/PlaygroundOutput.vue: PlaygroundOutput now destructures the optional policyMessage prop.
🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: informing users that Seedance blocks realistic faces.
Description check ✅ Passed The description explains the motivation, implementation, scope, provenance, testing, and known deviations. It does not use the repository template headings exactly, but it provides the required inform…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed PASS. The PR uses bug-fix signals (fix in the title and both commit subjects), but all listed changed files are under apps/website. The custom check explicitly excludes changes exclusively in `app…
Website End-To-End Regression Coverage ✅ Passed The PR changes website runtime files, but the observable change is conditional error guidance and related failure-state data. This is a text/copy-only edit, which the check explicitly excludes from fa…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains only website components, composables, configuration, translations, and tests. It contains no files under src/lib/litegraph/ or src/ecs/, and no graph-entity files. T…
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 30, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 30, 2026
@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ps/website/src/components/workshop/ModelDetail.vue 0.00% 0 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main   #19638      +/-   ##
==========================================
- Coverage   84.46%   84.36%   -0.11%     
==========================================
  Files        3341     3269      -72     
  Lines      161168   158997    -2171     
  Branches    41915    41195     -720     
==========================================
- Hits       136130   134134    -1996     
+ Misses      23142    23076      -66     
+ Partials     1896     1787     -109     
Flag Coverage Δ
billing-web-unit ?
website-unit 79.61% <88.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...bsite/src/components/workshop/PlaygroundOutput.vue 91.26% <100.00%> (+0.03%) ⬆️
.../workshop/cinematic-studio/CinematicTakeNotice.vue 100.00% <100.00%> (ø)
...s/website/src/composables/useCinematicStudioRun.ts 81.11% <100.00%> (ø)
.../website/src/config/workshop-model-restrictions.ts 100.00% <100.00%> (ø)
apps/website/src/i18n/translations.ts 100.00% <ø> (ø)
.../website/src/lib/workshop/cinematic-studio/reel.ts 100.00% <ø> (ø)
...ps/website/src/components/workshop/ModelDetail.vue 90.47% <0.00%> (-0.23%) ⬇️

... and 72 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

benjcooley
benjcooley previously approved these changes Sep 30, 2026

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 BILL: APPROVED at 5039ba2590, a full review of the diff against main.

Severity Count
BLOCKER 0
SHOULD FIX 0
TRIVIAL 1
  • One rule, two callers: REAL_FACE_REFUSALS in workshop-model-restrictions.ts follows the file's existing restriction pattern (source + reviewed date). All 7 slugs exist in the catalogue, and the 4 Seedance 2.x pages left out are exactly the text-to-video ones, which take no image or video input.
  • Model page: ModelDetail passes policyMessage only for those pages, and PlaygroundOutput uses it only when reason === 'policy'. The no-credits and member paths still come first.
  • Cinematic Studio: takeFailure records model.slug, which is the operation that actually ran. loadModel(slug) is per take, so a first-frame take is checked against the first/last-frame page, not the directed model. runSlug is threaded through ReelEvent → reduceReel, and CinematicTakeNotice uses the rule only for blocked failed takes. The model-load-failure path has no runSlug and correctly keeps the generic text.
  • Copy: en and zh-CN are both present.

Verified: restrictions, PlaygroundOutput, ModelDetail, cinematic-studio components/lib and useCinematicStudioRun pass 566/566 (43 files), typecheck clean, clean merge with current main. All required CI is green.

Comment thread apps/website/src/i18n/translations.ts Resolved
The Router drops BytePlus's face code, so on the Seedance image pages a
policy block may come from the prompt rather than a face. Keep leading with
faces, the likely cause there, but add a short "or check your prompt" so a
blocked prompt doesn't send someone to swap out a face-free image.

Addresses BILL's TRIVIAL copy finding.
@benjcooley
benjcooley dismissed stale reviews from coderabbitai[bot] and themself via b75c276 September 30, 2026 17:21

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 BILL: APPROVED at b75c2760fc, a scoped re-review of 5039ba2590..b75c2760fc. 0 BLOCKER / 0 SHOULD FIX / 0 TRIVIAL.

The only change is the workshop.error.policyRealFaces copy in translations.ts: en now ends "…or check your prompt.", and zh-CN gets the matching clause. That resolves my trivial. No test hard-codes the sentence (they go through the key), and the rest of the PR is unchanged from my approval at 5039ba2590.

@benjcooley
benjcooley added this pull request to the merge queue Sep 30, 2026
'模型提供商因内容政策阻止了输入或生成的输出。请检查提示词和参考文件后再运行。'
},
'workshop.error.policyRealFaces': {
en: 'Seedance blocks realistic human faces, even AI-generated ones. Try an image without one or a stylized character, or check your prompt.',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRIVIAL (copy, non-blocking): thanks — this resolves my earlier finding. One nit introduced by the edit itself: the comma after "without one" was dropped, and "without X or Y" greedily parses as "without (X or Y)".

Try an image without one or a stylized character, or check your prompt.

reads as "try an image that has neither a realistic face nor a stylized character" — which inverts the recommendation, since a stylized character is the thing we want them to try. The old wording ("Try an image without one, or a stylized character.") was unambiguous; re-adding the clause is what cost it.

The zh-CN line does not have this problem, because it repeats the verb (换一张不含人脸的图片 或使用 风格化角色), so the two options stay separate.

Suggestion — restore the split, e.g.:

Seedance blocks realistic human faces, even AI-generated ones. Try a stylized character, or an image with no face at all. The block can also come from your prompt.

Not blocking; approving either way.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 BILL: APPROVED at b75c2760fc, a scoped re-review of 5039ba2590..b75c2760fc (not the whole PR).

Severity Count
BLOCKER 0
SHOULD FIX 0
TRIVIAL 1

Scope of the new work: one commit, one file, 2 lines — the workshop.error.policyRealFaces en and zh-CN strings in translations.ts. No logic, no test, no config change. REAL_FACE_REFUSALS, refusesRealFaces, the runSlug threading through ReelEvent → reduceReel, and the policyMessage prop on PlaygroundOutput are all byte-identical to what I approved at 5039ba2590.

Prior finding resolved. My TRIVIAL was that this copy replaces the generic policy text for every policy block on those seven pages, including prompt-triggered ones, and could send someone with a blocked prompt off to swap a face-free image. Both locales now carry a prompt clause. Thread resolved.

Test impact checked, not assumed. CinematicTakeNotice.test.ts:41 asserts on rendered English via queryByText(/realistic human face/) — it is coupled to this string, contrary to what I implied last round. The new copy still opens with "realistic human faces", so the regex still matches and the test still passes. PlaygroundOutput.test.ts passes its own literal through the policyMessage prop and is unaffected. Flagging the coupling so the next copy edit to this key does not surprise anyone.

One new trivial, inline: re-adding the clause cost the disambiguating comma — "Try an image without one or a stylized character" parses as "without (a face or a stylized character)", inverting the stylized-character suggestion. zh-CN avoids this by repeating the verb. Non-blocking.

CI: green except pr-risk / Grade PR risk, still pending — that is the only reason the PR reads UNSTABLE.

Process note, not a code finding: commit b75c2760 is authored by me (the reviewer), not by @wealthwiselabs. I wrote the fix for my own comment and am now approving it, so this round carries no independent reviewer on those 2 lines. Fine at this size for a copy tweak; worth a second pair of eyes if anything non-trivial lands this way.

Merged via the queue into main with commit 3be2aa8 Sep 30, 2026
93 checks passed
@benjcooley
benjcooley deleted the fix/seedance-real-face-block-message branch September 30, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants