Repository navigation
[backport core/1.54] fix: tolerate malformed historical tool-call rows in agent history load - #19626
Conversation
…ry load `agentRestClient.ts`'s `getMessages()` calls `zAgentMessages.parse()` (throws, not safeParse). Since `zAgentMessage.content.tool_calls` was typed as `z.array(zToolCallSummary)` -- the generated schema, which requires `tool_call_id`, closes `status` to `'success' | 'error'`, and requires an integer `duration_ms` -- a single non-conforming historical tool-call row threw during `.parse()` and failed the entire array/message/response parse, surfacing as `agent_history_load_failed` instead of gracefully degrading just that one entry. - agentApiSchema.ts: the message-parse boundary's `content.tool_calls` is now `z.array(z.unknown())`, so a malformed entry can never throw at `zAgentMessages.parse()`. `zPersistedToolCallSummary` (used only by `parseToolCallEntry`'s own `safeParse`) relaxes the generated schema: `tool_call_id` optional, `status` a bare string, `duration_ms` not required to be an integer. - agentTranscript.ts: `parseToolCallEntry` validates only the fields it reads (`.pick()`), restores the `tool_call_id ?? id` fallback for rows predating `tool_call_id`, and `toolCallOk` treats the older `'ok'` status alias the same as `'success'`. - agentTranscript.test.ts: restores the pre-tightening fixtures/tests this broke, and adds a regression test that exercises the actual `zAgentMessages.parse()` boundary with a malformed row, confirming the whole history still loads and only that one tool-call entry degrades.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1960 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T12:24:31.164Z",
"gitSha": "9333c56d50f9ac5c5dd60b0a20203f1288c0ac86",
"branch": "backport-19621-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2032.0429999999305,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.268,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.30199999999996,
"heapDeltaBytes": 1539084,
"heapUsedBytes": 70914668,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6.630000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2011.9529999999486,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.526,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.94000000000005,
"heapDeltaBytes": -12378488,
"heapUsedBytes": 57728524,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.046,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.3930000000391,
"styleRecalcs": 74,
"styleRecalcDurationMs": 19.006000000000004,
"layouts": 14,
"layoutDurationMs": 2.563,
"taskDurationMs": 756.7470000000001,
"heapDeltaBytes": -2811184,
"heapUsedBytes": 67466732,
"domNodes": -281,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 127.73600000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1758.3620000000337,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.103,
"layouts": 14,
"layoutDurationMs": 2.452,
"taskDurationMs": 656.6500000000001,
"heapDeltaBytes": 356240,
"heapUsedBytes": 70888796,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 100.82100000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1668.0239999999458,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.360000000000001,
"layouts": 6,
"layoutDurationMs": 0.763,
"taskDurationMs": 277.3,
"heapDeltaBytes": 4664568,
"heapUsedBytes": 75620828,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8.017999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.8469999999434,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.678,
"layouts": 6,
"layoutDurationMs": 0.9830000000000001,
"taskDurationMs": 288.082,
"heapDeltaBytes": 4290780,
"heapUsedBytes": 74669496,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8.801,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 528.1109999999671,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.785,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.202,
"heapDeltaBytes": -7874180,
"heapUsedBytes": 63000632,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 113.00100000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 552.8699999999844,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.248,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.361,
"heapDeltaBytes": 18715588,
"heapUsedBytes": 88270824,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 109.611,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2021.8639999999368,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.494999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.0309999999999,
"heapDeltaBytes": 11190740,
"heapUsedBytes": 87521892,
"domNodes": -268,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 25.531,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2006.5720000000056,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.088999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.8900000000001,
"heapDeltaBytes": 5694840,
"heapUsedBytes": 82571844,
"domNodes": -274,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 26.577999999999996,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2161.1760000000686,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.78,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1233.2040000000002,
"heapDeltaBytes": 3437300,
"heapUsedBytes": 80295084,
"domNodes": -242,
"jsHeapTotalBytes": 1433600,
"scriptDurationMs": 575.3549999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2119.7870000000876,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.8199999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1192.588,
"heapDeltaBytes": 8361396,
"heapUsedBytes": 85232372,
"domNodes": -268,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 545.425,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3097.701999999913,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.218999999999999,
"layouts": 60,
"layoutDurationMs": 8.013,
"taskDurationMs": 1230.798,
"heapDeltaBytes": 9511232,
"heapUsedBytes": 76726856,
"domNodes": -278,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 515.064,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3067.756000000145,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.862000000000001,
"layouts": 60,
"layoutDurationMs": 8.58,
"taskDurationMs": 1223.5320000000002,
"heapDeltaBytes": 8545460,
"heapUsedBytes": 76297948,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 518.5310000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2221.5400000000045,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.274,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1403.4430000000002,
"heapDeltaBytes": -8097240,
"heapUsedBytes": 72587724,
"domNodes": -248,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 644.501,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2306.0299999999643,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.031000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1364.131,
"heapDeltaBytes": -11643884,
"heapUsedBytes": 73339012,
"domNodes": 8,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 654.213,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.6599999999407,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.065999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.3770000000001,
"heapDeltaBytes": 4406944,
"heapUsedBytes": 83185888,
"domNodes": -277,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 20.897,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1996.6689999998835,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.866999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.141,
"heapDeltaBytes": 21807060,
"heapUsedBytes": 87896296,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.254000000000005,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 492.07000000001244,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.292999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.597,
"heapDeltaBytes": 13825476,
"heapUsedBytes": 86470476,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 92.848,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.1190000001643,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.280000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 300.108,
"heapDeltaBytes": 15053820,
"heapUsedBytes": 88076492,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 96.213,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.443999999964,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.008999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.656,
"heapDeltaBytes": -9107888,
"heapUsedBytes": 63174288,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.271000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.863000000114,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.862000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.22100000000006,
"heapDeltaBytes": 2290212,
"heapUsedBytes": 74885792,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.457000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.5870000000132,
"styleRecalcs": 79,
"styleRecalcDurationMs": 17.588,
"layouts": 18,
"layoutDurationMs": 2.545,
"taskDurationMs": 610.173,
"heapDeltaBytes": -8902936,
"heapUsedBytes": 63337288,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 67.275,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.0959999999359,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.122999999999998,
"layouts": 18,
"layoutDurationMs": 2.6350000000000002,
"taskDurationMs": 619.8860000000001,
"heapDeltaBytes": -4951328,
"heapUsedBytes": 68317088,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 68.17999999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 882.8840000001037,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.968000000000004,
"layouts": 16,
"layoutDurationMs": 10.179999999999998,
"taskDurationMs": 690.22,
"heapDeltaBytes": 22801740,
"heapUsedBytes": 106439692,
"domNodes": 13831,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 21.39,
"eventListeners": 2385,
"totalBlockingTimeMs": 114,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8205.631999999923,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.369,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4303.674,
"heapDeltaBytes": 4671412,
"heapUsedBytes": 80987008,
"domNodes": -274,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 1880.9569999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8140.080000000125,
"styleRecalcs": 250,
"styleRecalcDurationMs": 23.362,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4253.234,
"heapDeltaBytes": -8411428,
"heapUsedBytes": 68216652,
"domNodes": -274,
"jsHeapTotalBytes": 1208320,
"scriptDurationMs": 1855.1490000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11318.71000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10641.418,
"heapDeltaBytes": -47680488,
"heapUsedBytes": 180817588,
"domNodes": -8068,
"jsHeapTotalBytes": -21979136,
"scriptDurationMs": 136.896,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12057.397999999921,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10971.457999999999,
"heapDeltaBytes": -53077660,
"heapUsedBytes": 178099972,
"domNodes": -8068,
"jsHeapTotalBytes": -16089088,
"scriptDurationMs": 181.52399999999997,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14374.729000000003,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.258999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13708.999,
"heapDeltaBytes": -37514760,
"heapUsedBytes": 180268040,
"domNodes": -8068,
"jsHeapTotalBytes": -9957376,
"scriptDurationMs": 795.493,
"eventListeners": -14929,
"totalBlockingTimeMs": 57,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14053.575000000137,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.362000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13359.771000000002,
"heapDeltaBytes": -40447000,
"heapUsedBytes": 164186588,
"domNodes": -8068,
"jsHeapTotalBytes": -15769600,
"scriptDurationMs": 686.2779999999999,
"eventListeners": -14933,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4147.823000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.36,
"layouts": 20,
"layoutDurationMs": 21.399,
"taskDurationMs": 4058.033999999999,
"heapDeltaBytes": -35828716,
"heapUsedBytes": 182755888,
"domNodes": -8068,
"jsHeapTotalBytes": 15962112,
"scriptDurationMs": 74.28899999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 17,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4060.1509999999053,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.45500000000001,
"layouts": 20,
"layoutDurationMs": 19.114999999999995,
"taskDurationMs": 3941.178,
"heapDeltaBytes": -36500004,
"heapUsedBytes": 182570128,
"domNodes": -8068,
"jsHeapTotalBytes": 15507456,
"scriptDurationMs": 62.23999999999999,
"eventListeners": -14933,
"totalBlockingTimeMs": 72,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5641.0640000000285,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5336.632,
"heapDeltaBytes": 11109736,
"heapUsedBytes": 192221972,
"domNodes": 0,
"jsHeapTotalBytes": -26476544,
"scriptDurationMs": 63.52799999999997,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5793.57600000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5397.7829999999985,
"heapDeltaBytes": 18072292,
"heapUsedBytes": 183540004,
"domNodes": 0,
"jsHeapTotalBytes": -4718592,
"scriptDurationMs": 66.20799999999993,
"eventListeners": -6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 420.40799999995215,
"styleRecalcs": 13,
"styleRecalcDurationMs": 12.491,
"layouts": 3,
"layoutDurationMs": 0.7130000000000001,
"taskDurationMs": 74.802,
"heapDeltaBytes": 4777408,
"heapUsedBytes": 73306560,
"domNodes": 122,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.100999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 82.6550000001589,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.659,
"layouts": 2,
"layoutDurationMs": 1.123,
"taskDurationMs": 53.953999999999986,
"heapDeltaBytes": 2982708,
"heapUsedBytes": 72143500,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.8580000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #19626 +/- ##
=============================================
- Coverage 84.18% 84.18% -0.01%
=============================================
Files 2112 2112
Lines 126488 126489 +1
Branches 34025 34027 +2
=============================================
- Hits 106482 106481 -1
- Misses 19820 19822 +2
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Requested by Christian Byrne · Slack thread
Backport of #19621 to
core/1.54. This branch'szToolCallSummary/zPersistedToolCallSummary/parseToolCallEntrycode is byte-identical tomainat the time #19621 was branched (both descend from #19608's[backport core/1.54] feat: use generated ToolCallSummary type for persisted tool-call schema), so the cherry-pick applied cleanly with no conflicts.Before
agentRestClient.ts'sgetMessages()callszAgentMessages.parse()(throws, notsafeParse). BecausezAgentMessage.content.tool_callswas typed asz.array(zToolCallSummary)— the generated schema, which requirestool_call_id, closesstatusto'success' | 'error', and requires an integerduration_ms— a single non-conforming historical tool-call row threw during.parse()and failed the entire array/message/response parse, surfacing asagent_history_load_failedinstead of gracefully degrading just that one entry.After
agentApiSchema.ts: the message-parse boundary'scontent.tool_callsis nowz.array(z.unknown()), so a malformed entry can never throw atzAgentMessages.parse().zPersistedToolCallSummary(used only byparseToolCallEntry's ownsafeParse) relaxes the generated schema:tool_call_idoptional,statusa bare string,duration_msnot required to be an integer.agentTranscript.ts:parseToolCallEntryvalidates only the fields it reads (.pick()), restores thetool_call_id ?? idfallback for rows predatingtool_call_id, andtoolCallOktreats the older'ok'status alias the same as'success'.agentTranscript.test.ts: restores the pre-tightening fixtures/tests this broke, and adds a regression test that exercises the actualzAgentMessages.parse()boundary with a malformed row, confirming the whole history still loads and only that one tool-call entry degrades.Verification
f8424cad75ontoorigin/core/1.54applied with zero conflicts.pnpm typecheck— clean.pnpm exec vitest run agentTranscript.test.ts agentApiSchema.test.ts agentRestClient.test.ts— 98/98 passed.Original PR: #19621
Depends on: #19608 (already on this branch)
🤖 Generated with Claude Code
https://claude.ai/code/session_01RuB3pFMNyS3AE7JYNFNesb
Generated by Claude Code