Repository navigation
[backport cloud/1.54] fix: tolerate malformed historical tool-call rows in agent history load - #19624
Conversation
…ry load `agentRestClient.ts`'s `getMessages()` calls `zAgentMessages.parse()` (throws, not safeParse). Since `zAgentMessage.content.tool_calls` was typed as `z.array(zToolCallSummary)` -- the generated schema, which requires `tool_call_id`, closes `status` to `'success' | 'error'`, and requires an integer `duration_ms` -- a single non-conforming historical tool-call row threw during `.parse()` and failed the entire array/message/response parse, surfacing as `agent_history_load_failed` instead of gracefully degrading just that one entry. - agentApiSchema.ts: the message-parse boundary's `content.tool_calls` is now `z.array(z.unknown())`, so a malformed entry can never throw at `zAgentMessages.parse()`. `zPersistedToolCallSummary` (used only by `parseToolCallEntry`'s own `safeParse`) relaxes the generated schema: `tool_call_id` optional, `status` a bare string, `duration_ms` not required to be an integer. - agentTranscript.ts: `parseToolCallEntry` validates only the fields it reads (`.pick()`), restores the `tool_call_id ?? id` fallback for rows predating `tool_call_id`, and `toolCallOk` treats the older `'ok'` status alias the same as `'success'`. - agentTranscript.test.ts: restores the pre-tightening fixtures/tests this broke, and adds a regression test that exercises the actual `zAgentMessages.parse()` boundary with a malformed row, confirming the whole history still loads and only that one tool-call entry degrades.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1960 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-30T12:23:14.924Z",
"gitSha": "769cadf6f9a3220cead55719b485f8da896b36e9",
"branch": "backport-19621-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2087.9699999999843,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.691999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 648.264,
"heapDeltaBytes": 1677876,
"heapUsedBytes": 72644948,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 14.025999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2051.056000000017,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.398000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.596,
"heapDeltaBytes": 1740576,
"heapUsedBytes": 73226204,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.697,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2273.74599999996,
"styleRecalcs": 80,
"styleRecalcDurationMs": 46.749,
"layouts": 14,
"layoutDurationMs": 4.679,
"taskDurationMs": 1199.098,
"heapDeltaBytes": -4667024,
"heapUsedBytes": 65807620,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 198.016,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1849.9519999999166,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.065,
"layouts": 14,
"layoutDurationMs": 4.044,
"taskDurationMs": 914.9070000000002,
"heapDeltaBytes": 1465312,
"heapUsedBytes": 71722952,
"domNodes": -280,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 168.145,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.1279999999897,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.128,
"layouts": 6,
"layoutDurationMs": 1.3980000000000001,
"taskDurationMs": 427.149,
"heapDeltaBytes": 4647356,
"heapUsedBytes": 75590732,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 15.578999999999995,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1729.8720000000003,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.860999999999997,
"layouts": 6,
"layoutDurationMs": 1.123,
"taskDurationMs": 409.53499999999997,
"heapDeltaBytes": 4532408,
"heapUsedBytes": 75851500,
"domNodes": 72,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 14.941999999999997,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 726.5300000000252,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.544,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.16800000000006,
"heapDeltaBytes": -7317312,
"heapUsedBytes": 63289692,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 178.009,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 714.4620000000259,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.3809999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.95200000000006,
"heapDeltaBytes": 18991748,
"heapUsedBytes": 88936024,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 166.44,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2061.7689999999698,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.1850000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 726.8969999999999,
"heapDeltaBytes": 3327192,
"heapUsedBytes": 79994900,
"domNodes": -281,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 39.663999999999994,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2038.1600000000617,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.4649999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 652.7899999999998,
"heapDeltaBytes": 10198556,
"heapUsedBytes": 86884800,
"domNodes": -272,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 36.416999999999994,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2424.896999999987,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.228000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1753.7439999999997,
"heapDeltaBytes": -517036,
"heapUsedBytes": 77124424,
"domNodes": -285,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 839.055,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2586.00899999999,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.668999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1763.96,
"heapDeltaBytes": 27429240,
"heapUsedBytes": 93937836,
"domNodes": -279,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 890.471,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3766.065000000026,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.491999999999996,
"layouts": 60,
"layoutDurationMs": 12.299999999999999,
"taskDurationMs": 1870.932,
"heapDeltaBytes": -3176464,
"heapUsedBytes": 75844236,
"domNodes": -287,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 812.8930000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3680.1679999999806,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.401,
"layouts": 60,
"layoutDurationMs": 12.555,
"taskDurationMs": 1802.7259999999999,
"heapDeltaBytes": 8073776,
"heapUsedBytes": 76256460,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 814.959,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3107.1620000000166,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.898000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1991.7500000000002,
"heapDeltaBytes": 25649456,
"heapUsedBytes": 92297180,
"domNodes": -282,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 978.189,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3154.3879999999263,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.067000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2021.5649999999998,
"heapDeltaBytes": 780708,
"heapUsedBytes": 68502792,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1002.9440000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2041.8580000000475,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.705999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 689.4590000000001,
"heapDeltaBytes": 8896200,
"heapUsedBytes": 87785040,
"domNodes": -270,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 40.89000000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.6910000000516,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.6409999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.0490000000001,
"heapDeltaBytes": 9071828,
"heapUsedBytes": 87956744,
"domNodes": -276,
"jsHeapTotalBytes": -2723840,
"scriptDurationMs": 37.772,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 660.0389999999834,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.167,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.28100000000006,
"heapDeltaBytes": 15107520,
"heapUsedBytes": 88494872,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 150.957,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 639.8100000000113,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.444999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.23499999999996,
"heapDeltaBytes": 15178216,
"heapUsedBytes": 88684976,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 150.442,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2037.6600000000167,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.068000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.5989999999999,
"heapDeltaBytes": -6222188,
"heapUsedBytes": 67191568,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.109999999999998,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2020.9370000000035,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.124000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.219,
"heapDeltaBytes": -5247608,
"heapUsedBytes": 68325892,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 10.933000000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.3600000000233,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.963000000000005,
"layouts": 18,
"layoutDurationMs": 5.227,
"taskDurationMs": 880.007,
"heapDeltaBytes": -13835332,
"heapUsedBytes": 61594780,
"domNodes": -296,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 120.087,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.2829999999813,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.253,
"layouts": 18,
"layoutDurationMs": 4.8420000000000005,
"taskDurationMs": 893.1360000000001,
"heapDeltaBytes": -6778556,
"heapUsedBytes": 66676612,
"domNodes": -296,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 119.85100000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.9640000000445,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.47599999999999,
"layouts": 14,
"layoutDurationMs": 15.38,
"taskDurationMs": 976.3820000000001,
"heapDeltaBytes": 20223232,
"heapUsedBytes": 104938428,
"domNodes": 13831,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 32.259,
"eventListeners": 2385,
"totalBlockingTimeMs": 152,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10358.007000000043,
"styleRecalcs": 246,
"styleRecalcDurationMs": 39.624,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6599.710999999999,
"heapDeltaBytes": -35817372,
"heapUsedBytes": 67907184,
"domNodes": -271,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 2929.049,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9371.542999999974,
"styleRecalcs": 245,
"styleRecalcDurationMs": 34.821,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6318.061,
"heapDeltaBytes": -8576360,
"heapUsedBytes": 68055864,
"domNodes": -272,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 2844.7039999999997,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17740.159999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16983.085000000003,
"heapDeltaBytes": -28928052,
"heapUsedBytes": 179772580,
"domNodes": -8068,
"jsHeapTotalBytes": -11329536,
"scriptDurationMs": 282.828,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17507.510999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16892.837,
"heapDeltaBytes": -45186280,
"heapUsedBytes": 177065580,
"domNodes": -8068,
"jsHeapTotalBytes": -14426112,
"scriptDurationMs": 316.448,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21466.88100000006,
"styleRecalcs": 172,
"styleRecalcDurationMs": 20.935000000000038,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21137.774999999998,
"heapDeltaBytes": -59140332,
"heapUsedBytes": 180117580,
"domNodes": -8068,
"jsHeapTotalBytes": -21921792,
"scriptDurationMs": 988.888,
"eventListeners": -14929,
"totalBlockingTimeMs": 21,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21596.126000000026,
"styleRecalcs": 161,
"styleRecalcDurationMs": 20.99699999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21279.103,
"heapDeltaBytes": -68718380,
"heapUsedBytes": 170403536,
"domNodes": -8068,
"jsHeapTotalBytes": -19300352,
"scriptDurationMs": 964.856,
"eventListeners": -14925,
"totalBlockingTimeMs": 164,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6328.084999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 93.64700000000003,
"layouts": 20,
"layoutDurationMs": 30.824999999999992,
"taskDurationMs": 6210.3460000000005,
"heapDeltaBytes": -32576816,
"heapUsedBytes": 186406496,
"domNodes": -8068,
"jsHeapTotalBytes": 11214848,
"scriptDurationMs": 116.393,
"eventListeners": -14928,
"totalBlockingTimeMs": 405,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6341.221000000019,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.513,
"layouts": 20,
"layoutDurationMs": 23.39200000000001,
"taskDurationMs": 6246.878000000001,
"heapDeltaBytes": -41352668,
"heapUsedBytes": 177386328,
"domNodes": -8068,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 135.76600000000002,
"eventListeners": -14931,
"totalBlockingTimeMs": 410,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9042.085000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8602.681999999999,
"heapDeltaBytes": 19755920,
"heapUsedBytes": 187675540,
"domNodes": -1,
"jsHeapTotalBytes": -23068672,
"scriptDurationMs": 147.19399999999993,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8905.856999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8599.657000000003,
"heapDeltaBytes": -2929836,
"heapUsedBytes": 177227320,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 179.52499999999992,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 470.271999999909,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.275000000000002,
"layouts": 3,
"layoutDurationMs": 1.7990000000000002,
"taskDurationMs": 129.11800000000002,
"heapDeltaBytes": 5009432,
"heapUsedBytes": 74582772,
"domNodes": 145,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.625,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 474.3900000000849,
"styleRecalcs": 16,
"styleRecalcDurationMs": 19.043,
"layouts": 3,
"layoutDurationMs": 1.214,
"taskDurationMs": 119.363,
"heapDeltaBytes": 5002804,
"heapUsedBytes": 74441600,
"domNodes": 142,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.488,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19624 +/- ##
=============================================
Coverage ? 84.00%
=============================================
Files ? 2121
Lines ? 126961
Branches ? 34366
=============================================
Hits ? 106659
Misses ? 20123
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Requested by Christian Byrne · Slack thread
Backport of #19621 to
cloud/1.54. This branch'szToolCallSummary/zPersistedToolCallSummary/parseToolCallEntrycode is byte-identical tomainat the time #19621 was branched (both descend from #19606's[backport cloud/1.54] feat: use generated ToolCallSummary type for persisted tool-call schema), so the cherry-pick applied cleanly with no conflicts.Before
agentRestClient.ts'sgetMessages()callszAgentMessages.parse()(throws, notsafeParse). BecausezAgentMessage.content.tool_callswas typed asz.array(zToolCallSummary)— the generated schema, which requirestool_call_id, closesstatusto'success' | 'error', and requires an integerduration_ms— a single non-conforming historical tool-call row threw during.parse()and failed the entire array/message/response parse, surfacing asagent_history_load_failedinstead of gracefully degrading just that one entry.After
agentApiSchema.ts: the message-parse boundary'scontent.tool_callsis nowz.array(z.unknown()), so a malformed entry can never throw atzAgentMessages.parse().zPersistedToolCallSummary(used only byparseToolCallEntry's ownsafeParse) relaxes the generated schema:tool_call_idoptional,statusa bare string,duration_msnot required to be an integer.agentTranscript.ts:parseToolCallEntryvalidates only the fields it reads (.pick()), restores thetool_call_id ?? idfallback for rows predatingtool_call_id, andtoolCallOktreats the older'ok'status alias the same as'success'.agentTranscript.test.ts: restores the pre-tightening fixtures/tests this broke, and adds a regression test that exercises the actualzAgentMessages.parse()boundary with a malformed row, confirming the whole history still loads and only that one tool-call entry degrades.Verification
f8424cad75ontoorigin/cloud/1.54applied with zero conflicts.pnpm typecheck— clean.pnpm exec vitest run agentTranscript.test.ts agentApiSchema.test.ts agentRestClient.test.ts— 126/126 passed.Original PR: #19621
Depends on: #19606 (already on this branch)
🤖 Generated with Claude Code
https://claude.ai/code/session_01RuB3pFMNyS3AE7JYNFNesb
Generated by Claude Code