Skip to content

[backport cloud/1.54] fix: tolerate malformed historical tool-call rows in agent history load - #19624

Merged
claude[bot] merged 1 commit into
cloud/1.54from
backport-19621-to-cloud-1.54
Sep 30, 2026
Merged

claude[bot] merged 1 commit into
cloud/1.54from
backport-19621-to-cloud-1.54

Conversation

@claude

@claude claude Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Requested by Christian Byrne · Slack thread

Backport of #19621 to cloud/1.54. This branch's zToolCallSummary / zPersistedToolCallSummary / parseToolCallEntry code is byte-identical to main at the time #19621 was branched (both descend from #19606's [backport cloud/1.54] feat: use generated ToolCallSummary type for persisted tool-call schema), so the cherry-pick applied cleanly with no conflicts.

Before

agentRestClient.ts's getMessages() calls zAgentMessages.parse() (throws, not safeParse). Because zAgentMessage.content.tool_calls was typed as z.array(zToolCallSummary) — the generated schema, which requires tool_call_id, closes status to 'success' | 'error', and requires an integer duration_ms — a single non-conforming historical tool-call row threw during .parse() and failed the entire array/message/response parse, surfacing as agent_history_load_failed instead of gracefully degrading just that one entry.

After

  • agentApiSchema.ts: the message-parse boundary's content.tool_calls is now z.array(z.unknown()), so a malformed entry can never throw at zAgentMessages.parse(). zPersistedToolCallSummary (used only by parseToolCallEntry's own safeParse) relaxes the generated schema: tool_call_id optional, status a bare string, duration_ms not required to be an integer.
  • agentTranscript.ts: parseToolCallEntry validates only the fields it reads (.pick()), restores the tool_call_id ?? id fallback for rows predating tool_call_id, and toolCallOk treats the older 'ok' status alias the same as 'success'.
  • agentTranscript.test.ts: restores the pre-tightening fixtures/tests this broke, and adds a regression test that exercises the actual zAgentMessages.parse() boundary with a malformed row, confirming the whole history still loads and only that one tool-call entry degrades.

Verification

  • Cherry-pick of f8424cad75 onto origin/cloud/1.54 applied with zero conflicts.
  • pnpm typecheck — clean.
  • pnpm exec vitest run agentTranscript.test.ts agentApiSchema.test.ts agentRestClient.test.ts — 126/126 passed.

Original PR: #19621
Depends on: #19606 (already on this branch)

🤖 Generated with Claude Code

https://claude.ai/code/session_01RuB3pFMNyS3AE7JYNFNesb


Generated by Claude Code

…ry load

`agentRestClient.ts`'s `getMessages()` calls `zAgentMessages.parse()`
(throws, not safeParse). Since `zAgentMessage.content.tool_calls` was typed
as `z.array(zToolCallSummary)` -- the generated schema, which requires
`tool_call_id`, closes `status` to `'success' | 'error'`, and requires an
integer `duration_ms` -- a single non-conforming historical tool-call row
threw during `.parse()` and failed the entire array/message/response parse,
surfacing as `agent_history_load_failed` instead of gracefully degrading
just that one entry.

- agentApiSchema.ts: the message-parse boundary's `content.tool_calls` is
  now `z.array(z.unknown())`, so a malformed entry can never throw at
  `zAgentMessages.parse()`. `zPersistedToolCallSummary` (used only by
  `parseToolCallEntry`'s own `safeParse`) relaxes the generated schema:
  `tool_call_id` optional, `status` a bare string, `duration_ms` not
  required to be an integer.
- agentTranscript.ts: `parseToolCallEntry` validates only the fields it
  reads (`.pick()`), restores the `tool_call_id ?? id` fallback for rows
  predating `tool_call_id`, and `toolCallOk` treats the older `'ok'` status
  alias the same as `'success'`.
- agentTranscript.test.ts: restores the pre-tightening fixtures/tests this
  broke, and adds a regression test that exercises the actual
  `zAgentMessages.parse()` boundary with a malformed row, confirming the
  whole history still loads and only that one tool-call entry degrades.
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 671e3c21-0c8c-4f25-9cfb-54130aaafc4e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 30, 2026 12:12pm UTC
billing-web-test Ignored Ignored Sep 30, 2026 12:12pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/30/2026, 12:13:36 PM UTC

Links

🎭 Playwright: ✅ 1960 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1939 / ❌ 0 / ⚠️ 2 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 152ms TBT · 100.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.8 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.2 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 93ms TBT · 167.1 MB heap
vue-node-resize-workload: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 408ms TBT · 173.5 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 174.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 602ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.6 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -164
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 38ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 1057ms
canvas-mouse-sweep: script duration 183ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.6 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -195
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 418ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.2 MB
canvas-zoom-sweep: DOM nodes 74
canvas-zoom-sweep: event listeners 21
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 479ms
dom-widget-clipping: script duration 172ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.6 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 690ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.6 MB
large-graph-idle: DOM nodes -277
large-graph-idle: event listeners -162
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1759ms
large-graph-pan: script duration 865ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 81.6 MB
large-graph-pan: DOM nodes -282
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1837ms
large-graph-zoom: script duration 814ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.5 MB
large-graph-zoom: DOM nodes -144
large-graph-zoom: event listeners -89
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2007ms
legacy-node-drag: script duration 991ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 76.7 MB
legacy-node-drag: DOM nodes -141
legacy-node-drag: event listeners 187
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 676ms
minimap-idle: script duration 39ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.8 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -177
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 441ms
subgraph-dom-widget-clipping: script duration 151ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.5 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 559ms
subgraph-idle: script duration 11ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.6 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 30ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 887ms
subgraph-mouse-sweep: script duration 120ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 61.2 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -225
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 976ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 152ms
subgraph-transition-enter: heap used 100.1 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 6459ms
viewport-pan-sweep: script duration 2887ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 64.8 MB
viewport-pan-sweep: DOM nodes -272
viewport-pan-sweep: event listeners -143
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16938ms
vue-large-graph-idle: script duration 300ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.2 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 167
vue-large-graph-pan: task duration 21208ms
vue-large-graph-pan: script duration 977ms
vue-large-graph-pan: TBT 93ms
vue-large-graph-pan: heap used 167.1 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 27ms
vue-node-resize-workload: style recalc duration 88ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6229ms
vue-node-resize-workload: script duration 126ms
vue-node-resize-workload: TBT 408ms
vue-node-resize-workload: heap used 173.5 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8601ms
vue-zoom-out-idle: script duration 163ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 174.0 MB
vue-zoom-out-idle: DOM nodes -1
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 3
workflow-execution: style recalc count 17
workflow-execution: task duration 124ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 71.1 MB
workflow-execution: DOM nodes 144
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-09-30T12:23:14.924Z",
  "gitSha": "769cadf6f9a3220cead55719b485f8da896b36e9",
  "branch": "backport-19621-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2087.9699999999843,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.691999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 648.264,
      "heapDeltaBytes": 1677876,
      "heapUsedBytes": 72644948,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 14.025999999999996,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2051.056000000017,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.398000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 556.596,
      "heapDeltaBytes": 1740576,
      "heapUsedBytes": 73226204,
      "domNodes": -283,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 11.697,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2273.74599999996,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 46.749,
      "layouts": 14,
      "layoutDurationMs": 4.679,
      "taskDurationMs": 1199.098,
      "heapDeltaBytes": -4667024,
      "heapUsedBytes": 65807620,
      "domNodes": -280,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 198.016,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1849.9519999999166,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 29.065,
      "layouts": 14,
      "layoutDurationMs": 4.044,
      "taskDurationMs": 914.9070000000002,
      "heapDeltaBytes": 1465312,
      "heapUsedBytes": 71722952,
      "domNodes": -280,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 168.145,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.1279999999897,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 20.128,
      "layouts": 6,
      "layoutDurationMs": 1.3980000000000001,
      "taskDurationMs": 427.149,
      "heapDeltaBytes": 4647356,
      "heapUsedBytes": 75590732,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 15.578999999999995,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1729.8720000000003,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.860999999999997,
      "layouts": 6,
      "layoutDurationMs": 1.123,
      "taskDurationMs": 409.53499999999997,
      "heapDeltaBytes": 4532408,
      "heapUsedBytes": 75851500,
      "domNodes": 72,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 14.941999999999997,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 726.5300000000252,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.544,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.16800000000006,
      "heapDeltaBytes": -7317312,
      "heapUsedBytes": 63289692,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 178.009,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 714.4620000000259,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.3809999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 469.95200000000006,
      "heapDeltaBytes": 18991748,
      "heapUsedBytes": 88936024,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 166.44,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2061.7689999999698,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.1850000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 726.8969999999999,
      "heapDeltaBytes": 3327192,
      "heapUsedBytes": 79994900,
      "domNodes": -281,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 39.663999999999994,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.1600000000617,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.4649999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 652.7899999999998,
      "heapDeltaBytes": 10198556,
      "heapUsedBytes": 86884800,
      "domNodes": -272,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 36.416999999999994,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2424.896999999987,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.228000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1753.7439999999997,
      "heapDeltaBytes": -517036,
      "heapUsedBytes": 77124424,
      "domNodes": -285,
      "jsHeapTotalBytes": -401408,
      "scriptDurationMs": 839.055,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2586.00899999999,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.668999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1763.96,
      "heapDeltaBytes": 27429240,
      "heapUsedBytes": 93937836,
      "domNodes": -279,
      "jsHeapTotalBytes": 1536000,
      "scriptDurationMs": 890.471,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3766.065000000026,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 12.491999999999996,
      "layouts": 60,
      "layoutDurationMs": 12.299999999999999,
      "taskDurationMs": 1870.932,
      "heapDeltaBytes": -3176464,
      "heapUsedBytes": 75844236,
      "domNodes": -287,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 812.8930000000001,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3680.1679999999806,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.401,
      "layouts": 60,
      "layoutDurationMs": 12.555,
      "taskDurationMs": 1802.7259999999999,
      "heapDeltaBytes": 8073776,
      "heapUsedBytes": 76256460,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 814.959,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3107.1620000000166,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.898000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1991.7500000000002,
      "heapDeltaBytes": 25649456,
      "heapUsedBytes": 92297180,
      "domNodes": -282,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 978.189,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3154.3879999999263,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.067000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2021.5649999999998,
      "heapDeltaBytes": 780708,
      "heapUsedBytes": 68502792,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 1002.9440000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.8580000000475,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.705999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 689.4590000000001,
      "heapDeltaBytes": 8896200,
      "heapUsedBytes": 87785040,
      "domNodes": -270,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 40.89000000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2025.6910000000516,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 2.6409999999999973,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 663.0490000000001,
      "heapDeltaBytes": 9071828,
      "heapUsedBytes": 87956744,
      "domNodes": -276,
      "jsHeapTotalBytes": -2723840,
      "scriptDurationMs": 37.772,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 660.0389999999834,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.167,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.28100000000006,
      "heapDeltaBytes": 15107520,
      "heapUsedBytes": 88494872,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 150.957,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 639.8100000000113,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.444999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.23499999999996,
      "heapDeltaBytes": 15178216,
      "heapUsedBytes": 88684976,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 150.442,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2037.6600000000167,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.068000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 551.5989999999999,
      "heapDeltaBytes": -6222188,
      "heapUsedBytes": 67191568,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 11.109999999999998,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.9370000000035,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.124000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 567.219,
      "heapDeltaBytes": -5247608,
      "heapUsedBytes": 68325892,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 10.933000000000002,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1725.3600000000233,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.963000000000005,
      "layouts": 18,
      "layoutDurationMs": 5.227,
      "taskDurationMs": 880.007,
      "heapDeltaBytes": -13835332,
      "heapUsedBytes": 61594780,
      "domNodes": -296,
      "jsHeapTotalBytes": 5541888,
      "scriptDurationMs": 120.087,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1735.2829999999813,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 29.253,
      "layouts": 18,
      "layoutDurationMs": 4.8420000000000005,
      "taskDurationMs": 893.1360000000001,
      "heapDeltaBytes": -6778556,
      "heapUsedBytes": 66676612,
      "domNodes": -296,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 119.85100000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.9640000000445,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 32.47599999999999,
      "layouts": 14,
      "layoutDurationMs": 15.38,
      "taskDurationMs": 976.3820000000001,
      "heapDeltaBytes": 20223232,
      "heapUsedBytes": 104938428,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 32.259,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 152,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10358.007000000043,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 39.624,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6599.710999999999,
      "heapDeltaBytes": -35817372,
      "heapUsedBytes": 67907184,
      "domNodes": -271,
      "jsHeapTotalBytes": -1638400,
      "scriptDurationMs": 2929.049,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9371.542999999974,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 34.821,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6318.061,
      "heapDeltaBytes": -8576360,
      "heapUsedBytes": 68055864,
      "domNodes": -272,
      "jsHeapTotalBytes": -626688,
      "scriptDurationMs": 2844.7039999999997,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17740.159999999945,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16983.085000000003,
      "heapDeltaBytes": -28928052,
      "heapUsedBytes": 179772580,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11329536,
      "scriptDurationMs": 282.828,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17507.510999999908,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16892.837,
      "heapDeltaBytes": -45186280,
      "heapUsedBytes": 177065580,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14426112,
      "scriptDurationMs": 316.448,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21466.88100000006,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 20.935000000000038,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21137.774999999998,
      "heapDeltaBytes": -59140332,
      "heapUsedBytes": 180117580,
      "domNodes": -8068,
      "jsHeapTotalBytes": -21921792,
      "scriptDurationMs": 988.888,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 21,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21596.126000000026,
      "styleRecalcs": 161,
      "styleRecalcDurationMs": 20.99699999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21279.103,
      "heapDeltaBytes": -68718380,
      "heapUsedBytes": 170403536,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19300352,
      "scriptDurationMs": 964.856,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 164,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6328.084999999987,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 93.64700000000003,
      "layouts": 20,
      "layoutDurationMs": 30.824999999999992,
      "taskDurationMs": 6210.3460000000005,
      "heapDeltaBytes": -32576816,
      "heapUsedBytes": 186406496,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11214848,
      "scriptDurationMs": 116.393,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 405,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6341.221000000019,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.513,
      "layouts": 20,
      "layoutDurationMs": 23.39200000000001,
      "taskDurationMs": 6246.878000000001,
      "heapDeltaBytes": -41352668,
      "heapUsedBytes": 177386328,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10473472,
      "scriptDurationMs": 135.76600000000002,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 410,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9042.085000000043,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8602.681999999999,
      "heapDeltaBytes": 19755920,
      "heapUsedBytes": 187675540,
      "domNodes": -1,
      "jsHeapTotalBytes": -23068672,
      "scriptDurationMs": 147.19399999999993,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8905.856999999969,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8599.657000000003,
      "heapDeltaBytes": -2929836,
      "heapUsedBytes": 177227320,
      "domNodes": 0,
      "jsHeapTotalBytes": -18612224,
      "scriptDurationMs": 179.52499999999992,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 470.271999999909,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 23.275000000000002,
      "layouts": 3,
      "layoutDurationMs": 1.7990000000000002,
      "taskDurationMs": 129.11800000000002,
      "heapDeltaBytes": 5009432,
      "heapUsedBytes": 74582772,
      "domNodes": 145,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 10.625,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 474.3900000000849,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 19.043,
      "layouts": 3,
      "layoutDurationMs": 1.214,
      "taskDurationMs": 119.363,
      "heapDeltaBytes": 5002804,
      "heapUsedBytes": 74441600,
      "domNodes": 142,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.488,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50766 76060 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from ryan-di September 30, 2026 12:12
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 30, 2026
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19624   +/-   ##
=============================================
  Coverage              ?   84.00%           
=============================================
  Files                 ?     2121           
  Lines                 ?   126961           
  Branches              ?    34366           
=============================================
  Hits                  ?   106659           
  Misses                ?    20123           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.76% <ø> (?)
unit 79.16% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rkbench/extensions/agent/schemas/agentApiSchema.ts 100.00% <100.00%> (ø)
...extensions/agent/services/agent/agentTranscript.ts 97.72% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claude
claude Bot merged commit 9d80c0a into cloud/1.54 Sep 30, 2026
99 checks passed
@claude
claude Bot deleted the backport-19621-to-cloud-1.54 branch September 30, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants