Skip to content

fix(website): Re-shoot follow-ups from the #19465 review - #19558

Closed
benjcooley wants to merge 3 commits into
mainfrom
benjcooley/reshoot-review-fixes
Closed

benjcooley wants to merge 3 commits into
mainfrom
benjcooley/reshoot-review-fixes

Conversation

@benjcooley

Copy link
Copy Markdown
Collaborator

Follow-ups BILL raised as trivials in his review of #19465, which is merged. Each item is small and none blocked #19465.

  • Failure message placement. If a scene read fails and the app then turns out to be unavailable, "not available" now appears in the preview instead of beside a Try again that cannot help. The failure-once split also keys on unavailable (now exposed read-only from useReshoot).
  • Seed limit. A typed seed is held to MAX_SEED (2³²−1), the range every random draw spans. A larger one used to fail the take. The input also sets max.
  • Replacement clip race. Only the latest pick can land: an earlier pick whose length resolves later no longer replaces a newer one.
  • Warp preview cleanup. Frames decoded after the preview unmounts are closed and not drawn on a disposed renderer. WarpRenderer.dispose() also releases the WebGL context, since every re-read mounts a new preview and browsers cap live contexts.
  • One zone definition. cameraZone now calls the engine's zoneOf instead of a second copy. The constants and maths were identical, so there's no behaviour change.
  • Removes the unused reshoot.demoNote string.

Tests. Two page tests cover the failure-once split: said once beside Try again, and moved to the preview when the app turns out to be unavailable. A panel test covers the seed limit. Each was checked to fail with its fix reverted.

Checks. typecheck 0 errors, pnpm lint, format:check and knip clean, website suite 10156 passed.

- A read that failed before the app turned out to be unavailable now
  says "not available" in the preview, not beside a Try again that
  cannot help: the failure-once split also keys on `unavailable`.
- A typed seed is held to MAX_SEED, the range every random draw spans;
  one above it would fail the take.
- Only the latest replacement clip can land: an earlier pick whose
  length resolves later no longer replaces a newer one.
- The warp preview closes frames decoded after it unmounts and no
  longer draws on a disposed renderer; dispose() also releases the
  WebGL context, since every re-read mounts a new preview.
- cameraZone reuses the engine's zoneOf instead of a second copy.
- The unused reshoot.demoNote string is removed.

Page tests cover the failure-once split, including the unavailable
case, and a panel test covers the seed limit.
@benjcooley
benjcooley requested a review from a team September 30, 2026 04:24
@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 30, 2026 6:24am UTC
billing-web-test Ignored Ignored Sep 30, 2026 6:24am UTC

Request Review

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 68e54ec4fc2f7646befbb46bde7a69d481b22a73

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19558.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-34pandvhy-comfyui.vercel.app

Last updated: 2026-09-30T08:32:41Z for 6d31f7e

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 BILL: APPROVED at f209cc6f63 (this posts as COMMENTED because the PR is authored as benjcooley; a counting approval from a human reviewer is still needed). 0 BLOCKER / 0 SHOULD FIX / 0 TRIVIAL.

All six #19465 follow-ups are fixed as asked:

  1. Failure-once split: both sides key on depth === 'failed' && !unavailable, so a failed read plus an app_unavailable quote leaves "not available" in the preview with no dead Try again. I agree with not setting unavailable from a read failure: only a successful quote clears it, so the page would lock. The new page test fails when the split is reverted (I checked).
  2. Replacement pick race: the picks counter drops a stale pick, including its rejection message.
  3. Seed: clamped to MAX_SEED = 2^32 − 1, the same range as the random draw, with :max on the field. Well inside noise_seed's range. Tested.
  4. Warp: bitmaps decoded after unmount are closed and never drawn, the renderer ref is cleared, and dispose() releases the WebGL context.
  5. Zones: cameraZone delegates to zoneOf. camera.ts has no imports, so there's no cycle, and the header is corrected.
  6. Copy: demoNote is removed, with no references left.

Verified locally: reshoot/cinematic unit tests 407/407 (40 files) and typecheck clean.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f4e0b2c5-1b9c-43c4-9dda-c6ff78824922

📥 Commits

Reviewing files that changed from the base of the PR and between 28614ee and 6d31f7e.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 64243c3e-9072-439c-af59-bfb0e1c56d13

📥 Commits

Reviewing files that changed from the base of the PR and between f209cc6 and 28614ee.

📒 Files selected for processing (2)
  • apps/website/e2e/fixtures/reshootProxy.ts
  • apps/website/e2e/workshop-apps.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Re-shoot changes update camera-zone classification, seed and clip handling, unavailable-app notices, and rendering cleanup. Tests cover seed limits and failure-message placement.

Changes

Re-shoot

Layer / File(s) Summary
Shared constants and camera classification
apps/website/src/lib/workshop/cinematic-studio/reshoot.ts
The module exports MAX_SEED and delegates camera-zone classification to zoneOf. Its description identifies the app proxy.
Seed bounds and clip selection
apps/website/src/composables/useReshoot.ts, apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootSide.vue, apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootSide.test.ts, apps/website/e2e/workshop-apps.spec.ts
Generated and fixed seeds use the inclusive range 0 through MAX_SEED. Clip selection ignores duration reads from earlier selections. Tests cover seed bounds.
Unavailable-app notices and preview copy
apps/website/src/composables/useReshoot.ts, apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootStudio.vue, apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootStudio.test.ts, apps/website/src/lib/workshop/cinematic-studio/reshoot-copy.ts, apps/website/e2e/fixtures/reshootProxy.ts, apps/website/e2e/workshop-apps.spec.ts
The studio routes unavailable-app notices to the stage and omits them from the side-panel error. Tests check failure-message placement. The returned unavailable ref is readonly, and the demo-note localization entries are removed. The proxy fixture supports request-aware overrides for end-to-end tests.
Render resource cleanup
apps/website/src/lib/workshop/cinematic-studio/reshoot-engine/warp-renderer.ts, apps/website/src/components/workshop/cinematic-studio/reshoot/ReshootWarp.vue
The renderer loses its WebGL context during disposal. If image decoding finishes after unmount, the component closes the decoded bitmaps and skips drawing.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 28614

The changes improve seed bounds, failure notices, clip selection, and renderer cleanup without an identified merge-blocking regression. Mergeable subject to normal checks.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately identifies the pull request as follow-up fixes for the Re-shoot changes reviewed in #19465. It is concise and related to the changeset, although it does not list each individual f…
Description check ✅ Passed The description provides a clear summary of the Re-shoot fixes, test coverage, and reported validation results. It does not use the repository template headings and does not explicitly address breakin…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The PR uses bug-fix language, but all changed files are under apps/website, including Playwright coverage under apps/website/e2e/. The custom check explicitly excludes PRs that are exclusively in …
Website End-To-End Regression Coverage ✅ Passed The PR changes website runtime behavior, including failure-message placement and seed handling. It also updates apps/website/e2e/workshop-apps.spec.ts with Playwright assertions for the failed scene…
Adr Compliance For Entity/Litegraph Changes ✅ Passed PASS. The changed-file list contains only website Re-shoot files under apps/website. No files under src/lib/litegraph/, src/ecs/, or graph-entity-related files are listed, so this check does not apply…
✨ Finishing Touches 💡 1
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously requested changes Sep 30, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-merge checks failed. Please resolve the failing checks before merging.

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../workshop/cinematic-studio/reshoot/ReshootWarp.vue 37.50% 5 Missing ⚠️
.../workshop/cinematic-studio/reshoot/ReshootSide.vue 33.33% 2 Missing ⚠️
...p/cinematic-studio/reshoot-engine/warp-renderer.ts 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (52.94%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main   #19558      +/-   ##
==========================================
- Coverage   84.37%   84.27%   -0.10%     
==========================================
  Files        3325     3253      -72     
  Lines      160359   158185    -2174     
  Branches    41760    41035     -725     
==========================================
- Hits       135300   133309    -1991     
+ Misses      23159    23096      -63     
+ Partials     1900     1780     -120     
Flag Coverage Δ
billing-web-unit ?
website-unit 79.52% <52.94%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...orkshop/cinematic-studio/reshoot/ReshootStudio.vue 93.10% <100.00%> (+6.89%) ⬆️
apps/website/src/composables/useReshoot.ts 93.14% <100.00%> (+1.20%) ⬆️
.../src/lib/workshop/cinematic-studio/reshoot-copy.ts 80.00% <ø> (ø)
...bsite/src/lib/workshop/cinematic-studio/reshoot.ts 100.00% <100.00%> (ø)
...p/cinematic-studio/reshoot-engine/warp-renderer.ts 13.48% <0.00%> (-0.16%) ⬇️
.../workshop/cinematic-studio/reshoot/ReshootSide.vue 75.00% <33.33%> (+8.84%) ⬆️
.../workshop/cinematic-studio/reshoot/ReshootWarp.vue 47.61% <37.50%> (-0.96%) ⬇️

... and 73 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 30, 2026
…lamp

Covers the observable changes CodeRabbit's website e2e check flagged:
a failed scene reading is said once, beside Try again, not in the
preview too; a typed seed is held to MAX_SEED. Both fail with their fix
reverted. The proxy mock takes per-call overrides for the failure.
@datadog-official

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant