Repository navigation
fix(website): Re-shoot follow-ups from the #19465 review - #19558
benjcooley wants to merge 3 commits into
Conversation
- A read that failed before the app turned out to be unavailable now says "not available" in the preview, not beside a Try again that cannot help: the failure-once split also keys on `unavailable`. - A typed seed is held to MAX_SEED, the range every random draw spans; one above it would fail the take. - Only the latest replacement clip can land: an earlier pick whose length resolves later no longer replaces a newer one. - The warp preview closes frames decoded after it unmounts and no longer draws on a disposed renderer; dispose() also releases the WebGL context, since every re-read mounts a new preview. - cameraZone reuses the engine's zoneOf instead of a second copy. - The unused reshoot.demoNote string is removed. Page tests cover the failure-once split, including the unavailable case, and a panel test covers the seed limit.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 68e54ec4fc2f7646befbb46bde7a69d481b22a73
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19558.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-34pandvhy-comfyui.vercel.app Last updated: 2026-09-30T08:32:41Z for |
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL: APPROVED at f209cc6f63 (this posts as COMMENTED because the PR is authored as benjcooley; a counting approval from a human reviewer is still needed). 0 BLOCKER / 0 SHOULD FIX / 0 TRIVIAL.
All six #19465 follow-ups are fixed as asked:
- Failure-once split: both sides key on
depth === 'failed' && !unavailable, so a failed read plus anapp_unavailablequote leaves "not available" in the preview with no dead Try again. I agree with not settingunavailablefrom a read failure: only a successful quote clears it, so the page would lock. The new page test fails when the split is reverted (I checked). - Replacement pick race: the
pickscounter drops a stale pick, including its rejection message. - Seed: clamped to
MAX_SEED= 2^32 − 1, the same range as the random draw, with:maxon the field. Well insidenoise_seed's range. Tested. - Warp: bitmaps decoded after unmount are closed and never drawn, the renderer ref is cleared, and
dispose()releases the WebGL context. - Zones:
cameraZonedelegates tozoneOf.camera.tshas no imports, so there's no cycle, and the header is corrected. - Copy:
demoNoteis removed, with no references left.
Verified locally: reshoot/cinematic unit tests 407/407 (40 files) and typecheck clean.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughRe-shoot changes update camera-zone classification, seed and clip handling, unavailable-app notices, and rendering cleanup. Tests cover seed limits and failure-message placement. ChangesRe-shoot
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The changes improve seed bounds, failure notices, clip selection, and renderer cleanup without an identified merge-blocking regression. Mergeable subject to normal checks. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Comment |
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (52.94%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #19558 +/- ##
==========================================
- Coverage 84.37% 84.27% -0.10%
==========================================
Files 3325 3253 -72
Lines 160359 158185 -2174
Branches 41760 41035 -725
==========================================
- Hits 135300 133309 -1991
+ Misses 23159 23096 -63
+ Partials 1900 1780 -120
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 73 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…lamp Covers the observable changes CodeRabbit's website e2e check flagged: a failed scene reading is said once, beside Try again, not in the preview too; a typed seed is held to MAX_SEED. Both fail with their fix reverted. The proxy mock takes per-call overrides for the failure.
Follow-ups BILL raised as trivials in his review of #19465, which is merged. Each item is small and none blocked #19465.
unavailable(now exposed read-only fromuseReshoot).MAX_SEED(2³²−1), the range every random draw spans. A larger one used to fail the take. The input also setsmax.WarpRenderer.dispose()also releases the WebGL context, since every re-read mounts a new preview and browsers cap live contexts.cameraZonenow calls the engine'szoneOfinstead of a second copy. The constants and maths were identical, so there's no behaviour change.reshoot.demoNotestring.Tests. Two page tests cover the failure-once split: said once beside Try again, and moved to the preview when the app turns out to be unavailable. A panel test covers the seed limit. Each was checked to fail with its fix reverted.
Checks. typecheck 0 errors,
pnpm lint,format:checkand knip clean, website suite 10156 passed.