Skip to content

[backport cloud/1.54] Don't gate asset updates on sidebar, smarter page sizes - #19545

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
austin/backport-18633-cloud-1-54
Sep 30, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
austin/backport-18633-cloud-1-54

Conversation

@AustinMroz

Copy link
Copy Markdown
Collaborator

Manual backport of #18633 to cloud/1.54

Required non-trivial test changes since the branch predates the test mocking changes.

When a websocket event indicated that new assets were available, a load
event would only be triggered if assets were in a visible state. This
clashes with the need to have asset information available in more places
and results in a degraded user experience (The responsiveness of a user
opening the assets panel was gated on the time it took to reload asset
state)

Set `include_public: false` as a default option.
- In my personal testing, I had thought this would already be the
default. Since this appears to not always be the case it is formally
specified.
- The intent is that public assets, as with `temp` assets, should be
exposed as a filter option on the assets sidebar. This doesn't mesh as
well as I would like with my current caching system. I will need further
consideration to ensure things remain performant even once such a system
has been added.

Added context aware page sizes.
- Loading too many assets is rarely problematic. The base page size has
been quintupled to `100`
- LoadingNew is usually performed after a single node produces an
output. Usually this results in a single asset, so the page size is kept
small. After the first iteration, the page size returns to the default
to better handle long tail edge cases (Someone pipes a 1000 frame video
into a 'Save Image')

See #18046
I strongly believe that defaults should be used whenever possible.
Making page size frontend specified means
- We choose not to trust the server's ability to make informed decisions
about page size. (i.e. Local has lower roundtrip latency so it's more
responsive with small page size)
- We loose the ability to change the behaviour without frontend code
updates
- AI bots wind up writing change detector tests that verify arbitrary
numbers instead of actual performance characteristics.

The change here is more justifiable to me since it leverages information
the frontend has that the backend does not.

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>
@AustinMroz AustinMroz added the backport Backporting a PR onto a release candidate label Sep 30, 2026
@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 30, 2026 2:54am UTC
billing-web-test Ignored Ignored Sep 30, 2026 2:54am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 64b58b25-1e42-40b3-acf3-906f3bf9d00e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/30/2026, 03:03:57 AM UTC

Links

🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1941 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 124ms TBT · 79.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.5 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 162.8 MB heap
vue-large-graph-pan: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 154ms TBT · 179.3 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 453ms TBT · 175.5 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 164.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 576ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 74.9 MB
canvas-idle: DOM nodes -284
canvas-idle: event listeners -164
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 1005ms
canvas-mouse-sweep: script duration 167ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.0 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 364ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.8 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 468ms
dom-widget-clipping: script duration 164ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.7 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 677ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.9 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1712ms
large-graph-pan: script duration 808ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 75.5 MB
large-graph-pan: DOM nodes -277
large-graph-pan: event listeners -178
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1773ms
large-graph-zoom: script duration 786ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.1 MB
large-graph-zoom: DOM nodes -145
large-graph-zoom: event listeners -95
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 2039ms
legacy-node-drag: script duration 1017ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 88.1 MB
legacy-node-drag: DOM nodes -141
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 599ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.7 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -179
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 421ms
subgraph-dom-widget-clipping: script duration 146ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.0 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 8
subgraph-idle: task duration 539ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.6 MB
subgraph-idle: DOM nodes -298
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 823ms
subgraph-mouse-sweep: script duration 109ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.1 MB
subgraph-mouse-sweep: DOM nodes -131
subgraph-mouse-sweep: event listeners -103
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 909ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 124ms
subgraph-transition-enter: heap used 79.4 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 41ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5983ms
viewport-pan-sweep: script duration 2689ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.5 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -162
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17771ms
vue-large-graph-idle: script duration 299ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 162.8 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 24ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 22838ms
vue-large-graph-pan: script duration 961ms
vue-large-graph-pan: TBT 154ms
vue-large-graph-pan: heap used 179.3 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 76ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6463ms
vue-node-resize-workload: script duration 125ms
vue-node-resize-workload: TBT 453ms
vue-node-resize-workload: heap used 175.5 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8989ms
vue-zoom-out-idle: script duration 173ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 164.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 110ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.7 MB
workflow-execution: DOM nodes 119
workflow-execution: event listeners 67
Raw data
{
  "timestamp": "2026-09-30T03:12:05.724Z",
  "gitSha": "b1bd9f26f70deac0676ec6c40ea0b221e1542730",
  "branch": "austin/backport-18633-cloud-1-54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2085.268000000042,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.623,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 621.2950000000001,
      "heapDeltaBytes": 12579748,
      "heapUsedBytes": 83205172,
      "domNodes": -285,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 12.831999999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2055.0929999999994,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.698999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.565,
      "heapDeltaBytes": 2602148,
      "heapUsedBytes": 73861992,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.220999999999997,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2172.8070000000343,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 34.665,
      "layouts": 14,
      "layoutDurationMs": 4.876,
      "taskDurationMs": 1147.4909999999998,
      "heapDeltaBytes": -5996328,
      "heapUsedBytes": 64543584,
      "domNodes": -282,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 188.08,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1822.0760000000382,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 27.423000000000002,
      "layouts": 14,
      "layoutDurationMs": 4.216,
      "taskDurationMs": 862.857,
      "heapDeltaBytes": -11439900,
      "heapUsedBytes": 59216180,
      "domNodes": -279,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 145.15,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.9209999999812,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.906999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.1600000000000001,
      "taskDurationMs": 361.839,
      "heapDeltaBytes": 4604840,
      "heapUsedBytes": 75923372,
      "domNodes": 76,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 11.56,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1736.5290000000186,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.330000000000005,
      "layouts": 6,
      "layoutDurationMs": 1.2049999999999998,
      "taskDurationMs": 366.84900000000005,
      "heapDeltaBytes": 4300176,
      "heapUsedBytes": 74575532,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 12.517999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 724.36399999998,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.827000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.592,
      "heapDeltaBytes": -7415996,
      "heapUsedBytes": 63262372,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 166.80499999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 691.944000000035,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.4959999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.9,
      "heapDeltaBytes": 18650392,
      "heapUsedBytes": 89190592,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 160.283,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2058.5510000000227,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.542,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 733.3009999999999,
      "heapDeltaBytes": 10984788,
      "heapUsedBytes": 87071348,
      "domNodes": -273,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 40.20799999999999,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2058.00099999999,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.521000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 620.1949999999999,
      "heapDeltaBytes": 10610416,
      "heapUsedBytes": 86814520,
      "domNodes": -271,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 34.73,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2548.2529999999883,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 12.43,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1768.2599999999998,
      "heapDeltaBytes": 13156116,
      "heapUsedBytes": 90662112,
      "domNodes": -273,
      "jsHeapTotalBytes": -2236416,
      "scriptDurationMs": 828.7,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2225.4370000000563,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.810000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1656.327,
      "heapDeltaBytes": -9638768,
      "heapUsedBytes": 67697580,
      "domNodes": -281,
      "jsHeapTotalBytes": 421888,
      "scriptDurationMs": 787.779,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3540.290999999968,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.395000000000003,
      "layouts": 60,
      "layoutDurationMs": 13.619,
      "taskDurationMs": 1763.903,
      "heapDeltaBytes": 8359308,
      "heapUsedBytes": 76170344,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 789.494,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3586.270000000013,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 14.051,
      "layouts": 60,
      "layoutDurationMs": 13.786,
      "taskDurationMs": 1781.5979999999997,
      "heapDeltaBytes": -7465332,
      "heapUsedBytes": 70828176,
      "domNodes": -289,
      "jsHeapTotalBytes": 3829760,
      "scriptDurationMs": 781.8119999999999,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3271.195999999975,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 10.936000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2115.603,
      "heapDeltaBytes": 9617716,
      "heapUsedBytes": 91380088,
      "domNodes": -281,
      "jsHeapTotalBytes": 1626112,
      "scriptDurationMs": 1039.679,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3158.403000000021,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.626000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1961.866,
      "heapDeltaBytes": 25296572,
      "heapUsedBytes": 93339240,
      "domNodes": 0,
      "jsHeapTotalBytes": 1728512,
      "scriptDurationMs": 994.795,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.1079999999893,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.7430000000000025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 601.8960000000001,
      "heapDeltaBytes": 9712268,
      "heapUsedBytes": 87564116,
      "domNodes": -273,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 37.60300000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2032.6000000000022,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.5169999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 595.796,
      "heapDeltaBytes": 9825328,
      "heapUsedBytes": 87957728,
      "domNodes": -273,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 32.807,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 621.7340000000036,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.746,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 413.5779999999999,
      "heapDeltaBytes": 15111148,
      "heapUsedBytes": 88691716,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 141.85600000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 589.7099999999682,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 10.597000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 429.2049999999999,
      "heapDeltaBytes": 14663872,
      "heapUsedBytes": 87366056,
      "domNodes": 16,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 150.62599999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2057.6300000000174,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.647000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 589.074,
      "heapDeltaBytes": 3173852,
      "heapUsedBytes": 76730120,
      "domNodes": -297,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 11.289999999999997,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.4890000000405,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.9799999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.5919999999999,
      "heapDeltaBytes": -5773772,
      "heapUsedBytes": 67218572,
      "domNodes": -298,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.865,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1740.8260000000269,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 31.819,
      "layouts": 18,
      "layoutDurationMs": 5.936,
      "taskDurationMs": 886.385,
      "heapDeltaBytes": -13370036,
      "heapUsedBytes": 59347920,
      "domNodes": -295,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 114.548,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.9509999999937,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.966000000000005,
      "layouts": 18,
      "layoutDurationMs": 4.796,
      "taskDurationMs": 759.1909999999999,
      "heapDeltaBytes": -5770180,
      "heapUsedBytes": 66725376,
      "domNodes": 34,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 103.46600000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1367.240000000038,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 30.154,
      "layouts": 15,
      "layoutDurationMs": 14.175,
      "taskDurationMs": 908.7260000000001,
      "heapDeltaBytes": -5168820,
      "heapUsedBytes": 83289608,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 30.363000000000007,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 124,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8698.938999999995,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 42.202,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6087.889999999999,
      "heapDeltaBytes": 14423232,
      "heapUsedBytes": 90900512,
      "domNodes": -269,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 2744.984,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8426.442999999948,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 39.718,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5878.811000000001,
      "heapDeltaBytes": 9553004,
      "heapUsedBytes": 86281412,
      "domNodes": -270,
      "jsHeapTotalBytes": -1187840,
      "scriptDurationMs": 2633.4559999999997,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18158.613,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17785.695,
      "heapDeltaBytes": -55646680,
      "heapUsedBytes": 172632624,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10928128,
      "scriptDurationMs": 304.517,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18183.867999999962,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17757.053,
      "heapDeltaBytes": -53914640,
      "heapUsedBytes": 168682816,
      "domNodes": -8068,
      "jsHeapTotalBytes": -7348224,
      "scriptDurationMs": 293.90700000000004,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23140.326999999957,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 24.021000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22909.898,
      "heapDeltaBytes": -33193420,
      "heapUsedBytes": 195275728,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17059840,
      "scriptDurationMs": 971.9669999999999,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 176,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22929.459000000064,
      "styleRecalcs": 169,
      "styleRecalcDurationMs": 24.855000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22767.022999999997,
      "heapDeltaBytes": -32813928,
      "heapUsedBytes": 180670792,
      "domNodes": -8068,
      "jsHeapTotalBytes": -23244800,
      "scriptDurationMs": 949.4390000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 132,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6393.0869999999795,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.94499999999998,
      "layouts": 20,
      "layoutDurationMs": 24.001999999999995,
      "taskDurationMs": 6302.463,
      "heapDeltaBytes": -51051936,
      "heapUsedBytes": 184298256,
      "domNodes": -8067,
      "jsHeapTotalBytes": 17518592,
      "scriptDurationMs": 121.70499999999998,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 397,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6673.775999999975,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.237,
      "layouts": 20,
      "layoutDurationMs": 26.782,
      "taskDurationMs": 6623.906,
      "heapDeltaBytes": -39336664,
      "heapUsedBytes": 183834192,
      "domNodes": -8068,
      "jsHeapTotalBytes": 17276928,
      "scriptDurationMs": 128.023,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 509,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9160.08899999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8935.714,
      "heapDeltaBytes": 3400900,
      "heapUsedBytes": 177345588,
      "domNodes": 0,
      "jsHeapTotalBytes": -17301504,
      "scriptDurationMs": 184.562,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9182.395000000042,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9043.166000000001,
      "heapDeltaBytes": 9743820,
      "heapUsedBytes": 168186460,
      "domNodes": 0,
      "jsHeapTotalBytes": -3932160,
      "scriptDurationMs": 160.744,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 457.7239999999847,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 19.209,
      "layouts": 2,
      "layoutDurationMs": 0.495,
      "taskDurationMs": 104.50800000000002,
      "heapDeltaBytes": 4862224,
      "heapUsedBytes": 74309176,
      "domNodes": 120,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 8.461000000000002,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 487.5609999999142,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 20.462,
      "layouts": 3,
      "layoutDurationMs": 0.9849999999999998,
      "taskDurationMs": 115.83500000000002,
      "heapDeltaBytes": 4875236,
      "heapUsedBytes": 69747284,
      "domNodes": 117,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 8.784,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50765 76057 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.4% 252
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/assets/composables/useAssetsQuery.ts 80.00% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #19545   +/-   ##
=============================================
  Coverage              ?   84.00%           
=============================================
  Files                 ?     2120           
  Lines                 ?   126835           
  Branches              ?    34317           
=============================================
  Hits                  ?   106545           
  Misses                ?    20112           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.76% <75.00%> (?)
unit 79.15% <71.42%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/views/GraphView.vue 71.03% <100.00%> (ø)
src/platform/assets/composables/useAssetsQuery.ts 82.41% <80.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryan-di ryan-di left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches #18633. The page-size spec, unit tests and pinned limit it removes don't exist on cloud/1.54; the GraphView test adapts to the branch's mocked stores and checks the same behavior.

@comfy-pr-bot
comfy-pr-bot merged commit 76cd025 into cloud/1.54 Sep 30, 2026
106 of 109 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the austin/backport-18633-cloud-1-54 branch September 30, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants