Repository navigation
[backport cloud/1.54] Don't gate asset updates on sidebar, smarter page sizes - #19545
Conversation
When a websocket event indicated that new assets were available, a load event would only be triggered if assets were in a visible state. This clashes with the need to have asset information available in more places and results in a degraded user experience (The responsiveness of a user opening the assets panel was gated on the time it took to reload asset state) Set `include_public: false` as a default option. - In my personal testing, I had thought this would already be the default. Since this appears to not always be the case it is formally specified. - The intent is that public assets, as with `temp` assets, should be exposed as a filter option on the assets sidebar. This doesn't mesh as well as I would like with my current caching system. I will need further consideration to ensure things remain performant even once such a system has been added. Added context aware page sizes. - Loading too many assets is rarely problematic. The base page size has been quintupled to `100` - LoadingNew is usually performed after a single node produces an output. Usually this results in a single asset, so the page size is kept small. After the first iteration, the page size returns to the default to better handle long tail edge cases (Someone pipes a 1000 frame video into a 'Save Image') See #18046 I strongly believe that defaults should be used whenever possible. Making page size frontend specified means - We choose not to trust the server's ability to make informed decisions about page size. (i.e. Local has lower roundtrip latency so it's more responsive with small page size) - We loose the ability to change the behaviour without frontend code updates - AI bots wind up writing change detector tests that verify arbitrary numbers instead of actual performance characteristics. The change here is more justifiable to me since it leverages information the frontend has that the backend does not. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-30T03:12:05.724Z",
"gitSha": "b1bd9f26f70deac0676ec6c40ea0b221e1542730",
"branch": "austin/backport-18633-cloud-1-54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2085.268000000042,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.623,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 621.2950000000001,
"heapDeltaBytes": 12579748,
"heapUsedBytes": 83205172,
"domNodes": -285,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 12.831999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2055.0929999999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.698999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.565,
"heapDeltaBytes": 2602148,
"heapUsedBytes": 73861992,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.220999999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2172.8070000000343,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.665,
"layouts": 14,
"layoutDurationMs": 4.876,
"taskDurationMs": 1147.4909999999998,
"heapDeltaBytes": -5996328,
"heapUsedBytes": 64543584,
"domNodes": -282,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 188.08,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.0760000000382,
"styleRecalcs": 75,
"styleRecalcDurationMs": 27.423000000000002,
"layouts": 14,
"layoutDurationMs": 4.216,
"taskDurationMs": 862.857,
"heapDeltaBytes": -11439900,
"heapUsedBytes": 59216180,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 145.15,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.9209999999812,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.906999999999998,
"layouts": 6,
"layoutDurationMs": 1.1600000000000001,
"taskDurationMs": 361.839,
"heapDeltaBytes": 4604840,
"heapUsedBytes": 75923372,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.56,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.5290000000186,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.330000000000005,
"layouts": 6,
"layoutDurationMs": 1.2049999999999998,
"taskDurationMs": 366.84900000000005,
"heapDeltaBytes": 4300176,
"heapUsedBytes": 74575532,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.517999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 724.36399999998,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.827000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.592,
"heapDeltaBytes": -7415996,
"heapUsedBytes": 63262372,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 166.80499999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 691.944000000035,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.4959999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.9,
"heapDeltaBytes": 18650392,
"heapUsedBytes": 89190592,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 160.283,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2058.5510000000227,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.542,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 733.3009999999999,
"heapDeltaBytes": 10984788,
"heapUsedBytes": 87071348,
"domNodes": -273,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 40.20799999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2058.00099999999,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.521000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.1949999999999,
"heapDeltaBytes": 10610416,
"heapUsedBytes": 86814520,
"domNodes": -271,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 34.73,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2548.2529999999883,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.43,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1768.2599999999998,
"heapDeltaBytes": 13156116,
"heapUsedBytes": 90662112,
"domNodes": -273,
"jsHeapTotalBytes": -2236416,
"scriptDurationMs": 828.7,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2225.4370000000563,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.810000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1656.327,
"heapDeltaBytes": -9638768,
"heapUsedBytes": 67697580,
"domNodes": -281,
"jsHeapTotalBytes": 421888,
"scriptDurationMs": 787.779,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3540.290999999968,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.395000000000003,
"layouts": 60,
"layoutDurationMs": 13.619,
"taskDurationMs": 1763.903,
"heapDeltaBytes": 8359308,
"heapUsedBytes": 76170344,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 789.494,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3586.270000000013,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.051,
"layouts": 60,
"layoutDurationMs": 13.786,
"taskDurationMs": 1781.5979999999997,
"heapDeltaBytes": -7465332,
"heapUsedBytes": 70828176,
"domNodes": -289,
"jsHeapTotalBytes": 3829760,
"scriptDurationMs": 781.8119999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3271.195999999975,
"styleRecalcs": 42,
"styleRecalcDurationMs": 10.936000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2115.603,
"heapDeltaBytes": 9617716,
"heapUsedBytes": 91380088,
"domNodes": -281,
"jsHeapTotalBytes": 1626112,
"scriptDurationMs": 1039.679,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3158.403000000021,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.626000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1961.866,
"heapDeltaBytes": 25296572,
"heapUsedBytes": 93339240,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 994.795,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2037.1079999999893,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.7430000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.8960000000001,
"heapDeltaBytes": 9712268,
"heapUsedBytes": 87564116,
"domNodes": -273,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 37.60300000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.6000000000022,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.5169999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 595.796,
"heapDeltaBytes": 9825328,
"heapUsedBytes": 87957728,
"domNodes": -273,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 32.807,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 621.7340000000036,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.746,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.5779999999999,
"heapDeltaBytes": 15111148,
"heapUsedBytes": 88691716,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 141.85600000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.7099999999682,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.597000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.2049999999999,
"heapDeltaBytes": 14663872,
"heapUsedBytes": 87366056,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 150.62599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2057.6300000000174,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.647000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.074,
"heapDeltaBytes": 3173852,
"heapUsedBytes": 76730120,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.289999999999997,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2023.4890000000405,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.9799999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.5919999999999,
"heapDeltaBytes": -5773772,
"heapUsedBytes": 67218572,
"domNodes": -298,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.865,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.8260000000269,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.819,
"layouts": 18,
"layoutDurationMs": 5.936,
"taskDurationMs": 886.385,
"heapDeltaBytes": -13370036,
"heapUsedBytes": 59347920,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 114.548,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.9509999999937,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.966000000000005,
"layouts": 18,
"layoutDurationMs": 4.796,
"taskDurationMs": 759.1909999999999,
"heapDeltaBytes": -5770180,
"heapUsedBytes": 66725376,
"domNodes": 34,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 103.46600000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.240000000038,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.154,
"layouts": 15,
"layoutDurationMs": 14.175,
"taskDurationMs": 908.7260000000001,
"heapDeltaBytes": -5168820,
"heapUsedBytes": 83289608,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.363000000000007,
"eventListeners": 2385,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8698.938999999995,
"styleRecalcs": 248,
"styleRecalcDurationMs": 42.202,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6087.889999999999,
"heapDeltaBytes": 14423232,
"heapUsedBytes": 90900512,
"domNodes": -269,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 2744.984,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8426.442999999948,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.718,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5878.811000000001,
"heapDeltaBytes": 9553004,
"heapUsedBytes": 86281412,
"domNodes": -270,
"jsHeapTotalBytes": -1187840,
"scriptDurationMs": 2633.4559999999997,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18158.613,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17785.695,
"heapDeltaBytes": -55646680,
"heapUsedBytes": 172632624,
"domNodes": -8068,
"jsHeapTotalBytes": -10928128,
"scriptDurationMs": 304.517,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18183.867999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17757.053,
"heapDeltaBytes": -53914640,
"heapUsedBytes": 168682816,
"domNodes": -8068,
"jsHeapTotalBytes": -7348224,
"scriptDurationMs": 293.90700000000004,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 23140.326999999957,
"styleRecalcs": 175,
"styleRecalcDurationMs": 24.021000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22909.898,
"heapDeltaBytes": -33193420,
"heapUsedBytes": 195275728,
"domNodes": -8068,
"jsHeapTotalBytes": -17059840,
"scriptDurationMs": 971.9669999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 176,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22929.459000000064,
"styleRecalcs": 169,
"styleRecalcDurationMs": 24.855000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22767.022999999997,
"heapDeltaBytes": -32813928,
"heapUsedBytes": 180670792,
"domNodes": -8068,
"jsHeapTotalBytes": -23244800,
"scriptDurationMs": 949.4390000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 132,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6393.0869999999795,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.94499999999998,
"layouts": 20,
"layoutDurationMs": 24.001999999999995,
"taskDurationMs": 6302.463,
"heapDeltaBytes": -51051936,
"heapUsedBytes": 184298256,
"domNodes": -8067,
"jsHeapTotalBytes": 17518592,
"scriptDurationMs": 121.70499999999998,
"eventListeners": -14931,
"totalBlockingTimeMs": 397,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6673.775999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.237,
"layouts": 20,
"layoutDurationMs": 26.782,
"taskDurationMs": 6623.906,
"heapDeltaBytes": -39336664,
"heapUsedBytes": 183834192,
"domNodes": -8068,
"jsHeapTotalBytes": 17276928,
"scriptDurationMs": 128.023,
"eventListeners": -14927,
"totalBlockingTimeMs": 509,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9160.08899999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8935.714,
"heapDeltaBytes": 3400900,
"heapUsedBytes": 177345588,
"domNodes": 0,
"jsHeapTotalBytes": -17301504,
"scriptDurationMs": 184.562,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9182.395000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9043.166000000001,
"heapDeltaBytes": 9743820,
"heapUsedBytes": 168186460,
"domNodes": 0,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 160.744,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 457.7239999999847,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.209,
"layouts": 2,
"layoutDurationMs": 0.495,
"taskDurationMs": 104.50800000000002,
"heapDeltaBytes": 4862224,
"heapUsedBytes": 74309176,
"domNodes": 120,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.461000000000002,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 487.5609999999142,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.462,
"layouts": 3,
"layoutDurationMs": 0.9849999999999998,
"taskDurationMs": 115.83500000000002,
"heapDeltaBytes": 4875236,
"heapUsedBytes": 69747284,
"domNodes": 117,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.784,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #19545 +/- ##
=============================================
Coverage ? 84.00%
=============================================
Files ? 2120
Lines ? 126835
Branches ? 34317
=============================================
Hits ? 106545
Misses ? 20112
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Manual backport of #18633 to
cloud/1.54Required non-trivial test changes since the branch predates the test mocking changes.