Repository navigation
Conversation
The credential guard added in #19523 made the script exit before any scenario ran, but the harness only inherited GH_TOKEN from the shell, so the suite passed on a developer machine with a token exported and failed on every CI job. The harness now supplies its own stub token alongside the stub `gh`, and a new case pins the guard by running with the credential blank.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe backport-tag test helper now accepts an optional token and sets it as ChangesBackport tag token test
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The test no longer depends on an ambient GH_TOKEN and covers the missing-token error. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e71d2fa088ed561327479243c63cf0c7ef07c4ab
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 99585b3 | Docs | View more details | Give us feedback! |
|
Superseded — please close without merging. #19532 ("test: isolate cloud tag token contract") landed on
The one red check here is caused by that duplication, not by a defect in either change. The two branches insert That is
CodeRabbit's approval on this branch is accurate in isolation and changes nothing here; the diff is redundant regardless of its quality. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19544 +/- ##
==========================================
+ Coverage 84.31% 85.04% +0.72%
==========================================
Files 3294 2340 -954
Lines 158986 133925 -25061
Branches 43239 36088 -7151
==========================================
- Hits 134051 113892 -20159
+ Misses 23060 19668 -3392
+ Partials 1875 365 -1510
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
PR Created by the Glary-Bot Agent
scripts/cicd/cloud-backport-tag.test.tsis red onmainand on every PR whose merge ref includes #19523, regardless of what the PR changes. Reported from #17413 (a camera-angle PR that touches no CI scripts).Root cause
#19523 added a credential precondition to the script:
The harness never supplied one.
runTagScriptstubsghonPATHand sets every other variable the script reads —EVENT_NAME,BRANCH,GITHUB_REPOSITORY,GITHUB_OUTPUT,GITHUB_STEP_SUMMARY— butGH_TOKENarrived only through the...process.envspread. A developer shell with a token exported satisfies it;ci-tests-unit.yamlhas none, so the script exits at line 5 before reaching the stub and all six scenario tests fail.Reproduced on
mainwith the token unset —6 failed | 1 passed, and the[6/18]failure counter is 6 tests acrossretry: 2, which is why the report showed one test name three times.Fix
Pin
GH_TOKENin the spawned environment next to the stubgh, placed after the spread so an ambient token cannot change the outcome either, and add a case that runs with the credential blank to pin the guard #19523 introduced. That guard had no coverage, which is why a script change requiring a secret could ship green.Verification
vitest run --project tooling scripts/cicd/cloud-backport-tag.test.tsunderCI=truewithGH_TOKENandGITHUB_TOKENunset (the Actions environment): 8/8 pass, no retries.GH_TOKENexported: 8/8 pass — hermetic in both directions.cloud-backport-tag.shturns the new test red (exit 0,::notice::Tag cloud/v1.54.16 already exists); restoring it turns it green. It pins behavior, not wording.scripts/cicd/tooling suite with no token:203 passed. The one remaining red file,upsert-comment-section-large-content.test.ts, fails identically onmainin this container — it probes for theE2BIGenvironment-size limit, which this sandbox does not enforce — and is untouched here.scripts/cicd/cloud-backport-tag.sh: line 5: GH_TOKEN: PR_GH_TOKEN is required for cloud tag reconciliation, exit 1.typecheck:scriptsclean.No Playwright screenshots: the change is a CI shell-script test with no browser surface.
Unblocks #17413 and every other PR currently failing on this file.