Repository navigation
[backport core/1.54] feat(agent): show the credits paywall when the workspace runs out, not only when a send is refused - #19520
Conversation
… refused send The agent paywall was reachable from exactly one moment: a turn POST that came back 402/`no_funds`, which `recordSendError` turns into an inline card. Every other way a user meets the credit ceiling had no upgrade path at all. Two things produce that ceiling server-side, and both emit the same `team_billing:agent_credit_stopped`: the pre-turn gate on `AgentPostMessage` (the panel's own POST, so the browser sees the 402) and the per-call gate on `AgentLLMMessages`, the agent runtime's LLM hop. The frontend never calls that second route, so a refusal there kills a turn with no admission error to render. A user who simply does not type again gets nothing either: the one `hasFunds === false` surface in the product is `useBillingBanner`'s `outOfCredits`, which is gated to team plans and lives inside the settings dialog. Measured on 2026-09-25, the one full day the credit-stop event has existed: 65 of the 141 people who sent an agent message hit the ceiling, and 2 were shown a way to pay. Every one of those 65 workspaces is `personal`, so none could have seen the team banner. So read the funds signal the client already holds instead of waiting for a refusal to carry it. `AgentPanelRoot` already cleared paywalls when `subscription.hasFunds` became true; this is the symmetric other half, rendering the existing `AgentPaywallCard` beside the composer when it becomes false. It is non-modal and disables nothing - the composer stays live. `app:agent_paywall_shown` and `app:agent_paywall_cta_clicked` now carry a required `surface` of `refused_send | credits_exhausted`. Without it a rise in impressions is ambiguous between this fix landing and more users being refused. Gated on the capability read having settled (an unsettled read cannot name the right remediation), hidden when the presentation resolves to `unavailable`, suppressed while an inline card is already on screen, and cloud-only. One impression per exhaustion episode, reset when funds return. The pre-existing paywall tests are scoped to the transcript via a new `agent-conversation` testid, since two surfaces now render the same component with the same copy; no assertion was weakened.
Addresses Comfy-Org#18967 (comment) Addresses Comfy-Org#18967 (comment) Addresses Comfy-Org#18967 (comment) Addresses Comfy-Org#18967 (comment) Addresses Comfy-Org#18967 (comment) Addresses Comfy-Org#18967 (comment) Addresses Comfy-Org#18967 (comment)
Addresses review feedback: Comfy-Org#18967 (comment)
Addresses review feedback: Comfy-Org#18967 (comment) Comfy-Org#18967 (comment)
Addresses review feedback: Comfy-Org#18967 (review)
Addresses review feedback: Comfy-Org#18967 (comment)
Addresses review feedback: Comfy-Org#18967 (comment)
Addresses review feedback: Comfy-Org#18967 (comment)
Align billing status fields with generated cloud@4c75dea output. Amp-Thread-ID: https://ampcode.com/threads/T-01a0e60b-75fb-7411-9d36-582ff066db3b
|
@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel. A member of the Team first needs to authorize it. |
🎭 Playwright: ⏳ Running...🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T01:56:37.398Z",
"gitSha": "49de090c7750b961d69851674af57dcdb15b25da",
"branch": "backport-18967-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2062.7910000000043,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.105999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.946,
"heapDeltaBytes": 1799276,
"heapUsedBytes": 72201884,
"domNodes": -284,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.204999999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2055.878000000007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.257,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.908,
"heapDeltaBytes": -9103360,
"heapUsedBytes": 62200884,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.399000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1907.3290000000043,
"styleRecalcs": 79,
"styleRecalcDurationMs": 34.758,
"layouts": 14,
"layoutDurationMs": 4.678,
"taskDurationMs": 925.218,
"heapDeltaBytes": -3180284,
"heapUsedBytes": 68012960,
"domNodes": -280,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 176.98600000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.745000000068,
"styleRecalcs": 72,
"styleRecalcDurationMs": 27.072000000000003,
"layouts": 14,
"layoutDurationMs": 3.8859999999999997,
"taskDurationMs": 819.272,
"heapDeltaBytes": 24651580,
"heapUsedBytes": 88760708,
"domNodes": 34,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 163.519,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.6540000000205,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.261,
"layouts": 6,
"layoutDurationMs": 1.2289999999999999,
"taskDurationMs": 362.983,
"heapDeltaBytes": 4609256,
"heapUsedBytes": 75830344,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.188,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1664.7109999998975,
"styleRecalcs": 29,
"styleRecalcDurationMs": 17.163999999999998,
"layouts": 6,
"layoutDurationMs": 0.964,
"taskDurationMs": 366.658,
"heapDeltaBytes": 4553936,
"heapUsedBytes": 75742796,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.270999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 710.4929999999854,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.978000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.322,
"heapDeltaBytes": 18709848,
"heapUsedBytes": 88806148,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 177.014,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 704.6460000000252,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.039,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.05299999999994,
"heapDeltaBytes": 18432232,
"heapUsedBytes": 88732932,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 176.92000000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2063.9889999999923,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.049999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.1360000000001,
"heapDeltaBytes": 6711336,
"heapUsedBytes": 83544288,
"domNodes": -277,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 33.541000000000004,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2022.3489999999629,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.8280000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.2760000000001,
"heapDeltaBytes": 21857640,
"heapUsedBytes": 87130580,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.888999999999996,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2357.2810000000004,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.821,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1715.943,
"heapDeltaBytes": 7945156,
"heapUsedBytes": 85424048,
"domNodes": -271,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 829.132,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2343.332000000032,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.106000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1729.8709999999999,
"heapDeltaBytes": 20737384,
"heapUsedBytes": 98278420,
"domNodes": -283,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 839.5200000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3597.219999999993,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.511,
"layouts": 60,
"layoutDurationMs": 12.033000000000001,
"taskDurationMs": 1715.4239999999998,
"heapDeltaBytes": 9479352,
"heapUsedBytes": 76336428,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 779.527,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3665.4450000000907,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.786000000000003,
"layouts": 60,
"layoutDurationMs": 11.911000000000001,
"taskDurationMs": 1743.9370000000001,
"heapDeltaBytes": 11831248,
"heapUsedBytes": 80002132,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 792.48,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3139.026000000001,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.792000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2031.7060000000001,
"heapDeltaBytes": 6986732,
"heapUsedBytes": 87703592,
"domNodes": -288,
"jsHeapTotalBytes": 315392,
"scriptDurationMs": 984.101,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3115.688999999975,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.670000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1939.489,
"heapDeltaBytes": 22547724,
"heapUsedBytes": 90366992,
"domNodes": 0,
"jsHeapTotalBytes": 2252800,
"scriptDurationMs": 961.3779999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2031.6740000000095,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.6220000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.9029999999999,
"heapDeltaBytes": 9728748,
"heapUsedBytes": 88257112,
"domNodes": -271,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 34.37800000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.8530000000128,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.962999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.1759999999998,
"heapDeltaBytes": 4697068,
"heapUsedBytes": 81912628,
"domNodes": -283,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 37.587999999999994,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.6019999999899,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.732000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.952,
"heapDeltaBytes": 14572560,
"heapUsedBytes": 87928488,
"domNodes": 14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 143.47899999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.0210000000543,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.622000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.069,
"heapDeltaBytes": 13906616,
"heapUsedBytes": 86455816,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 142.38500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2020.7760000000121,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.11,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.92400000000004,
"heapDeltaBytes": -15693620,
"heapUsedBytes": 57464952,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.517,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2020.614999999907,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.651000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.5080000000001,
"heapDeltaBytes": 496644,
"heapUsedBytes": 72975704,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.226,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1775.1469999999472,
"styleRecalcs": 78,
"styleRecalcDurationMs": 30.519,
"layouts": 18,
"layoutDurationMs": 5.168,
"taskDurationMs": 867.6500000000001,
"heapDeltaBytes": 8244472,
"heapUsedBytes": 81601384,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 117.87700000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1751.011999999946,
"styleRecalcs": 76,
"styleRecalcDurationMs": 28.208,
"layouts": 18,
"layoutDurationMs": 5.221,
"taskDurationMs": 843.852,
"heapDeltaBytes": 4506212,
"heapUsedBytes": 77848476,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 115.62700000000001,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.4959999999674,
"styleRecalcs": 19,
"styleRecalcDurationMs": 34.36199999999999,
"layouts": 15,
"layoutDurationMs": 16.602999999999998,
"taskDurationMs": 973.1160000000001,
"heapDeltaBytes": 19402772,
"heapUsedBytes": 108873680,
"domNodes": 13831,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 32.736000000000004,
"eventListeners": 2385,
"totalBlockingTimeMs": 159,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8734.895999999992,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.416999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5960.377,
"heapDeltaBytes": 5099880,
"heapUsedBytes": 81582992,
"domNodes": -268,
"jsHeapTotalBytes": -696320,
"scriptDurationMs": 2717.711,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8835.393999999951,
"styleRecalcs": 250,
"styleRecalcDurationMs": 45.70600000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6162.5160000000005,
"heapDeltaBytes": 18429340,
"heapUsedBytes": 94772004,
"domNodes": -266,
"jsHeapTotalBytes": -696320,
"scriptDurationMs": 2829.93,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17439.536000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16814.74,
"heapDeltaBytes": -65433524,
"heapUsedBytes": 177619560,
"domNodes": -8068,
"jsHeapTotalBytes": -20492288,
"scriptDurationMs": 287.577,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17680.788000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16907.001999999997,
"heapDeltaBytes": -61655396,
"heapUsedBytes": 178499112,
"domNodes": -8068,
"jsHeapTotalBytes": -16928768,
"scriptDurationMs": 302.784,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21620.122999999978,
"styleRecalcs": 170,
"styleRecalcDurationMs": 19.213000000000036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21222.924,
"heapDeltaBytes": -56618164,
"heapUsedBytes": 183204960,
"domNodes": -8068,
"jsHeapTotalBytes": -20779008,
"scriptDurationMs": 977.1659999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 55,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21609.785999999986,
"styleRecalcs": 166,
"styleRecalcDurationMs": 19.72099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21271.261,
"heapDeltaBytes": -35077000,
"heapUsedBytes": 184011356,
"domNodes": -8068,
"jsHeapTotalBytes": -12185600,
"scriptDurationMs": 947.266,
"eventListeners": -14927,
"totalBlockingTimeMs": 74,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6259.49700000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.36899999999997,
"layouts": 20,
"layoutDurationMs": 23.596999999999994,
"taskDurationMs": 6189.8589999999995,
"heapDeltaBytes": -40986056,
"heapUsedBytes": 177375096,
"domNodes": -8068,
"jsHeapTotalBytes": 9936896,
"scriptDurationMs": 133.11100000000002,
"eventListeners": -14927,
"totalBlockingTimeMs": 453,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6317.6619999999275,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.67000000000002,
"layouts": 20,
"layoutDurationMs": 23.980999999999987,
"taskDurationMs": 6182.2519999999995,
"heapDeltaBytes": -64541204,
"heapUsedBytes": 175645200,
"domNodes": -8068,
"jsHeapTotalBytes": 4554752,
"scriptDurationMs": 140.289,
"eventListeners": -14929,
"totalBlockingTimeMs": 373,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9002.284000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8616.985,
"heapDeltaBytes": 7473976,
"heapUsedBytes": 179534120,
"domNodes": 0,
"jsHeapTotalBytes": -12320768,
"scriptDurationMs": 142.6099999999999,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8927.72699999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8482.857999999998,
"heapDeltaBytes": 20387172,
"heapUsedBytes": 178705588,
"domNodes": 0,
"jsHeapTotalBytes": -8126464,
"scriptDurationMs": 149.22999999999996,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 492.57299999999304,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.633999999999997,
"layouts": 3,
"layoutDurationMs": 1.59,
"taskDurationMs": 125.26300000000002,
"heapDeltaBytes": 4933292,
"heapUsedBytes": 73416380,
"domNodes": 145,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.466999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 106.88900000002377,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.522,
"layouts": 2,
"layoutDurationMs": 1.4089999999999998,
"taskDurationMs": 74.72200000000001,
"heapDeltaBytes": 3036008,
"heapUsedBytes": 72313368,
"domNodes": 109,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.627000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #19520 +/- ##
=============================================
- Coverage 83.93% 82.40% -1.53%
=============================================
Files 2110 2539 +429
Lines 126137 133619 +7482
Branches 33875 35696 +1821
=============================================
+ Hits 105872 110110 +4238
- Misses 20086 22995 +2909
- Partials 179 514 +335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 446 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
## Summary - complete the shared `AgentPanelRoot` billing-context fixture required by #19520 - provide the billing telemetry spies exercised by the existing paywall cases - keep the default fixture on the legacy rail so unrelated panel tests do not activate the new standing-paywall path ## Verification - `pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts --testTimeout=30000 --reporter=dot` (279/279) - `pnpm exec vitest run src/composables/billing/useBillingContext.test.ts src/composables/billing/useLegacyBilling.test.ts src/platform/workspace/composables/useWorkspaceBilling.test.ts src/workbench/extensions/agent/services/agent/agentPaywallPresentation.test.ts --testTimeout=30000 --reporter=dot` (144/144) - `pnpm exec oxlint src/workbench/extensions/agent/AgentPanelRoot.test.ts` Unblocks #19578 after this lands on `core/1.54`.
Backports #18967 to
core/1.54.Source: #18967
Recovered the PR-owned linear commits
c55988354cthrough7f22a90177, plus17b04a33ab. Excluded merge-history commits0515ae8357,b30e8487ab,df3106893b,4d0ccb3547, andb9638cbd42.Compatibility resolutions preserve the release branch panel/new-chat structure, use its billing-capability readiness as the authoritative settled read, add the scoped Agent funds fields and normal billing-store integration, and retain the standing-paywall refresh/recovery lifecycle without websocket parsing. Main-only test context was excluded.
Verification:
NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheckpnpm typecheck:browseruseBillingContext,useAgentDockMount, dock/load-failure) with--testTimeout=30000localhost:5173; hosted CI remains the browser execution gate.