Skip to content

[backport cloud/1.54] feat(agent): show the credits paywall when the workspace runs out, not only when a send is refused - #19519

Merged
christian-byrne merged 24 commits into
Comfy-Org:cloud/1.54from
christian-byrne:backport-18967-to-cloud-1.54
Sep 30, 2026
Merged

christian-byrne merged 24 commits into
Comfy-Org:cloud/1.54from
christian-byrne:backport-18967-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #18967 to cloud/1.54.

Source: #18967

This manually recovers the PR-owned linear commits after the automated merge-commit backport conflicted. It excludes the source branch merge-history commits and preserves the release branch's supported billing-store integration.

Verification:

  • 687 focused unit tests pass
  • app typecheck passes
  • browser typecheck passes
  • changed-file ESLint and Oxfmt checks pass
  • the focused cloud browser case collects, but its configured endpoint rejects fixture settings setup with HTTP 405 before the test body

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cloud/1.54 Backport PRs for cloud 1.54 agent Comfy Agent product, integration, tests or product documentation labels Sep 30, 2026
@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 7adbfcca-7697-4570-b1d8-f69ab16b90d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

christian-byrne and others added 24 commits September 29, 2026 17:58
… refused send

The agent paywall was reachable from exactly one moment: a turn POST that came
back 402/`no_funds`, which `recordSendError` turns into an inline card. Every
other way a user meets the credit ceiling had no upgrade path at all.

Two things produce that ceiling server-side, and both emit the same
`team_billing:agent_credit_stopped`: the pre-turn gate on `AgentPostMessage`
(the panel's own POST, so the browser sees the 402) and the per-call gate on
`AgentLLMMessages`, the agent runtime's LLM hop. The frontend never calls that
second route, so a refusal there kills a turn with no admission error to render.
A user who simply does not type again gets nothing either: the one
`hasFunds === false` surface in the product is `useBillingBanner`'s
`outOfCredits`, which is gated to team plans and lives inside the settings
dialog.

Measured on 2026-09-25, the one full day the credit-stop event has existed: 65
of the 141 people who sent an agent message hit the ceiling, and 2 were shown a
way to pay. Every one of those 65 workspaces is `personal`, so none could have
seen the team banner.

So read the funds signal the client already holds instead of waiting for a
refusal to carry it. `AgentPanelRoot` already cleared paywalls when
`subscription.hasFunds` became true; this is the symmetric other half, rendering
the existing `AgentPaywallCard` beside the composer when it becomes false. It is
non-modal and disables nothing - the composer stays live.

`app:agent_paywall_shown` and `app:agent_paywall_cta_clicked` now carry a
required `surface` of `refused_send | credits_exhausted`. Without it a rise in
impressions is ambiguous between this fix landing and more users being refused.

Gated on the capability read having settled (an unsettled read cannot name the
right remediation), hidden when the presentation resolves to `unavailable`,
suppressed while an inline card is already on screen, and cloud-only. One
impression per exhaustion episode, reset when funds return.

The pre-existing paywall tests are scoped to the transcript via a new
`agent-conversation` testid, since two surfaces now render the same component
with the same copy; no assertion was weakened.
Align billing status fields with generated cloud@4c75dea output.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0e60b-75fb-7411-9d36-582ff066db3b
@github-actions
github-actions Bot requested a review from ryan-di September 30, 2026 01:00
@christian-byrne
christian-byrne force-pushed the backport-18967-to-cloud-1.54 branch from 3ac7975 to dba6ec5 Compare September 30, 2026 01:00
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/30/2026, 01:03:51 AM UTC

Links

🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1941 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 148ms TBT · 101.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.2 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.5 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 132ms TBT · 170.6 MB heap
vue-node-resize-workload: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 489ms TBT · 175.2 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 575ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.7 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -179
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 34ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 969ms
canvas-mouse-sweep: script duration 173ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 69.0 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -182
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 374ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.3 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 470ms
dom-widget-clipping: script duration 167ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 73.4 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 617ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.9 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1644ms
large-graph-pan: script duration 824ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 85.0 MB
large-graph-pan: DOM nodes -278
large-graph-pan: event listeners -78
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1730ms
large-graph-zoom: script duration 784ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.8 MB
large-graph-zoom: DOM nodes 1
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1939ms
legacy-node-drag: script duration 960ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 89.1 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 594ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.9 MB
minimap-idle: DOM nodes -277
minimap-idle: event listeners -94
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 404ms
subgraph-dom-widget-clipping: script duration 140ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.0 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 512ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 58.3 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -210
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 837ms
subgraph-mouse-sweep: script duration 114ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 63.1 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -242
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 982ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 148ms
subgraph-transition-enter: heap used 101.9 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6258ms
viewport-pan-sweep: script duration 2956ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.2 MB
viewport-pan-sweep: DOM nodes -276
viewport-pan-sweep: event listeners -160
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16880ms
vue-large-graph-idle: script duration 337ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.5 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14930
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 171
vue-large-graph-pan: task duration 20772ms
vue-large-graph-pan: script duration 915ms
vue-large-graph-pan: TBT 132ms
vue-large-graph-pan: heap used 170.6 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14929
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 81ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6226ms
vue-node-resize-workload: script duration 116ms
vue-node-resize-workload: TBT 489ms
vue-node-resize-workload: heap used 175.2 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8435ms
vue-zoom-out-idle: script duration 140ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 3
workflow-execution: style recalc count 9
workflow-execution: task duration 86ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.2 MB
workflow-execution: DOM nodes 120
workflow-execution: event listeners 26
Raw data
{
  "timestamp": "2026-09-30T01:12:45.576Z",
  "gitSha": "3f8a54bbb973be6b3db5f94598b1da054364a93c",
  "branch": "backport-18967-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2123.435000000029,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.704000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 664.184,
      "heapDeltaBytes": 3175000,
      "heapUsedBytes": 74475328,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 13.894,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2032.9029999999761,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.081000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.62000000000006,
      "heapDeltaBytes": 1198016,
      "heapUsedBytes": 71691060,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 7.701,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2134.563000000014,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 38.290000000000006,
      "layouts": 14,
      "layoutDurationMs": 4.218,
      "taskDurationMs": 1065.3410000000001,
      "heapDeltaBytes": 6668540,
      "heapUsedBytes": 77942636,
      "domNodes": -279,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 185.28599999999997,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1830.1510000000007,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 29.964,
      "layouts": 14,
      "layoutDurationMs": 3.872,
      "taskDurationMs": 872.7410000000001,
      "heapDeltaBytes": -4376188,
      "heapUsedBytes": 66731572,
      "domNodes": -278,
      "jsHeapTotalBytes": 7593984,
      "scriptDurationMs": 161.309,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1680.8070000000157,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 16.479,
      "layouts": 6,
      "layoutDurationMs": 1.115,
      "taskDurationMs": 374.639,
      "heapDeltaBytes": 4494156,
      "heapUsedBytes": 75718348,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.220000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.4899999999798,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.162000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.1729999999999998,
      "taskDurationMs": 374.101,
      "heapDeltaBytes": 4262072,
      "heapUsedBytes": 73879076,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.233,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 705.773000000022,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.698999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.7319999999999,
      "heapDeltaBytes": -6635932,
      "heapUsedBytes": 64779540,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 169.88400000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 709.1249999999718,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.415999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 454.879,
      "heapDeltaBytes": 18602976,
      "heapUsedBytes": 89226180,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 164.99999999999997,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2061.292000000037,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.368000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 622.5999999999999,
      "heapDeltaBytes": 7885120,
      "heapUsedBytes": 84781080,
      "domNodes": -274,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 37.059,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.7720000000136,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.457000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 610.4269999999999,
      "heapDeltaBytes": 10866244,
      "heapUsedBytes": 86965368,
      "domNodes": -266,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 34.437,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2328.8779999999747,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 7.399000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1651.4450000000002,
      "heapDeltaBytes": 23705540,
      "heapUsedBytes": 89083216,
      "domNodes": -282,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 838.343,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2299.498999999969,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.703999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1637.339,
      "heapDeltaBytes": 22986248,
      "heapUsedBytes": 89133920,
      "domNodes": -273,
      "jsHeapTotalBytes": 1536000,
      "scriptDurationMs": 808.714,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3587.8769999999918,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 11.369,
      "layouts": 60,
      "layoutDurationMs": 11.911999999999999,
      "taskDurationMs": 1746.8600000000004,
      "heapDeltaBytes": 8278780,
      "heapUsedBytes": 76614408,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 788.653,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3638.6380000000145,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.714,
      "layouts": 60,
      "layoutDurationMs": 11.663,
      "taskDurationMs": 1713.7289999999998,
      "heapDeltaBytes": 12067148,
      "heapUsedBytes": 80354192,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 779.2640000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3120.273999999995,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.698,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1951.9579999999999,
      "heapDeltaBytes": 24874160,
      "heapUsedBytes": 93339972,
      "domNodes": 0,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 968.2480000000002,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3060.92799999999,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.673,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1926.0979999999997,
      "heapDeltaBytes": 25215024,
      "heapUsedBytes": 93456216,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 952.1129999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2006.104999999991,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.5709999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 567.8740000000001,
      "heapDeltaBytes": 22104816,
      "heapUsedBytes": 88673924,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 33.71600000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2042.931000000067,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.899000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 620.389,
      "heapDeltaBytes": 5273100,
      "heapUsedBytes": 83068616,
      "domNodes": -279,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 34.68099999999999,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 584.6090000000004,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.723,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.886,
      "heapDeltaBytes": 14326796,
      "heapUsedBytes": 86699220,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 139.44699999999997,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 578.3870000000206,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.158,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 399.155,
      "heapDeltaBytes": 14642980,
      "heapUsedBytes": 87383000,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 141.214,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.7750000000242,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.898,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 544.518,
      "heapDeltaBytes": -12900460,
      "heapUsedBytes": 60174492,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 11.115,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1997.478000000001,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.932999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.0799999999999,
      "heapDeltaBytes": -10947192,
      "heapUsedBytes": 62154544,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.041,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1759.1800000000148,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 29.764,
      "layouts": 18,
      "layoutDurationMs": 4.939,
      "taskDurationMs": 855.31,
      "heapDeltaBytes": -7683492,
      "heapUsedBytes": 65722272,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 117.181,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1739.571000000069,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.105000000000004,
      "layouts": 18,
      "layoutDurationMs": 4.666,
      "taskDurationMs": 817.8870000000001,
      "heapDeltaBytes": -6909548,
      "heapUsedBytes": 66658100,
      "domNodes": -297,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 111.39799999999998,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.3989999999694,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 33.046,
      "layouts": 16,
      "layoutDurationMs": 15.645,
      "taskDurationMs": 982.1770000000001,
      "heapDeltaBytes": 22173476,
      "heapUsedBytes": 106876572,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 32.773,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 148,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9494.937999999991,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.422000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6400.972,
      "heapDeltaBytes": 8659460,
      "heapUsedBytes": 85666716,
      "domNodes": -283,
      "jsHeapTotalBytes": 2449408,
      "scriptDurationMs": 3055.215,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8989.565000000084,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.712,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6115.58,
      "heapDeltaBytes": 16417716,
      "heapUsedBytes": 93042436,
      "domNodes": -268,
      "jsHeapTotalBytes": -434176,
      "scriptDurationMs": 2856.334,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17744.358999999975,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16976.281,
      "heapDeltaBytes": -62966724,
      "heapUsedBytes": 177062708,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16666624,
      "scriptDurationMs": 372.28099999999995,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17391.075,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16784.114,
      "heapDeltaBytes": -56304600,
      "heapUsedBytes": 182633212,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15106048,
      "scriptDurationMs": 301.118,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21231.854,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 17.330000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20837.29,
      "heapDeltaBytes": -24899968,
      "heapUsedBytes": 187773084,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18096128,
      "scriptDurationMs": 895.327,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 60,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21006.767999999967,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 18.428999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20707.207000000002,
      "heapDeltaBytes": -58887972,
      "heapUsedBytes": 169992252,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19337216,
      "scriptDurationMs": 935.5029999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 203,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6290.871000000038,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.16299999999998,
      "layouts": 20,
      "layoutDurationMs": 21.958000000000006,
      "taskDurationMs": 6159.923999999999,
      "heapDeltaBytes": -28606760,
      "heapUsedBytes": 184666712,
      "domNodes": -8068,
      "jsHeapTotalBytes": 13455360,
      "scriptDurationMs": 113.833,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 384,
      "frameDurationMs": 18.89333333333331,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6364.826999999991,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.235,
      "layouts": 20,
      "layoutDurationMs": 24.145,
      "taskDurationMs": 6291.625000000001,
      "heapDeltaBytes": -45256696,
      "heapUsedBytes": 182776580,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10862592,
      "scriptDurationMs": 117.54700000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 594,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8966.451000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8525.670000000002,
      "heapDeltaBytes": 12194216,
      "heapUsedBytes": 177728636,
      "domNodes": 0,
      "jsHeapTotalBytes": -13369344,
      "scriptDurationMs": 144.89300000000006,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8563.175000000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8343.354000000001,
      "heapDeltaBytes": 21103436,
      "heapUsedBytes": 179741228,
      "domNodes": 0,
      "jsHeapTotalBytes": -7077888,
      "scriptDurationMs": 135.88299999999998,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 107.03799999998864,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 18.119,
      "layouts": 3,
      "layoutDurationMs": 1.5610000000000004,
      "taskDurationMs": 78.16800000000002,
      "heapDeltaBytes": 3115880,
      "heapUsedBytes": 72533264,
      "domNodes": 129,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.524000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 146.9889999999623,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 16.280999999999995,
      "layouts": 2,
      "layoutDurationMs": 0.6659999999999999,
      "taskDurationMs": 93.67799999999998,
      "heapDeltaBytes": 3014628,
      "heapUsedBytes": 72486368,
      "domNodes": 110,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 4.856000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50781 76062 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.82540% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/workbench/extensions/agent/AgentPanelRoot.vue 95.65% 1 Missing and 1 partial ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #19519   +/-   ##
=============================================
  Coverage              ?   84.00%           
=============================================
  Files                 ?     2120           
  Lines                 ?   126886           
  Branches              ?    32168           
=============================================
  Hits                  ?   106591           
  Misses                ?    20116           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.78% <100.00%> (?)
unit 79.15% <96.82%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/billing/useLegacyBilling.ts 73.26% <100.00%> (ø)
src/platform/telemetry/types.ts 92.59% <ø> (ø)
...tform/workspace/composables/useWorkspaceBilling.ts 95.80% <100.00%> (ø)
...h/extensions/agent/components/agent/AgentPanel.vue 96.99% <100.00%> (ø)
...nsions/agent/components/agent/ConversationView.vue 95.32% <100.00%> (ø)
.../extensions/agent/composables/useAgentDockMount.ts 100.00% <100.00%> (ø)
...h/extensions/agent/stores/agent/agentPanelStore.ts 99.03% <100.00%> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 91.81% <95.65%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne requested review from dante01yoon and removed request for ryan-di September 30, 2026 03:03
@christian-byrne
christian-byrne merged commit d74f9c5 into Comfy-Org:cloud/1.54 Sep 30, 2026
89 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation backport Backporting a PR onto a release candidate cloud/1.54 Backport PRs for cloud 1.54

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants