Repository navigation
FE-3088 fix(billing): no second 3DS challenge in the app for a payment billing-web is taking - #19514
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughFor reattached pending subscriptions, the store now skips challenge handling and hosted-action opening. A test verifies that no challenge is driven, no payment page opens, and the action URL remains available. ChangesSubscription reattachment challenge handling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Reattached checkouts leave the challenge to billing-web while the app continues to receive operation updates. No material merge risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR uses bug-fix language: the title and a commit subject include
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 20a48754023ea407c410da01f609fbeff9cbecf1
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 10 MB gzip 🟢 -1.2 kBDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 133 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 643 kB (baseline 643 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 4 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 4.07 MB (baseline 4.08 MB) • 🟢 -1.8 kBStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 582 kB (baseline 582 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 16 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • 🟢 -2.07 kBBundles that do not match a named category
Status: 82 added / 82 removed / 218 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T01:07:37.729Z",
"gitSha": "f653ab6d7f9b03ee06e8e05b8aa50802e990b651",
"branch": "jaewon/fe-3088-no-second-3ds-for-reattached-subscribe",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.5369999999903,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.878,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.0489999999999,
"heapDeltaBytes": -38900852,
"heapUsedBytes": 59099756,
"domNodes": -228,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 11.737999999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2025.7669999999735,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.402999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.901,
"heapDeltaBytes": -22503076,
"heapUsedBytes": 76333756,
"domNodes": -228,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 11.447,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1754.8080000000255,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.556,
"layouts": 12,
"layoutDurationMs": 4.442,
"taskDurationMs": 740.6839999999999,
"heapDeltaBytes": -1948920,
"heapUsedBytes": 77041956,
"domNodes": -228,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 133.33299999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1761.3569999999754,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.971,
"layouts": 12,
"layoutDurationMs": 3.914,
"taskDurationMs": 743.253,
"heapDeltaBytes": -38580736,
"heapUsedBytes": 60115108,
"domNodes": -228,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 134.896,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.598000000019,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.655999999999999,
"layouts": 6,
"layoutDurationMs": 1.07,
"taskDurationMs": 293.632,
"heapDeltaBytes": 1488816,
"heapUsedBytes": 80500900,
"domNodes": 53,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 12.948,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.5389999999788,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.963,
"layouts": 6,
"layoutDurationMs": 1.1380000000000001,
"taskDurationMs": 308.66700000000003,
"heapDeltaBytes": 1501584,
"heapUsedBytes": 80406596,
"domNodes": 53,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 14.345,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 583.0339999999978,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.8639999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.97099999999995,
"heapDeltaBytes": -1877372,
"heapUsedBytes": 96676700,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 140.11800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 589.8839999999836,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.8909999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.04799999999994,
"heapDeltaBytes": 18020540,
"heapUsedBytes": 97361700,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 146.372,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1068.2500000000346,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 718.5089999999999,
"heapDeltaBytes": 10068336,
"heapUsedBytes": 87576732,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 60.735000000000014,
"eventListeners": 0,
"totalBlockingTimeMs": 434,
"frameDurationMs": 31.37352941176473,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1012.5189999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 676.252,
"heapDeltaBytes": 6104052,
"heapUsedBytes": 82020112,
"domNodes": 0,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 51.524999999999984,
"eventListeners": 0,
"totalBlockingTimeMs": 397,
"frameDurationMs": 30.806060606060615,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 798.2900000000086,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.83700000000033,
"heapDeltaBytes": 13251848,
"heapUsedBytes": 91749468,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 122.12400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 22.854285714285705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 814.9670000000242,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.8909999999998,
"heapDeltaBytes": 15729328,
"heapUsedBytes": 90178260,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 127.18000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 163,
"frameDurationMs": 23.331428571428557,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8312.430000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7356.741999999999,
"heapDeltaBytes": 6246736,
"heapUsedBytes": 79237676,
"domNodes": 0,
"jsHeapTotalBytes": -7340032,
"scriptDurationMs": 5802.076999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 57,
"frameDurationMs": 25.458895705521474,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7745.067000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6835.427000000001,
"heapDeltaBytes": 3839120,
"heapUsedBytes": 84705704,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 5375.733,
"eventListeners": 0,
"totalBlockingTimeMs": 28,
"frameDurationMs": 24.471835443037975,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7911.061999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6982.6179999999995,
"heapDeltaBytes": 2271160,
"heapUsedBytes": 84490080,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 5524.149,
"eventListeners": 0,
"totalBlockingTimeMs": 133,
"frameDurationMs": 24.919873817034702,
"p95FrameDurationMs": 49.900000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7824.076999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6952.543,
"heapDeltaBytes": -9562744,
"heapUsedBytes": 70748340,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 5530.491000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 66,
"frameDurationMs": 24.65741324921136,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2037.637000000018,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6999999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.863,
"heapDeltaBytes": -37319036,
"heapUsedBytes": 82723576,
"domNodes": -228,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 27.236000000000004,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754095,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2045.7079999999905,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1029999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.6099999999999,
"heapDeltaBytes": -36506160,
"heapUsedBytes": 83252976,
"domNodes": -228,
"jsHeapTotalBytes": -98304,
"scriptDurationMs": 35.018,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2104.4160000000147,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.402999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1263.183,
"heapDeltaBytes": 11354328,
"heapUsedBytes": 74142252,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 646.993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66587301587302,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2142.20899999998,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.175999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1393.2390000000003,
"heapDeltaBytes": 19904844,
"heapUsedBytes": 82300796,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 682.6220000000001,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666406249999994,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3312.1189999999956,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.126000000000001,
"layouts": 60,
"layoutDurationMs": 14.152,
"taskDurationMs": 1491.5919999999999,
"heapDeltaBytes": 12570876,
"heapUsedBytes": 76686096,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 668.762,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66616161616162,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3279.2709999999943,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.851,
"layouts": 60,
"layoutDurationMs": 14.007,
"taskDurationMs": 1482.755,
"heapDeltaBytes": 12590032,
"heapUsedBytes": 76711908,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 679.855,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665816326530614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2526.9499999999994,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.516000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1647.3080000000002,
"heapDeltaBytes": 21026156,
"heapUsedBytes": 85241372,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 819.175,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.776666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2494.9119999999994,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.173000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1635.271,
"heapDeltaBytes": 21823040,
"heapUsedBytes": 85428076,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 812.762,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.778378378378378,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.269000000037,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.954999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.811,
"heapDeltaBytes": 21513112,
"heapUsedBytes": 83754392,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.633000000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2019.1209999999273,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6849999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.854,
"heapDeltaBytes": 21032872,
"heapUsedBytes": 83473200,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.072,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.4970000000258,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.5120000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.12399999999997,
"heapDeltaBytes": 12582864,
"heapUsedBytes": 93990776,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 122.58399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.0579999999973,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.469,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.158,
"heapDeltaBytes": 12746656,
"heapUsedBytes": 94426408,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 127.717,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.5719999999915,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.723,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.645,
"heapDeltaBytes": -2271944,
"heapUsedBytes": 79127768,
"domNodes": -244,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.270999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.059000000032,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.610000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.587,
"heapDeltaBytes": -23425768,
"heapUsedBytes": 57453452,
"domNodes": -244,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 10.619,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.6270000000272,
"styleRecalcs": 79,
"styleRecalcDurationMs": 18.631,
"layouts": 16,
"layoutDurationMs": 5.491999999999999,
"taskDurationMs": 690.1279999999999,
"heapDeltaBytes": -17509420,
"heapUsedBytes": 63600560,
"domNodes": -215,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 97.09700000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.2660000000997,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.655,
"layouts": 16,
"layoutDurationMs": 6.170999999999999,
"taskDurationMs": 703.307,
"heapDeltaBytes": -3160800,
"heapUsedBytes": 77942456,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 98.30900000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1301.842000000022,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.831,
"layouts": 5,
"layoutDurationMs": 9.858,
"taskDurationMs": 805.897,
"heapDeltaBytes": 21484836,
"heapUsedBytes": 92516976,
"domNodes": 13667,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 27.320000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 86,
"frameDurationMs": 18.543661971830993,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8214.786000000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.126,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4966.15,
"heapDeltaBytes": -36752124,
"heapUsedBytes": 82675212,
"domNodes": -228,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 2290.812,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666260162601624,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8194.952000000058,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.723,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4993.5019999999995,
"heapDeltaBytes": -40818640,
"heapUsedBytes": 78890484,
"domNodes": -228,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 2271.353,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598778004073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14734.14200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14655.776999999998,
"heapDeltaBytes": 158752,
"heapUsedBytes": 194027236,
"domNodes": -3046,
"jsHeapTotalBytes": 14532608,
"scriptDurationMs": 226.142,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.94471544715447,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 14684.399999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14613.137000000002,
"heapDeltaBytes": -25976140,
"heapUsedBytes": 170240292,
"domNodes": -3045,
"jsHeapTotalBytes": 13742080,
"scriptDurationMs": 225.642,
"eventListeners": -14907,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.483534136546183,
"p95FrameDurationMs": 50.00000000000182
},
{
"name": "vue-large-graph-pan",
"durationMs": 18159.68699999996,
"styleRecalcs": 124,
"styleRecalcDurationMs": 17.783999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18088.368,
"heapDeltaBytes": -19115764,
"heapUsedBytes": 179873180,
"domNodes": 0,
"jsHeapTotalBytes": -42205184,
"scriptDurationMs": 756.853,
"eventListeners": 0,
"totalBlockingTimeMs": 56,
"frameDurationMs": 36.2984,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17811.761000000046,
"styleRecalcs": 123,
"styleRecalcDurationMs": 17.479999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17753.619,
"heapDeltaBytes": 8648344,
"heapUsedBytes": 188551164,
"domNodes": 0,
"jsHeapTotalBytes": -38080512,
"scriptDurationMs": 728.104,
"eventListeners": 0,
"totalBlockingTimeMs": 23,
"frameDurationMs": 35.316071428571426,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5366.997999999967,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.150000000000006,
"layouts": 20,
"layoutDurationMs": 22.781999999999996,
"taskDurationMs": 5345.0779999999995,
"heapDeltaBytes": 4775532,
"heapUsedBytes": 184241484,
"domNodes": -2373,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 92.44200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 246,
"frameDurationMs": 35.775999999999996,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5376.360999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.621999999999986,
"layouts": 20,
"layoutDurationMs": 23.188,
"taskDurationMs": 5336.425,
"heapDeltaBytes": -6107224,
"heapUsedBytes": 199187264,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 96.67999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 236,
"frameDurationMs": 34.96666666666666,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7501.606000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7455.466999999999,
"heapDeltaBytes": -3997416,
"heapUsedBytes": 178849964,
"domNodes": 0,
"jsHeapTotalBytes": -34603008,
"scriptDurationMs": 110.371,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.945816733067733,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7621.233000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7588.072,
"heapDeltaBytes": 12014456,
"heapUsedBytes": 183223900,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 111.78099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.343824701195217,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 461.8210000000431,
"styleRecalcs": 21,
"styleRecalcDurationMs": 16.529000000000003,
"layouts": 4,
"layoutDurationMs": 1.8249999999999997,
"taskDurationMs": 129.38,
"heapDeltaBytes": -14303796,
"heapUsedBytes": 82607104,
"domNodes": 129,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.294,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 104.78699999998753,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.902000000000001,
"layouts": 3,
"layoutDurationMs": 1.516,
"taskDurationMs": 78.492,
"heapDeltaBytes": -16592672,
"heapUsedBytes": 80247980,
"domNodes": 114,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 5.887,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 596.8209999999772,
"styleRecalcs": 78,
"styleRecalcDurationMs": 88.917,
"layouts": 76,
"layoutDurationMs": 19.643,
"taskDurationMs": 564.136,
"heapDeltaBytes": 14862592,
"heapUsedBytes": 81158744,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 205.86599999999999,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 707.56700000004,
"styleRecalcs": 78,
"styleRecalcDurationMs": 95.85499999999999,
"layouts": 76,
"layoutDurationMs": 21.168,
"taskDurationMs": 660.3240000000001,
"heapDeltaBytes": 15685052,
"heapUsedBytes": 82410768,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 249.832,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1205.2499999999782,
"styleRecalcs": 78,
"styleRecalcDurationMs": 250.38700000000003,
"layouts": 76,
"layoutDurationMs": 24.082,
"taskDurationMs": 1185.885,
"heapDeltaBytes": 7592792,
"heapUsedBytes": 114459336,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 358.41499999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666216216216206,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1157.2909999999865,
"styleRecalcs": 78,
"styleRecalcDurationMs": 235.569,
"layouts": 76,
"layoutDurationMs": 23.716,
"taskDurationMs": 1127.878,
"heapDeltaBytes": -20422544,
"heapUsedBytes": 109334272,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 336.51099999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2158 passed, 0 failed · 1 flaky📊 Browser Reports
|
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19514 +/- ##
==========================================
- Coverage 85.14% 85.04% -0.11%
==========================================
Files 2412 2340 -72
Lines 135967 133849 -2118
Branches 34865 34166 -699
==========================================
- Hits 115766 113828 -1938
+ Misses 19729 19656 -73
+ Partials 472 365 -107
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 78 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at exact head 1d517f56f3703d5fa3ed7f0172d0aca3820dc1a5.
The resumed-operation guard correctly leaves an already-running billing-web challenge with the page that initiated it, while preserving normal in-app challenge and hosted-action handling. The focused regression test covers the embedded challenge case, all exact-head checks are settled green, and no review threads remain open.
…ays is already done (Comfy-Org#19678) - Linear: FE-3137 ## Why Found in the Milestone 2 deployed pass (case C7, testcloud → testbilling, Alipay test payments, 4 of 4 runs). The customer authorizes the payment and lands back on `/v1/result` with `redirect_status=succeeded`, and the PaymentIntent is already `succeeded`. The page still shows "Payment declined · Authentication with your bank did not complete · Try again" for about 5–15 s, then switches to "Payment complete". The customer can press Try again on a payment that went through. ## Root cause Until its webhook lands, the server keeps serving the op as `pending` / `awaiting_invoice_payment` with `payment_intent_client_secret`. This was polled live from the result page: 0.2–4.7 s pending, then `succeeded` at 6.0 s. The result page drives that challenge, as it should for one that is really open. Stripe's `handleNextAction` throws `IntegrationError: The PaymentIntent supplied is not in the requires_action state` for an intent that has already moved on (reproduced live on the same intent). `challengeDriver.settle` maps any throw to `failed`, and `paymentProjection` renders `declined` / `authentication_failed`. ## How - `stripeChallengePort.ts`: when `handleNextAction` throws, the port reads the intent with `retrievePaymentIntent` and reports it. - `succeeded` / `processing` → the core settles the challenge as completed, polls on the fast cadence, and lands on the outcome. - An intent still in `requires_payment_method` / `requires_action` → still reported as failed (`UNMOVED_INTENT_STATUSES`). - An unreadable intent → rethrows. - First attempt (17a359d, reverted in c452d5a): `ResultView` with `autoContinue: () => false`. It removed the decline, but live it left the page on "Verify your payment · Continue verification" for 28 s+ (the 30 s parked cadence) after the customer had paid. A Continue click there hit the same throw. - Tests: - Unit: port cases for a settled, an unpaid and an unreadable intent. - E2E (`result.spec.ts`, now on the fake Stripe): the fake rejects `handleNextAction` the way Stripe does and reports the intent `succeeded`. The test expects no "Payment declined" ever rendered (a MutationObserver records it) and "Payment complete" once the server settles. ## Verification - Red: c452d5a (revert + E2E). Billing Web E2E https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36794439448 fails on the new case. Earlier red c33a4cc: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36791169680 - Green: 67a37f6 (port fix). CI link below. - Local: `result.spec.ts` + `checkout.spec.ts` pass; `src/session` unit 62 passed. Without the port fix the new E2E stays on "Payment declined". ## AS IS / TO BE Live, local billing-web against testcloud, Alipay test payment (Stripe test mode), Team monthly. | AS IS (deployed testbilling, before the fix) | TO BE (this PR) | | --- | --- | | <img width="600" alt="asis-declined" src="https://github.com/user-attachments/assets/4254cfd4-3644-4785-b168-e8f75268cfa5" /> | <img width="600" alt="alipay-3-landing" src="https://github.com/user-attachments/assets/0f3bc7d4-cd4a-41bb-88ba-137c00500548" /> <img width="600" alt="alipay-4-complete" src="https://github.com/user-attachments/assets/ee16331e-3eab-4a1a-8c53-cac54a1432e7" /> | AS IS: after Authorize Test Payment the result page showed "Payment declined · Authentication with your bank did not complete" although Stripe had charged (reproduced on 2 of 4 runs). TO BE: sampled every 0.4s after Authorize. 0.4s "Verify your payment", 0.9s to 8.9s waiting for the server, 9.3s "Payment complete". "Payment declined" never appeared. Regression: card 4242 checkout on a fresh workspace reached "You're all set" in 14.5s with no decline. <img width="600" alt="4242-complete" src="https://github.com/user-attachments/assets/52623545-8464-47da-8f23-69972bc9f502" /> E2E: red on the pre-fix code https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36794439448 , green on this head https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36794691732 ## Plan position Milestone 2 follow-up from the deployed pass (C7). Off `main`. ```mermaid graph LR A[M2 deployed pass C7] --> B[FE-3137 a challenge Stripe says is over is read, not failed]:::me C[Comfy-Org#19514 FE-3088 app does not drive a reattached challenge] -.same family.- B classDef me fill:#f9d71c,stroke:Comfy-Org#333,color:#000 ```
… the server settles a payment (Comfy-Org#19784) ## Why Back on `/v1/result` after a redirect payment (Alipay, 3DS return), the customer has already paid, but for the ~8 s the server takes to settle the operation the page reads **"Review payment · Confirm your selection."** The page has nothing to confirm, so the copy asks for an action that does not exist on a payment that already went through. Found while verifying FE-3137 live. - Fixes FE-3155 ## Root cause Until its webhook lands, the server serves the operation as `pending` with no open challenge. `projectPaymentStep` projects that as the `preview` step, which is the host's confirm screen. `ResultView` renders every projection through `CheckoutSteps`, so it shows the preview copy. The result page has no confirm form, so on this page `preview` only ever means "waiting on the server". ## How `ResultView` shows its existing "Checking on your payment…" line (the copy it already uses while recovering) for an operation in the `preview` step, instead of the step card. Every other step (verifying, declined, success, …) still renders through `CheckoutSteps`. The projection in `account-core` is unchanged; the in-app checkout still uses `preview` for its confirm screen. The `ResultView` test that pinned the "Review payment" region for a pending operation now asserts the checking line and the absence of that region. ## Verification - Red: the rewritten `ResultView` test fails on `main`'s view, https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36893202107 - Green: unit https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36893466316 , billing-web E2E https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36893466476 ## AS IS / TO BE Live, local billing-web against testcloud, Alipay test payment (Stripe test mode), Team monthly, one fresh workspace per run. Result page sampled every 0.4 s after Authorize. | AS IS (`main`'s `ResultView`) | TO BE (this PR) | | --- | --- | | <img width="600" alt="asis" src="https://github.com/user-attachments/assets/a30e9206-bd2b-4b60-9d07-f0fe90178e53" /> | <img width="600" alt="tobe" src="https://github.com/user-attachments/assets/d0d2b3c5-cf98-49f7-a85e-5c7946641f6b" /> | AS IS: 0.8 s "Verify your payment", 1.2 s to 9.3 s "Review payment · Confirm your selection.", 9.7 s "Payment complete". TO BE: 0.8 s "Verify your payment", 1.2 s to 5.7 s "Checking on your payment…", 6.1 s "Payment complete". "Review payment" never appears. ## Plan position M2 follow-up from the FE-3137 live verification. Off `main`, billing-web only (deploys from `main`; no release-branch backport). | Ticket | PR | State | | --- | --- | --- | | FE-3088 | Comfy-Org#19514 | merged | | FE-3137 | Comfy-Org#19678 | merged | | **FE-3155** | **this PR** | open | ```mermaid graph LR A[M2 deployed pass C7] --> B[FE-3137 no false decline on /v1/result] B --> C[FE-3155 no Review payment while the server settles]:::me classDef me fill:#f9d71c,stroke:Comfy-Org#333,color:#000 ```
Why
Found in the deployed Milestone 2 pass (testcloud 1.55.14 → testbilling, SDK subscription rail on). A Team monthly → annual upgrade was paid on billing-web with the 3DS test card. The customer completed 3DS on billing-web and the payment succeeded, and then the app tab opened its own Stripe 3DS challenge for the same payment. Cancelling it was harmless (the app then showed "Subscription updated successfully"), but with a real card the bank would ask the customer to verify twice.
Root cause
billingSdkStore.onSubscriptionChangedcallsdriveRequiredChallengefor every pending subscription state, including an operation the store reattached throughrecover(). #19120 (FE-3051) kept a reattached operation from opening the hosted page, but not from driving the in-page challenge. #19129 (FE-3057) now reattaches the operation billing-web started, so both tabs drove the same challenge.The legacy rail never did this:
resumePendingOperationstarts the poller withoutautoHandleRequiresAction, so a resumed operation shows its progress and waits.How
onSubscriptionChangedreturns after the progress toast for a reattached operation. The page that started the payment drives its challenge, the same as on the legacy rail. The progress and settle toasts from FE-3057 feat(billing): show the payment progress in the app while billing-web takes the payment #19129 are unchanged.subscriptionActionUrl.Regression check (3DS flows)
drives the in-page challenge a subscribe raises,opens no payment page while this tab drives the in-page challenge)onTopupChangedunchanged)subscriptionActionUrl, as on the legacy railVerification
drives no in-page challenge for a subscribe it reattached tofails withdriveChallengecalled once.src/platform/workspaceandsrc/composables/billing: 2238 passed.UnifiedPricingTable.test.tsfails identically on plainmainin this checkout (FirebaseExpected a class definition), unrelated.hosted_billing_destination = stripethe in-app upgrade still opened its own challenge (images below).AS IS / TO BE
Stripe test mode, workspace
m2-qa-0929-deploy, saved 3DS card (3184). AS IS is the deployed testcloud 1.55.14 → testbilling pair (Team 42.2K monthly → annual). TO BE is a local build of this branch against testcloud, with billing-web on testbilling (42.2K → 84.4K annual).Regression check (in-app embedded checkout, this branch). The app still drives the challenge for a subscribe it issued:
Plan position
Milestone 2 follow-up from the deployed pass. Off
main, no backport.