Repository navigation
fix: close cloud tag workflow review gaps - #19507
Conversation
christian-byrne
left a comment
There was a problem hiding this comment.
Self-review at c7f96eb1ff: checkout is pinned to the trusted target branch, existing-tag behavior is explicit and containment-checked, diagnostics remain visible outside command substitution, permissions are narrowed, and tests distinguish same-version outcomes. actionlint, ShellCheck, scripts typecheck, Knip, Fallow on changed files, and all 7 executable tests pass.
🎭 Playwright: ✅ 2160 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a02464024fafc20758f6952edf9116562d8f59e8
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@christian-byrne Successfully backported to #19508 |
|
@christian-byrne Successfully backported to #19509 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19507 +/- ##
==========================================
+ Coverage 84.28% 85.03% +0.74%
==========================================
Files 3286 2340 -946
Lines 158347 133798 -24549
Branches 41132 34142 -6990
==========================================
- Hits 133460 113770 -19690
+ Misses 23060 19664 -3396
+ Partials 1827 364 -1463
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #19507 to `cloud/1.54` Automatically created by backport workflow. Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Backport of #19507 to `cloud/1.55` Automatically created by backport workflow. Co-authored-by: Christian Byrne <cbyrne@comfy.org>
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 1 |
| 🟢 Low | 5 |
Panel: 8/8 reviewers contributed findings.
Follow-up to #19492 and its release backports. Pins checkout to the trusted target branch, improves containment and tag diagnostics, preserves SemVer build metadata, narrows token permissions, and strengthens the same-version test assertions.
Validation:
actionlint,shellcheck, and 7 executable tests covering 9 scenarios.