Skip to content

fix: close cloud tag workflow review gaps - #19507

Merged
christian-byrne merged 1 commit into
mainfrom
fix/cloud-tag-postmerge-review
Sep 30, 2026
Merged

christian-byrne merged 1 commit into
mainfrom
fix/cloud-tag-postmerge-review

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Follow-up to #19492 and its release backports. Pins checkout to the trusted target branch, improves containment and tag diagnostics, preserves SemVer build metadata, narrows token permissions, and strengthens the same-version test assertions.

Validation: actionlint, shellcheck, and 7 executable tests covering 9 scenarios.

Addresses post-merge review findings on #19501 and #19502.
@christian-byrne
christian-byrne requested a review from a team September 29, 2026 23:58
@christian-byrne christian-byrne added area:CI/CD area:cloud risk:xhigh PR risk grade (advisory shadow check; grader-owned) greenlight cursor-review Trigger multi-model Cursor agent review on this PR needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch cloud/1.54 Backport PRs for cloud 1.54 cloud/1.55 Backport PRs for cloud 1.55 labels Sep 29, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review at c7f96eb1ff: checkout is pinned to the trusted target branch, existing-tag behavior is explicit and containment-checked, diagnostics remain visible outside command substitution, permissions are narrowed, and tests distinguish same-version outcomes. actionlint, ShellCheck, scripts typecheck, Knip, Fallow on changed files, and all 7 executable tests pass.

@DrJKL
DrJKL self-requested a review September 29, 2026 23:58
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2160 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2139 / ❌ 0 / ⚠️ 0 / ⏭️ 9)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since a02464024fafc20758f6952edf9116562d8f59e8

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 90c3dc19-70d0-431f-90ae-266d4f385a5f

📥 Commits

Reviewing files that changed from the base of the PR and between a024640 and c7f96eb.

📒 Files selected for processing (3)
  • .github/workflows/cloud-backport-tag.yaml
  • scripts/cicd/cloud-backport-tag.sh
  • scripts/cicd/cloud-backport-tag.test.ts
 ______________________________________________________________________________
< Dr. CodeRabbit, or: How I Learned to Stop Worrying and Love the Code Review. >
 ------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@christian-byrne
christian-byrne merged commit 3c8ae40 into main Sep 30, 2026
147 of 149 checks passed
@christian-byrne
christian-byrne deleted the fix/cloud-tag-postmerge-review branch September 30, 2026 00:00
@comfy-pr-bot

Copy link
Copy Markdown
Member

@christian-byrne Successfully backported to #19508

@comfy-pr-bot

Copy link
Copy Markdown
Member

@christian-byrne Successfully backported to #19509

@comfy-pr-bot comfy-pr-bot removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Sep 30, 2026
@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #19507      +/-   ##
==========================================
+ Coverage   84.28%   85.03%   +0.74%     
==========================================
  Files        3286     2340     -946     
  Lines      158347   133798   -24549     
  Branches    41132    34142    -6990     
==========================================
- Hits       133460   113770   -19690     
+ Misses      23060    19664    -3396     
+ Partials     1827      364    -1463     
Flag Coverage Δ
billing-web-unit ?
unit 81.47% <ø> (ø)
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 946 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

comfy-pr-bot added a commit that referenced this pull request Sep 30, 2026
Backport of #19507 to `cloud/1.54`

Automatically created by backport workflow.

Co-authored-by: Christian Byrne <cbyrne@comfy.org>
comfy-pr-bot added a commit that referenced this pull request Sep 30, 2026
Backport of #19507 to `cloud/1.55`

Automatically created by backport workflow.

Co-authored-by: Christian Byrne <cbyrne@comfy.org>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 8 finding(s).

Severity Count
🟠 High 2
🟡 Medium 1
🟢 Low 5

Panel: 8/8 reviewers contributed findings.

Comment thread scripts/cicd/cloud-backport-tag.sh Resolved
Comment thread scripts/cicd/cloud-backport-tag.sh Resolved
Comment thread scripts/cicd/cloud-backport-tag.sh Resolved
Comment thread scripts/cicd/cloud-backport-tag.sh Resolved
Comment thread scripts/cicd/cloud-backport-tag.sh Resolved
Comment thread scripts/cicd/cloud-backport-tag.test.ts Resolved
@comfy-pr-bot comfy-pr-bot added the released:cloud PR has been released to cloud label Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CI/CD area:cloud cloud/1.54 Backport PRs for cloud 1.54 cloud/1.55 Backport PRs for cloud 1.55 cursor-review Trigger multi-model Cursor agent review on this PR greenlight released:cloud PR has been released to cloud risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants