Repository navigation
[backport core/1.54] feat(agent): emit app:agent_error telemetry (TEL-8) (#16628) - #19495
Conversation
Implements the required V1 telemetry event `app:agent_error` per `reports/telemetry/v1-checklist.md` in the `in-app-agent-program` workspace (row `TEL-8`): "FE surfaces an agent failure to the user, including pre-acceptance request failures not represented by `agent_turn_failed`." Follows the `app:agent_reconnect_failed` precedent (TEL-11, #16397) for the telemetry plumbing shape. - `AgentErrorMetadata` in `src/platform/telemetry/types.ts`: `error_class` (`request_failed | malformed_stream_event | cancel_failed | history_load_failed | ask_answer_failed | thread_list_load_failed | workflow_open_failed`), `failure_stage` (`pre_acceptance | post_acceptance`), `retryable`, `turn_accepted`, `ui_treatment` (`inline_notice | error_overlay | toast | none`). - `trackAgentError` wired through `TelemetryRegistry` and `PostHogTelemetryProvider`. - Call sites at every FE-visible agent failure not already covered by the backend's `agent_turn_failed`: - `sendMessage()`: a rejected `postMessage` (`request_failed`), `inline_notice` via `recordFailedSend`. - `stopTurn()`: a failed `cancelMessage` (`cancel_failed`), post-acceptance, `error_overlay`. A 409 already-settled race is not tracked - it is not a failure. - `answerAsk()`: a failed ask answer (`ask_answer_failed`), post-acceptance - the turn hangs on an unresolved ask. The 409 collapse path is not tracked. - `onRaw()`: any frame failing `parseAgentWsEvent` (`malformed_stream_event`), deduped per turn. - `hydrateFromServer()`: a non-404 transcript load failure (`history_load_failed`). The 404 thread-not-found branch is not tracked. - `AgentPanelRoot.vue`: a failed agent-driven tab open (`workflow_open_failed`) and a failed thread-list load (`thread_list_load_failed`), both `error_overlay`. `turn_accepted` and `retryable` default from `failure_stage` and are overridable, because the stage only approximates them: a resume-path history load is a request the server never accepted issued while an accepted turn streams on, and a failed cancel is post-acceptance yet safe to resend. `retryable` is derived from the response status via `isRetryableRequestFailure()` for every request-shaped class, so the column means one thing across rows. **Not counted:** a busy-state double-submit. It is a normal interaction rather than a failure, and it is frequent enough to dominate the other classes and make the rate unalertable. Admission errors (`no_funds` paywall) also emit nothing - they return early from the send catch and have their own UI. `AgentRestClient.request()` now reads the response body in its own `try` past `response.ok` and raises `AgentResponseUnreadableError`. A truncated or proxy-mangled 2xx therefore classifies as post-acceptance and non-retryable, the same as a `ZodError` - both mean the server started the turn and the FE lost the ack. ``` $ pnpm typecheck (clean) $ pnpm lint 0 errors (225 pre-existing warnings, none in changed files) $ pnpm format:check All matched files use the correct format. $ pnpm knip (clean) $ pnpm vitest run src/platform/telemetry src/workbench/extensions/agent Test Files 114 passed (114) Tests 1629 passed (1629) ``` Every added or changed test was proven red by mutating the fix it covers, then green on restore. Follow-up filed from review: #17358 (a `localStorage` failure after the ack hides a turn the server already started - pre-existing). Trace: MTG-29, mtg-29.2 emitted-vs-required diff (`in-app-agent-program` TEL-8). <!-- authored-by:agent lane-TEL-8 -->
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1959 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T01:50:16.420Z",
"gitSha": "b25d9b3ac0eecd67b5d0e5699523fc787ed310bf",
"branch": "backport-16628-to-core-1.54-manual",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.0629999999696,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.6450000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.421,
"heapDeltaBytes": 5700148,
"heapUsedBytes": 79364112,
"domNodes": 20,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 10.507000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2018.8289999999824,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.4670000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.746,
"heapDeltaBytes": 6102104,
"heapUsedBytes": 77053484,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.637000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.843000000018,
"styleRecalcs": 75,
"styleRecalcDurationMs": 30.406000000000002,
"layouts": 14,
"layoutDurationMs": 4.764,
"taskDurationMs": 850.6389999999999,
"heapDeltaBytes": 3783244,
"heapUsedBytes": 73890212,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 147.79,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.4740000000666,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.471999999999998,
"layouts": 14,
"layoutDurationMs": 3.1830000000000003,
"taskDurationMs": 630.996,
"heapDeltaBytes": -8011016,
"heapUsedBytes": 62444568,
"domNodes": -282,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 104.44999999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1668.092999999999,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.216999999999997,
"layouts": 6,
"layoutDurationMs": 1.206,
"taskDurationMs": 278.182,
"heapDeltaBytes": 4341452,
"heapUsedBytes": 74476764,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.047,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1656.9869999999582,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.258999999999999,
"layouts": 6,
"layoutDurationMs": 1.0479999999999998,
"taskDurationMs": 278.91700000000003,
"heapDeltaBytes": 4349504,
"heapUsedBytes": 75043696,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.068,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 542.761999999982,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.128,
"heapDeltaBytes": -8144956,
"heapUsedBytes": 63081888,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 120.87900000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 521.9059999999445,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.165,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 317.056,
"heapDeltaBytes": 18399256,
"heapUsedBytes": 88741304,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 105.982,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2006.2510000000202,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.866999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.375,
"heapDeltaBytes": 5350460,
"heapUsedBytes": 81399504,
"domNodes": -276,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 34.263000000000005,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2012.1070000000145,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.767999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.247,
"heapDeltaBytes": 10680056,
"heapUsedBytes": 87020960,
"domNodes": -270,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 26.503999999999994,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2132.1829999999977,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.885,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1326.3039999999999,
"heapDeltaBytes": -8091680,
"heapUsedBytes": 69190744,
"domNodes": -276,
"jsHeapTotalBytes": 684032,
"scriptDurationMs": 602.0550000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2145.584000000099,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.363,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1259.844,
"heapDeltaBytes": 7392792,
"heapUsedBytes": 84549196,
"domNodes": -268,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 574.723,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3191.4179999999988,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.441,
"layouts": 60,
"layoutDurationMs": 13.911000000000001,
"taskDurationMs": 1426.6809999999998,
"heapDeltaBytes": -2172196,
"heapUsedBytes": 76164776,
"domNodes": -272,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 599.9140000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3191.041999999925,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.433999999999997,
"layouts": 60,
"layoutDurationMs": 13.430000000000001,
"taskDurationMs": 1357.377,
"heapDeltaBytes": -3049516,
"heapUsedBytes": 75843428,
"domNodes": -280,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 565.1440000000001,
"eventListeners": -158,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2362.746999999956,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.583999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1571.3970000000002,
"heapDeltaBytes": 14706908,
"heapUsedBytes": 82115756,
"domNodes": -273,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 745.0300000000001,
"eventListeners": 18,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2483.0780000000914,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.593999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1479.077,
"heapDeltaBytes": 21630592,
"heapUsedBytes": 102495108,
"domNodes": 8,
"jsHeapTotalBytes": 4874240,
"scriptDurationMs": 704.2570000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.4389999999826,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.2540000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.91800000000006,
"heapDeltaBytes": 10537384,
"heapUsedBytes": 87799776,
"domNodes": -268,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 28.823999999999995,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2020.5949999999575,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.157999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.03700000000003,
"heapDeltaBytes": 7436848,
"heapUsedBytes": 87732560,
"domNodes": -264,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 22.114999999999995,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 492.71199999998316,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.0889999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.98199999999997,
"heapDeltaBytes": 14781872,
"heapUsedBytes": 88085192,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 97.463,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 556.3149999999268,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.325000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.624,
"heapDeltaBytes": 15104288,
"heapUsedBytes": 88634864,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 103.699,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2001.9870000000424,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.036999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.292,
"heapDeltaBytes": 810088,
"heapUsedBytes": 66483992,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.528,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2002.5009999999384,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.890999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.435,
"heapDeltaBytes": 7589808,
"heapUsedBytes": 80983588,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.334999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.0789999999743,
"styleRecalcs": 77,
"styleRecalcDurationMs": 22.648,
"layouts": 18,
"layoutDurationMs": 4.382000000000001,
"taskDurationMs": 694.554,
"heapDeltaBytes": 5858320,
"heapUsedBytes": 78433240,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 90.66000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.605000000005,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.147,
"layouts": 18,
"layoutDurationMs": 3.9159999999999995,
"taskDurationMs": 634.8119999999999,
"heapDeltaBytes": -3803980,
"heapUsedBytes": 69175404,
"domNodes": -265,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 77.637,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 882.722000000058,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.375000000000007,
"layouts": 16,
"layoutDurationMs": 10.497000000000002,
"taskDurationMs": 653.089,
"heapDeltaBytes": 21304396,
"heapUsedBytes": 109864932,
"domNodes": 13831,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 21.443000000000005,
"eventListeners": 2385,
"totalBlockingTimeMs": 97,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8164.094000000034,
"styleRecalcs": 250,
"styleRecalcDurationMs": 46.318,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4746.371,
"heapDeltaBytes": -5861720,
"heapUsedBytes": 70611540,
"domNodes": -246,
"jsHeapTotalBytes": 4878336,
"scriptDurationMs": 2157.383,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8145.858999999973,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.407000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4118.232,
"heapDeltaBytes": 9993688,
"heapUsedBytes": 85483592,
"domNodes": -266,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 1830.203,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11939.930000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11083.660000000002,
"heapDeltaBytes": -35749788,
"heapUsedBytes": 177264824,
"domNodes": -8068,
"jsHeapTotalBytes": -22982656,
"scriptDurationMs": 203.37500000000003,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10318.14200000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9406.654,
"heapDeltaBytes": -38796220,
"heapUsedBytes": 179151116,
"domNodes": -8068,
"jsHeapTotalBytes": -13627392,
"scriptDurationMs": 128.85800000000003,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14591.63099999995,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.422000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14072.592,
"heapDeltaBytes": -37999716,
"heapUsedBytes": 180963712,
"domNodes": -8068,
"jsHeapTotalBytes": -11284480,
"scriptDurationMs": 701.209,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.226666666666762,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13374.122999999941,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.492000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12839.907,
"heapDeltaBytes": -34387620,
"heapUsedBytes": 186067100,
"domNodes": -8068,
"jsHeapTotalBytes": -14348288,
"scriptDurationMs": 646.01,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4365.4290000000055,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.89300000000003,
"layouts": 20,
"layoutDurationMs": 24.632,
"taskDurationMs": 4250.157,
"heapDeltaBytes": -42383892,
"heapUsedBytes": 186096008,
"domNodes": -8068,
"jsHeapTotalBytes": 14196736,
"scriptDurationMs": 73.44700000000002,
"eventListeners": -14931,
"totalBlockingTimeMs": 79,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 3609.08900000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.512,
"layouts": 20,
"layoutDurationMs": 19.060000000000006,
"taskDurationMs": 3453.9539999999997,
"heapDeltaBytes": -46356436,
"heapUsedBytes": 187456072,
"domNodes": -8068,
"jsHeapTotalBytes": 16596992,
"scriptDurationMs": 54.548,
"eventListeners": -14935,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6160.901999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5710.12,
"heapDeltaBytes": 9946808,
"heapUsedBytes": 181690872,
"domNodes": 0,
"jsHeapTotalBytes": -27000832,
"scriptDurationMs": 85.54500000000004,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5555.777000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5111.758999999999,
"heapDeltaBytes": 2892916,
"heapUsedBytes": 181150880,
"domNodes": 0,
"jsHeapTotalBytes": -20185088,
"scriptDurationMs": 68.69399999999997,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 473.4879999999748,
"styleRecalcs": 22,
"styleRecalcDurationMs": 21.371000000000002,
"layouts": 6,
"layoutDurationMs": 2.036,
"taskDurationMs": 110.683,
"heapDeltaBytes": 5115652,
"heapUsedBytes": 74128732,
"domNodes": 155,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.516,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 472.2940000000335,
"styleRecalcs": 15,
"styleRecalcDurationMs": 27.483,
"layouts": 4,
"layoutDurationMs": 1.4680000000000002,
"taskDurationMs": 103.09000000000002,
"heapDeltaBytes": 4761832,
"heapUsedBytes": 73665368,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.969000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
…kport-16628-to-core-1.54-manual # Conflicts: # src/workbench/extensions/agent/AgentPanelRoot.vue
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 3 |
| 🟢 Low | 4 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.54 #19495 +/- ##
==========================================
Coverage 83.92% 83.92%
==========================================
Files 2110 2110
Lines 126055 126137 +82
Branches 33852 33875 +23
==========================================
+ Hits 105787 105863 +76
- Misses 20089 20095 +6
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 10 prior finding(s) across 1 round(s) (10 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 7 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:
src/platform/telemetry/providers/host/HostTelemetrySink.ts:374— 🟡 Medium — Unanswered from Round 1, and this round makes the omission starker: the sink gainedtrackAgentConsentShown,trackAgentConsentResolved,trackAgentOnboardingShown,trackAgentOnboardingStep,trackAgentStarterPromptClickedandtrackAgentConsentOfferExited, yettrackAgentError— added toTelemetryProvider,TelemetryRegistryandPostHogTelemetryProviderin this same PR — is still absent here. SincetrackAgentErroris optional on the provider and the registry dispatches it via?., everyapp:agent_errorevent is silently dropped wherever the desktop host sink is the provider, with no type error and no test coverage (the unit tests mock@/platform/telemetrywholesale).Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
src/workbench/extensions/agent/composables/agent/useAgentConsent.ts:166— 🟡 Medium —reportOutcomeruns beforecloseWith'ssettledguard, so a programmaticcloseDialog({ key: 'agent-consent' })duringawait consentStore.accept(...)(navigation, workspace switch) reportsdismissedfromonCloseand thenacceptedhere — twoagent_consent_resolvedevents for oneagent_consent_shown, breaking the 1:1 invariant the surrounding doc comments rely on. The same race also makescloseWith(saved)a no-op, so consent is durably stored whilewithConsentresolves false and the panel silently never opens. Guard the post-await path withif (settled) return, mirroringhandleSaveFailure.Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).
src/workbench/extensions/agent/AgentPanelRoot.vue:615— 🟡 Medium —pendingSendis a single unkeyed slot, but theprepare()that consumes it can outlive its own send:sendMessageracesprepare()againstPREPARE_TIMEOUT_MS(3s) and proceeds on timeout, leaving a stragglingrefreshCloudWorkflowIds()running. If that orphan resolves after a second send has installed its own entry, it consumes send B's metadata and reports it with whatever id is resolved at that instant — before B's own refresh lands, i.e. exactly the prematureworkflow_idthis deferral exists to prevent — and B's ownfinallythen no-ops. Tag the pending entry with the send it belongs to (e.g.client_message_id) and havereportPendingSendonly consume a matching one.Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).
src/platform/telemetry/types.ts:628— 🟡 Medium —AgentConsentOfferExitdeclares 14 values across 4AgentConsentOfferStages, but the only production emitter added by this PR isreportRequestExitinuseAgentConsent.ts, which hardcodesstage: 'request'and can produce just 5 of them. Nothing emits theload,startuporofferstages —extensions/core/agentPanel.tsis untouched apart from passing the newtriggerargument — sosigned_out,account_unresolved,workspace_unresolved,workspace_switching,consent_unresolved,consent_already_accepted,offer_in_flight,card_already_seen,already_offeredandstartup_probe_failedare unreachable. Every emittable value falls in the doc's "owed and not made" bucket and none in "correctly not needed", so the documentedsplit by exitquery reads as 100% loss over a partial denominator.Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
browser_tests/tests/agent/agentDuplicateInsertOpaqueWidgetWrite.spec.ts:491— 🟡 Medium — Thistest.fail()locks a silent write-loss in as expected behaviour: the assertions in the test just above prove that when the doc host rejects aset_widgetop the widget keeps showing the human's typed value whilehost.projection()still holds the original, with no toast and norole="alert". Keeping CI green over a data-integrity divergence on a normal editing path is worse than a failing test — surface the rejection (a toast or a per-widget error state) rather than encoding its absence as the expectation.Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max edge-case).
src/workbench/extensions/agent/stores/agent/agentComposerStore.ts:140— 🟢 Low — This reset only fires whenpromptOriginis'suggestion', so an'edited'origin (set byreplacePromptwhen a previous message is reopened through the conversation edit action) survives the user clearing the composer completely:applyEditorPromptwith empty text and no references leaves it'edited', and the next message typed from scratch is reported asinput_method: 'edited'. Drop thepromptOrigin.value === 'suggestion'condition so any non-'typed'origin resets once its text and references are gone.Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
Addresses review feedback:\nhttps://github.com//pull/19495#discussion_r4139478733\nhttps://github.com//pull/19495#discussion_r4139478736\nhttps://github.com//pull/19495#discussion_r4139478739\nhttps://github.com//pull/19495#discussion_r4139478742\nhttps://github.com//pull/19495#discussion_r4139478744\nhttps://github.com//pull/19495#discussion_r4139478747\nhttps://github.com//pull/19495#discussion_r4139478750\nhttps://github.com//pull/19495#discussion_r4139478754\nhttps://github.com//pull/19495#discussion_r4139478760
This comment has been minimized.
This comment has been minimized.
Corrects review feedback after the full coverage job proved these tests require fake timers:\nhttps://github.com//pull/19495#discussion_r4139478760
…o-core-1.54-manual
… installation failures (#18083) (#19543) Manual backport of #18083 onto `core/1.54`. Resolved against the current branch after #19495 landed. Kept the release branch’s Manager progress-panel refactor while preserving #18083’s task failure, queue retry, and version-choice behavior. Validation: `oxfmt --check` passed. Focused unit-test run was started using the identical `core/1.54` lockfile dependency set; it became blocked in uninterruptible filesystem I/O before producing results, so CI remains the authoritative validation. --------- Co-authored-by: Dr.Lt.Data <128333288+ltdrdata@users.noreply.github.com>
Backports #16628 to core/1.54 after the automated backport conflicted.
This preserves failed prompts for retry and records bounded agent error telemetry across transport, workflow, and session failures. The conflict resolution keeps the release branch agent implementation and layers the new telemetry contract onto it.
Validation: