Skip to content

[backport cloud/1.54] feat(agent): emit app:agent_error telemetry (TEL-8) (#16628) - #19486

Merged
christian-byrne merged 5 commits into
cloud/1.54from
backport-16628-to-cloud-1.54-manual
Sep 30, 2026
Merged

christian-byrne merged 5 commits into
cloud/1.54from
backport-16628-to-cloud-1.54-manual

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports #16628 to cloud/1.54 after the automated backport conflicted.

This preserves failed prompts for retry and records bounded agent error telemetry across transport, workflow, and session failures. The release-specific conflict resolution keeps the existing cloud/1.54 thread storage and browser harness APIs.

Validation:

  • pnpm typecheck:app
  • pnpm typecheck:browser
  • focused Vitest suite: 595 passed, 2 expected failures
  • pre-push Knip check

Implements the required V1 telemetry event `app:agent_error` per
`reports/telemetry/v1-checklist.md` in the `in-app-agent-program`
workspace (row `TEL-8`): "FE surfaces an agent failure to the user,
including pre-acceptance request failures not represented by
`agent_turn_failed`."

Follows the `app:agent_reconnect_failed` precedent (TEL-11, #16397) for
the telemetry plumbing shape.

- `AgentErrorMetadata` in `src/platform/telemetry/types.ts`:
`error_class` (`request_failed | malformed_stream_event | cancel_failed
| history_load_failed | ask_answer_failed | thread_list_load_failed |
workflow_open_failed`), `failure_stage` (`pre_acceptance |
post_acceptance`), `retryable`, `turn_accepted`, `ui_treatment`
(`inline_notice | error_overlay | toast | none`).
- `trackAgentError` wired through `TelemetryRegistry` and
`PostHogTelemetryProvider`.
- Call sites at every FE-visible agent failure not already covered by
the backend's `agent_turn_failed`:
- `sendMessage()`: a rejected `postMessage` (`request_failed`),
`inline_notice` via `recordFailedSend`.
- `stopTurn()`: a failed `cancelMessage` (`cancel_failed`),
post-acceptance, `error_overlay`. A 409 already-settled race is not
tracked - it is not a failure.
- `answerAsk()`: a failed ask answer (`ask_answer_failed`),
post-acceptance - the turn hangs on an unresolved ask. The 409 collapse
path is not tracked.
- `onRaw()`: any frame failing `parseAgentWsEvent`
(`malformed_stream_event`), deduped per turn.
- `hydrateFromServer()`: a non-404 transcript load failure
(`history_load_failed`). The 404 thread-not-found branch is not tracked.
- `AgentPanelRoot.vue`: a failed agent-driven tab open
(`workflow_open_failed`) and a failed thread-list load
(`thread_list_load_failed`), both `error_overlay`.

`turn_accepted` and `retryable` default from `failure_stage` and are
overridable, because the stage only approximates them: a resume-path
history load is a request the server never accepted issued while an
accepted turn streams on, and a failed cancel is post-acceptance yet
safe to resend. `retryable` is derived from the response status via
`isRetryableRequestFailure()` for every request-shaped class, so the
column means one thing across rows.

**Not counted:** a busy-state double-submit. It is a normal interaction
rather than a failure, and it is frequent enough to dominate the other
classes and make the rate unalertable. Admission errors (`no_funds`
paywall) also emit nothing - they return early from the send catch and
have their own UI.

`AgentRestClient.request()` now reads the response body in its own `try`
past `response.ok` and raises `AgentResponseUnreadableError`. A
truncated or proxy-mangled 2xx therefore classifies as post-acceptance
and non-retryable, the same as a `ZodError` - both mean the server
started the turn and the FE lost the ack.

```
$ pnpm typecheck
(clean)

$ pnpm lint
0 errors (225 pre-existing warnings, none in changed files)

$ pnpm format:check
All matched files use the correct format.

$ pnpm knip
(clean)

$ pnpm vitest run src/platform/telemetry src/workbench/extensions/agent
Test Files  114 passed (114)
Tests  1629 passed (1629)
```

Every added or changed test was proven red by mutating the fix it
covers, then green on restore.

Follow-up filed from review: #17358 (a `localStorage` failure after the
ack hides a turn the server already started - pre-existing).

Trace: MTG-29, mtg-29.2 emitted-vs-required diff (`in-app-agent-program`
TEL-8).

<!-- authored-by:agent lane-TEL-8 -->
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Sep 29, 2026
@christian-byrne christian-byrne self-assigned this Sep 29, 2026
@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 30, 2026 12:26am UTC
billing-web-test Ignored Ignored Sep 30, 2026 12:26am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 88550b13-cd62-455e-8abb-2c1e5245e632

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot requested a review from ryan-di September 29, 2026 22:57
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/30/2026, 12:28:53 AM UTC

Links

🎭 Playwright: ✅ 1960 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1939 / ❌ 0 / ⚠️ 2 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 149ms TBT · 79.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.5 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 43ms TBT · 178.6 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 391ms TBT · 167.9 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 489ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 63.4 MB
canvas-idle: DOM nodes -130
canvas-idle: event listeners -94
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 33ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 976ms
canvas-mouse-sweep: script duration 178ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 64.9 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -195
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 351ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.2 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 463ms
dom-widget-clipping: script duration 166ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.9 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 560ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.4 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1698ms
large-graph-pan: script duration 831ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 69.7 MB
large-graph-pan: DOM nodes -280
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 9ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1666ms
large-graph-zoom: script duration 761ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.8 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1914ms
legacy-node-drag: script duration 949ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 87.5 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 596ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.5 MB
minimap-idle: DOM nodes -271
minimap-idle: event listeners -194
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 404ms
subgraph-dom-widget-clipping: script duration 141ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.1 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 480ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 71.0 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 27ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 813ms
subgraph-mouse-sweep: script duration 111ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 66.6 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -227
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 738ms
subgraph-transition-enter: script duration 26ms
subgraph-transition-enter: TBT 149ms
subgraph-transition-enter: heap used 79.9 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5729ms
viewport-pan-sweep: script duration 2650ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 64.2 MB
viewport-pan-sweep: DOM nodes -276
viewport-pan-sweep: event listeners -152
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16602ms
vue-large-graph-idle: script duration 317ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.5 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14929
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 175
vue-large-graph-pan: task duration 20998ms
vue-large-graph-pan: script duration 915ms
vue-large-graph-pan: TBT 43ms
vue-large-graph-pan: heap used 178.6 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 84ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6095ms
vue-node-resize-workload: script duration 118ms
vue-node-resize-workload: TBT 391ms
vue-node-resize-workload: heap used 167.9 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8292ms
vue-zoom-out-idle: script duration 134ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 2
workflow-execution: style recalc count 8
workflow-execution: task duration 73ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.7 MB
workflow-execution: DOM nodes 129
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-09-30T00:41:29.351Z",
  "gitSha": "01f791777dd2cc1e14b9459f5e9f2b77a318133d",
  "branch": "backport-16628-to-cloud-1.54-manual",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2053.586999999993,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.355999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.48799999999994,
      "heapDeltaBytes": 1660060,
      "heapUsedBytes": 71669004,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 9.27,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.7349999999742,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.744000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.70300000000003,
      "heapDeltaBytes": -9250524,
      "heapUsedBytes": 61345040,
      "domNodes": -278,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.027999999999999,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2117.402000000027,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 35.534,
      "layouts": 14,
      "layoutDurationMs": 4.105,
      "taskDurationMs": 1058.9489999999998,
      "heapDeltaBytes": -1553832,
      "heapUsedBytes": 68948964,
      "domNodes": -281,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 196.06099999999998,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1874.1790000000265,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 30.104,
      "layouts": 14,
      "layoutDurationMs": 3.8240000000000003,
      "taskDurationMs": 892.7900000000001,
      "heapDeltaBytes": -4113968,
      "heapUsedBytes": 67248052,
      "domNodes": -283,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 160.732,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.5689999999977,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 15.848,
      "layouts": 6,
      "layoutDurationMs": 1.0879999999999999,
      "taskDurationMs": 350.80999999999995,
      "heapDeltaBytes": 4312132,
      "heapUsedBytes": 74557920,
      "domNodes": 75,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 9.638,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1662.7579999999398,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.826999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.0829999999999997,
      "taskDurationMs": 351.89400000000006,
      "heapDeltaBytes": 4579352,
      "heapUsedBytes": 74776144,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.724,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 647.9039999999827,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.687999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 453.223,
      "heapDeltaBytes": -7865664,
      "heapUsedBytes": 63165156,
      "domNodes": 20,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 163.93500000000003,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 693.7950000000228,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.100999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.13000000000005,
      "heapDeltaBytes": -6553448,
      "heapUsedBytes": 64572284,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 167.363,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2033.8370000000054,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.382000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 571.751,
      "heapDeltaBytes": 10939632,
      "heapUsedBytes": 87259156,
      "domNodes": -271,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 35.659,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2009.36200000001,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.9909999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 547.769,
      "heapDeltaBytes": 22262312,
      "heapUsedBytes": 87671212,
      "domNodes": -276,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 36.959999999999994,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2211.026000000004,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.777000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1681.7820000000002,
      "heapDeltaBytes": -9155948,
      "heapUsedBytes": 67954704,
      "domNodes": -278,
      "jsHeapTotalBytes": 684032,
      "scriptDurationMs": 832.357,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2381.5450000000737,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.199999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1713.6290000000001,
      "heapDeltaBytes": 623092,
      "heapUsedBytes": 78252556,
      "domNodes": -282,
      "jsHeapTotalBytes": 909312,
      "scriptDurationMs": 830.163,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3531.227000000001,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.406999999999998,
      "layouts": 60,
      "layoutDurationMs": 11.792,
      "taskDurationMs": 1670.8949999999998,
      "heapDeltaBytes": 8372100,
      "heapUsedBytes": 76512272,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 763.507,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3454.1189999999915,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.431,
      "layouts": 60,
      "layoutDurationMs": 11.69,
      "taskDurationMs": 1661.533,
      "heapDeltaBytes": 8070996,
      "heapUsedBytes": 76238508,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 757.695,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3040.723000000014,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.77,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1899.27,
      "heapDeltaBytes": 22346836,
      "heapUsedBytes": 90801976,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 948.9979999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3044.319000000087,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.693,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1929.5849999999998,
      "heapDeltaBytes": 22638600,
      "heapUsedBytes": 92697372,
      "domNodes": 0,
      "jsHeapTotalBytes": 2252800,
      "scriptDurationMs": 949.4300000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2042.4510000000282,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.307999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 608.8969999999999,
      "heapDeltaBytes": 5063608,
      "heapUsedBytes": 83261424,
      "domNodes": -272,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 30.020999999999994,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.9660000000968,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.3020000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 584.071,
      "heapDeltaBytes": 10355132,
      "heapUsedBytes": 87672840,
      "domNodes": -270,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 31.735,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 578.2130000000052,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.669999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 404.27299999999997,
      "heapDeltaBytes": 14799684,
      "heapUsedBytes": 88263992,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 139.72899999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 577.1419999999807,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.050999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 404.4070000000001,
      "heapDeltaBytes": 14930060,
      "heapUsedBytes": 88043592,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 141.399,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.4930000000109,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.675000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.935,
      "heapDeltaBytes": 4887356,
      "heapUsedBytes": 78490344,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.256000000000002,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.200999999986,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.011999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.015,
      "heapDeltaBytes": -2330864,
      "heapUsedBytes": 70481336,
      "domNodes": -295,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.989000000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1738.328000000024,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 27.412999999999997,
      "layouts": 18,
      "layoutDurationMs": 5.683000000000001,
      "taskDurationMs": 816.9,
      "heapDeltaBytes": -7279412,
      "heapUsedBytes": 65398088,
      "domNodes": -295,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 109.64100000000002,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1722.0379999999977,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 26.708,
      "layouts": 18,
      "layoutDurationMs": 4.396000000000001,
      "taskDurationMs": 809.2470000000001,
      "heapDeltaBytes": 920424,
      "heapUsedBytes": 74231668,
      "domNodes": -295,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 111.479,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 965.9189999999853,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 31.878000000000004,
      "layouts": 16,
      "layoutDurationMs": 15.935,
      "taskDurationMs": 737.8960000000001,
      "heapDeltaBytes": -6928020,
      "heapUsedBytes": 83733620,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 26.470999999999993,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 149,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8338.851000000033,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 35.747,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5737.762999999999,
      "heapDeltaBytes": -20561448,
      "heapUsedBytes": 67405896,
      "domNodes": -279,
      "jsHeapTotalBytes": 5316608,
      "scriptDurationMs": 2660.961,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8415.916000000037,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 34.075,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5720.656,
      "heapDeltaBytes": -8740228,
      "heapUsedBytes": 67224736,
      "domNodes": -272,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 2638.1130000000003,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16776.095999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16075.665,
      "heapDeltaBytes": -44588036,
      "heapUsedBytes": 178240768,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12398592,
      "scriptDurationMs": 305.924,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17995.053999999982,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17128.718,
      "heapDeltaBytes": -54375712,
      "heapUsedBytes": 177212024,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12099584,
      "scriptDurationMs": 327.99500000000006,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20870.010999999977,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 18.467999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20520.471999999998,
      "heapDeltaBytes": -28499436,
      "heapUsedBytes": 190078848,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9752576,
      "scriptDurationMs": 903.265,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 10,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21862.293000000023,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 18.106999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21475.43,
      "heapDeltaBytes": -33726776,
      "heapUsedBytes": 184384344,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10612736,
      "scriptDurationMs": 927.017,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 75,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6138.687000000004,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 87.52100000000002,
      "layouts": 20,
      "layoutDurationMs": 22.43600000000001,
      "taskDurationMs": 6023.249,
      "heapDeltaBytes": -64991696,
      "heapUsedBytes": 174956380,
      "domNodes": -8068,
      "jsHeapTotalBytes": 1634304,
      "scriptDurationMs": 132.70100000000002,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 348,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6308.246000000054,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.905,
      "layouts": 20,
      "layoutDurationMs": 22.106000000000016,
      "taskDurationMs": 6166.486,
      "heapDeltaBytes": -41458544,
      "heapUsedBytes": 177172048,
      "domNodes": -8068,
      "jsHeapTotalBytes": 4415488,
      "scriptDurationMs": 102.97200000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 433,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8416.267000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8113.757000000001,
      "heapDeltaBytes": 7854468,
      "heapUsedBytes": 180065308,
      "domNodes": 0,
      "jsHeapTotalBytes": -17301504,
      "scriptDurationMs": 123.263,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8810.044999999946,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8470.962000000001,
      "heapDeltaBytes": 986924,
      "heapUsedBytes": 178850616,
      "domNodes": 0,
      "jsHeapTotalBytes": -20447232,
      "scriptDurationMs": 144.27500000000003,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 112.18600000000833,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.443,
      "layouts": 2,
      "layoutDurationMs": 1.4379999999999997,
      "taskDurationMs": 78.233,
      "heapDeltaBytes": 3025192,
      "heapUsedBytes": 71638236,
      "domNodes": 131,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.5600000000000005,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 96.67799999999716,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.472999999999997,
      "layouts": 2,
      "layoutDurationMs": 1.3760000000000001,
      "taskDurationMs": 68.57600000000001,
      "heapDeltaBytes": 2999696,
      "heapUsedBytes": 72409380,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.822000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@christian-byrne
christian-byrne removed the request for review from ryan-di September 29, 2026 23:01
@github-actions
github-actions Bot requested a review from ryan-di September 29, 2026 23:01
@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 29, 2026
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.07843% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/telemetry/TelemetryRegistry.ts 0.00% 2 Missing ⚠️
...emetry/providers/cloud/PostHogTelemetryProvider.ts 0.00% 2 Missing ⚠️
...ensions/agent/composables/agent/useAgentSession.ts 97.67% 2 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #19486   +/-   ##
=============================================
  Coverage              ?   83.95%           
=============================================
  Files                 ?     2120           
  Lines                 ?   126919           
  Branches              ?    32164           
=============================================
  Hits                  ?   106553           
  Misses                ?    20188           
  Partials              ?      178           
Flag Coverage Δ
unit 79.14% <96.07%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/telemetry/types.ts 87.09% <ø> (ø)
...platform/workflow/core/services/workflowService.ts 96.99% <ø> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 91.66% <100.00%> (ø)
...extensions/agent/services/agent/agentRestClient.ts 99.36% <100.00%> (ø)
...sions/agent/stores/agent/agentConversationStore.ts 98.49% <100.00%> (ø)
src/platform/telemetry/TelemetryRegistry.ts 48.00% <0.00%> (ø)
...emetry/providers/cloud/PostHogTelemetryProvider.ts 72.98% <0.00%> (ø)
...ensions/agent/composables/agent/useAgentSession.ts 98.93% <97.67%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 1
🟡 Medium 3
🟢 Low 5
⚪ Nit 1

Panel: 7/8 reviewers contributed findings.

Reviewers that did not contribute: gpt-5.6-sol-max:edge-case (error)

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 30, 2026
@christian-byrne
christian-byrne merged commit c552892 into cloud/1.54 Sep 30, 2026
95 checks passed
@christian-byrne
christian-byrne deleted the backport-16628-to-cloud-1.54-manual branch September 30, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants