Repository navigation
[backport cloud/1.55] FE-3056 fix(billing-web): re-quote a stale subscribe quote the way the app does - #19482
Conversation
…e app does (#19126) - Linear: FE-3056 When the server refuses a subscribe because the quote went stale, the embedded checkout re-quotes and tells the customer "Your quote changed. Review the updated amount and try again." billing-web instead shows "We couldn't reach the billing service. Please try again." and keeps the old quote, so every retry is refused the same way. Seen live on testcloud with a Team monthly → annual change (`POST /api/billing/subscribe` → 400 `SUBSCRIPTION_QUOTE_STALE`). `issueSubscribe` in `packages/account-core/src/core/billing/subscriptionCommands.ts` maps only `REACTIVATION_CONFIRMATION_REQUIRED`; any other coded 4xx reaches the host as a generic failure. `CheckoutView.pay` in billing-web has no branch for a stale quote, so the failure copy is the transport one. The app's legacy rail handles the code in `useSubscriptionCheckout.recoverStaleQuote`. - account-core: `SUBSCRIPTION_QUOTE_STALE` becomes the command code `QUOTE_STALE`, the same way the reactivation code is mapped. - billing-web: on `QUOTE_STALE`, re-quote the plan and show the app's copy ("Your quote changed. Review the updated amount and try again."); if the re-quote itself fails, show the app's "quote refresh failed" copy. - Tests: an account-core case for the mapping and a CheckoutView case for the re-quote and copy. Both fail before the fix. - Red: the two new tests fail locally on edd1324 (the CI run for that commit was cancelled by the fix push); green: CI on 2ca20d8. The stale quotes themselves come from the server (non-deterministic `renewal_at` on preview for a monthly → annual change); that was reported to backend separately. **AS IS:** billing-web monthly → annual shows "We couldn't reach the billing service" (server 400 `SUBSCRIPTION_QUOTE_STALE`); the same change in the embedded checkout then goes through. https://github.com/user-attachments/assets/b31ba7c9-0db0-4a84-a329-804ed28dac4f **TO BE:** Unit and view tests (CheckoutView re-quotes and shows "Your quote changed. Review the updated amount and try again."). The stale quote is intermittent server-side, so a live TO BE capture is pending the backend fix. | PR | Title | |---|---| | #19097 | FE-3045 drop the billing-web plan grid | | #19098 | FE-3046 A buttonVariants into design-system | | #19099 | FE-3046 B account-ui checkout surfaces | | #19100 | FE-3046 C app renders account-ui checkout | | #19101 | FE-3046 D billing-web shared checkout | | #19104 | FE-3046 E invite from the success step | | #19105 | FE-3047 F clear decline toasts on success | | #19106 | FE-3048 G return closes the tab | | #19115 | FE-3050 H CTA reachable | | **this PR** | **FE-3056 I stale quote re-quoted** | ```mermaid graph LR P97[#19097] --> A[#19098] --> B[#19099] --> C[#19100] --> D[#19101] --> E[#19104] --> F[#19105] --> G[#19106] --> H[#19115] --> I[FE-3056]:::me classDef me fill:#f9d71c,stroke:#333,color:#000 ``` --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit e352169)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 2123 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 61d527cd399d086ae07fe77cbb540941be0bdfd1
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T22:34:52.506Z",
"gitSha": "a508c529a02268fac3a5112e2f9e35ad7368c0ea",
"branch": "backport-19126-to-cloud/1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1999.2239999999128,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.754999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.286,
"heapDeltaBytes": -3502440,
"heapUsedBytes": 64246740,
"domNodes": -258,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.156999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 1999.4630000001052,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.86,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.13899999999995,
"heapDeltaBytes": 8655072,
"heapUsedBytes": 76344232,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1756.9859999999835,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.611999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 713.505,
"heapDeltaBytes": -7376640,
"heapUsedBytes": 60676920,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 163.329,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1718.4889999998632,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.354,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 718.099,
"heapDeltaBytes": -6526732,
"heapUsedBytes": 61335784,
"domNodes": -257,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 169.64600000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.9690000000846,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.508,
"layouts": 6,
"layoutDurationMs": 0.97,
"taskDurationMs": 329.045,
"heapDeltaBytes": 3077668,
"heapUsedBytes": 70805220,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.477,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.6519999999782,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.782999999999998,
"layouts": 6,
"layoutDurationMs": 1.218,
"taskDurationMs": 335.06199999999995,
"heapDeltaBytes": 2814632,
"heapUsedBytes": 70658884,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.112,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 647.3280000000159,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.649,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.77299999999997,
"heapDeltaBytes": 18653072,
"heapUsedBytes": 86541952,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 165.77599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 648.9540000000034,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.561000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.399,
"heapDeltaBytes": 18922604,
"heapUsedBytes": 86445468,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 168.00600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1224.9899999999343,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 880.8960000000001,
"heapDeltaBytes": 11610768,
"heapUsedBytes": 101852680,
"domNodes": -290,
"jsHeapTotalBytes": 22433792,
"scriptDurationMs": 72.67499999999998,
"eventListeners": -195,
"totalBlockingTimeMs": 594,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1184.2959999999039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 789.8030000000001,
"heapDeltaBytes": 38057060,
"heapUsedBytes": 107374612,
"domNodes": 0,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 70.85699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 569,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.2820000001111,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.63999999999936,
"heapDeltaBytes": 14754244,
"heapUsedBytes": 90886460,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.3,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.6430000001328,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.67799999999994,
"heapDeltaBytes": 15668640,
"heapUsedBytes": 91112244,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.62699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10474.174999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9538.548,
"heapDeltaBytes": 17765528,
"heapUsedBytes": 99614780,
"domNodes": -18,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 8177.845999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1547,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10439.544999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9621.393999999998,
"heapDeltaBytes": 10421572,
"heapUsedBytes": 92838128,
"domNodes": -16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7934.8009999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 1129,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10604.957000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9753.004,
"heapDeltaBytes": 17850560,
"heapUsedBytes": 93424100,
"domNodes": -6,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8071.282,
"eventListeners": 0,
"totalBlockingTimeMs": 1074,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10272.253000000092,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9409.402,
"heapDeltaBytes": -12092868,
"heapUsedBytes": 69510500,
"domNodes": -10,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7770.8279999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 1058,
"frameDurationMs": 18.883333333333333,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2057.5359999999137,
"styleRecalcs": 10,
"styleRecalcDurationMs": 13.733000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.0209999999999,
"heapDeltaBytes": -9843136,
"heapUsedBytes": 77522216,
"domNodes": -250,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 33.86700000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.3059999999678,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.052,
"heapDeltaBytes": -3365788,
"heapUsedBytes": 83597284,
"domNodes": -240,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.207,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2278.1309999999166,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.748000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1698.1940000000002,
"heapDeltaBytes": 20227720,
"heapUsedBytes": 84535164,
"domNodes": -246,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 869.695,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2227.6359999998476,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.860000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1612.981,
"heapDeltaBytes": 15734712,
"heapUsedBytes": 80074580,
"domNodes": -248,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 854.922,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3569.1779999999653,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.812,
"layouts": 60,
"layoutDurationMs": 13.206,
"taskDurationMs": 1757.0339999999999,
"heapDeltaBytes": -24235400,
"heapUsedBytes": 65332952,
"domNodes": -266,
"jsHeapTotalBytes": 5795840,
"scriptDurationMs": 800.636,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3522.491999999829,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.066000000000004,
"layouts": 60,
"layoutDurationMs": 13.027000000000001,
"taskDurationMs": 1702.81,
"heapDeltaBytes": -15114912,
"heapUsedBytes": 74122592,
"domNodes": -256,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 774.028,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3184.9280000000135,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.489,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1990.7880000000002,
"heapDeltaBytes": -2921528,
"heapUsedBytes": 88179112,
"domNodes": -227,
"jsHeapTotalBytes": 2805760,
"scriptDurationMs": 1019.6400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3031.721999999945,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.349999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1933.4080000000001,
"heapDeltaBytes": 25541184,
"heapUsedBytes": 91700036,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 987.3360000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2028.2889999999725,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.046999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.9799999999999,
"heapDeltaBytes": -4939780,
"heapUsedBytes": 84080132,
"domNodes": -246,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 37.924,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.6060000000198,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.204999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.091,
"heapDeltaBytes": -4892008,
"heapUsedBytes": 83890448,
"domNodes": -246,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 36.358000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.0100000000002,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.97,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.381,
"heapDeltaBytes": 13791224,
"heapUsedBytes": 83667596,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 146.024,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.230000000005,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.956000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.913,
"heapDeltaBytes": 14089908,
"heapUsedBytes": 83665672,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 146.65800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.4749999999567,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.319000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.827,
"heapDeltaBytes": 8318512,
"heapUsedBytes": 78219024,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.432000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.7700000001114,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.669,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.87199999999996,
"heapDeltaBytes": 9553360,
"heapUsedBytes": 79432708,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.41,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.2389999999687,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.482,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 734.986,
"heapDeltaBytes": 2344960,
"heapUsedBytes": 72491828,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 103.896,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.8439999999937,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.106,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 741.618,
"heapDeltaBytes": -5239096,
"heapUsedBytes": 64655180,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 105.631,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 916.580999999951,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.199,
"layouts": 5,
"layoutDurationMs": 13.046000000000003,
"taskDurationMs": 704.5980000000001,
"heapDeltaBytes": -6220600,
"heapUsedBytes": 81565372,
"domNodes": 13667,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 26.569000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8369.371000000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.823,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5761.313999999999,
"heapDeltaBytes": -5086224,
"heapUsedBytes": 81955888,
"domNodes": -216,
"jsHeapTotalBytes": 3104768,
"scriptDurationMs": 2782.8340000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8363.213000000087,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5801.9800000000005,
"heapDeltaBytes": -6036996,
"heapUsedBytes": 80509300,
"domNodes": -241,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2830.973,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16832.858999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16340.871,
"heapDeltaBytes": -41344612,
"heapUsedBytes": 193269296,
"domNodes": -8065,
"jsHeapTotalBytes": -5779456,
"scriptDurationMs": 258.75100000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16995.33500000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16570.854,
"heapDeltaBytes": -75624464,
"heapUsedBytes": 171245400,
"domNodes": -8061,
"jsHeapTotalBytes": -16908288,
"scriptDurationMs": 267.38399999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20577.269999999997,
"styleRecalcs": 160,
"styleRecalcDurationMs": 16.887000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20410.747,
"heapDeltaBytes": -67137920,
"heapUsedBytes": 167294840,
"domNodes": -8069,
"jsHeapTotalBytes": -12070912,
"scriptDurationMs": 887.955,
"eventListeners": -14928,
"totalBlockingTimeMs": 35,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20624.83199999997,
"styleRecalcs": 170,
"styleRecalcDurationMs": 16.99199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20282.471999999998,
"heapDeltaBytes": -29196244,
"heapUsedBytes": 191888232,
"domNodes": -8061,
"jsHeapTotalBytes": -11616256,
"scriptDurationMs": 869.18,
"eventListeners": -14928,
"totalBlockingTimeMs": 17,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6314.592999999945,
"styleRecalcs": 20,
"styleRecalcDurationMs": 89.01200000000001,
"layouts": 20,
"layoutDurationMs": 31.292000000000016,
"taskDurationMs": 6176.557,
"heapDeltaBytes": -44747804,
"heapUsedBytes": 176877280,
"domNodes": -8061,
"jsHeapTotalBytes": 11988992,
"scriptDurationMs": 131.36700000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 581,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6188.4000000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.10800000000002,
"layouts": 20,
"layoutDurationMs": 23.976,
"taskDurationMs": 6056.869999999999,
"heapDeltaBytes": -51116184,
"heapUsedBytes": 175850004,
"domNodes": -8061,
"jsHeapTotalBytes": 12779520,
"scriptDurationMs": 109.433,
"eventListeners": -14928,
"totalBlockingTimeMs": 480,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8577.08700000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8319.546999999999,
"heapDeltaBytes": -20750516,
"heapUsedBytes": 165369064,
"domNodes": 0,
"jsHeapTotalBytes": -33292288,
"scriptDurationMs": 130.643,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8677.077999999938,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8394.808,
"heapDeltaBytes": -156448,
"heapUsedBytes": 184144292,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 146.501,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 475.16300000006595,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.276999999999997,
"layouts": 5,
"layoutDurationMs": 2.492,
"taskDurationMs": 144.937,
"heapDeltaBytes": 5164776,
"heapUsedBytes": 70738860,
"domNodes": 151,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 14.63,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 443.11900000002424,
"styleRecalcs": 12,
"styleRecalcDurationMs": 22.776000000000003,
"layouts": 3,
"layoutDurationMs": 0.9349999999999999,
"taskDurationMs": 109.044,
"heapDeltaBytes": 4903852,
"heapUsedBytes": 70935428,
"domNodes": 119,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.815000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19482 +/- ##
=============================================
Coverage ? 83.74%
=============================================
Files ? 3056
Lines ? 150546
Branches ? 40780
=============================================
Hits ? 126075
Misses ? 23098
Partials ? 1373
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
🔗 Commit SHA: 03f803e | Docs | View more details | Give us feedback! |
Why
When the server refuses a subscribe because the quote went stale (400
SUBSCRIPTION_QUOTE_STALE), billing-web shows "We couldn't reach the billing service" and keeps the old quote, so every retry is refused the same way. The embedded checkout already re-quotes.Root cause
issueSubscribeinpackages/account-core/src/core/billing/subscriptionCommands.tsdid not map the stale-quote code, andCheckoutView.payhad no branch for it.How
The SDK maps a 4xx
SUBSCRIPTION_QUOTE_STALEtoQUOTE_STALE.CheckoutView.payclearsquoteIsCurrent, re-quotes, and shows "Your quote changed" or "couldn't be refreshed" copy.AS IS / TO BE
Same as #19126, which carries the AS IS description and the TO BE test evidence. This backport does not change behavior relative to main.
Backport of #19126 to
cloud/1.55. Cherry-picked with-xfrom e352169.Conflicts
One file,
apps/billing-web/src/views/CheckoutView.vue, two hunks. Both took the #19126 side.useHostedCopy()destructure: 1.55 had{ refusal }(FE-2642, backported in [backport cloud/1.55] FE-2642 show server refusal reason (#19185) #19304). FE-3056 fix(billing-web): re-quote a stale subscribe quote the way the app does #19126 needscodedback for the stale-quote copy, so it is{ coded, refusal }.pay(): 1.55 ends withsubmitFailure.value = refusal(result). TheQUOTE_STALEbranch (clearquoteIsCurrent, re-quote, show "Your quote changed" or "couldn't be refreshed") is inserted before it, as on main.The FE-2642 parts of the squash (
useHostedCopy.refusal, its call sites in the panels andInvoicesView, and the "shows the reason the server gave for a refused quote" test) were already oncloud/1.55and applied as no-ops. The SDK mapping insubscriptionCommands.ts(refusedWithfor a 4xxSUBSCRIPTION_QUOTE_STALE,refusedWhilePendingotherwise), the two locale strings, and the new tests applied cleanly.Verification
pnpm typecheck(all five stages) passes.QUOTE_STALE/ 503 →REQUEST_FAILEDtable.