Repository navigation
[backport core/1.55] FE-3056 fix(billing-web): re-quote a stale subscribe quote the way the app does - #19481
Conversation
…e app does (#19126) - Linear: FE-3056 When the server refuses a subscribe because the quote went stale, the embedded checkout re-quotes and tells the customer "Your quote changed. Review the updated amount and try again." billing-web instead shows "We couldn't reach the billing service. Please try again." and keeps the old quote, so every retry is refused the same way. Seen live on testcloud with a Team monthly → annual change (`POST /api/billing/subscribe` → 400 `SUBSCRIPTION_QUOTE_STALE`). `issueSubscribe` in `packages/account-core/src/core/billing/subscriptionCommands.ts` maps only `REACTIVATION_CONFIRMATION_REQUIRED`; any other coded 4xx reaches the host as a generic failure. `CheckoutView.pay` in billing-web has no branch for a stale quote, so the failure copy is the transport one. The app's legacy rail handles the code in `useSubscriptionCheckout.recoverStaleQuote`. - account-core: `SUBSCRIPTION_QUOTE_STALE` becomes the command code `QUOTE_STALE`, the same way the reactivation code is mapped. - billing-web: on `QUOTE_STALE`, re-quote the plan and show the app's copy ("Your quote changed. Review the updated amount and try again."); if the re-quote itself fails, show the app's "quote refresh failed" copy. - Tests: an account-core case for the mapping and a CheckoutView case for the re-quote and copy. Both fail before the fix. - Red: the two new tests fail locally on edd1324 (the CI run for that commit was cancelled by the fix push); green: CI on 2ca20d8. The stale quotes themselves come from the server (non-deterministic `renewal_at` on preview for a monthly → annual change); that was reported to backend separately. **AS IS:** billing-web monthly → annual shows "We couldn't reach the billing service" (server 400 `SUBSCRIPTION_QUOTE_STALE`); the same change in the embedded checkout then goes through. https://github.com/user-attachments/assets/b31ba7c9-0db0-4a84-a329-804ed28dac4f **TO BE:** Unit and view tests (CheckoutView re-quotes and shows "Your quote changed. Review the updated amount and try again."). The stale quote is intermittent server-side, so a live TO BE capture is pending the backend fix. | PR | Title | |---|---| | #19097 | FE-3045 drop the billing-web plan grid | | #19098 | FE-3046 A buttonVariants into design-system | | #19099 | FE-3046 B account-ui checkout surfaces | | #19100 | FE-3046 C app renders account-ui checkout | | #19101 | FE-3046 D billing-web shared checkout | | #19104 | FE-3046 E invite from the success step | | #19105 | FE-3047 F clear decline toasts on success | | #19106 | FE-3048 G return closes the tab | | #19115 | FE-3050 H CTA reachable | | **this PR** | **FE-3056 I stale quote re-quoted** | ```mermaid graph LR P97[#19097] --> A[#19098] --> B[#19099] --> C[#19100] --> D[#19101] --> E[#19104] --> F[#19105] --> G[#19106] --> H[#19115] --> I[FE-3056]:::me classDef me fill:#f9d71c,stroke:#333,color:#000 ``` --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit e352169)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2125 passed, 0 failed📊 Browser Reports
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8037227acb594e7d39ad587fefe5aa4dfc909d2b
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T22:33:24.958Z",
"gitSha": "507ed9975284bd86aaa7a00ee17c7fef0c8f347b",
"branch": "backport-19126-to-core/1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.566999999985,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.162,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.661,
"heapDeltaBytes": -8685716,
"heapUsedBytes": 59265236,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.133999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2017.7829999998949,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.926,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.74899999999997,
"heapDeltaBytes": 9897884,
"heapUsedBytes": 72431660,
"domNodes": -264,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.633,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1734.9350000000072,
"styleRecalcs": 44,
"styleRecalcDurationMs": 13.934,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 807.357,
"heapDeltaBytes": 11585192,
"heapUsedBytes": 79202588,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 163.42299999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1732.6900000000478,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.684,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 796.946,
"heapDeltaBytes": -5376152,
"heapUsedBytes": 62343352,
"domNodes": -261,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 161.146,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.7609999999913,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.339,
"layouts": 6,
"layoutDurationMs": 1.0219999999999998,
"taskDurationMs": 329.60299999999995,
"heapDeltaBytes": 3139192,
"heapUsedBytes": 70826284,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.035,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.9669999999787,
"styleRecalcs": 33,
"styleRecalcDurationMs": 15.562999999999999,
"layouts": 6,
"layoutDurationMs": 1.186,
"taskDurationMs": 332.975,
"heapDeltaBytes": 3138896,
"heapUsedBytes": 70647736,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.043999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 630.3509999999619,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.575,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.8540000000001,
"heapDeltaBytes": 19026216,
"heapUsedBytes": 86584956,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 181.57399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 631.0709999999062,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.45,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.706,
"heapDeltaBytes": 18869892,
"heapUsedBytes": 86196912,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 162.12400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1182.3029999999903,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 794.461,
"heapDeltaBytes": 13585344,
"heapUsedBytes": 103882472,
"domNodes": -262,
"jsHeapTotalBytes": 19812352,
"scriptDurationMs": 66.65800000000002,
"eventListeners": -195,
"totalBlockingTimeMs": 545,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1238.6919999999009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 897.5640000000001,
"heapDeltaBytes": 12952100,
"heapUsedBytes": 103024556,
"domNodes": -277,
"jsHeapTotalBytes": 22958080,
"scriptDurationMs": 70.668,
"eventListeners": -195,
"totalBlockingTimeMs": 611,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.3609999999644,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.2409999999995,
"heapDeltaBytes": 14300008,
"heapUsedBytes": 90874856,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.022,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.5920000000106,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.4600000000003,
"heapDeltaBytes": 14977496,
"heapUsedBytes": 91445316,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.29899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10391.73999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9476.887999999999,
"heapDeltaBytes": -10513108,
"heapUsedBytes": 71992856,
"domNodes": -16,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 7759.236,
"eventListeners": 0,
"totalBlockingTimeMs": 1085,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9927.701999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9048.086000000001,
"heapDeltaBytes": -1995360,
"heapUsedBytes": 79915320,
"domNodes": -16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7447.587,
"eventListeners": 0,
"totalBlockingTimeMs": 879,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11329.891999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10452.21,
"heapDeltaBytes": -3576312,
"heapUsedBytes": 73023932,
"domNodes": -273,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8727.181,
"eventListeners": -174,
"totalBlockingTimeMs": 1647,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10312.389000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9426.7,
"heapDeltaBytes": -27488,
"heapUsedBytes": 82164872,
"domNodes": -14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7794.094,
"eventListeners": 0,
"totalBlockingTimeMs": 986,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2050.397999999973,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.973000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.3230000000001,
"heapDeltaBytes": -3865492,
"heapUsedBytes": 83079980,
"domNodes": -238,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 41.615,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.348000000061,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.407999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.3739999999999,
"heapDeltaBytes": -3644688,
"heapUsedBytes": 83656724,
"domNodes": -241,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.799000000000007,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2236.165000000028,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.090000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1646.344,
"heapDeltaBytes": -7408476,
"heapUsedBytes": 80351936,
"domNodes": -246,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 845.1550000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2232.7099999999973,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.234000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1488.543,
"heapDeltaBytes": -7703788,
"heapUsedBytes": 80340492,
"domNodes": -245,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 858.3329999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3547.792999999956,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.962000000000003,
"layouts": 60,
"layoutDurationMs": 12.711999999999998,
"taskDurationMs": 1544.7989999999998,
"heapDeltaBytes": 8264552,
"heapUsedBytes": 74612584,
"domNodes": 6,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 798.838,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3486.5760000000137,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.868000000000004,
"layouts": 60,
"layoutDurationMs": 12.653,
"taskDurationMs": 1597.0129999999997,
"heapDeltaBytes": -15324536,
"heapUsedBytes": 74087248,
"domNodes": -258,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 800.2479999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3203.8049999999885,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.838000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2026.3029999999999,
"heapDeltaBytes": -1214272,
"heapUsedBytes": 89847112,
"domNodes": -254,
"jsHeapTotalBytes": 1232896,
"scriptDurationMs": 1034.8050000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3185.3720000000294,
"styleRecalcs": 45,
"styleRecalcDurationMs": 12.366999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1999.117,
"heapDeltaBytes": -3280672,
"heapUsedBytes": 87679644,
"domNodes": -255,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 1011.9639999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.2679999999918,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.214000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.858,
"heapDeltaBytes": -4490884,
"heapUsedBytes": 84223232,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.033000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2035.759999999982,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.831999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.011,
"heapDeltaBytes": -5456628,
"heapUsedBytes": 83603596,
"domNodes": -246,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 33.016000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.4250000000056,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.882,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.24799999999993,
"heapDeltaBytes": 14051576,
"heapUsedBytes": 83023120,
"domNodes": 23,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 150.162,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.2450000000563,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.851,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.171,
"heapDeltaBytes": 13136912,
"heapUsedBytes": 77102456,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 146.904,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.1839999999902,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.755000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.59499999999997,
"heapDeltaBytes": -14428028,
"heapUsedBytes": 55287296,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.155000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.3379999999615,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.577,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.0540000000001,
"heapDeltaBytes": -14643780,
"heapUsedBytes": 55259432,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.835000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.3740000000203,
"styleRecalcs": 44,
"styleRecalcDurationMs": 13.179,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 737.8389999999999,
"heapDeltaBytes": 8841024,
"heapUsedBytes": 78597100,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 105.712,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.1780000000044,
"styleRecalcs": 47,
"styleRecalcDurationMs": 17.398,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 756.9300000000001,
"heapDeltaBytes": -10023824,
"heapUsedBytes": 59329640,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 106.83000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.5159999999623,
"styleRecalcs": 15,
"styleRecalcDurationMs": 29.563999999999993,
"layouts": 5,
"layoutDurationMs": 13.167000000000002,
"taskDurationMs": 886.4620000000001,
"heapDeltaBytes": -6401876,
"heapUsedBytes": 84140532,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 28.979000000000006,
"eventListeners": 2383,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8430.446999999958,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.568000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5857.897,
"heapDeltaBytes": -10888284,
"heapUsedBytes": 76141328,
"domNodes": -244,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 2830.902,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8272.921999999995,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.54,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5137.973000000001,
"heapDeltaBytes": -18088216,
"heapUsedBytes": 68396468,
"domNodes": -244,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 2744.8379999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17350.279000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16856.212999999996,
"heapDeltaBytes": -70166852,
"heapUsedBytes": 171119176,
"domNodes": -8061,
"jsHeapTotalBytes": -18288640,
"scriptDurationMs": 281.5609999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16936.22000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16541.285000000003,
"heapDeltaBytes": -60678488,
"heapUsedBytes": 165165428,
"domNodes": -8090,
"jsHeapTotalBytes": -14426112,
"scriptDurationMs": 254.56099999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20573.761999999988,
"styleRecalcs": 162,
"styleRecalcDurationMs": 16.584000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20223.705,
"heapDeltaBytes": -45978908,
"heapUsedBytes": 180962840,
"domNodes": -8061,
"jsHeapTotalBytes": -17891328,
"scriptDurationMs": 887.011,
"eventListeners": -14928,
"totalBlockingTimeMs": 68,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20889.36000000001,
"styleRecalcs": 160,
"styleRecalcDurationMs": 17.672999999999966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20649.635,
"heapDeltaBytes": -62217800,
"heapUsedBytes": 167307816,
"domNodes": -8061,
"jsHeapTotalBytes": -20680704,
"scriptDurationMs": 913.6790000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 119,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4820.550000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.401,
"layouts": 20,
"layoutDurationMs": 24.725000000000012,
"taskDurationMs": 4743.462,
"heapDeltaBytes": -49999824,
"heapUsedBytes": 186901076,
"domNodes": -8062,
"jsHeapTotalBytes": 21385216,
"scriptDurationMs": 96.38399999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 130,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5934.8549999999705,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.31400000000002,
"layouts": 20,
"layoutDurationMs": 22.335999999999995,
"taskDurationMs": 5841.0650000000005,
"heapDeltaBytes": 6070084,
"heapUsedBytes": 181762276,
"domNodes": -8061,
"jsHeapTotalBytes": 17825792,
"scriptDurationMs": 105.344,
"eventListeners": -14928,
"totalBlockingTimeMs": 384,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8611.030000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8402.219000000001,
"heapDeltaBytes": 3232784,
"heapUsedBytes": 178509984,
"domNodes": 0,
"jsHeapTotalBytes": -29884416,
"scriptDurationMs": 141.042,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8457.961999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8293.443,
"heapDeltaBytes": 2865512,
"heapUsedBytes": 183861388,
"domNodes": 0,
"jsHeapTotalBytes": -28049408,
"scriptDurationMs": 133.74099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 111.83999999991556,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.965,
"layouts": 3,
"layoutDurationMs": 1.669,
"taskDurationMs": 89.013,
"heapDeltaBytes": 3099508,
"heapUsedBytes": 68751520,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.848999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 447.9469999999992,
"styleRecalcs": 12,
"styleRecalcDurationMs": 18.804000000000002,
"layouts": 3,
"layoutDurationMs": 0.8419999999999999,
"taskDurationMs": 103.125,
"heapDeltaBytes": 4782108,
"heapUsedBytes": 70528532,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.569999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #19481 +/- ##
=============================================
- Coverage 84.68% 83.74% -0.94%
=============================================
Files 2323 3056 +733
Lines 132603 150437 +17834
Branches 35460 40459 +4999
=============================================
+ Hits 112292 125987 +13695
- Misses 19951 23077 +3126
- Partials 360 1373 +1013
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 738 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport fidelity matches merged frontend PR 19126, including the package surface; exact-head CI is settled green and no review threads remain.
Why
When the server refuses a subscribe because the quote went stale (400
SUBSCRIPTION_QUOTE_STALE), billing-web shows "We couldn't reach the billing service" and keeps the old quote, so every retry is refused the same way. The embedded checkout already re-quotes.Root cause
issueSubscribeinpackages/account-core/src/core/billing/subscriptionCommands.tsdid not map the stale-quote code, andCheckoutView.payhad no branch for it.How
The SDK maps a 4xx
SUBSCRIPTION_QUOTE_STALEtoQUOTE_STALE.CheckoutView.payclearsquoteIsCurrent, re-quotes, and shows "Your quote changed" or "couldn't be refreshed" copy.AS IS / TO BE
Same as #19126, which carries the AS IS description and the TO BE test evidence. This backport does not change behavior relative to main.
Backport of #19126 to
core/1.55. Cherry-picked with-xfrom e352169.Conflicts
One file,
apps/billing-web/src/views/CheckoutView.vue, two hunks. Both took the #19126 side.useHostedCopy()destructure: 1.55 had{ refusal }(FE-2642, backported in [backport core/1.55] FE-2642 show server refusal reason (#19185) #19305). FE-3056 fix(billing-web): re-quote a stale subscribe quote the way the app does #19126 needscodedback for the stale-quote copy, so it is{ coded, refusal }.pay(): 1.55 ends withsubmitFailure.value = refusal(result). TheQUOTE_STALEbranch (clearquoteIsCurrent, re-quote, show "Your quote changed" or "couldn't be refreshed") is inserted before it, as on main.The FE-2642 parts of the squash (
useHostedCopy.refusal, its call sites in the panels andInvoicesView, and the "shows the reason the server gave for a refused quote" test) were already oncore/1.55and applied as no-ops. The SDK mapping insubscriptionCommands.ts(refusedWithfor a 4xxSUBSCRIPTION_QUOTE_STALE,refusedWhilePendingotherwise), the two locale strings, and the new tests applied cleanly.Verification
pnpm typecheck(all five stages) passes.QUOTE_STALE/ 503 →REQUEST_FAILEDtable.