Repository navigation
[backport core/1.55] fix(agent): harden undeliverable ask telemetry - #19474
christian-byrne merged 1 commit into
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8037227acb594e7d39ad587fefe5aa4dfc909d2b
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2121 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T21:27:29.382Z",
"gitSha": "ab704e5b69829a1c7e95fdcf4a9ead2e589f3961",
"branch": "fix/core-1.55-undeliverable-ask-telemetry-hardening",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2000.4260000000045,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.062999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.951,
"heapDeltaBytes": -7096264,
"heapUsedBytes": 60490656,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.328999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2017.2939999999926,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.696999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.947,
"heapDeltaBytes": -7175668,
"heapUsedBytes": 60594500,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.872999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.234000000024,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.086,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 806.815,
"heapDeltaBytes": -5062456,
"heapUsedBytes": 62627796,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 159.158,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.3849999999893,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.181999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 773.081,
"heapDeltaBytes": 6871200,
"heapUsedBytes": 74419176,
"domNodes": -259,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 157.701,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.434999999985,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.068999999999999,
"layouts": 6,
"layoutDurationMs": 0.9700000000000001,
"taskDurationMs": 244.82000000000005,
"heapDeltaBytes": 3056176,
"heapUsedBytes": 70745864,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.497000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.6589999999842,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.202,
"layouts": 6,
"layoutDurationMs": 1.0800000000000003,
"taskDurationMs": 315.33900000000006,
"heapDeltaBytes": 2850632,
"heapUsedBytes": 70521768,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.984,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 672.8570000000218,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.145000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.368,
"heapDeltaBytes": 18943416,
"heapUsedBytes": 86586888,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 167.4,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 631.1549999999215,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.489999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.9069999999999,
"heapDeltaBytes": 18922848,
"heapUsedBytes": 87004708,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 168.826,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1324.0030000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1036.7350000000001,
"heapDeltaBytes": -18116248,
"heapUsedBytes": 72427220,
"domNodes": -297,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 86.614,
"eventListeners": -217,
"totalBlockingTimeMs": 688,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1162.4029999999266,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 814.5230000000001,
"heapDeltaBytes": 34895212,
"heapUsedBytes": 104763068,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 68.82300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 549,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.0329999999772,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.70500000000004,
"heapDeltaBytes": 14772780,
"heapUsedBytes": 91037768,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.73499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.5109999999877,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.16199999999986,
"heapDeltaBytes": 14628728,
"heapUsedBytes": 91105232,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.748,
"eventListeners": 0,
"totalBlockingTimeMs": 229,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10180.960999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9295.931,
"heapDeltaBytes": 12342816,
"heapUsedBytes": 94180332,
"domNodes": -12,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7922.123,
"eventListeners": 0,
"totalBlockingTimeMs": 1175,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10148.487000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9340.448999999999,
"heapDeltaBytes": 3999272,
"heapUsedBytes": 86040508,
"domNodes": -12,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7723.499000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1002,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11058.352000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10153.48,
"heapDeltaBytes": -2895044,
"heapUsedBytes": 73353824,
"domNodes": -12,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 8492.149,
"eventListeners": 0,
"totalBlockingTimeMs": 1664,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9982.860999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9122.533000000001,
"heapDeltaBytes": 3664216,
"heapUsedBytes": 85575964,
"domNodes": -12,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7482.839999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 839,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2056.1720000000037,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.688999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.668,
"heapDeltaBytes": -6324200,
"heapUsedBytes": 80477572,
"domNodes": -248,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 31.604000000000006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2018.067999999971,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.335000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.2470000000001,
"heapDeltaBytes": 2898940,
"heapUsedBytes": 83584748,
"domNodes": -240,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 29.845999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2271.620999999982,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.870000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1600.7889999999998,
"heapDeltaBytes": 20235340,
"heapUsedBytes": 84330156,
"domNodes": -245,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 855.1,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2244.355999999925,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.850999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1479.6499999999999,
"heapDeltaBytes": -22134800,
"heapUsedBytes": 65649348,
"domNodes": -257,
"jsHeapTotalBytes": 1863680,
"scriptDurationMs": 854.463,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3479.105000000004,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.809999999999999,
"layouts": 60,
"layoutDurationMs": 12.624,
"taskDurationMs": 1660.071,
"heapDeltaBytes": -7617540,
"heapUsedBytes": 74473576,
"domNodes": -252,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 760.061,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3497.474000000011,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.831999999999997,
"layouts": 60,
"layoutDurationMs": 12.596,
"taskDurationMs": 1644.979,
"heapDeltaBytes": 7925684,
"heapUsedBytes": 73957200,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 789.0500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2852.634000000023,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.225999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1699.986,
"heapDeltaBytes": 21006044,
"heapUsedBytes": 87457876,
"domNodes": 4,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 963.9570000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2964.3330000000105,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.953000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1851.718,
"heapDeltaBytes": 20987472,
"heapUsedBytes": 87488520,
"domNodes": 8,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 956.3059999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.3399999999801,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.930000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.9790000000001,
"heapDeltaBytes": 20243096,
"heapUsedBytes": 84297904,
"domNodes": -246,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.20300000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.5820000000385,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.960999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.112,
"heapDeltaBytes": -11989788,
"heapUsedBytes": 77003704,
"domNodes": -255,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 33.995999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.1409999999928,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.939000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.60200000000003,
"heapDeltaBytes": 14067540,
"heapUsedBytes": 83658308,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.837,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 570.850000000064,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.991000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.56499999999994,
"heapDeltaBytes": 13731612,
"heapUsedBytes": 83681456,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 142.427,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.0650000000487,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.685,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.86299999999994,
"heapDeltaBytes": -4785244,
"heapUsedBytes": 65186520,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.250000000000003,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1989.6540000000869,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.215000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.64000000000004,
"heapDeltaBytes": -14647108,
"heapUsedBytes": 55300748,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.39,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.4459999999904,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.934999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 729.5319999999999,
"heapDeltaBytes": -3709136,
"heapUsedBytes": 65320388,
"domNodes": -274,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 105.938,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.5970000000307,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.656,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.3019999999999,
"heapDeltaBytes": -6864988,
"heapUsedBytes": 63015052,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 100.148,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.8299999999808,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.243999999999993,
"layouts": 5,
"layoutDurationMs": 13.075,
"taskDurationMs": 927.7280000000001,
"heapDeltaBytes": -6297916,
"heapUsedBytes": 80912552,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 28.762000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8282.857000000036,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.098000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5636.876,
"heapDeltaBytes": -6124916,
"heapUsedBytes": 80918164,
"domNodes": -242,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 2776.6870000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8365.504999999985,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.175,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5742.845,
"heapDeltaBytes": -10201752,
"heapUsedBytes": 76954548,
"domNodes": -242,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2804.688,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16794.846000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16257.555,
"heapDeltaBytes": -49396088,
"heapUsedBytes": 171350440,
"domNodes": -8061,
"jsHeapTotalBytes": -15794176,
"scriptDurationMs": 255.05,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16937.130999999907,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16466.383,
"heapDeltaBytes": -42192516,
"heapUsedBytes": 183566240,
"domNodes": -8061,
"jsHeapTotalBytes": -15736832,
"scriptDurationMs": 257.52599999999995,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20444.76899999995,
"styleRecalcs": 162,
"styleRecalcDurationMs": 16.30100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20067.584,
"heapDeltaBytes": -28253936,
"heapUsedBytes": 192501872,
"domNodes": -8061,
"jsHeapTotalBytes": -18882560,
"scriptDurationMs": 875.2330000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 95,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20736.79000000004,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.769999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20352.281000000003,
"heapDeltaBytes": -22398368,
"heapUsedBytes": 191660900,
"domNodes": -8061,
"jsHeapTotalBytes": -12402688,
"scriptDurationMs": 907.28,
"eventListeners": -14928,
"totalBlockingTimeMs": 117,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6081.23599999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.26999999999998,
"layouts": 20,
"layoutDurationMs": 22.694999999999993,
"taskDurationMs": 5951.974999999999,
"heapDeltaBytes": -58083460,
"heapUsedBytes": 176042472,
"domNodes": -8061,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 104.71299999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 417,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4723.010000000045,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.872,
"layouts": 20,
"layoutDurationMs": 23.188,
"taskDurationMs": 4617.266,
"heapDeltaBytes": -54528192,
"heapUsedBytes": 183814192,
"domNodes": -8061,
"jsHeapTotalBytes": 15462400,
"scriptDurationMs": 94.02400000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 92,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8556.697000000098,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8339.193000000001,
"heapDeltaBytes": -2774188,
"heapUsedBytes": 171022188,
"domNodes": 0,
"jsHeapTotalBytes": -28835840,
"scriptDurationMs": 125.43500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8501.50999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8175.419,
"heapDeltaBytes": 23163100,
"heapUsedBytes": 183950040,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 132.01799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 120.90599999999085,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.096,
"layouts": 4,
"layoutDurationMs": 2.252,
"taskDurationMs": 92.918,
"heapDeltaBytes": 3349080,
"heapUsedBytes": 69174552,
"domNodes": 136,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.463,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 466.44499999990785,
"styleRecalcs": 21,
"styleRecalcDurationMs": 22.599999999999998,
"layouts": 3,
"layoutDurationMs": 1.7329999999999999,
"taskDurationMs": 116.74900000000002,
"heapDeltaBytes": 5020484,
"heapUsedBytes": 70933140,
"domNodes": 148,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.123999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #19474 +/- ##
============================================
Coverage 84.68% 84.68%
============================================
Files 2323 2323
Lines 132603 132606 +3
Branches 35460 33574 -1886
============================================
+ Hits 112292 112295 +3
Misses 19951 19951
Partials 360 360
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Follow-up to #19346 (the core/1.55 backport for approval prompts surviving reconnects). This carries the review hardening that was omitted when the earlier backport merged.
Validation
pnpm exec vitest run src/workbench/extensions/agent/services/agent/agentEventTransport.test.ts src/workbench/extensions/agent/stores/agent/agentConversationStore.test.ts(96 tests passed)