Repository navigation
FE-2900 fix(cloud): show localized copy when a web-session token mint fails - #19452
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughWeb-session authorization wraps token failures in errors with localized messages. It reports selected failures as warnings. Tests cover failure messages, reporting rules, and customer event error handling. ChangesWeb-session token failure handling
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: 🔵 Low · up to A narrow sign-out race can show misleading account-change guidance. The impact is limited, but the copy should be corrected. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to Authorization failures still reject without granting access, and existing error compatibility is preserved. No authorization bypass or credential disclosure was identified in the inspected flow. The new failure reporting has limited exposure, although deployed telemetry collection and redaction settings were not verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR uses bug-fix language in the title and commit subjects, including ✨ Finishing Touches 💡 1📝 Generate docstrings
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7336da7bb2cda2c962e5fd364f0790433c84a9e4
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2160 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 10 MB gzipDetailsSummary
Category Glance App Entry Points — 3.77 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.46 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 133 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 643 kBConfiguration panels, inspectors, and settings screens
Status: 28 added User & Accounts — 39.4 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 125 kBReusable component library chunks
Status: 16 added Data & Services — 4.07 MBStores, services, APIs, and repositories
Status: 15 added Utilities & Hooks — 582 kBHelpers, composables, and utility bundles
Status: 37 added Vendor & Third-Party — 17.4 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 17.9 MBBundles that do not match a named category
Status: 300 added ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T04:22:06.952Z",
"gitSha": "70d0c6f6be02815d09e6a7683daf7c6245193908",
"branch": "dante01yoon/fe-2900-mint-failure-copy",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2032.8559999999811,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.219,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.34399999999994,
"heapDeltaBytes": -19464328,
"heapUsedBytes": 59375584,
"domNodes": -228,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 8.814000000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2041.6519999999991,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.715999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.7129999999999,
"heapDeltaBytes": -22151172,
"heapUsedBytes": 76651680,
"domNodes": -228,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.909,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6672131147541,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1861.2379999999575,
"styleRecalcs": 78,
"styleRecalcDurationMs": 18.672,
"layouts": 12,
"layoutDurationMs": 7.371999999999999,
"taskDurationMs": 848.5290000000001,
"heapDeltaBytes": -37065260,
"heapUsedBytes": 61722244,
"domNodes": -228,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 176.40099999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576576576577,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1816.314000000034,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.878999999999998,
"layouts": 12,
"layoutDurationMs": 4.5120000000000005,
"taskDurationMs": 818.751,
"heapDeltaBytes": -15388640,
"heapUsedBytes": 63415772,
"domNodes": -228,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 168.522,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.820370370370373,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.4409999999893,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.095999999999998,
"layouts": 6,
"layoutDurationMs": 1.1389999999999998,
"taskDurationMs": 341.662,
"heapDeltaBytes": -18379712,
"heapUsedBytes": 80367080,
"domNodes": 53,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.936000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.5730000000158,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.23,
"layouts": 6,
"layoutDurationMs": 1.191,
"taskDurationMs": 336.003,
"heapDeltaBytes": 1568968,
"heapUsedBytes": 80146848,
"domNodes": 53,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 12.004999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 749.1820000000189,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.042000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.329,
"heapDeltaBytes": -1993452,
"heapUsedBytes": 96768752,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 165.622,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 695.0859999999466,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.84,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.71599999999995,
"heapDeltaBytes": -1852728,
"heapUsedBytes": 96631808,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 168.928,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414634,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1162.7970000000118,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 778.0360000000001,
"heapDeltaBytes": 9394940,
"heapUsedBytes": 85017480,
"domNodes": 0,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 68.62299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 546,
"frameDurationMs": 35.35454545454547,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.561999999929,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 855.0680000000001,
"heapDeltaBytes": 9400640,
"heapUsedBytes": 84988080,
"domNodes": 0,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 78.14500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 575,
"frameDurationMs": 35.294117647058826,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.822999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.67199999999957,
"heapDeltaBytes": 16575948,
"heapUsedBytes": 90997540,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 184.04600000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 236,
"frameDurationMs": 25.237142857142835,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.5449999999919,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.3689999999997,
"heapDeltaBytes": 16321020,
"heapUsedBytes": 89993272,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 168.98499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.997058823529454,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10036.899000000005,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.5059999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9143.908000000001,
"heapDeltaBytes": 12111120,
"heapUsedBytes": 85948612,
"domNodes": -226,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 7737.272,
"eventListeners": -139,
"totalBlockingTimeMs": 1376,
"frameDurationMs": 35.26866197183098,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9406.149000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8668.281,
"heapDeltaBytes": 1934900,
"heapUsedBytes": 83226104,
"domNodes": 0,
"jsHeapTotalBytes": -7340032,
"scriptDurationMs": 7308.982,
"eventListeners": 0,
"totalBlockingTimeMs": 1238,
"frameDurationMs": 34.81333333333333,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11325.212000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10349.646999999999,
"heapDeltaBytes": 9744640,
"heapUsedBytes": 91111176,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 8618.509000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 1561,
"frameDurationMs": 33.77970149253731,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9133.70800000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8495.585000000001,
"heapDeltaBytes": 7900644,
"heapUsedBytes": 83107956,
"domNodes": 0,
"jsHeapTotalBytes": -12582912,
"scriptDurationMs": 7158.186,
"eventListeners": 0,
"totalBlockingTimeMs": 1109,
"frameDurationMs": 34.99233716475095,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2065.9729999999854,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.5020000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.7469999999998,
"heapDeltaBytes": -35963728,
"heapUsedBytes": 82985576,
"domNodes": -228,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 33.93399999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2046.2079999999787,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.0900000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.7460000000001,
"heapDeltaBytes": -36221676,
"heapUsedBytes": 82707876,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 33.205,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2405.3420000000187,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.641,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1588.1469999999997,
"heapDeltaBytes": 23642904,
"heapUsedBytes": 87381192,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 829.741,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78251748251748,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2349.171999999953,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.089,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1612.9220000000003,
"heapDeltaBytes": 23878120,
"heapUsedBytes": 86489584,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 850.148,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.784999999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3662.3779999999897,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.917999999999997,
"layouts": 60,
"layoutDurationMs": 13.797,
"taskDurationMs": 1688.5300000000002,
"heapDeltaBytes": 8545232,
"heapUsedBytes": 73616212,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 783.0859999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454548,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3626.651000000038,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.47,
"layouts": 60,
"layoutDurationMs": 13.354,
"taskDurationMs": 1668.6200000000001,
"heapDeltaBytes": 8569924,
"heapUsedBytes": 73350208,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 784.052,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66559633027523,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3116.8460000000096,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.186000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1945.2200000000003,
"heapDeltaBytes": 25587836,
"heapUsedBytes": 90685816,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 985.37,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755675675675672,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3122.9419999999664,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.753000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1862.523,
"heapDeltaBytes": 23953124,
"heapUsedBytes": 87995176,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 945.4479999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755913978494622,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.1630000000164,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.5299999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.701,
"heapDeltaBytes": -38432544,
"heapUsedBytes": 82606892,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 37.720000000000006,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2015.6059999999343,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.1330000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.6510000000001,
"heapDeltaBytes": 21347128,
"heapUsedBytes": 83602920,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.806000000000004,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.5130000000122,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.464000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.481,
"heapDeltaBytes": 12775324,
"heapUsedBytes": 93487212,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 146.58700000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.4140000000525,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.826999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.754,
"heapDeltaBytes": 12432104,
"heapUsedBytes": 93909984,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 145.617,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2038.815999999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.504000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.49999999999994,
"heapDeltaBytes": -2490128,
"heapUsedBytes": 78028660,
"domNodes": -244,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.721,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2056.263000000058,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.383999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.831,
"heapDeltaBytes": -11466224,
"heapUsedBytes": 69085912,
"domNodes": -244,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 8.175999999999998,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1791.8640000000323,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.353999999999996,
"layouts": 16,
"layoutDurationMs": 5.994,
"taskDurationMs": 819.384,
"heapDeltaBytes": -17894692,
"heapUsedBytes": 62922544,
"domNodes": -215,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 120.19999999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.5289999999704,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.764999999999997,
"layouts": 16,
"layoutDurationMs": 5.398,
"taskDurationMs": 752.722,
"heapDeltaBytes": -8508484,
"heapUsedBytes": 71630944,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 108.80300000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.0000000000064,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.470999999999997,
"layouts": 5,
"layoutDurationMs": 13.243999999999998,
"taskDurationMs": 895.6560000000001,
"heapDeltaBytes": 23304848,
"heapUsedBytes": 103306292,
"domNodes": 13667,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 32.363,
"eventListeners": 2383,
"totalBlockingTimeMs": 140,
"frameDurationMs": 19.634246575342456,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "viewport-pan-sweep",
"durationMs": 8299.349000000006,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.524,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5149.859,
"heapDeltaBytes": -38738984,
"heapUsedBytes": 80189732,
"domNodes": -228,
"jsHeapTotalBytes": 356352,
"scriptDurationMs": 2761.549,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69959758551308,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8671.780000000013,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.32500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5832.981,
"heapDeltaBytes": -36146896,
"heapUsedBytes": 82896216,
"domNodes": -228,
"jsHeapTotalBytes": -1216512,
"scriptDurationMs": 2811.375,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698073217726396,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16949.351000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16495.233,
"heapDeltaBytes": -22703716,
"heapUsedBytes": 174929748,
"domNodes": -3045,
"jsHeapTotalBytes": 8605696,
"scriptDurationMs": 273.99600000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.352941176470587,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 17104.605000000105,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16647.337999999996,
"heapDeltaBytes": -59434480,
"heapUsedBytes": 177163764,
"domNodes": -8049,
"jsHeapTotalBytes": -13041664,
"scriptDurationMs": 267.95199999999994,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.663604852686305,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 20306.979000000014,
"styleRecalcs": 146,
"styleRecalcDurationMs": 16.11399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20011.037,
"heapDeltaBytes": -13166580,
"heapUsedBytes": 167974208,
"domNodes": 0,
"jsHeapTotalBytes": -13893632,
"scriptDurationMs": 868.028,
"eventListeners": 0,
"totalBlockingTimeMs": 32,
"frameDurationMs": 38.237547169811315,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 15816.29499999997,
"styleRecalcs": 85,
"styleRecalcDurationMs": 12.666000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15334.388,
"heapDeltaBytes": -38894988,
"heapUsedBytes": 185835168,
"domNodes": -3045,
"jsHeapTotalBytes": 7974912,
"scriptDurationMs": 829.648,
"eventListeners": -14915,
"totalBlockingTimeMs": 83,
"frameDurationMs": 27.564173913043476,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 6228.032999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.539,
"layouts": 20,
"layoutDurationMs": 23.280999999999995,
"taskDurationMs": 6087.276,
"heapDeltaBytes": 7632732,
"heapUsedBytes": 208487648,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 107.61,
"eventListeners": 0,
"totalBlockingTimeMs": 452,
"frameDurationMs": 35.52228571428572,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6149.241999999958,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.90399999999998,
"layouts": 20,
"layoutDurationMs": 25.186,
"taskDurationMs": 6099.445000000001,
"heapDeltaBytes": 14787012,
"heapUsedBytes": 208510692,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 111.99300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 444,
"frameDurationMs": 38.19689440993789,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8725.157000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8480.156,
"heapDeltaBytes": -15776096,
"heapUsedBytes": 194943376,
"domNodes": -3045,
"jsHeapTotalBytes": 9936896,
"scriptDurationMs": 149.227,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.467148014440426,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8592.445999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8339.184000000001,
"heapDeltaBytes": -53142756,
"heapUsedBytes": 176406792,
"domNodes": -3045,
"jsHeapTotalBytes": 6901760,
"scriptDurationMs": 139.15300000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.221830985915492,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 499.0689999999631,
"styleRecalcs": 22,
"styleRecalcDurationMs": 23.406000000000002,
"layouts": 4,
"layoutDurationMs": 2.053,
"taskDurationMs": 160.53,
"heapDeltaBytes": -14562852,
"heapUsedBytes": 82555004,
"domNodes": 129,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 14.223,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 499.9129999999923,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.892,
"layouts": 4,
"layoutDurationMs": 1.9189999999999998,
"taskDurationMs": 233.81899999999996,
"heapDeltaBytes": -41947072,
"heapUsedBytes": 54895452,
"domNodes": -125,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 12.382000000000001,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 930.6280000000697,
"styleRecalcs": 78,
"styleRecalcDurationMs": 107.572,
"layouts": 76,
"layoutDurationMs": 23.66,
"taskDurationMs": 896.657,
"heapDeltaBytes": 18174736,
"heapUsedBytes": 90571732,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 369.387,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 862.794000000008,
"styleRecalcs": 78,
"styleRecalcDurationMs": 100.785,
"layouts": 76,
"layoutDurationMs": 21.71,
"taskDurationMs": 817.797,
"heapDeltaBytes": 17429744,
"heapUsedBytes": 89317200,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 329.909,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307705,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1399.9689999999418,
"styleRecalcs": 78,
"styleRecalcDurationMs": 246.548,
"layouts": 76,
"layoutDurationMs": 25.608,
"taskDurationMs": 1374.264,
"heapDeltaBytes": -18922636,
"heapUsedBytes": 110817412,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 459.072,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.931645569620258,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1418.2739999999967,
"styleRecalcs": 78,
"styleRecalcDurationMs": 257.661,
"layouts": 76,
"layoutDurationMs": 26.849,
"taskDurationMs": 1404.938,
"heapDeltaBytes": -18991068,
"heapUsedBytes": 110738544,
"domNodes": 76,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 473.926,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33125,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19452 +/- ##
==========================================
+ Coverage 84.33% 85.05% +0.71%
==========================================
Files 3302 2341 -961
Lines 159107 133921 -25186
Branches 43265 34187 -9078
==========================================
- Hits 134189 113906 -20283
+ Misses 23045 19651 -3394
+ Partials 1873 364 -1509
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 965 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
- Source review found the change sound.
- CI is settled: 105 checks passed and 19 were skipped.
Full context for agent readers
The reviewed head preserves tab-local workspace scope, and all review threads are resolved.
e129d7f
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head review is sound: the localized web-session mint failure remains scoped to the intended session path, preserves tab-local workspace selection, and exact-head CI is settled green with no unresolved review threads.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve. c0b6888 addresses every open finding from round two, and the three comments left are P3s.
The new holdMint harness drives the in-flight sign-out race, and the test stayed stable over 20 repeated runs. The IDENTITY_CHANGED copy now fits both sign-out and account switch. The description follows the template, and its tables match the code. I re-ran all eleven mutations from the description. Ten fail as claimed. "Report on a 401" stays green, which is the first inline comment. Of the other two, one tightens the cause test, and one corrects the workspace-denied action I suggested last round. One description nit is below.
Description nit
Nit (P3). The template asks for a one-sentence Summary (this one has three) and says to remove the Breaking line when there's nothing breaking. I found no repository requirement for the plan-position graph in AGENTS.md, CONTRIBUTING.md, .github/ or docs/. If your team asks for it elsewhere, keeping it is fine.
Checked and cleared
override readonly cause: SessionTokenErrorbehaves at runtime. Built with the app's esbuild target (es2022), the class field setscausetoundefinedright aftersuper(), and the constructor then assigns the original. Nothing setscauseearlier, so nothing is lost.String(error)and the stack header readWebSessionTokenError: <copy>.- The
pnpm lintclaim holds: thelintcheck is green at this head. - The two
firebaseSignOut.mockImplementation(...)lines are scenario setup. This describe'sbeforeEachdoesn't install the identity-changing sign-out, and moving it there would change unrelated tests. vi.waitFor(() => expect(ingest.heldMints).toBe(1))waits on an observable signal, not a timer.installIngest()creates a fresh gate for each test. Removing the gate makes the in-flight test fail, so it depends on the hold.- knip is clean after the export was removed.
Review record
Round 1 (review, head e129d7f):
- P2
IDENTITY_CHANGEDgiven the session-ended copy: addressed in05bebe5(reply). The replacement copy was corrected in round 2. - P3 no-status lifecycle races reported: addressed in
05bebe5viaLIFECYCLE_RACES(reply). - P3 one-caller
localizeTokenFailure: addressed in05bebe5, inlined (reply). - P3 copy values typed as
string: addressed in05bebe5, keys typed fromenMessages(reply). - P3 question on
WORKSPACE_ACCESS_DENIEDcopy: answered, own copy added in05bebe5(reply). Wording revisited in rounds 2 and 3. - P3 docblock said "refused mint": addressed in
05bebe5(reply). - P3 sibling error class: addressed in
05bebe5, now extendsSessionTokenError(reply). - P3 original error dropped as
cause: addressed in05bebe5(reply). - P3 table missing three codes: addressed in
05bebe5andc0b6888(reply). - Nit redundant
not.toContain: addressed in05bebe5(reply). - P3 network failure untested: addressed in
05bebe5(reply). - Nit redundant
mockClear: addressed in05bebe5(reply). - P2 loose telemetry assertion: addressed in
05bebe5. Dropping tags or reporting the wrapper now fails (reply). - P3 customer-events test used the i18n key as message: addressed in
05bebe5(reply). - P3 description "Where this sits" states stale: addressed by the description edit before round 2.
- P3 grouped AS IS cells: addressed by the template rewrite (comment).
- P3 "Screenshots follow." with none: addressed by the template rewrite (same comment).
- P3 description not on the template: mostly addressed by the rewrite. The remaining nit is above.
Round 2 (review, head 05bebe5):
- P2
IDENTITY_CHANGEDcopy false after an in-flight sign-out: addressed inc0b6888, "Your session changed. Reload to continue." (reply). The account-coreNO_SESSIONfix is a stated follow-up. - P3
IDENTITY_CHANGEDno-report branch unpinned: addressed inc0b6888, held-mint test; removing it fromLIFECYCLE_RACESnow fails (reply). - Nit sign-out test in the wrong describe: addressed in
c0b6888(reply). - P3
instanceof SessionTokenErrorunpinned: addressed inc0b6888;extends Errornow fails 11 tests (reply). - Nit
TOKEN_FAILURE_COPYexported for a test: addressed inc0b6888, export and eight-row table removed (reply). - P3
causetypedunknown: addressed inc0b6888(reply). - P3
workspaceDeniedsaid "no longer" with no next step: addressed inc0b6888(reply). The action I suggested turned out not to fit this path; round 3 corrects it. - P3 description How section stale: addressed by the template rewrite.
- P3 description Tests section stale: addressed by the template rewrite.
Round 3 (this review, head c0b6888): three inline P3s, the 401 row, the cause test, and the workspace-denied action, plus the description nit above. None blocks.
Checks at c0b6888: pnpm typecheck exit 0; pnpm knip exit 0; eslint on the four changed TS files exit 0; oxfmt --check clean; vitest run src/platform/auth/webSessionFlagOn.test.ts src/services/customerEventsService.test.ts 101 passed; 15 mutation runs (the eleven from the description plus four of mine), all reverted; held-mint test 20 repeats stable; fallow audit clean on the changed files. CI when posting: lint, lint-and-format, typecheck, repo-checks green, with Playwright and the ecosystem matrix still running.
| }) | ||
|
|
||
| it.for([ | ||
| { name: 'a 401', refuse: () => jsonResponse({}, 401), reported: false }, |
There was a problem hiding this comment.
P3. The empty 401 body maps to NO_SESSION, and LIFECYCLE_RACES already suppresses that code, so this row can't see the 401 rule. I replaced failure.httpStatus !== 401 with true and all 101 tests stayed green. The description lists "report on a 401" as a red mutation, and with this row it isn't. A 401 whose code isn't a race pins the rule. With this change the row passes, and the same mutation turns it red:
| { name: 'a 401', refuse: () => jsonResponse({}, 401), reported: false }, | |
| { | |
| name: 'a 401', | |
| refuse: () => jsonResponse({ code: 'session_revoked' }, 401), | |
| reported: false | |
| }, |
There was a problem hiding this comment.
Fixed in e562e4a: the 401 row now returns a session_revoked body. Replacing the 401 guard with true turns it red.
| expect(rejection.cause).toBeInstanceOf(SessionTokenError) | ||
| expect(rejection.cause.failure).toBe(rejection.failure) |
There was a problem hiding this comment.
P3. This test still passes with this.cause = this. The wrapper is itself a SessionTokenError and shares failure, so both assertions hold for a self-reference. Only the telemetry test catches that mutation today. Asserting that the cause is the unwrapped error pins it here:
| expect(rejection.cause).toBeInstanceOf(SessionTokenError) | |
| expect(rejection.cause.failure).toBe(rejection.failure) | |
| expect(rejection.cause).toBeInstanceOf(SessionTokenError) | |
| expect(rejection.cause).not.toBeInstanceOf(WebSessionTokenError) |
There was a problem hiding this comment.
Fixed in e562e4a: the test asserts cause is a SessionTokenError and not a WebSessionTokenError. this.cause = this turns it red.
| "ended": "Your session ended. Sign in again to continue.", | ||
| "identityChanged": "Your session changed. Reload to continue.", | ||
| "unavailable": "We couldn't reach your account. Try again in a moment.", | ||
| "workspaceDenied": "You don't have access to this workspace. Choose another workspace or ask its owner for access.", |
There was a problem hiding this comment.
P3. I suggested this wording last round, and I was wrong about the action. authorizeResource always mints without a workspace id (cloudWebSessionStore.ts:209-212, sessionTokenMint.ts:176-182), so choosing another workspace retries the same personal-workspace mint, and there's no other owner to ask. Neither step can clear the error. I'd drop the second sentence, or point to support if it keeps happening, for example "You don't have access to this workspace. Contact support if this keeps happening." Non-blocking: the client can't produce this code on this path today.
There was a problem hiding this comment.
Fixed in e562e4a: copy is now "You don't have access to this workspace. Contact support if this keeps happening." The test literal and the PR body table match.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve. e562e4a closes the three P3s from round three and the description nit, and I have nothing new.
I re-ran the two mutations the new tests target. Replacing failure.httpStatus !== 401 with true now fails the session_revoked 401 row. Setting this.cause = this now fails the cause test on its own. The workspace-denied copy no longer offers an action this path can't take. The test literal and the description table match main.json. The Summary is one sentence and the Breaking line is gone. You keep the plan-position graph because your team asks for it, and that's fine with me.
Review record
Round 1 (review, head e129d7f):
- P2
IDENTITY_CHANGEDgiven the session-ended copy: addressed in05bebe5(reply). The replacement copy was corrected inc0b6888. - P3 no-status lifecycle races reported: addressed in
05bebe5viaLIFECYCLE_RACES(reply). - P3 one-caller
localizeTokenFailure: addressed in05bebe5, inlined (reply). - P3 copy values typed as
string: addressed in05bebe5, keys typed fromenMessages(reply). - P3 question on
WORKSPACE_ACCESS_DENIEDcopy: answered, own copy added in05bebe5(reply). Wording settled ine562e4a. - P3 docblock said "refused mint": addressed in
05bebe5(reply). - P3 sibling error class: addressed in
05bebe5, now extendsSessionTokenError(reply). - P3 original error dropped as
cause: addressed in05bebe5(reply). - P3 table missing three codes: addressed in
05bebe5andc0b6888(reply). - Nit redundant
not.toContain: addressed in05bebe5(reply). - P3 network failure untested: addressed in
05bebe5(reply). - Nit redundant
mockClear: addressed in05bebe5(reply). - P2 loose telemetry assertion: addressed in
05bebe5(reply). - P3 customer-events test used the i18n key as message: addressed in
05bebe5(reply). - P3 description "Where this sits" states stale: addressed by the description edit before round 2.
- P3 grouped AS IS cells: addressed by the template rewrite (comment).
- P3 "Screenshots follow." with none: addressed by the template rewrite (same comment).
- P3 description not on the template: addressed by the rewrite and the round-3 follow-up (comment). The graph stays by team practice.
Round 2 (review, head 05bebe5):
- P2
IDENTITY_CHANGEDcopy false after an in-flight sign-out: addressed inc0b6888(reply). The account-coreNO_SESSIONfix is a stated follow-up. - P3
IDENTITY_CHANGEDno-report branch unpinned: addressed inc0b6888, held-mint test (reply). - Nit sign-out test in the wrong describe: addressed in
c0b6888(reply). - P3
instanceof SessionTokenErrorunpinned: addressed inc0b6888(reply). - Nit
TOKEN_FAILURE_COPYexported for a test: addressed inc0b6888(reply). - P3
causetypedunknown: addressed inc0b6888(reply). - P3
workspaceDeniedsaid "no longer" with no next step: addressed inc0b6888(reply). The action I suggested was then corrected in round 3. - P3 description How section stale: addressed by the template rewrite.
- P3 description Tests section stale: addressed by the template rewrite.
Round 3 (review, head c0b6888):
- P3 empty-401 row couldn't see the 401 rule: addressed in
e562e4a, row sendssession_revoked(reply). - P3 cause test passed with
this.cause = this: addressed ine562e4a(reply). - P3 workspace-denied action didn't fit a personal-workspace mint: addressed in
e562e4a, now points to support (reply). - Nit description Summary length and Breaking line: addressed (comment). I withdrew the graph point because the team asks for one.
Checks at e562e4a: vitest run src/platform/auth/webSessionFlagOn.test.ts src/services/customerEventsService.test.ts 101 passed; eslint on the changed test exit 0; oxfmt --check clean on the test and main.json; the 401-predicate mutation fails the 401 row and the self-cause mutation fails the cause test, both reverted. The delta touches no source file and renames no locale key, so the round-3 pnpm typecheck and pnpm knip results at c0b6888 still apply. CI at c0b6888 finished with 104 passed and 26 skipped. At e562e4a nothing had failed when I posted, and Playwright was still running.
This comment has been minimized.
This comment has been minimized.
…credit action (Comfy-Org#19454) ## Why The other `useWorkshopCredits` callers still mint via Firebase in session mode. This continues Comfy-Org#19368, which moved the model page onto `useWorkshopModelBalance`. ## How Switch three callers from `useWorkshopCredits().balance` to `useWorkshopModelBalance(session)`: - `WorkflowPlayground.vue`, which takes `session` from `useWorkshopSession()` - `CinematicCreditAction.vue` - `useCinematicStudioRun.ts`, which already destructures `session` `useWorkshopModelBalance` binds once per page: the cookie balance for a personal workspace in session mode, the Firebase balance otherwise. The Firebase store is only started on the Firebase branch. `BuyCreditsDialog.vue` is unchanged. The request recorder from `workshop-model-balance.test.ts` moves to `config/__fixtures__/workshopCloudRecorder.ts` so both suites share it. ## AS IS / TO BE Requests from the three callers' balance path, per rollout state: | State | AS IS | TO BE | | --- | --- | --- | | Flag off (probe absent or false) | Firebase balance, no cookie request | Same: Firebase balance, no `/api/billing/balance` or `/api/auth/token` from the balance path | | Session mode, personal workspace | `POST /api/auth/token` with Firebase ID token, then `GET /api/billing/balance` with Bearer | One `GET /api/billing/balance` (cookie, `X-Comfy-Client`), no `/api/auth/token`, Firebase store not started | | Session mode, team workspace | Firebase balance | Balance unknown; the server's refusal still gates the run | Screenshots follow. ## Tests - New `BalanceCallers.test.ts` renders `WorkflowPlayground`, `CinematicStudio` and `CinematicCreditAction` against the recorder. - Session mode: exactly one cookie balance read, no `/api/auth/token`, `useWorkshopCredits` never called. - Flag off: Firebase balance read, no balance or token request. - Run gates: a funded cookie balance runs where an empty Firebase balance would not; flag off with an empty Firebase balance cannot run. - `WorkflowPlayground.test.ts` mocks `useWorkshopModelBalance` as `ModelDetail.test.ts` does. - Website unit suite: 512 files, 9779 tests pass. Website typecheck, oxlint, eslint and oxfmt are clean. - Mutation check: reverting each caller to `useWorkshopCredits` turns red. - `WorkflowPlayground`: the session-mode read test and the funded-gate test. - `CinematicCreditAction`: the session-mode read test. - `useCinematicStudioRun`: the session-mode read test and the funded-gate test. - `models-performance.spec.ts` passes. Total website JS is 8,828,894 B before and 8,828,836 B after (-58 B). ## Known limits - The Run gate still starts Firebase: `refreshWorkshopCredits` and the run path use the Firebase store. - Needs the backend to confirm that Router accepts session-minted tokens and that comfy.org is trusted for credentialed POSTs. - `BuyCreditsDialog` is skipped: it renders nothing in session mode, and top-up needs the Firebase token. ## Where this sits | Node | PR / ticket | Scope | | --- | --- | --- | | Comfy-Org#19390 | FE-3079 part 1 | Run token on session, part 1 | | Comfy-Org#19414 | FE-3079 part 2 | Run token on session, part 2 | | Comfy-Org#19452 | FE-2900 | Mint failure copy | | **F3a** | **FE-2899** | **Website balance (this PR)** | | Comfy-Org#19450 | FE-2901 | API-key rows | | Comfy-Org#19453 | FE-2891 | Flag-off pins | | Comfy-Org#19449 | FE-2893 | Docs | | F8 | FE-2904 | E2E Run (depends on Comfy-Org#19414) | | Ramp | FE-2907 | Fed by all of the above | ```mermaid graph LR A["Comfy-Org#19390 FE-3079 part 1"] --> R B["Comfy-Org#19414 FE-3079 part 2"] --> R B --> F8["F8 FE-2904 E2E Run"] C["Comfy-Org#19452 FE-2900 mint failure copy"] --> R D["F3a FE-2899 website balance"]:::this --> R E["Comfy-Org#19450 FE-2901 API-key rows"] --> R F["Comfy-Org#19453 FE-2891 flag-off pins"] --> R G["Comfy-Org#19449 FE-2893 docs"] --> R F8 --> R R["FE-2907 ramp"] classDef this fill:#ffd54f,stroke:#f57f17,stroke-width:3px,color:#000 ``` - Part of FE-2899
…ession off (Comfy-Org#19453) ## Why FE-2891's criterion: with `unified_web_session` absent, the three apps issue the same network calls as main. Only the cloud app was pinned (`nonWebClientsStayOnTokens.test.ts`). The website had no request-level pin, and billing-web pinned main only relatively (the flag-off rows were compared against a run of the same code, so a change that hit both sides passed). ## How Tests only, no production change. - **website**: new `workshop-flag-off.requests.test.ts`. Real `workshop-account`, `workshop-session-state`, `workshop-credits`, `workshop-account-source` and `workshop-model-balance` run over a recording `fetch`. Only `workshop-firebase` (signed-in user, `getIdToken` -> `id-token`) and `scripts/posthog` (auth flag on) are mocked. Flow: boot, header balance, model-page balance, a direct session freshness check (`ensureFresh`), refocus, sign-out. Each request records `{method, url, credentials, header names, authorization, client, body}` and is compared to a literal golden. `setTimeout` is faked and never advanced, so the 800 ms account-source cap cannot fire. - **billing-web**: `billingWebAuth.flagOff.test.ts` gains a literal `MAIN_GOLDEN` next to the existing relative check, plus an entry-link workspace rebind flow and a sign-out flow. Golden values were captured by running main's code, not written by hand. ## AS IS / TO BE No UI change. | | AS IS | TO BE | |---|---|---| | website, probe absent / `false` | unpinned | anonymous `GET /api/features` (`credentials: 'omit'`, no headers), then `POST /api/auth/token` (Bearer id-token), `GET /api/billing/balance` (Bearer jwt), a targeted `POST /api/auth/token` for the freshness check, one more balance read on refocus, nothing on sign-out | | website, probe `true` + flag `false` / `'true'` (string) | unpinned | same, plus one credentialed `GET /api/features` (`credentials: 'include'`, `X-Comfy-Client`) | | website, all rows | no assertion on `/api/auth/session` or `X-CSRF-Token` | neither ever appears; header names are pinned, so an extra header fails | | billing-web sign-in + billing call | compared only to a run of the same code | literal: features, `POST /api/auth/token` `{}`, `POST /api/auth/token` `{workspace_id: 'ws-1'}`, `GET /api/billing/status`, with header names and `Authorization` values | | billing-web entry link -> `ws-2` | unpinned | exactly one `POST /api/auth/token` `{workspace_id: 'ws-2'}`, however often the link repeats | | billing-web sign-out | unpinned | stored credential dropped, no request | ## Tests `pnpm --filter @comfyorg/website test:unit` (512 files, 9773 tests), `pnpm --filter @comfyorg/billing-web test:unit` (27 files, 312 tests), `pnpm typecheck:website`, `pnpm typecheck:billing-web`: green. Mutation checks, each reverted afterwards: | Mutation | Result | |---|---| | `decideAccountSource` returns `'session'` when the probe is false | website: 4/4 rows red | | `credentials: 'omit'` dropped from `readWebSessionProbe` | website: 4/4 red | | flag read as true for the string `'true'` | website: the `'true'` row red; billing-web: the `'true'` row red | | `X-Comfy-Client` sent on the probe | website: 4/4 red | | billing-web default flips to web-session | billing-web: 9/10 red (timeouts, since the Firebase path never runs) | | extra header on the token exchange | website: 4/4 red; billing-web: 6/10 red | | entry-workspace re-mint removed | billing-web: rebind test red | ## Where this sits | Item | PR | Ticket | Depends on | |---|---|---|---| | Web session, part 1 | Comfy-Org#19390 | FE-3079 | | | Web session, part 2 | Comfy-Org#19414 | FE-3079 | Comfy-Org#19390 | | Comfy-Org#19452 | | FE-2900 mint failure copy | | | F3a | | FE-2899 website balance | | | Comfy-Org#19450 | | FE-2901 API-key rows | | | **F5 (this PR)** | | FE-2891 flag-off pins | | | Comfy-Org#19449 | | FE-2893 docs | | | Comfy-Org#19457 | | FE-2904 E2E Run | Comfy-Org#19414 | | Ramp | | FE-2907 | all of the above | ```mermaid graph LR P1["Comfy-Org#19390 FE-3079 part 1"] --> P2["Comfy-Org#19414 FE-3079 part 2"] P2 --> F8["F8 FE-2904 E2E Run"] F2a["Comfy-Org#19452 FE-2900 mint failure copy"] --> R["FE-2907 ramp"] F3a["F3a FE-2899 website balance"] --> R F4["Comfy-Org#19450 FE-2901 API-key rows"] --> R F5["F5 FE-2891 flag-off pins"] --> R F6["Comfy-Org#19449 FE-2893 docs"] --> R F8 --> R P1 --> R P2 --> R style F5 fill:#f9c74f,stroke:#000,stroke-width:3px,color:#000 ``` - Part of FE-2891
…rg#19457) ## Why Comfy-Org#19382 covered the queue path with `fetchApi('/prompt')` because Run did not yet take its token from the web session. With Comfy-Org#19390 and Comfy-Org#19414 it does, so the E2E should click the real Run button and prove the prompt carries the session-minted workspace token. ## How - `WEB_SESSION_MINT` in `fixtures/data/webSession.ts`, typed as `ExchangeTokenResponse` from `@comfyorg/ingest-types`. - `webSessionFixture` routes `**/api/auth/token` to that fixture and records each mint as `{ body, authorization, workspace }` instead of a string. - The fixture also mocks billing (`mockBilling`, active subscription) so Run is not replaced by the subscribe dialog. - Existing prompt tests click Run via `runDefaultWorkflow`; E2E-06 keeps `fetchApi` because it needs a bare request. - New test: exactly one mint `{ workspace_id: 'ws-team' }`, no `Authorization` header, `x-comfy-workspace-id: ws-team`, and `extra_data.auth_token_comfy_org === 'session-jwt-e2e'` on the prompt. - E2E-03: no mint after the switch, exactly one `ws-team` mint after Run. Needs Comfy-Org#19390 (billing reads on the session; without it Run opens the subscribe dialog) and Comfy-Org#19414 (the Run token). Both are merged into main. ## AS IS / TO BE No UI change. | Step | AS IS | TO BE | | --- | --- | --- | | Queue a prompt | `fetchApi('/prompt')` from `page.evaluate` | Load default workflow, click Run | | `/api/auth/token` | Not mocked, mints recorded as strings | Typed `ExchangeTokenResponse`, mints recorded with body, auth and workspace header | | Token asserted | None | One `ws-team` mint, prompt carries `session-jwt-e2e` | | E2E-03 mints | Empty after the whole flow | Empty after the switch, one `ws-team` mint after Run | ## Tests - `pnpm typecheck:browser`, oxlint and eslint on the touched files: clean. - `unifiedWebSession.spec.ts` against a production cloud build (`pnpm build:cloud`) served by a local ComfyUI backend, `--project=cloud`: 5 passed on main with Comfy-Org#19390 and Comfy-Org#19414 merged, no temporary merges. - Mutation: `webSessionRunToken` ignored (branch skipped) turns 3 tests red; token altered to `credential.token + 'x'` turns only the new token test red (`Received: "session-jwt-e2ex"`). Reverted. ## Where this sits | PR | Ticket | What | | --- | --- | --- | | Comfy-Org#19390 (merged) | FE-3079 part 1 | Workspace API and agent consent on the session | | Comfy-Org#19414 (merged) | FE-3079 part 2 | Run token from the session | | Comfy-Org#19452 | FE-2900 | Mint failure copy | | Comfy-Org#19454 | FE-2899 | Website balance | | Comfy-Org#19450 | FE-2901 | API-key rows | | Comfy-Org#19453 | FE-2891 | Flag-off pins | | Comfy-Org#19449 | FE-2893 | Docs | | **Comfy-Org#19457 (this PR)** | FE-2904 | E2E clicks Run, depends on Comfy-Org#19414 | | FE-2907 | ramp | All of the above feed into it | ```mermaid graph LR A["Comfy-Org#19390 FE-3079 part 1"] --> B["Comfy-Org#19414 FE-3079 part 2"] B --> F8["F8 FE-2904 E2E Run (this PR)"] F2a["Comfy-Org#19452 FE-2900 mint failure copy"] --> R["FE-2907 ramp"] F3a["Comfy-Org#19454 FE-2899 website balance"] --> R F4["Comfy-Org#19450 FE-2901 API-key rows"] --> R F5["Comfy-Org#19453 FE-2891 flag-off pins"] --> R F6["Comfy-Org#19449 FE-2893 docs"] --> R A --> R B --> R F8 --> R style F8 fill:#f9d648,stroke:Comfy-Org#333,stroke-width:3px ``` - Part of FE-2904
christian-byrne
left a comment
There was a problem hiding this comment.
Approved. The updated error path preserves SessionTokenError compatibility and the original cause, maps each mint outcome to accurate localized copy, and reports service failures without treating sign-out or account-change races as incidents.
Verified on 917fa3a361865155b0043e22c60e3607a4a62ac3: the 101 focused tests pass; type checking, targeted ESLint, and formatting pass; all required CI checks are green.
Summary
A failed web-session workspace-token mint showed the raw
SessionTokenErrortext (Workspace token mint failed: <CODE>) in the toast; it now shows localized copy.Changes
authorizeResourcecatchesSessionTokenErrorand rethrowsWebSessionTokenError(webSessionFetch.ts). It extendsSessionTokenError, sofailureis kept andinstanceofstill holds. Itscauseis typed as the original error.auth.webSession.token(ended,identityChanged,unavailable,workspaceDenied,refused), typed fromenMessages. ARecord<WebSessionErrorCode, key>keeps all eight codes mapped.reportError(auth_session_token_mint_failure, warning, tagscodeandhttp_status) is called with the original error, except for a 401 and for a no-statusNO_SESSIONorIDENTITY_CHANGED. Those are session lifecycle events, not service faults. A no-status network failure is reported.authorizeResourceis only provided when the session is on. Other callers ofwebSessionResourceHeaderstill get aSessionTokenError(now a subclass).NO_SESSION,SESSION_EXPIRED,SESSION_REVOKEDWorkspace token mint failed: <CODE>IDENTITY_CHANGEDWorkspace token mint failed: IDENTITY_CHANGEDSESSION_UNAVAILABLEWorkspace token mint failed: SESSION_UNAVAILABLECSRF_STALE,SESSION_REQUEST_REFUSEDWorkspace token mint failed: <CODE>WORKSPACE_ACCESS_DENIEDWorkspace token mint failed: WORKSPACE_ACCESS_DENIEDReview Focus
IDENTITY_CHANGEDalso fires when the same account signs out mid-mint (sessionTokenMint.tscompares against an absent session), so its copy does not name another account. ReturningNO_SESSIONfor an absent session is an account-core follow-up.webSessionFlagOn.test.ts,customerEventsService.test.ts):webSessionResourceHeader, asserting the literal English copy.IDENTITY_CHANGED, asserting the copy and no report.NO_SESSION.SessionTokenErrorwith the original as itscause.IDENTITY_CHANGEDfrom the no-report set; removeNO_SESSIONfrom it;extends Errorinstead ofSessionTokenError; swap theIDENTITY_CHANGEDorWORKSPACE_ACCESS_DENIEDcopy.pnpm typecheck,pnpm lint(0 errors),pnpm knippass.Where this sits
Web-session follow-ups: #19390 and #19414 are merged; this PR is FE-2900.