Repository navigation
[backport cloud/1.55] FE-3013 feat(pricing): read the plan's raw credit grant from the catalog - #19447
Conversation
…log (#18873) ## Summary The pricing cards read the plan's raw credit grant from the backend (`Plan.credits`, added in Comfy-Org/cloud#10703) instead of the hardcoded `TIER_PRICING` figure. They fall back to the static grant only when the field is absent. - Follows #18867 (the FE-3013 hotfix). Part of FE-3013. - Comfy-Org/cloud#10703 is merged and live on test-v2. The generated `Plan.credits` type and its SDK projection landed on `main` through #19212, so this PR is now only the pricing surfaces reading it. Until prod serves the field, both tables fall back to the static grant. ## Why The hotfix #18867 stops misreading `credits_cents` by going back to a static grant. A static grant cannot follow a catalog change. Converting `credits_cents` cannot produce the real grant either, because the backend rounds it to whole cents: 23,887¢ → 50,402, while the catalog grants 50,400. The backend now sends the grant itself. ## Root cause `Plan` exposed the grant only as `credits_cents`. The raw count the subscription actually receives, the catalog's `credit_grant`, never reached the client. ## How - `Plan.credits` (generated types) and its safe-number projection in `billingPlansView.ts` are on `main` via #19212. - `UnifiedPricingTable.vue` / `PricingTableWorkspace.vue`: `plan.credits ?? amountForBillingCycle(static)`. The value is read straight off the server; nothing is derived. - Tests: the catalog grant wins over the static figure on the matching cycle only. The #18867 tests still pin the fallback (field absent) to the static grant. ## Screenshots Both builds run locally against the Comfy-Org/cloud#10703 preview backend (`pr-10703.testenvs.comfy.org`). The page's own `GET /api/billing/plans` response already carries `credits`: | slug | `credits_cents` | `credits` | | --- | --- | --- | | standard-monthly | 1,991 | 4,200 | | standard-annual | 23,887 | 50,400 | | creator-monthly | 3,508 | 7,400 | | creator-annual | 42,086 | 88,800 | | pro-monthly | 10,000 | 21,100 | | pro-annual | 120,000 | 253,200 | AS IS (#18867, `86fba0349b`, static grant): Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. | Yearly | Monthly | | --- | --- | | <img width="480" alt="asis-yearly" src="https://github.com/user-attachments/assets/a790c178-0acd-4a1f-9f38-b1925ddbddc2" /> | <img width="480" alt="asis-monthly" src="https://github.com/user-attachments/assets/3dfb46e7-f7cc-486b-98af-8f49a15265ef" /> | TO BE (`a7270257f7`, reads `plan.credits`): same figures, Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. The numbers now come from the API instead of the static table. | Yearly | Monthly | | --- | --- | | <img width="480" alt="tobe-yearly" src="https://github.com/user-attachments/assets/94eafd26-f717-4d31-a6c6-8d2e861617fe" /> | <img width="480" alt="tobe-monthly" src="https://github.com/user-attachments/assets/6e7733e0-71d1-44ee-9b43-b5f318dbcbe7" /> |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4f1cc29f1feb9a31f05a8373eb3992e3a2c6178f
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2121 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T23:08:08.945Z",
"gitSha": "0e90ed901a8f60cef58790756bc7b03519a579a4",
"branch": "backport-18873-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.1639999999888,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.98,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.156,
"heapDeltaBytes": -7659104,
"heapUsedBytes": 60095352,
"domNodes": -259,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 10.682999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2019.9049999999943,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.853000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.272,
"heapDeltaBytes": 9431816,
"heapUsedBytes": 77092412,
"domNodes": -256,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.600999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.2879999999623,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.602000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 647.417,
"heapDeltaBytes": 10656728,
"heapUsedBytes": 78260928,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 123.63199999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1704.796999999985,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.156999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.89,
"heapDeltaBytes": 11174256,
"heapUsedBytes": 78809420,
"domNodes": -257,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 118.11999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.3239999999519,
"styleRecalcs": 28,
"styleRecalcDurationMs": 14.726,
"layouts": 6,
"layoutDurationMs": 1.1620000000000001,
"taskDurationMs": 272.108,
"heapDeltaBytes": 3138612,
"heapUsedBytes": 70617208,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.377,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.1069999999881,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.171,
"layouts": 6,
"layoutDurationMs": 1.186,
"taskDurationMs": 278.70900000000006,
"heapDeltaBytes": 3097116,
"heapUsedBytes": 70845708,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 14.208,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 530.7359999999903,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.155,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.951,
"heapDeltaBytes": 18816484,
"heapUsedBytes": 86664592,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 119.134,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 495.5619999999499,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.610999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.218,
"heapDeltaBytes": 18029056,
"heapUsedBytes": 80800124,
"domNodes": 21,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 110.622,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1012.9120000000285,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 677.514,
"heapDeltaBytes": -17265524,
"heapUsedBytes": 73354480,
"domNodes": -291,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 43.736999999999995,
"eventListeners": -217,
"totalBlockingTimeMs": 363,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 939.5009999999502,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.0350000000001,
"heapDeltaBytes": 15184272,
"heapUsedBytes": 86013668,
"domNodes": 0,
"jsHeapTotalBytes": 22179840,
"scriptDurationMs": 45.25800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 339,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.3259999999614,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.48399999999964,
"heapDeltaBytes": 14433600,
"heapUsedBytes": 89963116,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 96.85199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 92,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 685.0670000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.0750000000004,
"heapDeltaBytes": 14680460,
"heapUsedBytes": 91159744,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 100.14500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 88,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6515.4389999999585,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5779.294,
"heapDeltaBytes": -7504448,
"heapUsedBytes": 74559100,
"domNodes": -18,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 4424.825999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 50,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6215.051000000017,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.9369999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4913.8330000000005,
"heapDeltaBytes": -2029696,
"heapUsedBytes": 70081268,
"domNodes": -6,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 3900.297,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6485.668000000032,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.9910000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5533.683,
"heapDeltaBytes": 13328128,
"heapUsedBytes": 95131508,
"domNodes": -14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 4186.737000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6140.751000000023,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.3880000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4964.527999999999,
"heapDeltaBytes": -12020188,
"heapUsedBytes": 69947348,
"domNodes": -14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 3956.8,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.2709999999988,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.570999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.327,
"heapDeltaBytes": -6231000,
"heapUsedBytes": 80361736,
"domNodes": -241,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 30.207000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2014.002000000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.59,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.4049999999999,
"heapDeltaBytes": -3729460,
"heapUsedBytes": 83126740,
"domNodes": -236,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.501000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2748.5789999999497,
"styleRecalcs": 71,
"styleRecalcDurationMs": 17.683000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1309.835,
"heapDeltaBytes": -7525568,
"heapUsedBytes": 80406000,
"domNodes": -212,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 624.019,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2185.4020000000673,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.739,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1159.7440000000001,
"heapDeltaBytes": -11035540,
"heapUsedBytes": 76312416,
"domNodes": -210,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 564.732,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3427.902999999958,
"styleRecalcs": 67,
"styleRecalcDurationMs": 16.892,
"layouts": 60,
"layoutDurationMs": 15.192,
"taskDurationMs": 1331.927,
"heapDeltaBytes": -8633872,
"heapUsedBytes": 73522348,
"domNodes": -242,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 550.933,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3201.359000000025,
"styleRecalcs": 67,
"styleRecalcDurationMs": 16.308000000000003,
"layouts": 60,
"layoutDurationMs": 14.369000000000002,
"taskDurationMs": 1234.575,
"heapDeltaBytes": -16011224,
"heapUsedBytes": 73201308,
"domNodes": -241,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 523.764,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2770.4140000000166,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.516,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1558.143,
"heapDeltaBytes": -15486716,
"heapUsedBytes": 75403504,
"domNodes": -215,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 744.452,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2581.8970000000263,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.618,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1478.6229999999998,
"heapDeltaBytes": -15695920,
"heapUsedBytes": 74321920,
"domNodes": -215,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 705.452,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.5030000000238,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.568,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.38200000000006,
"heapDeltaBytes": -4289448,
"heapUsedBytes": 84221496,
"domNodes": -240,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 30.222000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2048.180000000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.408999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.8810000000001,
"heapDeltaBytes": -8977460,
"heapUsedBytes": 80895780,
"domNodes": -241,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 32.733000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 509.5600000000218,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.612999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.122,
"heapDeltaBytes": 13741384,
"heapUsedBytes": 84006780,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 111.75000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 409.67799999998533,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.498999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 273.189,
"heapDeltaBytes": 13708760,
"heapUsedBytes": 83719468,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 95.636,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2008.305000000007,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.33899999999994,
"heapDeltaBytes": 11287800,
"heapUsedBytes": 81096744,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.842,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1991.7659999999842,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.780999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.04699999999997,
"heapDeltaBytes": -6660552,
"heapUsedBytes": 63534348,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.2730000000000015,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.833000000027,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.535,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.7969999999999,
"heapDeltaBytes": -4410104,
"heapUsedBytes": 65606196,
"domNodes": -273,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 98.22299999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.717000000016,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.597,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.9789999999999,
"heapDeltaBytes": -9063500,
"heapUsedBytes": 61245480,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 85.831,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 818.760999999995,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.112000000000005,
"layouts": 5,
"layoutDurationMs": 8.020000000000001,
"taskDurationMs": 567.5560000000002,
"heapDeltaBytes": -6292620,
"heapUsedBytes": 81556236,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 19.004,
"eventListeners": 2383,
"totalBlockingTimeMs": 62,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9628.254999999968,
"styleRecalcs": 250,
"styleRecalcDurationMs": 45.431,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4598.335999999999,
"heapDeltaBytes": -5541588,
"heapUsedBytes": 80558420,
"domNodes": -240,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2069.681,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8387.144000000035,
"styleRecalcs": 251,
"styleRecalcDurationMs": 43.668,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4175.593999999999,
"heapDeltaBytes": -4811220,
"heapUsedBytes": 81854744,
"domNodes": -210,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 1998.5130000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 12299.531000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11833.825,
"heapDeltaBytes": -42824824,
"heapUsedBytes": 179695096,
"domNodes": -8062,
"jsHeapTotalBytes": -13688832,
"scriptDurationMs": 170.773,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12462.523000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12334.09,
"heapDeltaBytes": -48546700,
"heapUsedBytes": 176344108,
"domNodes": -8062,
"jsHeapTotalBytes": -7806976,
"scriptDurationMs": 171.60500000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.22666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14592.482000000018,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.194999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14433.868999999999,
"heapDeltaBytes": -29263612,
"heapUsedBytes": 186962084,
"domNodes": -8062,
"jsHeapTotalBytes": -22933504,
"scriptDurationMs": 625.087,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15344.108000000006,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.635999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15226.255000000001,
"heapDeltaBytes": -53481096,
"heapUsedBytes": 168412428,
"domNodes": -8062,
"jsHeapTotalBytes": -19861504,
"scriptDurationMs": 789.0970000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 79,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4470.640000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.988000000000014,
"layouts": 20,
"layoutDurationMs": 24.603,
"taskDurationMs": 4453.144,
"heapDeltaBytes": -17026340,
"heapUsedBytes": 198781720,
"domNodes": -8062,
"jsHeapTotalBytes": 20652032,
"scriptDurationMs": 72.05199999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 115,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4680.593999999928,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.79100000000001,
"layouts": 20,
"layoutDurationMs": 26.73600000000001,
"taskDurationMs": 4639.103,
"heapDeltaBytes": -53495552,
"heapUsedBytes": 167586388,
"domNodes": -8062,
"jsHeapTotalBytes": 10342400,
"scriptDurationMs": 84.38699999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 141,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6215.039999999931,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6115.736,
"heapDeltaBytes": -13895972,
"heapUsedBytes": 181784896,
"domNodes": 0,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 86.26300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5890.223999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5851.530000000001,
"heapDeltaBytes": 1649352,
"heapUsedBytes": 166772960,
"domNodes": 0,
"jsHeapTotalBytes": -21757952,
"scriptDurationMs": 80.455,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 94.72900000002937,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.127999999999998,
"layouts": 3,
"layoutDurationMs": 1.4449999999999998,
"taskDurationMs": 75.31400000000002,
"heapDeltaBytes": 3289604,
"heapUsedBytes": 68969192,
"domNodes": 110,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.415999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 422.7009999999609,
"styleRecalcs": 15,
"styleRecalcDurationMs": 16.523,
"layouts": 3,
"layoutDurationMs": 0.955,
"taskDurationMs": 84.16099999999999,
"heapDeltaBytes": 4786292,
"heapUsedBytes": 70454296,
"domNodes": 122,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.17,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19447 +/- ##
=============================================
Coverage ? 80.48%
=============================================
Files ? 2209
Lines ? 116844
Branches ? 35362
=============================================
Hits ? 94039
Misses ? 22419
Partials ? 386
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Pull request was closed
Backport of #18873 to
cloud/1.55Automatically created by backport workflow.