Repository navigation
[backport cloud/1.55] fix: await in-flight unified-auth mint instead of racing it - #19433
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2123 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d0ab834c8001a02fd93df8064535220a80a95fe9
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T21:22:54.974Z",
"gitSha": "c912ceedf25d4839ce05b6429980ef0ab2b5f7e2",
"branch": "backport-15184-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2011.6639999999961,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.500999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.59299999999996,
"heapDeltaBytes": -7301124,
"heapUsedBytes": 55204880,
"domNodes": 18,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.36,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2040.3049999999894,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.281000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.901,
"heapDeltaBytes": -3385136,
"heapUsedBytes": 64404336,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.519,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1758.9280000000826,
"styleRecalcs": 44,
"styleRecalcDurationMs": 16.331,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 813.769,
"heapDeltaBytes": 3693208,
"heapUsedBytes": 71401468,
"domNodes": -263,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 164.092,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.2200000001121,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.59,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 823.534,
"heapDeltaBytes": -5282572,
"heapUsedBytes": 62671680,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 165.22,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.7790000001496,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.266,
"layouts": 6,
"layoutDurationMs": 0.93,
"taskDurationMs": 344.27200000000005,
"heapDeltaBytes": 3134516,
"heapUsedBytes": 71020240,
"domNodes": 80,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.055,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.23699999991,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.546000000000001,
"layouts": 6,
"layoutDurationMs": 1.0939999999999999,
"taskDurationMs": 339.16900000000004,
"heapDeltaBytes": 2973484,
"heapUsedBytes": 71037580,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.734000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 646.98199999998,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.959,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.7150000000001,
"heapDeltaBytes": 18972552,
"heapUsedBytes": 86609028,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 164.91599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 636.75400000011,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.516,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.44100000000003,
"heapDeltaBytes": 18571836,
"heapUsedBytes": 86285436,
"domNodes": 20,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 169.777,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1176.4749999999822,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 868.511,
"heapDeltaBytes": 11577444,
"heapUsedBytes": 89118792,
"domNodes": 0,
"jsHeapTotalBytes": 20606976,
"scriptDurationMs": 73.73900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 570,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1186.2619999999424,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 859.1450000000001,
"heapDeltaBytes": 38532932,
"heapUsedBytes": 107573100,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 70.91300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 577,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 840.6109999999671,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.98600000000005,
"heapDeltaBytes": 14616636,
"heapUsedBytes": 91826820,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.92299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.5310000000081,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.9680000000002,
"heapDeltaBytes": 14659744,
"heapUsedBytes": 91387540,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 170.72500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 229,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10343.031999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9418.991,
"heapDeltaBytes": 12671380,
"heapUsedBytes": 95236564,
"domNodes": -20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8000.353999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1195,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10645.436999999902,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9682.041,
"heapDeltaBytes": -11985660,
"heapUsedBytes": 69951472,
"domNodes": -12,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8259.256,
"eventListeners": 0,
"totalBlockingTimeMs": 1269,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10533.083000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9717.606,
"heapDeltaBytes": -2400788,
"heapUsedBytes": 74092608,
"domNodes": -10,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7958.819,
"eventListeners": 0,
"totalBlockingTimeMs": 1074,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11688.938999999891,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10831.673999999999,
"heapDeltaBytes": -683392,
"heapUsedBytes": 81949728,
"domNodes": -16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 9012.166000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1618,
"frameDurationMs": 19.996666666666595,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2027.456999999913,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.265999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.2919999999999,
"heapDeltaBytes": -2558092,
"heapUsedBytes": 83653104,
"domNodes": -238,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 37.583000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2034.889000000021,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.178,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.055,
"heapDeltaBytes": -3162696,
"heapUsedBytes": 83617604,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 38.563,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2300.703999999996,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.477000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1632.1429999999998,
"heapDeltaBytes": -21712368,
"heapUsedBytes": 66053796,
"domNodes": -256,
"jsHeapTotalBytes": 2650112,
"scriptDurationMs": 899.7320000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2291.8170000000373,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.936000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1656.469,
"heapDeltaBytes": 16102480,
"heapUsedBytes": 80313580,
"domNodes": -243,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 848.9469999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3724.820000000136,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.994999999999997,
"layouts": 60,
"layoutDurationMs": 13.874999999999998,
"taskDurationMs": 1862.4950000000001,
"heapDeltaBytes": -8592428,
"heapUsedBytes": 73163344,
"domNodes": -256,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 815.01,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3615.291999999954,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.390999999999998,
"layouts": 60,
"layoutDurationMs": 13.656999999999998,
"taskDurationMs": 1725.14,
"heapDeltaBytes": 10280004,
"heapUsedBytes": 75327928,
"domNodes": -247,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 799.373,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3259.053999999878,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2098.353,
"heapDeltaBytes": -3384972,
"heapUsedBytes": 87132052,
"domNodes": -221,
"jsHeapTotalBytes": 1757184,
"scriptDurationMs": 1041.581,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3176.963999999998,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.356000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2010.8519999999999,
"heapDeltaBytes": 30699856,
"heapUsedBytes": 96916000,
"domNodes": 6,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 1050.8540000000003,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2049.449999999979,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.53,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.764,
"heapDeltaBytes": -5781836,
"heapUsedBytes": 82855064,
"domNodes": -247,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 39.673,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.0219999999026,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.4239999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.9259999999999,
"heapDeltaBytes": -4781188,
"heapUsedBytes": 84217372,
"domNodes": -248,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.389,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.1360000000823,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.502,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.60300000000007,
"heapDeltaBytes": 14039072,
"heapUsedBytes": 83769528,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 146.74200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.3389999999908,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.241,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.33599999999996,
"heapDeltaBytes": 14066024,
"heapUsedBytes": 84004756,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 151.763,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.2020000000066,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.610999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.2850000000001,
"heapDeltaBytes": -863144,
"heapUsedBytes": 69179540,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.9330000000000025,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.4570000000076,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.561000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.639,
"heapDeltaBytes": -6399756,
"heapUsedBytes": 62591832,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.806999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.56700000013,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.288999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 776.6820000000001,
"heapDeltaBytes": 4794884,
"heapUsedBytes": 73968684,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 117.922,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.792000000003,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.253000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 747.911,
"heapDeltaBytes": -2699928,
"heapUsedBytes": 67001548,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 109.021,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.7230000001746,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.206000000000003,
"layouts": 5,
"layoutDurationMs": 13.315000000000001,
"taskDurationMs": 922.5059999999999,
"heapDeltaBytes": -6248588,
"heapUsedBytes": 81861500,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 31.387000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8674.851999999873,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.799,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6042.302000000001,
"heapDeltaBytes": -5762556,
"heapUsedBytes": 80591260,
"domNodes": -241,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2849.369,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8614.820000000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.546,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6037.7880000000005,
"heapDeltaBytes": -6179428,
"heapUsedBytes": 80589816,
"domNodes": -242,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 2860.909,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17241.40599999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16762.469000000005,
"heapDeltaBytes": -32293836,
"heapUsedBytes": 183289668,
"domNodes": -8061,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 290.562,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17474.588999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16984.043999999998,
"heapDeltaBytes": -44564728,
"heapUsedBytes": 177202240,
"domNodes": -8061,
"jsHeapTotalBytes": -11603968,
"scriptDurationMs": 276.12399999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21497.874000000138,
"styleRecalcs": 159,
"styleRecalcDurationMs": 19.899999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21297.289,
"heapDeltaBytes": -60264148,
"heapUsedBytes": 180964484,
"domNodes": -8062,
"jsHeapTotalBytes": -19599360,
"scriptDurationMs": 934.987,
"eventListeners": -14928,
"totalBlockingTimeMs": 150,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21939.22500000008,
"styleRecalcs": 158,
"styleRecalcDurationMs": 21.028999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21678.916,
"heapDeltaBytes": -53164836,
"heapUsedBytes": 167492556,
"domNodes": -8061,
"jsHeapTotalBytes": -18153472,
"scriptDurationMs": 949.5760000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 117,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6236.098000000084,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.08399999999999,
"layouts": 20,
"layoutDurationMs": 24.514000000000006,
"taskDurationMs": 6167.29,
"heapDeltaBytes": -68363980,
"heapUsedBytes": 172940428,
"domNodes": -8060,
"jsHeapTotalBytes": 9498624,
"scriptDurationMs": 110.55599999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 517,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6291.519999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.928,
"layouts": 20,
"layoutDurationMs": 24.063000000000017,
"taskDurationMs": 6253.005999999999,
"heapDeltaBytes": -57176820,
"heapUsedBytes": 183157548,
"domNodes": -8061,
"jsHeapTotalBytes": 12689408,
"scriptDurationMs": 117.594,
"eventListeners": -14928,
"totalBlockingTimeMs": 437,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8477.57200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8287.446000000002,
"heapDeltaBytes": 10492500,
"heapUsedBytes": 172401228,
"domNodes": 0,
"jsHeapTotalBytes": -8126464,
"scriptDurationMs": 131.78400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8924.172999999882,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8637.497000000001,
"heapDeltaBytes": -6258176,
"heapUsedBytes": 178355980,
"domNodes": 0,
"jsHeapTotalBytes": -13893632,
"scriptDurationMs": 135.19800000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 469.5729999998548,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.883000000000003,
"layouts": 5,
"layoutDurationMs": 2.601,
"taskDurationMs": 138.22199999999998,
"heapDeltaBytes": 5196540,
"heapUsedBytes": 70812424,
"domNodes": 151,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.012,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 469.0469999998186,
"styleRecalcs": 21,
"styleRecalcDurationMs": 28.124000000000002,
"layouts": 5,
"layoutDurationMs": 2.157,
"taskDurationMs": 131.83999999999997,
"heapDeltaBytes": 5048844,
"heapUsedBytes": 67037760,
"domNodes": 148,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.873000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19433 +/- ##
=============================================
Coverage ? 80.64%
=============================================
Files ? 2220
Lines ? 118158
Branches ? 35781
=============================================
Hits ? 95289
Misses ? 22482
Partials ? 387
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 5 |
| 🟢 Low | 3 |
Panel: 8/8 reviewers contributed findings.
| useWorkspaceAuthStore() | ||
| .mintAtLogin() | ||
| .then((success) => { | ||
| if (!success) mintUnifiedToken.delete(uid) |
There was a problem hiding this comment.
🟠 High — useMemoize is only evicted on the fulfilled-false path, so a rejected mintAtLogin() (network error, thrown WorkspaceAuthError) stays cached under that uid for the rest of the session: awaitUnifiedMint swallows it via .catch(() => false) on every later call and the mint is never retried, and the fire-and-forget void mintUnifiedToken(user.uid) at sign-in surfaces the same rejection as an unhandled rejection. Add a .catch that deletes the entry (and reports through reportError()) before returning false. Raised by 8 of 8 reviewers (every panel cell).
| if (await awaitUnifiedMint()) return null | ||
| const token = useWorkspaceAuthStore().getUnifiedToken() | ||
| if (token) return { Authorization: `Bearer ${token}` } | ||
| return await getFirebaseAuthHeader() |
There was a problem hiding this comment.
🟠 High — This fallback applies to permanent authorization denials too — mintAtLogin() returns false for ACCESS_DENIED/WORKSPACE_NOT_FOUND, and the Firebase ID token carries user identity but none of the workspace scoping the Cloud JWT encodes. Cloud API traffic therefore keeps flowing after a server-side revocation, and requests issued while a team workspace is active can resolve against the personal workspace instead of failing closed. Restrict the fallback to transient mint failures. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial).
| */ | ||
| const awaitUnifiedMint = async (): Promise<boolean> => { | ||
| const uid = currentUser.value?.uid | ||
| if (uid) await mintUnifiedToken(uid).catch(() => false) |
There was a problem hiding this comment.
🟡 Medium — Because a falsy result evicts the memo entry there is no cooldown between attempts: getAuthHeader runs on every cloud fetchApi call and in the router guard, so while /auth/token is down or denying, each request starts a fresh mintAtLogin() and blocks on it (up to the 15s identity-settle ceiling), amplifying load against an already-failing endpoint. Cache the failure with a TTL/backoff rather than deleting it on every failure. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| */ | ||
| const getUnifiedAuthToken = async (): Promise<string | undefined> => { | ||
| if (await awaitUnifiedMint()) return undefined | ||
| return useWorkspaceAuthStore().getUnifiedToken() |
There was a problem hiding this comment.
🟡 Medium — getUnifiedAuthToken returns undefined on mint failure while getUnifiedAuthHeader falls back to Firebase, so a mint outage leaves the app half-authenticated: REST calls carry a Firebase bearer while the realtime socket and backend-node auth get nothing and treat the user as logged out. Either mirror the fallback here or document why the socket must fail closed while REST does not. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| let customerRecovery: Promise<void> | null = null | ||
| let customerRecoveryIdentity: string | null = null | ||
| const isFetchingBalance = ref(false) | ||
| const mintUnifiedToken = useMemoize((uid: string) => |
There was a problem hiding this comment.
🟡 Medium — The memo records "a mint succeeded once for this uid" and is only cleared on sign-out/identity change, not when the unified token is dropped without one (workspace switch that clears context then fails its re-mint, flag rollback, session teardown that does not reload). After any of those, awaitUnifiedMint short-circuits on the cached true, getUnifiedToken() returns nothing, and every request silently serves the Firebase fallback for the rest of the session. Clear the memo wherever the unified context is cleared. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| const token = useWorkspaceAuthStore().getUnifiedToken() | ||
| return token ? { Authorization: `Bearer ${token}` } : null | ||
| } | ||
| if (flags.unifiedCloudAuthEnabled) return getUnifiedAuthHeader() |
There was a problem hiding this comment.
🟡 Medium — getAuthHeader now awaits the mint with no deadline of its own, and it is awaited by router.beforeEach and every cloud fetchApi, so a wedged /auth/token stalls navigation and all API traffic instead of degrading. The same missing bound means a call started just before sign-out keeps waiting on the abandoned mint, since clear() drops the cache entry without settling the promise. Bound awaitUnifiedMint with a timeout and/or race it against an auth-state change. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).
| @@ -307,16 +338,23 @@ export const useAuthStore = defineStore('auth', () => { | |||
| return useWorkspaceAuthStore().ensureWorkspaceAuthHeader(activeWorkspaceId) | |||
There was a problem hiding this comment.
🟡 Medium — Only getAuthHeader/getAuthToken were taught to await the in-flight mint; getWorkspaceAuthHeader and getWorkspaceAuthToken still read useWorkspaceAuthStore().getUnifiedToken() synchronously on the unified branch, so a call landing in the login-mint window still returns null and getWorkspaceAuthHeaderOrThrow still throws userNotAuthenticated for a signed-in user — the exact race this PR fixes elsewhere. Route those two through awaitUnifiedMint as well. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
|
|
||
| if (user === null || identityChanged) { | ||
| useWorkspaceAuthStore().clearWorkspaceContext() | ||
| mintUnifiedToken.clear() |
There was a problem hiding this comment.
🟢 Low — The .then closure evicts by uid rather than by promise identity, so after sign-out and sign-in as the same user (or A→B→A), the abandoned first mint resolving false deletes the new entry for that uid, defeating the dedupe and firing a redundant mintAtLogin() against an already-valid session. Only delete when the cached entry is still the promise that callback created. Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case, kimi-k3-max edge-case).
| if (await awaitUnifiedMint()) return null | ||
| const token = useWorkspaceAuthStore().getUnifiedToken() | ||
| if (token) return { Authorization: `Bearer ${token}` } | ||
| return await getFirebaseAuthHeader() |
There was a problem hiding this comment.
🟢 Low — getFirebaseAuthHeader() calls getIdToken(), which opens a modal via useDialogService().showErrorDialog for any non-network FirebaseError. That path was unreachable from getAuthHeader under unified_cloud_auth before this change and is now taken by every request whose mint failed, so concurrent fetchApi calls can stack error dialogs on the user. Suppress or dedupe the dialog when reached through this fallback. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| with: | ||
| # The optional pnpm cache currently fails during runner cleanup on this PR. | ||
| # Lint and format verification do not depend on the cache. | ||
| node_cache: 'false' |
There was a problem hiding this comment.
🟢 Low — The comment scopes the cache cleanup failure to "this PR", but the override is permanent and unrelated to the auth fix, and every other setup-frontend caller still defaults node_cache to true and stays exposed to the same failure. Drop this workaround before merge or fix the underlying cleanup failure. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
ee9433b to
686d4fb
Compare
Backport of #15184 to
cloud/1.55Automatically created by backport workflow.