Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
272811e
fix(website): a running take says its own name, without a bar that ca…
mariana953 Sep 28, 2026
56e9c8d
fix(website): design pass on the Hub, from the team's feedback
mariana953 Sep 29, 2026
d38f69a
fix(website): a workflow card's name keeps to one line
mariana953 Sep 29, 2026
971f29a
fix(website): Re-shoot's empty preview says what it is waiting for
mariana953 Sep 29, 2026
093a7e9
test(website): pin what the design pass changed
mariana953 Sep 29, 2026
6606a06
Merge remote-tracking branch 'origin/mariana/hub-design-pass' into ma…
mariana953 Sep 29, 2026
f5aaf21
test(website): start the take's clock when the test renders it
mariana953 Sep 29, 2026
e7ae97e
feat(website): the nav calls the catalogue the Hub
mariana953 Sep 29, 2026
beb4089
fix(website): bring the stray node back into the remove-object graph
mariana953 Sep 29, 2026
a6eb474
test(website): keep the full workflow name within reach
mariana953 Sep 29, 2026
032709d
fix(website): the running take says out loud that it is rendering
mariana953 Sep 29, 2026
ddeb017
test(website): cover the shelf filter and the example dialog in the b…
mariana953 Sep 29, 2026
ba1e53e
Merge remote-tracking branch 'origin/main' into mariana/hub-design-pass
mariana953 Sep 29, 2026
62964cf
fix(website): a hovered workflow card shows the whole name
mariana953 Sep 29, 2026
3d971ba
test(website): follow the Hub name through the menu and the screenshots
mariana953 Sep 29, 2026
4211eb1
test(website): name the example dialog's two answers
mariana953 Sep 29, 2026
ba362f0
test(website): the card opens its name for the keyboard too
mariana953 Sep 29, 2026
d929582
fix(website): example prompts name what the form shows
mariana953 Sep 29, 2026
9aadeef
fix(website): the prompt box grows to the prompt it holds
mariana953 Sep 29, 2026
4331e60
Merge branch 'mariana/prompt-box-fits-text' into mariana/workflow-cop…
mariana953 Sep 29, 2026
13d4d10
fix(website): the workflow examples read and mark themselves like a m…
mariana953 Sep 29, 2026
790ae27
refactor(website): the workflow example card is its own component
mariana953 Sep 29, 2026
1ba2bcb
fix(website): the prompt box refits when the layout narrows under it
mariana953 Sep 29, 2026
38ca211
test(website): the workflow example card marks the chosen example
mariana953 Sep 29, 2026
880f692
fix(website): a catalogue card opens its whole name on hover
mariana953 Sep 29, 2026
7889072
feat(website): a removed upload offers itself back
mariana953 Sep 29, 2026
b33b5da
Revert "fix(website): a catalogue card opens its whole name on hover"
mariana953 Sep 29, 2026
613ab68
fix(website): the workflow graph opens where it can be read
mariana953 Sep 29, 2026
bf49d5f
fix(website): the prompt box stops short of swallowing the window
mariana953 Sep 29, 2026
12d71a2
refactor(website): where the graph opens is a function, with tests
mariana953 Sep 29, 2026
836e2b8
fix(website): a card name drops what its task pill already says
mariana953 Sep 29, 2026
bc13586
fix(website): the catalogue tab marker takes the canvas grey
mariana953 Sep 29, 2026
bd39e25
feat(website): one heading shape for the details and API sections
mariana953 Sep 29, 2026
4acf3de
feat(website): keep apps out of the catalogue banner
mariana953 Sep 28, 2026
288ec92
[automated] Apply ESLint and Oxfmt fixes
actions-user Sep 29, 2026
4b8e9eb
fix(website): the workflow page stops repeating itself and the banner…
mariana953 Sep 29, 2026
77373e4
refactor(website): the banner dots and the graph controls move out
mariana953 Sep 29, 2026
bc970e4
fix(website): the example says it once, and the shot options get room
mariana953 Sep 29, 2026
e2ee7fc
fix(website): the workflow API panel keeps its conditions with its facts
mariana953 Sep 29, 2026
c9750f8
merge mariana/cinematic-take-label-and-bar into the preview stack
mariana953 Sep 29, 2026
221ac79
merge mariana/hub-design-pass into the preview stack
mariana953 Sep 29, 2026
0cd0d2f
merge mariana/hub-nav-name into the preview stack
mariana953 Sep 29, 2026
ca29153
merge mariana/workflow-copy-fixes into the preview stack
mariana953 Sep 29, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions apps/website/e2e/header-models-navigation.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ async function expectNoHorizontalOverflow(page: Page) {
}

for (const viewport of viewports) {
test(`enabled Models navigation fits at ${viewport.name}`, async ({
page
}) => {
test(`enabled Hub navigation fits at ${viewport.name}`, async ({ page }) => {
await page.setViewportSize({ width: viewport.width, height: 900 })
await page.goto('/')

Expand All @@ -36,7 +34,7 @@ for (const viewport of viewports) {
if (viewport.desktopNavigation) {
await expect(desktopLinks).toBeVisible()
await expect(
desktopLinks.getByRole('link', { name: 'Models', exact: true })
desktopLinks.getByRole('link', { name: 'Hub', exact: true })
).toHaveAttribute('href', '/models')
await expect(menuButton).toBeHidden()
} else {
Expand All @@ -45,9 +43,10 @@ for (const viewport of viewports) {
await menuButton.click()
const menu = page.getByRole('dialog', { name: 'Menu' })
await expect(menu).toBeVisible()
await expect(
menu.getByRole('link', { name: /^Models\b/ })
).toHaveAttribute('href', '/models')
await expect(menu.getByRole('link', { name: /^Hub\b/ })).toHaveAttribute(
'href',
'/models'
)
}

await expectNoHorizontalOverflow(page)
Expand Down
58 changes: 58 additions & 0 deletions apps/website/e2e/homepage.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -278,3 +278,61 @@ test.describe('Get started section links @smoke', () => {
)
})
})

test.describe('Model discovery row @interaction', () => {
test('a hovered or focused workflow card gives its whole name', async ({
page,
context
}) => {
await context.route('**/t.comfy.org/**', (route) =>
/\/(flags|decide)\//.test(route.request().url())
? route.fulfill({
json: {
featureFlags: {
'workshop-enabled': true,
'workshop-workflows-enabled': true
},
featureFlagPayloads: {}
}
})
: route.abort('blockedbyclient')
)
await page.goto('/')
await page
.getByTestId('catalogue-tabs')
.getByRole('button', { name: 'Workflows' })
.click()
const cards = page.getByTestId('discovery-workflow')
await expect(cards.first()).toBeAttached()
await page.addStyleTag({
content:
'[data-testid="discovery-marquee"] { animation: none !important }'
})

const cut = await cards.evaluateAll((elements) =>
elements.findIndex((element) => {
const name = element.querySelector('span[title]')
const box = element.getBoundingClientRect()
return (
name !== null &&
name.scrollWidth > name.clientWidth + 1 &&
box.x > 0 &&
box.right < window.innerWidth
)
})
)
expect(cut).toBeGreaterThan(-1)

const card = cards.nth(cut)
const name = card.locator('span[title]')
const overflow = () =>
name.evaluate((element) => element.scrollWidth - element.clientWidth)
await card.hover()
await expect.poll(overflow).toBeLessThanOrEqual(1)

await page.mouse.move(0, 0)
await expect.poll(overflow).toBeGreaterThan(1)
await card.focus()
await expect.poll(overflow).toBeLessThanOrEqual(1)
})
})
8 changes: 4 additions & 4 deletions apps/website/e2e/navigation.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const minimaxRoute = '/minimax-h3'
const minimaxRouteZh = '/zh-CN/minimax-h3'

const TOP_LEVEL_LABELS = [
'Models',
'Hub',
'Products',
'Pricing',
'Community',
Expand Down Expand Up @@ -113,7 +113,7 @@ test.describe('Desktop navigation @smoke', () => {

await expect(
desktopLinks
.getByRole('link', { name: 'Models' })
.getByRole('link', { name: 'Hub' })
.getByText('NEW', { exact: true })
).toBeVisible()
for (const label of ['Products', 'Community']) {
Expand Down Expand Up @@ -326,7 +326,7 @@ test.describe('Mobile menu @mobile', () => {
const menu = page.getByRole('dialog')
await expect(menu).toBeVisible()

for (const label of ['Models', 'Products', 'Pricing', 'Community']) {
for (const label of ['Hub', 'Products', 'Pricing', 'Community']) {
await expect(menu.getByText(label, { exact: true }).first()).toBeVisible()
}
})
Expand All @@ -339,7 +339,7 @@ test.describe('Mobile menu @mobile', () => {
const menu = page.getByRole('dialog')

await expect(
menu.getByRole('link', { name: 'Models' }).getByText('NEW', {
menu.getByRole('link', { name: 'Hub' }).getByText('NEW', {
exact: true
})
).toBeVisible()
Expand Down
2 changes: 1 addition & 1 deletion apps/website/e2e/visual-responsive.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ async function navigateAndSettle(page: Page, url: string) {
await expect(
page
.getByTestId('desktop-nav-links')
.getByRole('link', { name: 'Models', includeHidden: true })
.getByRole('link', { name: 'Hub', includeHidden: true })
).toBeAttached()
await waitForPpFormulaLight(page)
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion apps/website/e2e/workshop-visibility.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ test('keeps the public site when PostHog is unavailable', async ({ page }) => {
})
await page.goto('/')
await expect(
page.getByRole('link', { name: 'Models', exact: true })
page.getByRole('link', { name: 'Hub', exact: true })
).toHaveCount(0)
await expect(page.getByTestId('model-discovery')).toHaveCount(0)
await expect(
Expand Down
49 changes: 36 additions & 13 deletions apps/website/e2e/workshop-workflows.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ test('workflow launch groups lead to the existing shared form', async ({
await page.getByTestId('sort-name').click()
await expect(
page.getByTestId('workflow-search-results').getByRole('link').first()
).toHaveAttribute('href', '/models/workflows/animate-reference-sheet/')
).toHaveAttribute('href', '/models/workflows/connect-images-with-motion/')
await page.getByTestId('section-back').click()
await expect(page.getByTestId('workshop-hero')).toBeVisible()
await page.getByTestId('workshop-search').fill('Change a material')
Expand All @@ -103,7 +103,7 @@ test('workflow launch groups lead to the existing shared form', async ({
).toBeVisible()
const prompt = page.getByRole('textbox', { name: 'What should change?' })
await expect(prompt).toHaveValue(
'Change the furniture leather difference in image 1 to the fur material in image 2.'
'Give the sofa the fur texture from the material reference instead of its leather.'
)
await prompt.fill('Use the material from the second image.')
await page
Expand Down Expand Up @@ -177,24 +177,29 @@ test('the Details graph waits for its tab, names its subgraphs, and zooms from i
expect(graphRequests).toHaveLength(1)
await expect(drawing).toContainText('Image to Video (LTX-2.3)')

// Fitting the whole drawing into the panel renders its titles at a few
// pixels, so it opens zoomed onto the node the workflow starts from.
const zoom = () =>
graph
.getByText('%')
.evaluate((el) => Number(el.textContent.replace('%', '')))
const opening = await zoom()
expect(opening).toBeGreaterThan(100)

// The controls sit inside the draggable frame; a press on them has to reach
// them rather than the frame.
await graph.getByRole('button', { name: 'Zoom in' }).click()
await expect(graph).toContainText('120%')
await expect.poll(zoom).toBeGreaterThan(opening)
const frame = await graph.boundingBox()
const drawn = await drawing.locator('g').first().boundingBox()
const centre = {
x: drawn!.x + drawn!.width / 2,
y: drawn!.y + drawn!.height / 2
}
// Zooming keeps the drawing where it was rather than carrying it off-frame.
expect(centre.x).toBeGreaterThan(frame!.x)
expect(centre.x).toBeLessThan(frame!.x + frame!.width)
expect(centre.y).toBeGreaterThan(frame!.y)
expect(centre.y).toBeLessThan(frame!.y + frame!.height)
// Zooming keeps the drawing under the frame rather than carrying it off.
expect(drawn!.x).toBeLessThan(frame!.x + frame!.width)
expect(drawn!.x + drawn!.width).toBeGreaterThan(frame!.x)
expect(drawn!.y).toBeLessThan(frame!.y + frame!.height)
expect(drawn!.y + drawn!.height).toBeGreaterThan(frame!.y)

await graph.getByRole('button', { name: 'Reset' }).click()
await expect(graph).toContainText('100%')
await expect.poll(zoom).toBe(opening)
})

test('withholds workflow discovery and direct pages when the workflow flag is off', async ({
Expand Down Expand Up @@ -513,3 +518,21 @@ test('keeps the workflow form inside a phone screen @mobile', async ({
const box = await footer.boundingBox()
expect((box?.x ?? 0) + (box?.width ?? 0)).toBeLessThanOrEqual(viewportWidth)
})

test('the examples below the form read and mark themselves like a model page', async ({
page,
context
}) => {
await mockWorkflowVisibility(context, true)
await page.goto('/models/workflows/change-material/')

await expect(
page.getByRole('heading', { name: 'Try an example' })
).toBeVisible()

const example = page.getByRole('button', {
name: /A softer finish for a leather sofa/
})
await expect(example).toHaveAttribute('aria-current', 'true')
await expect(page.getByTestId('workflow-example-chosen')).toHaveCount(1)
})
83 changes: 82 additions & 1 deletion apps/website/e2e/workshop.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,21 @@ test.describe('Models catalog', () => {
await expect(page.getByTestId('workshop-sections')).toBeVisible()
})

test('an opened shelf reads as a chosen filter', async ({ page }) => {
await page.goto('/models/')
await page.getByTestId('section-generate-videos-open').click()
await expect(page.getByRole('heading', { level: 1 })).toContainText(
'Generate videos'
)
await expect(page.getByTestId('workshop-filter-count')).toHaveText('1')
await page.getByTestId('workshop-filter').click()
await expect(page.getByTestId('workshop-filter-applied')).toHaveText(
'1 selected'
)
await page.getByTestId('workshop-filter-clear').click()
await expect(page.getByTestId('workshop-sections')).toBeVisible()
})

test('a model page returns to the shelf it was opened from', async ({
page
}) => {
Expand Down Expand Up @@ -531,6 +546,65 @@ test.describe('Models catalog', () => {
})

test.describe('Model playground', () => {
test('keeps a long prompt whole instead of scrolling it out of sight', async ({
page
}) => {
await page.goto(MODEL_PATH)
const prompt = page.getByTestId('field-prompt')
const hidden = () =>
prompt.evaluate((box) => box.scrollHeight - box.clientHeight)
const height = () => prompt.evaluate((box) => box.clientHeight)

await prompt.fill(
Array.from({ length: 12 }, (_, line) => `Line ${line + 1}.`).join('\n')
)
await expect.poll(hidden).toBeLessThanOrEqual(1)
const tall = await height()

await prompt.fill('One line.')
await expect.poll(height).toBeLessThan(tall)
await expect.poll(hidden).toBeLessThanOrEqual(1)
})

test('keeps a long prompt whole when the layout narrows under it', async ({
page
}) => {
await page.goto(MODEL_PATH)
const prompt = page.getByTestId('field-prompt')
const hidden = () =>
prompt.evaluate((box) => box.scrollHeight - box.clientHeight)

await prompt.fill(
'A slow push-in on a glass teapot lit from behind by a low winter sun, steam rising and catching the light while the room around it stays in shadow, the reflections on the table kept sharp and the background soft, with no people, no text and no logos anywhere in the frame.'
)
await expect.poll(hidden).toBeLessThanOrEqual(1)

await page.setViewportSize({ width: 380, height: 900 })

await expect.poll(hidden).toBeLessThanOrEqual(1)
})

test('stops the prompt box short of swallowing the window', async ({
page
}) => {
await page.setViewportSize({ width: 1280, height: 800 })
await page.goto(MODEL_PATH)
const prompt = page.getByTestId('field-prompt')

await prompt.fill(
Array.from({ length: 60 }, (_, line) => `Line ${line + 1}.`).join('\n')
)

// A prompt this long would bury the rest of the form, so the box keeps a
// share of the window and scrolls what is left.
await expect
.poll(() => prompt.evaluate((box) => box.clientHeight))
.toBeLessThan(800)
await expect
.poll(() => prompt.evaluate((box) => box.scrollHeight - box.clientHeight))
.toBeGreaterThan(1)
})

test('puts data-declared parameters in the Advanced disclosure', async ({
page
}) => {
Expand Down Expand Up @@ -593,7 +667,7 @@ test.describe('Model playground', () => {

await page
.getByRole('navigation', { name: 'Main navigation', exact: true })
.getByRole('link', { name: 'Models', exact: true })
.getByRole('link', { name: 'Hub', exact: true })
.click()
await page.getByTestId('workshop-search').fill('Seedream 4.5 Image Edit')
await page.getByRole('link', { name: /Seedream 4\.5 Image Edit/ }).click()
Expand Down Expand Up @@ -711,6 +785,13 @@ test.describe('Model playground', () => {
await prompt.fill('')

await page.getByTestId('example-card').first().click()
const dialog = page.getByTestId('example-replace-dialog')
await expect(dialog.getByRole('heading')).toHaveText('Load this example?')
await expect(dialog.getByRole('button')).toHaveCount(2)
await expect(dialog.getByRole('button', { name: 'Cancel' })).toBeVisible()
await expect(
dialog.getByRole('button', { name: 'Load example' })
).toBeVisible()
await page.getByTestId('example-replace-keep').click()

await expect(page.getByTestId('example-replace-dialog')).toHaveCount(0)
Expand Down
2 changes: 1 addition & 1 deletion apps/website/public/workflow-graphs/remove-object.json
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
"id": 16,
"type": "LoadImageMask",
"title": "Edit mask (white = edit)",
"pos": [300, 600],
"pos": [-2900, 5390],
"size": [300, 310],
"flags": {},
"order": 0,
Expand Down
2 changes: 1 addition & 1 deletion apps/website/public/workflow-graphs/remove-object.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading