Repository navigation
test(agent): prove persisted approvals recover on refresh - #19340
Conversation
Addresses review feedback: #18952 (comment)
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe browser test suite now covers approval recovery after a page reload. It uses a shared run-approval button locator and verifies that the resolved event hides the button while preserving the recorded answer. ChangesAgent approval recovery
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: 🔵 Low · up to The refresh test exercises recovery and answer submission; the remaining concern is the unchanged spec filename despite the repository’s rename-on-scope-change rule. This is a localized, low-impact issue; rename the file before merge. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9fa2eb037fb1c0e2b51d7b90f5fab119cb63d33f
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2160 passed, 0 failed📊 Browser Reports
📦 Bundle: 10 MB gzip 🟢 -1 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 133 kB (baseline 133 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 643 kB (baseline 643 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 4.07 MB (baseline 4.07 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 15 unchanged Utilities & Hooks — 582 kB (baseline 582 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 299 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T00:29:10.853Z",
"gitSha": "df14b57104c11a89c6f5d96b78f9ff44f299f6c2",
"branch": "test/agent-approval-refresh-recovery",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2091.24700000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.267,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.139,
"heapDeltaBytes": -31574996,
"heapUsedBytes": 66840452,
"domNodes": -228,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.846,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665599999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.626999999933,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.349,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.727,
"heapDeltaBytes": -21948428,
"heapUsedBytes": 76608856,
"domNodes": -228,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 9.094999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.953000000005,
"styleRecalcs": 80,
"styleRecalcDurationMs": 18.667,
"layouts": 12,
"layoutDurationMs": 4.676,
"taskDurationMs": 849.2839999999999,
"heapDeltaBytes": -38220892,
"heapUsedBytes": 60127692,
"domNodes": -228,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 168.648,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1895.0079999999616,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.783,
"layouts": 12,
"layoutDurationMs": 4.469,
"taskDurationMs": 870.769,
"heapDeltaBytes": -20786864,
"heapUsedBytes": 77848292,
"domNodes": -228,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 176.53199999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.8141592920354,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.2420000000375,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.25,
"layouts": 6,
"layoutDurationMs": 1.1039999999999999,
"taskDurationMs": 329.052,
"heapDeltaBytes": -19065688,
"heapUsedBytes": 78542908,
"domNodes": 53,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.643999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.9439999999368,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.336,
"layouts": 6,
"layoutDurationMs": 1.075,
"taskDurationMs": 327.5,
"heapDeltaBytes": -18895632,
"heapUsedBytes": 79486340,
"domNodes": 53,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.623000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 728.6310000000071,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.9170000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.17800000000005,
"heapDeltaBytes": -1926804,
"heapUsedBytes": 96958720,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 173.993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 707.6660000000174,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.215,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.96599999999995,
"heapDeltaBytes": 18346336,
"heapUsedBytes": 97274856,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 167.723,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1159.866999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 830.065,
"heapDeltaBytes": 9498488,
"heapUsedBytes": 86704868,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 72.635,
"eventListeners": 0,
"totalBlockingTimeMs": 556,
"frameDurationMs": 35.34848484848485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1175.6699999999682,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 823.023,
"heapDeltaBytes": 9772224,
"heapUsedBytes": 85277892,
"domNodes": 0,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 70.612,
"eventListeners": 0,
"totalBlockingTimeMs": 548,
"frameDurationMs": 34.80588235294119,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 880.6020000000103,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.1939999999999,
"heapDeltaBytes": 15965688,
"heapUsedBytes": 89319220,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 167.63,
"eventListeners": 0,
"totalBlockingTimeMs": 237,
"frameDurationMs": 25.23999999999999,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.1119999999773,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.9009999999998,
"heapDeltaBytes": 14301788,
"heapUsedBytes": 92902632,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 156.873,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.757142857142856,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11138.184999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10165.74,
"heapDeltaBytes": 1815848,
"heapUsedBytes": 83185636,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 8466.078,
"eventListeners": 0,
"totalBlockingTimeMs": 1459,
"frameDurationMs": 33.53253012048193,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11391.246000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10384.439,
"heapDeltaBytes": -9292756,
"heapUsedBytes": 71116428,
"domNodes": 0,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 8688.962,
"eventListeners": 0,
"totalBlockingTimeMs": 1694,
"frameDurationMs": 33.67721893491124,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11081.519000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10148.783,
"heapDeltaBytes": 2167420,
"heapUsedBytes": 83558188,
"domNodes": 0,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 8502.114,
"eventListeners": 0,
"totalBlockingTimeMs": 1662,
"frameDurationMs": 34.47445482866044,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10379.403000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9443.246000000001,
"heapDeltaBytes": 8168576,
"heapUsedBytes": 90056992,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 7823.35,
"eventListeners": 0,
"totalBlockingTimeMs": 1107,
"frameDurationMs": 31.896307692307694,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2059.024000000022,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.4579999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.646,
"heapDeltaBytes": -36079980,
"heapUsedBytes": 82760716,
"domNodes": -228,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 38.36400000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.801626016260165,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2059.9399999999832,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0589999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.882,
"heapDeltaBytes": -35767316,
"heapUsedBytes": 82523300,
"domNodes": -228,
"jsHeapTotalBytes": -98304,
"scriptDurationMs": 38.396000000000015,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2508.43500000002,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.406999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1642.7880000000002,
"heapDeltaBytes": 27043116,
"heapUsedBytes": 90353592,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 877.762,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.777852348993292,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2426.2959999999794,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.871,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1637.855,
"heapDeltaBytes": 24034892,
"heapUsedBytes": 87908588,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 883.148,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78194444444445,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3618.3469999999716,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.297999999999998,
"layouts": 60,
"layoutDurationMs": 13.866999999999999,
"taskDurationMs": 1648.084,
"heapDeltaBytes": 9600892,
"heapUsedBytes": 74019652,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 792.679,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3589.484999999968,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.713000000000001,
"layouts": 60,
"layoutDurationMs": 13.531999999999998,
"taskDurationMs": 1673.0969999999998,
"heapDeltaBytes": 8564984,
"heapUsedBytes": 73701384,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 794.507,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3128.39299999996,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.422,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1881.3270000000002,
"heapDeltaBytes": 27316480,
"heapUsedBytes": 92582484,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 983.2010000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75537634408602,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3108.253999999988,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.955000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1866.9850000000001,
"heapDeltaBytes": 21694644,
"heapUsedBytes": 85841992,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 968.681,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756756756756758,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2014.9089999999887,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.5390000000000033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.128,
"heapDeltaBytes": 20620896,
"heapUsedBytes": 84647532,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.956999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.513999999992,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.172999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.3589999999999,
"heapDeltaBytes": -36868060,
"heapUsedBytes": 84178452,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 31.319,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 627.7690000000007,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.794,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.563,
"heapDeltaBytes": 13310296,
"heapUsedBytes": 93940044,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 149.142,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 620.0319999999238,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.4110000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.196,
"heapDeltaBytes": 12737988,
"heapUsedBytes": 93570744,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 143.687,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2054.6830000000114,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.281999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.18399999999997,
"heapDeltaBytes": -11083364,
"heapUsedBytes": 69510140,
"domNodes": -244,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.586000000000002,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2035.4150000000573,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.228000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.63000000000005,
"heapDeltaBytes": -19555544,
"heapUsedBytes": 60682876,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.188,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1775.6390000000124,
"styleRecalcs": 72,
"styleRecalcDurationMs": 17.995,
"layouts": 16,
"layoutDurationMs": 5.999,
"taskDurationMs": 800.824,
"heapDeltaBytes": -27091868,
"heapUsedBytes": 53860376,
"domNodes": -244,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 117.77000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1760.185999999976,
"styleRecalcs": 80,
"styleRecalcDurationMs": 21.46,
"layouts": 16,
"layoutDurationMs": 5.311,
"taskDurationMs": 806.6,
"heapDeltaBytes": -16371692,
"heapUsedBytes": 64403324,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 114.352,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.7570000000514,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.355000000000008,
"layouts": 5,
"layoutDurationMs": 13.040000000000003,
"taskDurationMs": 897.3220000000002,
"heapDeltaBytes": 23210232,
"heapUsedBytes": 104611284,
"domNodes": 13667,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.552999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 143,
"frameDurationMs": 19.368918918918908,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8825.422000000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 32.218999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5926.485,
"heapDeltaBytes": -34478784,
"heapUsedBytes": 85237700,
"domNodes": -228,
"jsHeapTotalBytes": 94208,
"scriptDurationMs": 2949.319,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69772727272727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8679.040999999983,
"styleRecalcs": 248,
"styleRecalcDurationMs": 31.817999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5871.343,
"heapDeltaBytes": -34227176,
"heapUsedBytes": 85025008,
"domNodes": -228,
"jsHeapTotalBytes": 94208,
"scriptDurationMs": 2909.093,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6980732177264,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12491.070000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11617.724,
"heapDeltaBytes": -31357012,
"heapUsedBytes": 193691620,
"domNodes": -3045,
"jsHeapTotalBytes": 12812288,
"scriptDurationMs": 208.128,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.909380234505864,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 16809.055999999942,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16241.363,
"heapDeltaBytes": -88346724,
"heapUsedBytes": 163648588,
"domNodes": -8049,
"jsHeapTotalBytes": -24535040,
"scriptDurationMs": 261.76899999999995,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.549645390070914,
"p95FrameDurationMs": 66.5
},
{
"name": "vue-large-graph-pan",
"durationMs": 20973.153000000024,
"styleRecalcs": 165,
"styleRecalcDurationMs": 17.21199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20618.771,
"heapDeltaBytes": -62372444,
"heapUsedBytes": 166671784,
"domNodes": -3045,
"jsHeapTotalBytes": 3133440,
"scriptDurationMs": 960.065,
"eventListeners": -14915,
"totalBlockingTimeMs": 31,
"frameDurationMs": 38.75378927911275,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 20954.94800000006,
"styleRecalcs": 172,
"styleRecalcDurationMs": 17.647000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20613.922,
"heapDeltaBytes": -20608756,
"heapUsedBytes": 179907152,
"domNodes": -3046,
"jsHeapTotalBytes": 7704576,
"scriptDurationMs": 934.9690000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 74,
"frameDurationMs": 37.678237410071944,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6061.000999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.22200000000002,
"layouts": 20,
"layoutDurationMs": 22.942000000000004,
"taskDurationMs": 5963.019,
"heapDeltaBytes": -5071024,
"heapUsedBytes": 219955664,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 121.12999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 422,
"frameDurationMs": 35.68529411764706,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6021.804000000088,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.83200000000002,
"layouts": 20,
"layoutDurationMs": 22.90500000000001,
"taskDurationMs": 5918.098000000001,
"heapDeltaBytes": 14397940,
"heapUsedBytes": 218672636,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.42500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 425,
"frameDurationMs": 35.076744186046504,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8590.791000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8227.37,
"heapDeltaBytes": -37494400,
"heapUsedBytes": 177069084,
"domNodes": -3046,
"jsHeapTotalBytes": 6873088,
"scriptDurationMs": 135.44600000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.49484536082474,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6526.816999999937,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6060.276999999999,
"heapDeltaBytes": -12474048,
"heapUsedBytes": 193095908,
"domNodes": -3045,
"jsHeapTotalBytes": 12369920,
"scriptDurationMs": 108.91499999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.505940594059403,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 150.15700000003562,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.238,
"layouts": 3,
"layoutDurationMs": 1.95,
"taskDurationMs": 102.61799999999998,
"heapDeltaBytes": -16585532,
"heapUsedBytes": 80243656,
"domNodes": 117,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 10.011,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.737500000000068,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 127.67599999995127,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.118999999999998,
"layouts": 4,
"layoutDurationMs": 2.186,
"taskDurationMs": 94.90899999999999,
"heapDeltaBytes": -16521640,
"heapUsedBytes": 80102392,
"domNodes": 119,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.987,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65714285714278,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 861.8050000000039,
"styleRecalcs": 78,
"styleRecalcDurationMs": 107.82,
"layouts": 76,
"layoutDurationMs": 21.769000000000002,
"taskDurationMs": 830.376,
"heapDeltaBytes": 17303248,
"heapUsedBytes": 89165892,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 337.174,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 874.1610000000719,
"styleRecalcs": 78,
"styleRecalcDurationMs": 104.029,
"layouts": 76,
"layoutDurationMs": 21.515,
"taskDurationMs": 839.5590000000001,
"heapDeltaBytes": 17720956,
"heapUsedBytes": 89516808,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 345.46,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1383.2479999999805,
"styleRecalcs": 78,
"styleRecalcDurationMs": 246.26999999999998,
"layouts": 76,
"layoutDurationMs": 24.874,
"taskDurationMs": 1357.9920000000002,
"heapDeltaBytes": 8220164,
"heapUsedBytes": 115122132,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 454.67,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.72151898734177,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1428.2100000000355,
"styleRecalcs": 78,
"styleRecalcDurationMs": 261.184,
"layouts": 76,
"layoutDurationMs": 26.289,
"taskDurationMs": 1411.002,
"heapDeltaBytes": -18530052,
"heapUsedBytes": 111325720,
"domNodes": 76,
"jsHeapTotalBytes": 6324224,
"scriptDurationMs": 489.72499999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.375641025641016,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19340 +/- ##
==========================================
+ Coverage 84.24% 85.03% +0.78%
==========================================
Files 3236 2340 -896
Lines 157143 133849 -23294
Branches 42623 34460 -8163
==========================================
- Hits 132387 113816 -18571
+ Misses 23052 19668 -3384
+ Partials 1704 365 -1339
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 2 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: request changes. The toBeHidden added in d35048e (spec:143-148) waits for a state this fixture never produces, so the refresh case cannot go green as written.
After a successful answer POST, useAgentSession.answerAsk keeps the ask busy on purpose ("Keep the actions disabled until the canonical resolution frame arrives", useAgentSession.ts:757-760). The run-approval part leaves the message only when an agent_ask_resolved frame arrives (agentEventTransport.ts:358-364) or on the 409 path. TurnLockServer records the answer and returns 200, and nothing pushes the resolved frame, so the Run button stays mounted and disabled. disabled:opacity-50 still counts as visible to Playwright, and the assertion times out after 10s. The unit test "answers a run approval once and stays busy until its resolution event" (useAgentSession.test.ts:520-548, passing at this head) pins the same contract, and agentRunApprovalConsent.spec.ts pushes an explicit askResolved frame before it expects the card to go away. The cloud Playwright shards for d35048e were still running when I checked, so I have no runtime result either way; the verdict rests on that trace.
Everything before that line holds up. startTurn() stores the thread id in localStorage, the reload reads it and GETs /messages, the streaming assistant row with pending_ask restores both the card and activeTurnId in agentConversationStore.hydrate(), and the answer route checks the exact thread, ask id, and option before it records the answer. Break any of those links and the test goes red, so it pins the asymmetry benjcooley asked for in r4128112069. Deleting postAnswer is safe; nothing referenced it.
Pre-merge blockers:
- P1. spec:143-148,
toBeHidden()cannot pass without anagent_ask_resolvedframe (inline comment has the fix).
Findings without an anchorable line (2)
- P3.
browser_tests/fixtures/agentTurnLockFixture.ts:124-127. TheTurnLockServerdocblock still says "transcript()and the cancel route are not reached by the current specs." The new case reloads (spec:122), and the GET route at fixture:218-220 callstranscript(), so the refresh test now depends on it. Only the cancel-route half is still true. I'd reword it to say transcript hydration backs the refresh case and only the cancel route is kept for fidelity. These lines are outside the diff hunk, so the comment lives here. - P3. PR description. AGENTS.md asks PRs to follow
.github/pull_request_template.md. The body keepsSummarybut swaps the template'sChangesandReview Focussections forValidation. Moving the three bullets underChangesand naming refresh hydration as the review focus would match the template; the validation notes can stay.
Existing findings confirmed or contested (2)
- Cursor panel, r4129664617 (spec:129, default timeout after reload). Confirmed, and addressed in
4af7b72.useAgentSession.start()fireshydrateFromServerwithvoid(useAgentSession.ts:284-298), so gate settlement and panel visibility do not mean the transcript has rendered. The 30s budget on the question assertion now matchesagentChatRefreshPersistence.spec.ts:112-115. - Cursor panel, r4129664621 (spec:138, tautological check). Confirmed:
recordAnswer()appended the answer and clearedpendingAskin one synchronous call (fixture:163-166), so the old line could not fail.f3f3df5removed it. The replacement ind35048eis the P1 above. Once a resolved frame is pushed, the finalansweredAsks()equality is worth keeping, because it checks one HTTP answer across the whole UI lifecycle, which the fake-rest unit test cannot see.
Checked and cleared (3)
- Delete
pendingAskIsPrimed()and thetoBe(false)checks at spec:57, 77, 101. Rejected: this diff leaves those lines alone, and they guard the #18952 decision to move priming out ofpush(). WithprimePendingAsknow called, the value is no longer constant across the file. - "hosted browser CI is required" overstates it, since
pnpm container:startruns a local backend. Rejected: the same sentence limits the claim to "this runner has no ComfyUI server on localhost:8188." - spec:149 duplicates the unit test's duplicate-refusal coverage. Rejected: see item 2 above.
Coverage
- Depth standard. Lanes at
e6405aa: correctness (blast-radius, regression-risk-reviewer, idempotency, shared state, boundary discipline, root causes), maintainability (ponytail, no-comments, reader load, subtract-first, laziness, migrate-then-delete), idiomaticity (typescript-best-practices, type-system discipline), tests (designing-test-suites, reviewing-playwright-specs, writing-playwright-tests, hardening-flaky-e2e-tests, test-mock-quality-analysis, consolidating-test-setup, prove-it-works), documentation (technical-writing, simplifying-technical-documents). The three follow-up commits got a dedicated tests and correctness pass atd35048e. No lane skipped. - Checks at
d35048e:pnpm typecheck:browserexit 0;eslint,oxlint, andoxfmt --checkon both files clean;playwright test --listshows the four cases;fallow auditreports no issues in the 2 changed files;pnpm test:unitonuseAgentSession.test.tspasses 95 (plus 2 expected failures). Ate6405aa,agentTranscript.test.tsandagentConversationStore.test.tspassed 92/92 and every GitHub check was green, including the four cloud Playwright shards. - Not run: the Playwright case itself, since I have no backend here. Runtime evidence for
d35048eis pending in CI.
This comment has been minimized.
This comment has been minimized.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve. 03a229a addresses every finding from my last review, including the P1, and I found nothing new.
The refresh case now pushes RUN_APPROVAL_RESOLVED_EVENT through the post-reload socket before it expects the Run button to disappear, so the test follows the product contract: the button stays busy after the 200 and clears only when the canonical resolution frame arrives. The author's mutation (drop the push and toBeHidden() fails with the disabled button still visible) matches my trace. For comparison, cloud shard 1/4 failed at d35048e, which had no push.
Checked and cleared this round (1)
turnLock.liveSocket()right after the reload could hand back the pre-reload route. Cleared: outside standalone mode, agent events arrive on the main/ws(AgentPanelRoot.vue:186-189), whichapi.init()opens during app setup (app.ts:939). That happens well before the gate settles, the transcript hydrates, and the answer POST returns. Even if the old route came back,ws.send()on a dead route throws, so the failure would be loud, not silent.
Review record
Round 1: review at d35048e, request changes.
- P1,
toBeHidden()could never pass without anagent_ask_resolvedframe (thread). Addressed in03a229a: the fixture exportsRUN_APPROVAL_RESOLVED_EVENTand the test pushes it beforetoBeHidden(). Author reply with mutation evidence: r4139593204. - P3, file header, describe title, and filename contradicted the refresh case (thread). Addressed in
03a229a: renamed toagentApprovalRecovery.spec.ts, describe isapproval ask recovery across socket drop and refresh, and the header states the asymmetry. No references to the old filename remain. Author reply: r4139592386. - P3 Nit,
pendingAskIsPrimed()check right after priming restated the helper (thread). Addressed in03a229a: line removed. Author reply: r4139592572. - P3 Nit, hard-coded
integrated-tab-bar-actionstest id (thread). Addressed in03a229a: usesTestIds.topbar.integratedTabBarActions. Author reply: r4139592723. - P3 Nit, run-approval button locator repeated five times (thread). Addressed in
03a229a:AgentTurnLockHarness.runApprovalButton, used by all four cases. Author reply: r4139592886. - P3 Nit, comment restating the final two assertions (thread). Addressed in
03a229a: comment deleted. Author reply: r4139593024. - P3,
TurnLockServerdocblock saidtranscript()was unreached (review body). Addressed in03a229a: it now says transcript hydration backs the refresh case and only the cancel route is unused. - P3, PR description did not follow the template (review body). Addressed: the description now uses Summary, Changes, and Review Focus.
- Cursor panel r4129664617, default timeout after reload. Confirmed in round 1, addressed in
4af7b72. - Cursor panel r4129664621, tautological
pendingAskIsPrimed()after the answer. Confirmed in round 1, removed inf3f3df5. Its replacement became the P1 above, now fixed. - Cleared in round 1 and unchanged: keep the
toBe(false)guards at the socket-drop cases (they still distinguish WebSocket delivery from transcript priming); the "hosted CI is required" wording (scoped to the author's runner, and since replaced); spec:149's one-answer check (it verifies one HTTP answer across the full UI lifecycle).
Checks at 03a229a: pnpm typecheck:browser exit 0; eslint, oxlint, and oxfmt --check on both files clean; playwright test --list shows all four cases under the new describe; fallow audit reports no issues in the 2 changed files. I did not run the Playwright case locally (no backend here). When I checked, GitHub CI for this head was still in progress and the Playwright shards had not reported.
Summary
Proves that a persisted run-approval ask rehydrates after refresh, can be answered through the UI, and reaches the server exactly once.
Changes
agent_ask_resolvedframe, centralizes the Run-button locator, and renames the spec for its socket-drop and refresh scope.Review Focus
pending_ask, retain the active turn identity needed to POST, stay busy after the 200 response, and clear only after the canonical resolution frame.Validation
pnpm typecheck:browserpnpm exec playwright test browser_tests/tests/agent/agentApprovalRecovery.spec.ts --project=cloud -g "a refresh restores" --workers=1— 1 passedRUN_APPROVAL_RESOLVED_EVENTmakestoBeHidden()fail with the disabled Run button still visible; restoring it returns the case to green.