Repository navigation
[backport core/1.55] fix(agent): report an approval ask the panel never delivered (#18952) - #19334
christian-byrne wants to merge 4 commits into
Conversation
A turn parked waiting for the user to approve a tool call, the approval
prompt never reached the panel, and nothing anywhere recorded it — so
this PR makes that drop report, and pins the user's journey as a spec.
- **What**: `reportError('failure_delivering_agent_approval_ask')` at
the two reachable sites where an `agent_ask` frame is discarded, plus
`browser_tests/tests/agent/agentApprovalSurvivesSocketDrop.spec.ts`
reproducing the reported flow through the real socket and the rendered
panel.
A user asked for an img2img workflow, then for img2video, and the panel
went dead. They restarted the agent tab to get out of it.
A session-id trace established that **the backend never hung.** The turn
was alive the whole time, parked waiting for the user to approve a tool
call, and the approval prompt never made it into the panel. That is the
worst shape a stall can take: the product is working and waiting on the
user, while the user sees a dead panel and no way to answer.
**There was no telemetry for it at all.** It reached us through a
feedback form, not a dashboard — and only because that one user happened
to paste a session id.
`useAgentSession.onStatus(false)` answers a transient websocket close
with `abortActiveTurn()` + `dropBackgroundTurns()`. The server never
learned the socket went away, so it keeps running the turn and then
emits `agent_ask` for the approval it is parked on. By then `transport`
is null and `backgroundTurns` is empty, so the frame reaches
`ingestBackgroundTurnEvent`, hits `if (!entry …) return`, and is gone.
Nothing errors.
It is specifically the *socket blip*, not a refresh. On a refresh the
ask comes back, because the persisted row carries `pending_ask` and
`normalizeAgentTranscript` rebuilds the card — which is why restarting
the tab "fixed" it for this user, and why this class only ever surfaces
through a form.
Two sites, tagged by `reason` so they split on the dashboard:
| `reason` | Site | Why it is the same user-visible outcome |
|---|---|---|
| `no-live-turn` | `ingestBackgroundTurnEvent`, `!entry` | The
socket-drop teardown left nothing to route the ask to. |
| `unknown-kind` | `handleAskEvent`, `kind !== 'run_approval'` | Renders
no card while the server still parks on the ask. |
The third `return` in `ingest` (`eventThreadId === undefined`) is
**unreachable for an ask** — `zAgentAskEvent` is
`zAgentPendingAsk.extend({ thread_id: z.string() })`, and
`agent_active_tab` is the only event with an optional `thread_id`,
handled above it. It is commented rather than instrumented, because a
report at a dead branch is noise that reads as coverage.
Deliberately **not** a `pushError`: the user cannot act on it, and a
notice would replace a silent stall with a stall plus a scary message.
This is for the dashboard.
**The spec's first two cases are `test.fail()` pins, on purpose.**
Fixing the delivery itself needs the turn to survive the blip, and that
is [#18152](#18152) —
on `main` there is no turn-recovery path at all. So this PR lands the
telemetry and the reproduction now, standing alone, and the pins flip
green when the delivery fix lands on top of #18152. Neither piece is
hostage to that stack.
The third case pushes the **same ask with no socket drop** and must stay
green. That is what stops the two pins from going vacuous on a renamed
locator, a gate, or reworded copy — without it, a card that never
renders under this fixture at all would look exactly like the defect.
Run against a cloud dev server plus the e2e ComfyUI container:
```
✘ 1 the approval card reaches the panel after a reconnect (expected)
✘ 2 the user can answer the ask that arrived after the reconnect (expected)
✓ 3 the same ask renders when the socket never drops
✓ 4 the fixture pushes an ask the client can parse
4 passed (33.4s)
```
Pin 1 fails for the stated reason, not an incidental one — with
`test.fail()` removed:
```
Error: expect(locator).toBeVisible() failed
Locator: locator('#agent-panel-root').getByText('Do you approve?')
Error: element(s) not found
```
- Store and transport unit suites: `392 passed (392)`.
- Agent subtree: `Test Files 137 passed (137)`, `Tests 2338 passed | 17
expected fail (2355)` (the expected fails are pre-existing).
- The four new store cases are **red on `main` production code** (`2
failed | 2 passed`), and the two that fail are the two reporting
assertions while both "stays quiet" guards pass — so they are not
tautological.
- `typecheck:app`, `typecheck:browser`, ESLint, type-aware Oxlint, Oxfmt
and Knip clean.
(cherry picked from commit 8223a93)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
Self-review under the standing release-backport grant at exact head 885dc1a3361fbddbab63b4466c03399e26a9c7c7: reviewed all seven files against source merge 8223a93de30cd630338924e923e2f6fe9bb9d6e6. The two conflict resolutions retain the core/1.55 transport/store structure and omit only unrelated main-only adjacent state (dropDraft, approval timing, and paywall-impression bookkeeping); all #18952 telemetry, bounded departed-turn ledger, dedupe, tests, fixture, and browser spec are present. Focused target-native tests pass 96/96. Removing reportedAskIds.add(data.ask_id) makes the dedupe test fail with two reports, and restoration is green with a clean tree. Browser fixture/spec are byte-identical to source; target harness startup was blocked by the shared backend devtools 404, so the current source browser receipt remains the acceptance evidence. No unresolved concern found; hosted exact-head checks and target-aware gate remain required before merge.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6c3a7ea63d14a02b74537801d8b88ae52580db53
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2123 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T06:59:07.533Z",
"gitSha": "e4b2bc914a2468052c9e52c8c1fb5b2e4b59cfe0",
"branch": "christian-byrne/backport-18952-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.5650000000232,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.905000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.06899999999996,
"heapDeltaBytes": 6140616,
"heapUsedBytes": 73774932,
"domNodes": -259,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.764,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2012.4979999999368,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.798,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.73699999999997,
"heapDeltaBytes": -4340400,
"heapUsedBytes": 63600120,
"domNodes": -258,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.216999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1764.00000000001,
"styleRecalcs": 44,
"styleRecalcDurationMs": 14.213000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 810.8149999999999,
"heapDeltaBytes": 10378208,
"heapUsedBytes": 77813004,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 144.87800000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.642000000007,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.469000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 682.252,
"heapDeltaBytes": 9559088,
"heapUsedBytes": 77400988,
"domNodes": -260,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 135.88799999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.8190000000013,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.213,
"layouts": 6,
"layoutDurationMs": 1.0910000000000002,
"taskDurationMs": 336.4549999999999,
"heapDeltaBytes": 3067640,
"heapUsedBytes": 71006232,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.382999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.1939999999731,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.131000000000002,
"layouts": 6,
"layoutDurationMs": 1.1450000000000002,
"taskDurationMs": 324.402,
"heapDeltaBytes": 3089208,
"heapUsedBytes": 70785276,
"domNodes": 80,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 12.135,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 678.594999999973,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.343000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.845,
"heapDeltaBytes": 19002120,
"heapUsedBytes": 86609788,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 152.242,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 632.8059999999596,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.896999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.203,
"heapDeltaBytes": 18820404,
"heapUsedBytes": 86532724,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 145.791,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1112.2460000000274,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 749.8890000000001,
"heapDeltaBytes": 38302228,
"heapUsedBytes": 107729152,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 58.599,
"eventListeners": 0,
"totalBlockingTimeMs": 498,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1132.3869999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 815.521,
"heapDeltaBytes": -16574772,
"heapUsedBytes": 73775492,
"domNodes": -293,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 57.16800000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 475,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 777.1060000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.0419999999999,
"heapDeltaBytes": 14769332,
"heapUsedBytes": 91589964,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.79500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 153,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 764.0140000000883,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.70500000000015,
"heapDeltaBytes": 15942828,
"heapUsedBytes": 91484892,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 123.676,
"eventListeners": 0,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9105.201999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8107.203,
"heapDeltaBytes": -11961552,
"heapUsedBytes": 70565880,
"domNodes": -16,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 6360.223,
"eventListeners": 0,
"totalBlockingTimeMs": 209,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8315.17800000006,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.8930000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7438.282,
"heapDeltaBytes": 15915232,
"heapUsedBytes": 92668100,
"domNodes": -267,
"jsHeapTotalBytes": 7593984,
"scriptDurationMs": 5974.245,
"eventListeners": -174,
"totalBlockingTimeMs": 125,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8872.027000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7789.708,
"heapDeltaBytes": -10871164,
"heapUsedBytes": 71055820,
"domNodes": -14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6039.831,
"eventListeners": 0,
"totalBlockingTimeMs": 97,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8560.44499999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7492.476,
"heapDeltaBytes": 6671636,
"heapUsedBytes": 81595424,
"domNodes": -12,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 5843.019,
"eventListeners": 0,
"totalBlockingTimeMs": 67,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2055.870000000027,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.438,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 617.037,
"heapDeltaBytes": -6365324,
"heapUsedBytes": 80432100,
"domNodes": -246,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 36.30799999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.3480000000318,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.441999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.165,
"heapDeltaBytes": -3883292,
"heapUsedBytes": 83534680,
"domNodes": -244,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 30.516000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2217.1129999999835,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.680000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1537.4289999999999,
"heapDeltaBytes": 18591944,
"heapUsedBytes": 83437188,
"domNodes": 6,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 759.584,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2410.5539999999337,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.950000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1650.6499999999996,
"heapDeltaBytes": -5381272,
"heapUsedBytes": 83011152,
"domNodes": -245,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 845.1840000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3661.2199999999575,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.626999999999999,
"layouts": 60,
"layoutDurationMs": 16.066,
"taskDurationMs": 1713.8229999999999,
"heapDeltaBytes": -15799560,
"heapUsedBytes": 73747376,
"domNodes": -254,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 736.7080000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3535.180000000082,
"styleRecalcs": 62,
"styleRecalcDurationMs": 13.186000000000003,
"layouts": 60,
"layoutDurationMs": 15.629999999999997,
"taskDurationMs": 1616.498,
"heapDeltaBytes": 7627304,
"heapUsedBytes": 73932880,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 708.958,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3145.3970000000027,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.326,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1897.584,
"heapDeltaBytes": 25187084,
"heapUsedBytes": 91899816,
"domNodes": 8,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 926.9479999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3009.443000000033,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.062000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1822.242,
"heapDeltaBytes": 27141696,
"heapUsedBytes": 91587132,
"domNodes": -248,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 906.8770000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2004.4679999999744,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.932000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.7270000000001,
"heapDeltaBytes": 20206308,
"heapUsedBytes": 84624680,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.651,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2001.525000000015,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.8609999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.923,
"heapDeltaBytes": 20174252,
"heapUsedBytes": 84677276,
"domNodes": -247,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.88400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.7710000000075,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.079,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.07,
"heapDeltaBytes": 14114760,
"heapUsedBytes": 83934772,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 131.967,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.333999999978,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.069,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.59099999999995,
"heapDeltaBytes": 13086964,
"heapUsedBytes": 77083076,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 132.828,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2016.5380000000255,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.276,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.43399999999997,
"heapDeltaBytes": -12707760,
"heapUsedBytes": 57040044,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.671,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.5200000000468,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.845,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.382,
"heapDeltaBytes": -3791336,
"heapUsedBytes": 66419380,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.978999999999997,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1769.5699999999874,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.450000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 774.6039999999999,
"heapDeltaBytes": -10836432,
"heapUsedBytes": 59286936,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 98.031,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.3869999999497,
"styleRecalcs": 45,
"styleRecalcDurationMs": 12.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 715.9830000000001,
"heapDeltaBytes": -9713312,
"heapUsedBytes": 60047932,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 95.428,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1116.6210000000092,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.774000000000004,
"layouts": 5,
"layoutDurationMs": 9.727,
"taskDurationMs": 815.9929999999999,
"heapDeltaBytes": -6331696,
"heapUsedBytes": 86034820,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 27.801,
"eventListeners": 2383,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8289.468999999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.241,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5577.023999999999,
"heapDeltaBytes": -18433668,
"heapUsedBytes": 68262252,
"domNodes": -212,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 2583.784,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8357.611999999903,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.961,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5568.1,
"heapDeltaBytes": -4171736,
"heapUsedBytes": 83161568,
"domNodes": -242,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2577.571,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14215.210999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13798.798999999999,
"heapDeltaBytes": -49620412,
"heapUsedBytes": 175849120,
"domNodes": -8061,
"jsHeapTotalBytes": -18882560,
"scriptDurationMs": 221.78300000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 14173.003999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13650.199,
"heapDeltaBytes": -49912320,
"heapUsedBytes": 175748252,
"domNodes": -8061,
"jsHeapTotalBytes": -17309696,
"scriptDurationMs": 213.231,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17278.895000000033,
"styleRecalcs": 128,
"styleRecalcDurationMs": 20.975999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17058.436,
"heapDeltaBytes": -63158700,
"heapUsedBytes": 178284820,
"domNodes": -8062,
"jsHeapTotalBytes": -17240064,
"scriptDurationMs": 899.3019999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 59,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17440.527999999973,
"styleRecalcs": 130,
"styleRecalcDurationMs": 18.857000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17227.491,
"heapDeltaBytes": -27026060,
"heapUsedBytes": 192137088,
"domNodes": -8061,
"jsHeapTotalBytes": -16068608,
"scriptDurationMs": 878.698,
"eventListeners": -14928,
"totalBlockingTimeMs": 48,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5237.0690000000195,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.084,
"layouts": 20,
"layoutDurationMs": 24.701,
"taskDurationMs": 5146.213000000001,
"heapDeltaBytes": -30774584,
"heapUsedBytes": 194795184,
"domNodes": -8061,
"jsHeapTotalBytes": 14147584,
"scriptDurationMs": 93.54599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 182,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5227.729999999951,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.20800000000001,
"layouts": 20,
"layoutDurationMs": 24.962,
"taskDurationMs": 5200.346,
"heapDeltaBytes": -46322860,
"heapUsedBytes": 181470032,
"domNodes": -8061,
"jsHeapTotalBytes": 9498624,
"scriptDurationMs": 93.36900000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 207,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7147.777000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6948.855999999999,
"heapDeltaBytes": -15643312,
"heapUsedBytes": 169937508,
"domNodes": 0,
"jsHeapTotalBytes": -27787264,
"scriptDurationMs": 109.11599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7111.05299999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7009.5960000000005,
"heapDeltaBytes": -5376200,
"heapUsedBytes": 175527912,
"domNodes": 0,
"jsHeapTotalBytes": -10485760,
"scriptDurationMs": 108.75300000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 474.70399999997426,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.429000000000002,
"layouts": 5,
"layoutDurationMs": 2.519,
"taskDurationMs": 144.777,
"heapDeltaBytes": 5405240,
"heapUsedBytes": 71003612,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.509000000000004,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 107.85899999996218,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.981000000000005,
"layouts": 3,
"layoutDurationMs": 1.936,
"taskDurationMs": 82.43299999999998,
"heapDeltaBytes": 2909792,
"heapUsedBytes": 68403368,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.3629999999999995,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #19334 +/- ##
============================================
Coverage 84.70% 84.71%
============================================
Files 2322 2323 +1
Lines 132720 132788 +68
Branches 33704 35618 +1914
============================================
+ Hits 112419 112486 +67
- Misses 19949 19950 +1
Partials 352 352
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 3 |
| 🟢 Low | 6 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head self-review at a1c5866f9ba299e7793b89c5dd0ddaf84a8222d8: reviewed the complete seven-file carrier diff plus the five-file review fix against live core/1.55 (6c3a7ea63d14a02b74537801d8b88ae52580db53). All ten Cursor findings are dispositioned with evidence; three introduced issues were fixed (bounded-cardinality ask_kind tag with raw context, POST-only fake answer route, and a shared reason type), while the approval-loss production, telemetry, browser, expected-failure, and non-vacuity hunks remain intact. Focused transport/store tests pass 96/96; reverting the tag bucketing makes both relevant assertions fail; full typecheck, formatting, and lint pass with only existing repository warnings. This push spends no approval because none existed, but it invalidates all prior hosted evidence. Fresh exact-head hosted checks and the target-aware gate are required before landing. No unresolved concern found in the current diff.
|
Superseded by merged #19346. Closing to avoid applying the same core/1.55 telemetry backport twice. |
Summary
Backports merged #18952 (source merge
8223a93de30cd630338924e923e2f6fe9bb9d6e6) tocore/1.55, preserving its approval-ask loss telemetry and durable browser contract.Changes
agentApprovalSurvivesSocketDrop.spec.tsand its fixture support.core/1.55; two cherry-pick context conflicts were resolved by retaining the target line’s structure while applying only fix(agent): report an approval ask the panel never delivered #18952’s telemetry/departed-turn changes.Review Focus
agentEventTransport.tsandagentConversationStore.tspreserve the target branch’s existing code while matching fix(agent): report an approval ask the panel never delivered #18952 behavior.8223a93de3. A target harness attempt was blocked before product execution because the shared backend returned 404 for/api/devtools/fake_model.safetensors; source exact-seam browser evidence remains current.Source: #18952