Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
a7e8607
feat(website): link each workshop app to its GitHub repository
mariana953 Sep 28, 2026
1c5684b
refactor(website): keep app repos with the other external links
mariana953 Sep 28, 2026
13e6615
test(website): cover the GitHub placeholder on both app pages
mariana953 Sep 28, 2026
2c7f3fe
test(website): expect exactly one GitHub placeholder per app page
mariana953 Sep 29, 2026
c45d911
feat(website): the nav calls the catalogue the Hub
mariana953 Sep 29, 2026
ea9aedd
test(website): follow the Hub name through the menu and the screenshots
mariana953 Sep 29, 2026
ecdc464
fix(website): a video example's tile shows a frame before it plays
mariana953 Sep 29, 2026
300d942
test(website): the Re-shoot example video tile asks for a first frame
mariana953 Sep 29, 2026
908dcc5
fix(website): Re-shoot's aim badges fit a phone and the header reads …
mariana953 Sep 29, 2026
432b6e0
fix(website): a workflow's example output leaves no gap under it on a…
mariana953 Sep 29, 2026
9f83ce6
test(website): pin the output panel's minimum height and the one-line…
mariana953 Sep 29, 2026
77f6130
fix(website): catalogue tabs stay put when the hero subtitle changes …
mariana953 Sep 29, 2026
7f58683
fix(website): catalogue tabs span the width of a phone
mariana953 Sep 29, 2026
4e9f83c
fix(website): source pictures open full screen with the close button …
mariana953 Sep 29, 2026
5b4c714
fix(website): Re-shoot's preview stays pinned on phones, with buttons…
mariana953 Sep 29, 2026
2430f5d
feat(website): the workflow API tab numbers what to do first
mariana953 Sep 29, 2026
7186cd7
test(website): the workflow API tab downloads its API graph
mariana953 Sep 29, 2026
920ae11
test(website): no API graph download when the workflow can't run on C…
mariana953 Sep 29, 2026
02a706a
fix(website): a running take says its own name, without a bar that ca…
mariana953 Sep 28, 2026
595d879
test(website): start the take's clock when the test renders it
mariana953 Sep 29, 2026
8d4f910
fix(website): the running take says out loud that it is rendering
mariana953 Sep 29, 2026
ca8b7a5
fix(website): direction options show their preview frame, not a drawn…
mariana953 Sep 29, 2026
cac7dde
fix(website): each direction option previews one scene, changed only …
mariana953 Sep 29, 2026
fc7a41b
fix(website): one subject per direction part, sharper option frames
mariana953 Sep 29, 2026
c869f51
test(website): cover each way a direction thumbnail draws an option
mariana953 Sep 29, 2026
1530307
test(website): every Cinematic Studio shot option shows its preview f…
mariana953 Sep 29, 2026
ca7d328
test(website): pin each Cinematic Studio shot option to its own frame
mariana953 Sep 29, 2026
66817fe
fix(website): Cinematic Studio output card shares the model output's …
mariana953 Sep 29, 2026
0bc5237
fix(website): Cinematic Studio output header drops the take letters
mariana953 Sep 29, 2026
e4aaa2e
fix(website): the generated shot spans the Output card on phones
mariana953 Sep 29, 2026
35b7235
test(website): match Cinematic render status
benjcooley Sep 29, 2026
d7a2d8c
fix(website): preserve cinematic video integration
benjcooley Sep 29, 2026
b12fed5
fix(website): example prompts name what the form shows
mariana953 Sep 29, 2026
0d9af2f
fix(website): the prompt box grows to the prompt it holds
mariana953 Sep 29, 2026
05054cc
fix(website): the workflow examples read and mark themselves like a m…
mariana953 Sep 29, 2026
14ca96c
refactor(website): the workflow example card is its own component
mariana953 Sep 29, 2026
3e5009c
fix(website): the prompt box refits when the layout narrows under it
mariana953 Sep 29, 2026
e373e75
test(website): the workflow example card marks the chosen example
mariana953 Sep 29, 2026
efa67e8
fix(website): a catalogue card opens its whole name on hover
mariana953 Sep 29, 2026
7222931
feat(website): a removed upload offers itself back
mariana953 Sep 29, 2026
38d2e48
Revert "fix(website): a catalogue card opens its whole name on hover"
mariana953 Sep 29, 2026
dec5167
fix(website): the workflow graph opens where it can be read
mariana953 Sep 29, 2026
538aa8a
fix(website): the prompt box stops short of swallowing the window
mariana953 Sep 29, 2026
bbb7252
refactor(website): where the graph opens is a function, with tests
mariana953 Sep 29, 2026
b8d3704
fix(website): a card name drops what its task pill already says
mariana953 Sep 29, 2026
df68b93
fix(website): the catalogue tab marker takes the canvas grey
mariana953 Sep 29, 2026
9c1b38c
feat(website): one heading shape for the details and API sections
mariana953 Sep 29, 2026
0021040
fix(website): the workflow page stops repeating itself and the banner…
mariana953 Sep 29, 2026
0d3d1b2
refactor(website): the banner dots and the graph controls move out
mariana953 Sep 29, 2026
1d6ff91
fix(website): the example says it once, and the shot options get room
mariana953 Sep 29, 2026
b1064db
fix(website): the workflow API panel keeps its conditions with its facts
mariana953 Sep 29, 2026
31b0711
fix(website): the way to the full-size graph opens, and the undo answ…
mariana953 Sep 29, 2026
ff94b9d
fix(website): preserve Hub feedback integration
benjcooley Sep 29, 2026
777350a
fix(website): design pass on the Hub, from the team's feedback
mariana953 Sep 29, 2026
b476c31
fix(website): a workflow card's name keeps to one line
mariana953 Sep 29, 2026
8a19031
fix(website): Re-shoot's empty preview says what it is waiting for
mariana953 Sep 29, 2026
07e1088
test(website): pin what the design pass changed
mariana953 Sep 29, 2026
b68479f
fix(website): bring the stray node back into the remove-object graph
mariana953 Sep 29, 2026
b4ad7c8
test(website): keep the full workflow name within reach
mariana953 Sep 29, 2026
3b04189
test(website): cover the shelf filter and the example dialog in the b…
mariana953 Sep 29, 2026
fffe6c3
fix(website): a hovered workflow card shows the whole name
mariana953 Sep 29, 2026
235c241
test(website): name the example dialog's two answers
mariana953 Sep 29, 2026
06b518c
test(website): the card opens its name for the keyboard too
mariana953 Sep 29, 2026
44bce56
feat(website): keep apps out of the catalogue banner
mariana953 Sep 28, 2026
d96dc87
[automated] Apply ESLint and Oxfmt fixes
actions-user Sep 29, 2026
a8e1659
fix(website): reconcile the final Hub design pass
benjcooley Sep 29, 2026
a80ddd2
chore(website): format cinematic integration
benjcooley Sep 29, 2026
1b43913
feat(website): a card says when a workflow runs on Comfy API
mariana953 Sep 29, 2026
b645c52
fix(website): preserve audited material examples
benjcooley Sep 29, 2026
b0e32ac
fix(website): reconcile SDK steps and tall graphs
benjcooley Sep 29, 2026
6c0c446
test(website): cover putting a picture back at its old place
mariana953 Sep 29, 2026
d367ca3
fix(website): let the API graph download finish before its URL is rel…
mariana953 Sep 29, 2026
952a18a
Merge main into mariana/hub-design-pass
mariana953 Sep 29, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions apps/website/e2e/header-models-navigation.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ async function expectNoHorizontalOverflow(page: Page) {
}

for (const viewport of viewports) {
test(`enabled Models navigation fits at ${viewport.name}`, async ({
page
}) => {
test(`enabled Hub navigation fits at ${viewport.name}`, async ({ page }) => {
await page.setViewportSize({ width: viewport.width, height: 900 })
await page.goto('/')

Expand All @@ -36,7 +34,7 @@ for (const viewport of viewports) {
if (viewport.desktopNavigation) {
await expect(desktopLinks).toBeVisible()
await expect(
desktopLinks.getByRole('link', { name: 'Models', exact: true })
desktopLinks.getByRole('link', { name: 'Hub', exact: true })
).toHaveAttribute('href', '/models')
await expect(menuButton).toBeHidden()
} else {
Expand All @@ -45,9 +43,10 @@ for (const viewport of viewports) {
await menuButton.click()
const menu = page.getByRole('dialog', { name: 'Menu' })
await expect(menu).toBeVisible()
await expect(
menu.getByRole('link', { name: /^Models\b/ })
).toHaveAttribute('href', '/models')
await expect(menu.getByRole('link', { name: /^Hub\b/ })).toHaveAttribute(
'href',
'/models'
)
}

await expectNoHorizontalOverflow(page)
Expand Down
58 changes: 58 additions & 0 deletions apps/website/e2e/homepage.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -278,3 +278,61 @@ test.describe('Get started section links @smoke', () => {
)
})
})

test.describe('Model discovery row @interaction', () => {
test('a hovered or focused workflow card gives its whole name', async ({
page,
context
}) => {
await context.route('**/t.comfy.org/**', (route) =>
/\/(flags|decide)\//.test(route.request().url())
? route.fulfill({
json: {
featureFlags: {
'workshop-enabled': true,
'workshop-workflows-enabled': true
},
featureFlagPayloads: {}
}
})
: route.abort('blockedbyclient')
)
await page.goto('/')
await page
.getByTestId('catalogue-tabs')
.getByRole('button', { name: 'Workflows' })
.click()
const cards = page.getByTestId('discovery-workflow')
await expect(cards.first()).toBeAttached()
await page.addStyleTag({
content:
'[data-testid="discovery-marquee"] { animation: none !important }'
})

const cut = await cards.evaluateAll((elements) =>
elements.findIndex((element) => {
const name = element.querySelector('span[title]')
const box = element.getBoundingClientRect()
return (
name !== null &&
name.scrollWidth > name.clientWidth + 1 &&
box.x > 0 &&
box.right < window.innerWidth
)
})
)
expect(cut).toBeGreaterThan(-1)

const card = cards.nth(cut)
const name = card.locator('span[title]')
const overflow = () =>
name.evaluate((element) => element.scrollWidth - element.clientWidth)
await card.hover()
await expect.poll(overflow).toBeLessThanOrEqual(1)

await page.mouse.move(0, 0)
await expect.poll(overflow).toBeGreaterThan(1)
await card.focus()
await expect.poll(overflow).toBeLessThanOrEqual(1)
})
})
8 changes: 4 additions & 4 deletions apps/website/e2e/navigation.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const minimaxRoute = '/minimax-h3'
const minimaxRouteZh = '/zh-CN/minimax-h3'

const TOP_LEVEL_LABELS = [
'Models',
'Hub',
'Products',
'Pricing',
'Community',
Expand Down Expand Up @@ -113,7 +113,7 @@ test.describe('Desktop navigation @smoke', () => {

await expect(
desktopLinks
.getByRole('link', { name: 'Models' })
.getByRole('link', { name: 'Hub' })
.getByText('NEW', { exact: true })
).toBeVisible()
for (const label of ['Products', 'Community']) {
Expand Down Expand Up @@ -326,7 +326,7 @@ test.describe('Mobile menu @mobile', () => {
const menu = page.getByRole('dialog')
await expect(menu).toBeVisible()

for (const label of ['Models', 'Products', 'Pricing', 'Community']) {
for (const label of ['Hub', 'Products', 'Pricing', 'Community']) {
await expect(menu.getByText(label, { exact: true }).first()).toBeVisible()
}
})
Expand All @@ -339,7 +339,7 @@ test.describe('Mobile menu @mobile', () => {
const menu = page.getByRole('dialog')

await expect(
menu.getByRole('link', { name: 'Models' }).getByText('NEW', {
menu.getByRole('link', { name: 'Hub' }).getByText('NEW', {
exact: true
})
).toBeVisible()
Expand Down
2 changes: 1 addition & 1 deletion apps/website/e2e/visual-responsive.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ async function navigateAndSettle(page: Page, url: string) {
await expect(
page
.getByTestId('desktop-nav-links')
.getByRole('link', { name: 'Models', includeHidden: true })
.getByRole('link', { name: 'Hub', includeHidden: true })
).toBeAttached()
await waitForPpFormulaLight(page)
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
61 changes: 61 additions & 0 deletions apps/website/e2e/workshop-api-actions.spec.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { readFile } from 'node:fs/promises'

import type { BrowserContext, Locator } from '@playwright/test'
import { expect } from '@playwright/test'

Expand Down Expand Up @@ -78,3 +80,62 @@ test('the workflow API tab opens with the key action and what it needs beside th
expect(action.y).toBeLessThanOrEqual(code.y)
expect(action.x).toBeGreaterThanOrEqual(code.x + code.width)
})

test('@mobile the workflow example output is as tall as its 16:9 media', async ({
page,
context
}) => {
await allowWorkflows(context)
await page.goto(WORKFLOW_PATH)

const output = page.getByTestId('playground-output')
await expect(output).toHaveAttribute('data-state', 'example')
const media = await frame(output.getByTestId('output-media'))
expect(media.height).toBeCloseTo((media.width * 9) / 16, 0)
})

test('@mobile opens a source picture full screen with its close button clear of it', async ({
page,
context
}) => {
await allowWorkflows(context)
await page.goto(WORKFLOW_PATH)
await page
.locator('input[type=file]')
.first()
.setInputFiles('public/images/cinematic-studio/diner.jpg')
await page
.getByRole('button', { name: /^Expand / })
.first()
.click()

const dialog = page.getByTestId('image-source-dialog')
const viewportWidth = page.viewportSize()?.width ?? 0
await expect
.poll(async () => (await frame(dialog)).width)
.toBeGreaterThan(viewportWidth - 2)
const [close, picture] = await Promise.all([
frame(dialog.getByRole('button', { name: 'Close' })),
frame(dialog.getByRole('img'))
])
expect(close.y + close.height).toBeLessThanOrEqual(picture.y)
})

test('the workflow API tab downloads the API graph as JSON', async ({
page,
context
}) => {
await allowWorkflows(context)
await page.goto(WORKFLOW_PATH)
await page.getByRole('tab', { name: 'API', exact: true }).click()

const [download] = await Promise.all([
page.waitForEvent('download'),
page.getByRole('button', { name: /Download the API graph/ }).click()
])
expect(download.suggestedFilename()).toBe('remove-background-api.json')
const path = await download.path()
const graph = await readFile(path, 'utf8')
expect(Object.keys(JSON.parse(graph))).not.toHaveLength(0)
expect(graph).toContain('"class_type"')
})
108 changes: 108 additions & 0 deletions apps/website/e2e/workshop-apps.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,111 @@ test('sends the old studio address to the app page it named', async ({
await page.goto('/cinematic-studio/?app=reshoot&ux=d&model=flux')
await expect(page).toHaveURL(/\/models\/apps\/reshoot\/\?ux=d&model=flux$/)
})

test.describe('GitHub link before an app repo is published', () => {
for (const path of [
'/models/apps/cinematic-studio/',
'/models/apps/reshoot/'
])
test(`shows a placeholder, not a link, on ${path}`, async ({
page,
context
}) => {
await mockFlags(context, { apps: true, workflows: false })
await page.goto(path)
await expect(page.getByText('GitHub · Coming soon')).toHaveCount(1)
await expect(
page.getByRole('link', { name: 'View on GitHub' })
).toHaveCount(0)
})
})

test('asks Safari for a first frame on the Re-shoot example video tile', async ({
page,
context
}) => {
await mockFlags(context, { apps: true, workflows: false })
await page.goto('/models/apps/reshoot/')
await expect(page.getByTestId('example-video')).toHaveAttribute(
'src',
/#t=0\.1$/
)
})

test('@mobile keeps the Re-shoot aim badges to one line on a phone', async ({
page,
context
}) => {
await mockFlags(context, { apps: true, workflows: false })
await page.goto('/models/apps/reshoot/')
await page.getByText('Sci-fi pilot').first().click()

const viewport = page.getByTestId('reshoot-viewport').first()
await expect(
viewport.getByText('Drag to orbit', { exact: true })
).toBeVisible()
await expect(viewport.getByText(/Scroll to move closer/)).toBeHidden()

for (const badge of [
viewport.getByTestId('reshoot-drag-hint'),
viewport.getByTestId('reshoot-angle-readout')
]) {
const box = await badge.boundingBox()
expect(box?.height).toBeLessThan(40)
}
})

test('@mobile pins the Re-shoot preview while the camera controls scroll under it', async ({
page,
context
}) => {
await mockFlags(context, { apps: true, workflows: false })
await page.goto('/models/apps/reshoot/')
await page.getByText('Sci-fi pilot').first().click()

const frame = page.getByTestId('reshoot-frame')
const distance = page.getByRole('slider', { name: /Distance/ })
await page.getByTestId('reshoot-action').scrollIntoViewIfNeeded()
const pinned = await frame.boundingBox()
expect(pinned?.y).toBeGreaterThanOrEqual(0)
expect(pinned?.y).toBeLessThan(120)

const before = Number(await distance.inputValue())
await page.getByRole('button', { name: 'Move the camera closer' }).tap()
await expect
.poll(async () => Number(await distance.inputValue()))
.toBeLessThan(before)
})

test('shows a preview frame for every Cinematic Studio shot option', async ({
page,
context
}) => {
await mockFlags(context, { apps: true, workflows: false })
await page.goto('/models/apps/cinematic-studio/')
await page
.getByRole('button', { name: /^Shot\b/ })
.first()
.click()

const shots = page.getByRole('radiogroup', { name: 'Shot' })
await expect(shots.getByRole('radio')).toHaveCount(8)
await expect(
shots.locator('img[src^="/images/cinematic-studio/options/shot-"]')
).toHaveCount(7)
for (const id of [
'xwide',
'wide',
'medium',
'close',
'xclose',
'ots',
'low'
]) {
await expect(
shots.locator(
`img[src="/images/cinematic-studio/options/shot-${id}.jpg"]`
)
).toHaveCount(1)
}
})
2 changes: 1 addition & 1 deletion apps/website/e2e/workshop-visibility.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ test('keeps the public site when PostHog is unavailable', async ({ page }) => {
})
await page.goto('/')
await expect(
page.getByRole('link', { name: 'Models', exact: true })
page.getByRole('link', { name: 'Hub', exact: true })
).toHaveCount(0)
await expect(page.getByTestId('model-discovery')).toHaveCount(0)
await expect(
Expand Down
Loading
Loading