Repository navigation
FE-1656 refactor(billing): remove the unconfirmed team subscription checkout util - #19250
Conversation
…util performTeamSubscriptionCheckout POSTs /api/billing/subscribe with no confirmation step. Its only caller, the legacy /cloud/subscribe?tier=team deep link, was removed by #14998 in favor of showPricingTable. Delete the dead util and its test file, and drop the now-unused mock and assertions from CloudSubscriptionRedirectView.test.ts.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2157 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4ff36900475e5447304b2afb7e2e5d560d726d3f
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzip 🔴 +322 kBDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.73 kB) • 🔴 +38 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.43 MB) • 🔴 +26.6 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 134 kB (baseline 124 kB) • 🔴 +9.77 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 640 kB (baseline 621 kB) • 🔴 +18.4 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 39.4 kB (baseline 27.8 kB) • 🔴 +11.6 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +690 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 125 kB (baseline 117 kB) • 🔴 +8.06 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 4.01 MB (baseline 3.6 MB) • 🔴 +413 kBStores, services, APIs, and repositories
Status: 15 added / 16 removed Utilities & Hooks — 579 kB (baseline 559 kB) • 🔴 +19.9 kBHelpers, composables, and utility bundles
Status: 30 added / 30 removed / 6 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -685 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.9 MB (baseline 16.4 MB) • 🔴 +1.5 MBBundles that do not match a named category
Status: 179 added / 174 removed / 122 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-28T17:30:13.240Z",
"gitSha": "62e562dda142b6e1961d6e4203fe3f60c6720649",
"branch": "jaewon/remove-team-subscription-checkout-util",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2036.53300000002,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.4280000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.705,
"heapDeltaBytes": -846804,
"heapUsedBytes": 77849068,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.203,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2018.7499999999545,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.7550000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.653,
"heapDeltaBytes": -596440,
"heapUsedBytes": 78703956,
"domNodes": -228,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.937000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1801.4650000000074,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.883000000000001,
"layouts": 12,
"layoutDurationMs": 4.223,
"taskDurationMs": 723.7280000000001,
"heapDeltaBytes": -3815848,
"heapUsedBytes": 75129584,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 133.297,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1755.2890000000616,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.898000000000003,
"layouts": 12,
"layoutDurationMs": 4.254,
"taskDurationMs": 642.729,
"heapDeltaBytes": -17669904,
"heapUsedBytes": 61038004,
"domNodes": -228,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 125.94800000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.9059999999708,
"styleRecalcs": 31,
"styleRecalcDurationMs": 7.971000000000001,
"layouts": 6,
"layoutDurationMs": 1.1150000000000002,
"taskDurationMs": 280.40700000000004,
"heapDeltaBytes": 1461772,
"heapUsedBytes": 80914968,
"domNodes": 53,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.015,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.947000000071,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.822999999999999,
"layouts": 6,
"layoutDurationMs": 1.47,
"taskDurationMs": 299.383,
"heapDeltaBytes": 1529472,
"heapUsedBytes": 80928364,
"domNodes": 53,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.875,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 566.755999999998,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2150000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.945,
"heapDeltaBytes": 18212484,
"heapUsedBytes": 97432540,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 136.606,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 569.658000000004,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.319000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.162,
"heapDeltaBytes": 18283148,
"heapUsedBytes": 96856024,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 143.44700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1080.1380000000336,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 716.076,
"heapDeltaBytes": 6464356,
"heapUsedBytes": 83620128,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 54.81799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 457,
"frameDurationMs": 31.861764705882358,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1034.9410000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 683.935,
"heapDeltaBytes": 7134488,
"heapUsedBytes": 83941888,
"domNodes": 0,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 50.222,
"eventListeners": 0,
"totalBlockingTimeMs": 424,
"frameDurationMs": 31.31515151515153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.3820000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.8409999999998,
"heapDeltaBytes": -16771176,
"heapUsedBytes": 67067492,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 118.37700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 135,
"frameDurationMs": 22.379999999999978,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.7629999999554,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.42900000000014,
"heapDeltaBytes": -15622220,
"heapUsedBytes": 70669380,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 126.51800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 146,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7777.264000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6835.385,
"heapDeltaBytes": 3435692,
"heapUsedBytes": 83864448,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 5270.6849999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 85,
"frameDurationMs": 26.506484641638224,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7353.256999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6584.0509999999995,
"heapDeltaBytes": -13447040,
"heapUsedBytes": 67384168,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 5086.4259999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 72,
"frameDurationMs": 26.342652329749104,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7347.587000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6584.104,
"heapDeltaBytes": 11229960,
"heapUsedBytes": 92003708,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 5065.941000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 125,
"frameDurationMs": 26.823722627737222,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7692.992000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6874.715999999999,
"heapDeltaBytes": 2957876,
"heapUsedBytes": 83181928,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 5322.889,
"eventListeners": 0,
"totalBlockingTimeMs": 40,
"frameDurationMs": 26.459450171821302,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2048.9969999999857,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.436999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.0009999999999,
"heapDeltaBytes": -37205924,
"heapUsedBytes": 82300968,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 31.915999999999993,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2046.122999999966,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.363999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.322,
"heapDeltaBytes": -37865532,
"heapUsedBytes": 81873184,
"domNodes": -228,
"jsHeapTotalBytes": 1474560,
"scriptDurationMs": 33.681000000000004,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80245901639344,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2150.743000000034,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.308,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1254.164,
"heapDeltaBytes": 21623444,
"heapUsedBytes": 85332380,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 703.279,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66511627906976,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2217.6390000000765,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.45,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1456.591,
"heapDeltaBytes": 21481112,
"heapUsedBytes": 83519896,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 740.0600000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3471.9610000000216,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.077999999999998,
"layouts": 60,
"layoutDurationMs": 14.806,
"taskDurationMs": 1470.488,
"heapDeltaBytes": 12619132,
"heapUsedBytes": 76948584,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 660.54,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665865384615383,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3584.100000000035,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.673,
"layouts": 60,
"layoutDurationMs": 15.955999999999998,
"taskDurationMs": 1557.519,
"heapDeltaBytes": 8141308,
"heapUsedBytes": 71928588,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 683.896,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2366.7839999999956,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.467999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1496.389,
"heapDeltaBytes": 18366292,
"heapUsedBytes": 85453540,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 741.9800000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.784285714285716,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3005.952999999977,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.417999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1721.5549999999998,
"heapDeltaBytes": 19134556,
"heapUsedBytes": 84015640,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 845.386,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758659217877096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.9980000000114,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7410000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.23099999999994,
"heapDeltaBytes": -38876356,
"heapUsedBytes": 83056968,
"domNodes": -228,
"jsHeapTotalBytes": -1146880,
"scriptDurationMs": 30.056000000000008,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.7379999999666,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1670000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.39199999999994,
"heapDeltaBytes": -38114628,
"heapUsedBytes": 82743912,
"domNodes": -228,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 32.599000000000004,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.305000000008,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.744999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.69499999999994,
"heapDeltaBytes": 12424296,
"heapUsedBytes": 93544628,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 117.503,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 562.9469999998946,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.651999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.7800000000001,
"heapDeltaBytes": 12305012,
"heapUsedBytes": 93711544,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 123.37100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2027.243999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2250000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.296,
"heapDeltaBytes": -2914140,
"heapUsedBytes": 78584808,
"domNodes": -244,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.27,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2042.2459999999774,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.9689999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.457,
"heapDeltaBytes": -7016704,
"heapUsedBytes": 73458300,
"domNodes": -244,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 8.696000000000002,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1729.2869999999994,
"styleRecalcs": 59,
"styleRecalcDurationMs": 14.150999999999998,
"layouts": 16,
"layoutDurationMs": 4.413,
"taskDurationMs": 629.34,
"heapDeltaBytes": -14489916,
"heapUsedBytes": 66718488,
"domNodes": -244,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 83.41000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1729.1999999999916,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.67,
"layouts": 16,
"layoutDurationMs": 5.2170000000000005,
"taskDurationMs": 694.319,
"heapDeltaBytes": -20406072,
"heapUsedBytes": 60964908,
"domNodes": -244,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 92.79299999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.8980000000074,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.970000000000006,
"layouts": 5,
"layoutDurationMs": 9.302000000000001,
"taskDurationMs": 723.933,
"heapDeltaBytes": 21776612,
"heapUsedBytes": 91356720,
"domNodes": 13667,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 23.128999999999998,
"eventListeners": 2383,
"totalBlockingTimeMs": 109,
"frameDurationMs": 20,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8170.29500000001,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.821,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4381.883,
"heapDeltaBytes": -51640888,
"heapUsedBytes": 67906140,
"domNodes": -228,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 2236.6710000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8208.343000000013,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.179,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5079.821,
"heapDeltaBytes": -41331184,
"heapUsedBytes": 78320544,
"domNodes": -228,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 2322.18,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591836734694,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13540.077999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12805.421000000002,
"heapDeltaBytes": 5934452,
"heapUsedBytes": 179252940,
"domNodes": -8049,
"jsHeapTotalBytes": -11796480,
"scriptDurationMs": 257.62,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.695979899497488,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 14512.006000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13996.319,
"heapDeltaBytes": -18386972,
"heapUsedBytes": 187242212,
"domNodes": -3045,
"jsHeapTotalBytes": 7761920,
"scriptDurationMs": 288.19100000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.601587301587298,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 16300.33899999995,
"styleRecalcs": 102,
"styleRecalcDurationMs": 20.28100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15807.182,
"heapDeltaBytes": -33402744,
"heapUsedBytes": 173687568,
"domNodes": -3045,
"jsHeapTotalBytes": 1642496,
"scriptDurationMs": 839.17,
"eventListeners": -14915,
"totalBlockingTimeMs": 56,
"frameDurationMs": 29.375359712230217,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 17209.990000000063,
"styleRecalcs": 121,
"styleRecalcDurationMs": 17.788999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16921.827,
"heapDeltaBytes": -10203788,
"heapUsedBytes": 187515160,
"domNodes": -3045,
"jsHeapTotalBytes": 8523776,
"scriptDurationMs": 844.462,
"eventListeners": -14915,
"totalBlockingTimeMs": 12,
"frameDurationMs": 32.60606060606061,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4889.810000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.97800000000001,
"layouts": 20,
"layoutDurationMs": 23.818000000000005,
"taskDurationMs": 4771.171,
"heapDeltaBytes": 7794500,
"heapUsedBytes": 207941072,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 88.798,
"eventListeners": 0,
"totalBlockingTimeMs": 132,
"frameDurationMs": 29.06607142857143,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 5123.260999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.687,
"layouts": 20,
"layoutDurationMs": 24.916999999999994,
"taskDurationMs": 5075.884999999999,
"heapDeltaBytes": 5112084,
"heapUsedBytes": 171998092,
"domNodes": -8049,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 94.15899999999999,
"eventListeners": -3,
"totalBlockingTimeMs": 208,
"frameDurationMs": 31.583950617283953,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6874.681000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6581.745,
"heapDeltaBytes": 8924564,
"heapUsedBytes": 176659388,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 104.75099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.734827586206897,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7091.515999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6662.621,
"heapDeltaBytes": -39532808,
"heapUsedBytes": 181057028,
"domNodes": -3046,
"jsHeapTotalBytes": 7180288,
"scriptDurationMs": 114.66199999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.998943661971833,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 126.8360000000257,
"styleRecalcs": 9,
"styleRecalcDurationMs": 11.258,
"layouts": 3,
"layoutDurationMs": 1.3059999999999998,
"taskDurationMs": 96.521,
"heapDeltaBytes": -16869236,
"heapUsedBytes": 80048944,
"domNodes": 113,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.717999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 110.58000000002721,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.739,
"layouts": 3,
"layoutDurationMs": 1.682,
"taskDurationMs": 81.219,
"heapDeltaBytes": -16566436,
"heapUsedBytes": 80440592,
"domNodes": 113,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.491,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 658.6419999999862,
"styleRecalcs": 78,
"styleRecalcDurationMs": 88.187,
"layouts": 76,
"layoutDurationMs": 16.331,
"taskDurationMs": 595.654,
"heapDeltaBytes": -13493220,
"heapUsedBytes": 73609560,
"domNodes": 76,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 230.896,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000018,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 650.3549999999905,
"styleRecalcs": 78,
"styleRecalcDurationMs": 86.84100000000001,
"layouts": 76,
"layoutDurationMs": 16.184,
"taskDurationMs": 592.471,
"heapDeltaBytes": -13555816,
"heapUsedBytes": 73163276,
"domNodes": 76,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 226.749,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 903.4709999999677,
"styleRecalcs": 78,
"styleRecalcDurationMs": 204.034,
"layouts": 76,
"layoutDurationMs": 16.207,
"taskDurationMs": 870.5690000000001,
"heapDeltaBytes": 10474552,
"heapUsedBytes": 140084900,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 251.40200000000002,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.974074074074082,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 875.8769999999458,
"styleRecalcs": 78,
"styleRecalcDurationMs": 195.082,
"layouts": 76,
"layoutDurationMs": 14.865,
"taskDurationMs": 836.817,
"heapDeltaBytes": 10515568,
"heapUsedBytes": 140124496,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 237.08200000000002,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe team subscription checkout utility and its dedicated tests were deleted. The onboarding redirect tests no longer mock or assert calls to the utility, and its ESLint suppression entry was removed. ChangesTeam checkout removal
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to The removed checkout helper has no remaining source consumers. Team deep links still use the pricing table, and tests cover the redirect selection, fallback, and confirmation boundary; no material merge risk remains. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19250 +/- ##
==========================================
+ Coverage 84.20% 85.10% +0.90%
==========================================
Files 3193 2337 -856
Lines 155837 134403 -21434
Branches 42348 34469 -7879
==========================================
- Hits 131221 114385 -16836
+ Misses 22980 19668 -3312
+ Partials 1636 350 -1286
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
- The change removes the unconfirmed team-subscription checkout utility, its isolated tests, and its now-unused lint exception.
- The remaining test adjustment is formatting-only; no production billing or workspace behavior changes.
- Exact-head CI is settled with 97 successes, 49 expected skips, and no unresolved review threads.
Full context for agent readers
Reviewed at exact head 9521b1a22fca118c1e96aed956569af9e185e482. The production diff is deletion-only and removes an unused path rather than replacing live checkout behavior.
|
@dante01yoon Successfully backported to #19295 |
|
@dante01yoon Successfully backported to #19297 |
Why
performTeamSubscriptionCheckoutPOSTs/api/billing/subscribewith no confirmation. Its only caller was removed in #14998. Deleting the dead util prevents the FE-1656 charge-on-landing path from being reintroduced.Root cause
n/a (cleanup); the original FE-1656 root cause was fixed in #14998.
How
src/platform/cloud/subscription/utils/teamSubscriptionCheckoutUtil.tsand its own test file.performTeamSubscriptionCheckoutUtilmock and its twonot.toHaveBeenCalled()assertions fromCloudSubscriptionRedirectView.test.ts. The tests still prove the team deep link opens the pricing table with the teaminitialCheckoutvia the existingshowPricingTableassertions. That view test has no fetch/billing-API mock to assert against directly, so "no subscribe request" for the team deep link is covered instead bybrowser_tests/tests/dialogs/pricingTableDeepLink.spec.ts:770, which asserts 0 subscribe POSTs before confirmation.Verification
pnpm typecheck— passpnpm exec vitest run src/platform/cloud/onboarding/CloudSubscriptionRedirectView.test.ts— 12/12 passpnpm exec eslint/pnpm exec oxlint/pnpm exec oxfmt --checkon changed files — cleanpnpm knip— no new findingsAS IS / TO BE
n/a: no UI or behavior change; the deleted function has no production callers. This PR changes no visible behavior, so screenshots are not applicable.