Repository navigation
[backport cloud/1.53] test: add renderer toggle and zoom legibility e2e coverage for the ECS migration QA plan - #19215
Conversation
…S migration QA plan (#17462) - Longer titles and labels verified. - Clipping controls reject truncated text. - Human legibility check remains. <details><summary>Full context for agent readers</summary> Coverage includes Vue node movement and widget edits through renderer toggles and save/reload, repeated serialized renderer round trips, and text rendering at 50% and 200% zoom. At [the current test head](5e335f4), zoom cases use the longer title `KSampler Advanced Controls` and widget label `guidance scale`. Assertions check exact zoom and text, positive bounds, complete natural text layout inside clipping ancestors, and rendered ink. At 200%, deliberately halving each text container's width makes the clipping assertion reject both perturbations; the restored text passes. The parent independently repeated the two zoom cases successfully against the intended checkout and a private backend, then inspected both screenshots. The other two renderer-transition cases were not repeated in this pass, so the older 4/4 result is not claimed as current-head verification. Static checks and commit/push hooks passed. Hosted CI and review remain separate. The first parent attempt reached a user selector because the reused frontend port belonged to another checkout and backend. A newly bound server from the intended checkout resolved that harness mismatch; no product assertion was weakened. Source-plan case 54 remains partial: exact text presence and clipping are automated, but subjective legibility and physical-display appearance still require human assessment. [QA plan](https://app.notion.com/p/comfy-org/3c56d73d365081629481ea0f1d09fc65) · [Migration PR](#14246) Glossary: Vue is the DOM-rendered Nodes 2.0 interface; CI means hosted automated checks. </details> --------- Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎭 Playwright: ✅ 1904 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-28T06:42:52.872Z",
"gitSha": "955414cd489d0efc893bd09499b93336796a3ebd",
"branch": "backport-17462-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2042.4089999999637,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.404000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.354,
"heapDeltaBytes": -12022596,
"heapUsedBytes": 58176344,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.800000000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2007.2349999999233,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.032,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.741,
"heapDeltaBytes": 12613372,
"heapUsedBytes": 82478480,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.929,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1753.8850000000252,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.875999999999998,
"layouts": 14,
"layoutDurationMs": 3.953,
"taskDurationMs": 706.7620000000001,
"heapDeltaBytes": 4063884,
"heapUsedBytes": 74422224,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 111.93800000000002,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1735.648000000083,
"styleRecalcs": 73,
"styleRecalcDurationMs": 29.086000000000002,
"layouts": 14,
"layoutDurationMs": 4.585999999999999,
"taskDurationMs": 746.892,
"heapDeltaBytes": -9416824,
"heapUsedBytes": 60856664,
"domNodes": -282,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 117.455,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.9849999999747,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.183000000000002,
"layouts": 6,
"layoutDurationMs": 1.1219999999999999,
"taskDurationMs": 313.86800000000005,
"heapDeltaBytes": 4408164,
"heapUsedBytes": 75101008,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.729,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.0049999999064,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.095999999999998,
"layouts": 6,
"layoutDurationMs": 1.2739999999999998,
"taskDurationMs": 326.719,
"heapDeltaBytes": 4448352,
"heapUsedBytes": 74681520,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.697,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 541.5089999999623,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.231,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.99800000000005,
"heapDeltaBytes": 18151540,
"heapUsedBytes": 87863916,
"domNodes": 16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 120.65299999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 544.6759999999813,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.52,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.678,
"heapDeltaBytes": -8073832,
"heapUsedBytes": 62430680,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 127.29299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2042.0050000000174,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.889,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.8009999999998,
"heapDeltaBytes": 10487876,
"heapUsedBytes": 85838348,
"domNodes": -271,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 28.982999999999993,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.1349999999775,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.334999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.791,
"heapDeltaBytes": -14286796,
"heapUsedBytes": 86788364,
"domNodes": -266,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 29.490000000000002,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2101.4920000000075,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.129,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1293.1499999999999,
"heapDeltaBytes": 17668864,
"heapUsedBytes": 83772996,
"domNodes": 6,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 619.2950000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2099.609999999984,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.108999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1318.599,
"heapDeltaBytes": 19058020,
"heapUsedBytes": 84600868,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 623.433,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3238.6260000000107,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.181999999999997,
"layouts": 60,
"layoutDurationMs": 13.062,
"taskDurationMs": 1437.4930000000002,
"heapDeltaBytes": 11220032,
"heapUsedBytes": 80447696,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 630.841,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3268.049000000019,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.876000000000001,
"layouts": 60,
"layoutDurationMs": 12.944,
"taskDurationMs": 1421.9360000000001,
"heapDeltaBytes": 7715980,
"heapUsedBytes": 75480640,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 616.8290000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2448.211000000015,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.921,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1572.444,
"heapDeltaBytes": 17449660,
"heapUsedBytes": 85282620,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 756.764,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2423.240000000078,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.920999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1512.038,
"heapDeltaBytes": 17995024,
"heapUsedBytes": 85682732,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 726.7600000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.2099999999673,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.7489999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.55899999999997,
"heapDeltaBytes": 21850660,
"heapUsedBytes": 87206116,
"domNodes": -269,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.179,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2029.7039999999242,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.6430000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.43800000000005,
"heapDeltaBytes": 10636524,
"heapUsedBytes": 87054320,
"domNodes": -270,
"jsHeapTotalBytes": -2965504,
"scriptDurationMs": 28.914,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 534.9640000000022,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.746000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.728,
"heapDeltaBytes": 14855628,
"heapUsedBytes": 87515760,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 109.32499999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.190000000005,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.473999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.472,
"heapDeltaBytes": 15054432,
"heapUsedBytes": 86956940,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 111.04,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.8500000000336,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.986999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.442,
"heapDeltaBytes": -7575904,
"heapUsedBytes": 65067108,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.166000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2022.512000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.348000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.108,
"heapDeltaBytes": -8287872,
"heapUsedBytes": 64021940,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.313,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.426999999986,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.159,
"layouts": 18,
"layoutDurationMs": 4.353,
"taskDurationMs": 683.38,
"heapDeltaBytes": 8634004,
"heapUsedBytes": 80426376,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 81.84700000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.2890000000034,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.399999999999995,
"layouts": 18,
"layoutDurationMs": 4.382,
"taskDurationMs": 692.056,
"heapDeltaBytes": 3262988,
"heapUsedBytes": 75980012,
"domNodes": -298,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 83.717,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 949.3280000000368,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.630000000000006,
"layouts": 16,
"layoutDurationMs": 11.344000000000001,
"taskDurationMs": 760.173,
"heapDeltaBytes": 21798096,
"heapUsedBytes": 105190496,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 25.103999999999996,
"eventListeners": 2381,
"totalBlockingTimeMs": 123,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8157.932000000017,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.496,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4882.937,
"heapDeltaBytes": -11216000,
"heapUsedBytes": 89079060,
"domNodes": -271,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 2173.5979999999995,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8209.095999999932,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.211,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4824.299,
"heapDeltaBytes": -12098212,
"heapUsedBytes": 88604108,
"domNodes": -267,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 2149.219,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13349.865000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12694.962,
"heapDeltaBytes": -34319336,
"heapUsedBytes": 174216132,
"domNodes": -6548,
"jsHeapTotalBytes": -5517312,
"scriptDurationMs": 241.99300000000002,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13514.538000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12753.660000000002,
"heapDeltaBytes": -35639444,
"heapUsedBytes": 174287540,
"domNodes": -6548,
"jsHeapTotalBytes": 1298432,
"scriptDurationMs": 265.31,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15986.525999999969,
"styleRecalcs": 84,
"styleRecalcDurationMs": 15.023000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15438.737,
"heapDeltaBytes": -41711888,
"heapUsedBytes": 162588576,
"domNodes": -6548,
"jsHeapTotalBytes": 782336,
"scriptDurationMs": 761.442,
"eventListeners": -7469,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16052.073999999948,
"styleRecalcs": 87,
"styleRecalcDurationMs": 20.059999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15503.526000000002,
"heapDeltaBytes": -39823200,
"heapUsedBytes": 163261372,
"domNodes": -6548,
"jsHeapTotalBytes": -9863168,
"scriptDurationMs": 791.299,
"eventListeners": -7471,
"totalBlockingTimeMs": 63,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4728.269000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.138999999999996,
"layouts": 20,
"layoutDurationMs": 22.551000000000002,
"taskDurationMs": 4622.306,
"heapDeltaBytes": -25717716,
"heapUsedBytes": 178701064,
"domNodes": -6548,
"jsHeapTotalBytes": 15200256,
"scriptDurationMs": 90.54,
"eventListeners": -7471,
"totalBlockingTimeMs": 77,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4757.123000000092,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.863999999999976,
"layouts": 20,
"layoutDurationMs": 24.02399999999999,
"taskDurationMs": 4683.191000000001,
"heapDeltaBytes": -37493800,
"heapUsedBytes": 179116828,
"domNodes": -6548,
"jsHeapTotalBytes": 11182080,
"scriptDurationMs": 88.33499999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 84,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 448.75899999999547,
"styleRecalcs": 13,
"styleRecalcDurationMs": 16.233999999999998,
"layouts": 2,
"layoutDurationMs": 0.709,
"taskDurationMs": 99.93400000000001,
"heapDeltaBytes": 5080296,
"heapUsedBytes": 73913384,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.373999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 98.97399999999834,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.729999999999999,
"layouts": 3,
"layoutDurationMs": 1.336,
"taskDurationMs": 66.50600000000001,
"heapDeltaBytes": 3194816,
"heapUsedBytes": 70955172,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.6610000000000005,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.53 #19215 +/- ##
=============================================
Coverage ? 83.43%
=============================================
Files ? 2028
Lines ? 117788
Branches ? 32711
=============================================
Hits ? 98280
Misses ? 19150
Partials ? 358
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #17462 to
cloud/1.53Automatically created by backport workflow.