Skip to content

[backport cloud/1.53] test: add renderer toggle and zoom legibility e2e coverage for the ECS migration QA plan - #19215

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-17462-to-cloud-1.53
Sep 28, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-17462-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #17462 to cloud/1.53

Automatically created by backport workflow.

…S migration QA plan (#17462)

- Longer titles and labels verified.
- Clipping controls reject truncated text.
- Human legibility check remains.

<details><summary>Full context for agent readers</summary>

Coverage includes Vue node movement and widget edits through renderer
toggles and save/reload, repeated serialized renderer round trips, and
text rendering at 50% and 200% zoom.

At [the current test
head](5e335f4),
zoom cases use the longer title `KSampler Advanced Controls` and widget
label `guidance scale`. Assertions check exact zoom and text, positive
bounds, complete natural text layout inside clipping ancestors, and
rendered ink. At 200%, deliberately halving each text container's width
makes the clipping assertion reject both perturbations; the restored
text passes.

The parent independently repeated the two zoom cases successfully
against the intended checkout and a private backend, then inspected both
screenshots. The other two renderer-transition cases were not repeated
in this pass, so the older 4/4 result is not claimed as current-head
verification. Static checks and commit/push hooks passed. Hosted CI and
review remain separate.

The first parent attempt reached a user selector because the reused
frontend port belonged to another checkout and backend. A newly bound
server from the intended checkout resolved that harness mismatch; no
product assertion was weakened.

Source-plan case 54 remains partial: exact text presence and clipping
are automated, but subjective legibility and physical-display appearance
still require human assessment.

[QA
plan](https://app.notion.com/p/comfy-org/3c56d73d365081629481ea0f1d09fc65)
· [Migration
PR](#14246)

Glossary: Vue is the DOM-rendered Nodes 2.0 interface; CI means hosted
automated checks.
</details>

---------

Co-authored-by: Amp <amp@ampcode.com>
@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 28, 2026 6:30am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 28, 2026 6:30am UTC

Request Review

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1904 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1883 / ❌ 0 / ⚠️ 3 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 123ms TBT · 100.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.7 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.2 MB heap
vue-large-graph-pan: · 57.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 37ms TBT · 155.4 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 81ms TBT · 170.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 471ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.1 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 28ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 727ms
canvas-mouse-sweep: script duration 115ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 64.5 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -170
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 320ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.4 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 363ms
dom-widget-clipping: script duration 124ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.7 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 522ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.3 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -182
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1306ms
large-graph-pan: script duration 621ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.3 MB
large-graph-pan: DOM nodes -133
large-graph-pan: event listeners -73
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1430ms
large-graph-zoom: script duration 624ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.4 MB
large-graph-zoom: DOM nodes 3
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1542ms
legacy-node-drag: script duration 742ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.5 MB
legacy-node-drag: DOM nodes 5
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 497ms
minimap-idle: script duration 30ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.1 MB
minimap-idle: DOM nodes -270
minimap-idle: event listeners -166
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 340ms
subgraph-dom-widget-clipping: script duration 110ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.2 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 424ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.6 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -201
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 688ms
subgraph-mouse-sweep: script duration 83ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 74.6 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -216
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 760ms
subgraph-transition-enter: script duration 25ms
subgraph-transition-enter: TBT 123ms
subgraph-transition-enter: heap used 100.3 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 4854ms
viewport-pan-sweep: script duration 2161ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.7 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -136
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 12724ms
vue-large-graph-idle: script duration 254ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 166.2 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 86
vue-large-graph-pan: task duration 15471ms
vue-large-graph-pan: script duration 776ms
vue-large-graph-pan: TBT 37ms
vue-large-graph-pan: heap used 155.4 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 62ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4653ms
vue-node-resize-workload: script duration 89ms
vue-node-resize-workload: TBT 81ms
vue-node-resize-workload: heap used 170.6 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 10
workflow-execution: task duration 83ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.1 MB
workflow-execution: DOM nodes 117
workflow-execution: event listeners 73
Raw data
{
  "timestamp": "2026-09-28T06:42:52.872Z",
  "gitSha": "955414cd489d0efc893bd09499b93336796a3ebd",
  "branch": "backport-17462-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2042.4089999999637,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.404000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.354,
      "heapDeltaBytes": -12022596,
      "heapUsedBytes": 58176344,
      "domNodes": -283,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.800000000000002,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2007.2349999999233,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.032,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.741,
      "heapDeltaBytes": 12613372,
      "heapUsedBytes": 82478480,
      "domNodes": -279,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.929,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1753.8850000000252,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 27.875999999999998,
      "layouts": 14,
      "layoutDurationMs": 3.953,
      "taskDurationMs": 706.7620000000001,
      "heapDeltaBytes": 4063884,
      "heapUsedBytes": 74422224,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 111.93800000000002,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1735.648000000083,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 29.086000000000002,
      "layouts": 14,
      "layoutDurationMs": 4.585999999999999,
      "taskDurationMs": 746.892,
      "heapDeltaBytes": -9416824,
      "heapUsedBytes": 60856664,
      "domNodes": -282,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 117.455,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1706.9849999999747,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.183000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.1219999999999999,
      "taskDurationMs": 313.86800000000005,
      "heapDeltaBytes": 4408164,
      "heapUsedBytes": 75101008,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.729,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.0049999999064,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 15.095999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.2739999999999998,
      "taskDurationMs": 326.719,
      "heapDeltaBytes": 4448352,
      "heapUsedBytes": 74681520,
      "domNodes": 79,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 16.697,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 541.5089999999623,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.231,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 350.99800000000005,
      "heapDeltaBytes": 18151540,
      "heapUsedBytes": 87863916,
      "domNodes": 16,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 120.65299999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 544.6759999999813,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.52,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 374.678,
      "heapDeltaBytes": -8073832,
      "heapUsedBytes": 62430680,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 127.29299999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.0050000000174,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.889,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 527.8009999999998,
      "heapDeltaBytes": 10487876,
      "heapUsedBytes": 85838348,
      "domNodes": -271,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 28.982999999999993,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.1349999999775,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.334999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.791,
      "heapDeltaBytes": -14286796,
      "heapUsedBytes": 86788364,
      "domNodes": -266,
      "jsHeapTotalBytes": -831488,
      "scriptDurationMs": 29.490000000000002,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2101.4920000000075,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.129,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1293.1499999999999,
      "heapDeltaBytes": 17668864,
      "heapUsedBytes": 83772996,
      "domNodes": 6,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 619.2950000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2099.609999999984,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.108999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1318.599,
      "heapDeltaBytes": 19058020,
      "heapUsedBytes": 84600868,
      "domNodes": -272,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 623.433,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3238.6260000000107,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.181999999999997,
      "layouts": 60,
      "layoutDurationMs": 13.062,
      "taskDurationMs": 1437.4930000000002,
      "heapDeltaBytes": 11220032,
      "heapUsedBytes": 80447696,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 630.841,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3268.049000000019,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.876000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.944,
      "taskDurationMs": 1421.9360000000001,
      "heapDeltaBytes": 7715980,
      "heapUsedBytes": 75480640,
      "domNodes": 6,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 616.8290000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2448.211000000015,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 6.921,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1572.444,
      "heapDeltaBytes": 17449660,
      "heapUsedBytes": 85282620,
      "domNodes": 6,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 756.764,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2423.240000000078,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 5.920999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1512.038,
      "heapDeltaBytes": 17995024,
      "heapUsedBytes": 85682732,
      "domNodes": 4,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 726.7600000000001,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2003.2099999999673,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.7489999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.55899999999997,
      "heapDeltaBytes": 21850660,
      "heapUsedBytes": 87206116,
      "domNodes": -269,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.179,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2029.7039999999242,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.6430000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 508.43800000000005,
      "heapDeltaBytes": 10636524,
      "heapUsedBytes": 87054320,
      "domNodes": -270,
      "jsHeapTotalBytes": -2965504,
      "scriptDurationMs": 28.914,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 534.9640000000022,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 7.746000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 334.728,
      "heapDeltaBytes": 14855628,
      "heapUsedBytes": 87515760,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 109.32499999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 542.190000000005,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.473999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 345.472,
      "heapDeltaBytes": 15054432,
      "heapUsedBytes": 86956940,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 111.04,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.8500000000336,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.986999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 422.442,
      "heapDeltaBytes": -7575904,
      "heapUsedBytes": 65067108,
      "domNodes": -297,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.166000000000002,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.512000000006,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.348000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.108,
      "heapDeltaBytes": -8287872,
      "heapUsedBytes": 64021940,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.313,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1705.426999999986,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 27.159,
      "layouts": 18,
      "layoutDurationMs": 4.353,
      "taskDurationMs": 683.38,
      "heapDeltaBytes": 8634004,
      "heapUsedBytes": 80426376,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 81.84700000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1719.2890000000034,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 29.399999999999995,
      "layouts": 18,
      "layoutDurationMs": 4.382,
      "taskDurationMs": 692.056,
      "heapDeltaBytes": 3262988,
      "heapUsedBytes": 75980012,
      "domNodes": -298,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 83.717,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 949.3280000000368,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 25.630000000000006,
      "layouts": 16,
      "layoutDurationMs": 11.344000000000001,
      "taskDurationMs": 760.173,
      "heapDeltaBytes": 21798096,
      "heapUsedBytes": 105190496,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 25.103999999999996,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 123,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8157.932000000017,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 38.496,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4882.937,
      "heapDeltaBytes": -11216000,
      "heapUsedBytes": 89079060,
      "domNodes": -271,
      "jsHeapTotalBytes": -868352,
      "scriptDurationMs": 2173.5979999999995,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8209.095999999932,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 39.211,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4824.299,
      "heapDeltaBytes": -12098212,
      "heapUsedBytes": 88604108,
      "domNodes": -267,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 2149.219,
      "eventListeners": -135,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13349.865000000023,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12694.962,
      "heapDeltaBytes": -34319336,
      "heapUsedBytes": 174216132,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5517312,
      "scriptDurationMs": 241.99300000000002,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13514.538000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12753.660000000002,
      "heapDeltaBytes": -35639444,
      "heapUsedBytes": 174287540,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1298432,
      "scriptDurationMs": 265.31,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15986.525999999969,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 15.023000000000009,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15438.737,
      "heapDeltaBytes": -41711888,
      "heapUsedBytes": 162588576,
      "domNodes": -6548,
      "jsHeapTotalBytes": 782336,
      "scriptDurationMs": 761.442,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 10,
      "frameDurationMs": 17.216666666666665,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16052.073999999948,
      "styleRecalcs": 87,
      "styleRecalcDurationMs": 20.059999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15503.526000000002,
      "heapDeltaBytes": -39823200,
      "heapUsedBytes": 163261372,
      "domNodes": -6548,
      "jsHeapTotalBytes": -9863168,
      "scriptDurationMs": 791.299,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 63,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4728.269000000011,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.138999999999996,
      "layouts": 20,
      "layoutDurationMs": 22.551000000000002,
      "taskDurationMs": 4622.306,
      "heapDeltaBytes": -25717716,
      "heapUsedBytes": 178701064,
      "domNodes": -6548,
      "jsHeapTotalBytes": 15200256,
      "scriptDurationMs": 90.54,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 77,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4757.123000000092,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 63.863999999999976,
      "layouts": 20,
      "layoutDurationMs": 24.02399999999999,
      "taskDurationMs": 4683.191000000001,
      "heapDeltaBytes": -37493800,
      "heapUsedBytes": 179116828,
      "domNodes": -6548,
      "jsHeapTotalBytes": 11182080,
      "scriptDurationMs": 88.33499999999998,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 84,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 448.75899999999547,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 16.233999999999998,
      "layouts": 2,
      "layoutDurationMs": 0.709,
      "taskDurationMs": 99.93400000000001,
      "heapDeltaBytes": 5080296,
      "heapUsedBytes": 73913384,
      "domNodes": 126,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.373999999999999,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 98.97399999999834,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.729999999999999,
      "layouts": 3,
      "layoutDurationMs": 1.336,
      "taskDurationMs": 66.50600000000001,
      "heapDeltaBytes": 3194816,
      "heapUsedBytes": 70955172,
      "domNodes": 108,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.6610000000000005,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 48266 70947 68.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.2% 1185
src/LGraphNode.ts 69.5% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.1% 305
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.4% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 45.0% 203

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 28, 2026
@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #19215   +/-   ##
=============================================
  Coverage              ?   83.43%           
=============================================
  Files                 ?     2028           
  Lines                 ?   117788           
  Branches              ?    32711           
=============================================
  Hits                  ?    98280           
  Misses                ?    19150           
  Partials              ?      358           
Flag Coverage Δ
e2e 66.53% <ø> (?)
unit 76.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit fec6f89 into cloud/1.53 Sep 28, 2026
108 of 109 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-17462-to-cloud-1.53 branch September 28, 2026 07:38

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — aa222679 Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants