Skip to content

[backport cloud/1.55] FE-3045 docs(adr): billing-web hosts checkout only; hosts own plan selection - #19201

Merged
comfy-pr-bot merged 1 commit into
cloud/1.55from
backport-19096-to-cloud-1.55
Sep 28, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.55from
backport-19096-to-cloud-1.55

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #19096 to cloud/1.55

Automatically created by backport workflow.

…lection (#19096)

## Why

Records the 2026-09-27 owner decision: billing-web hosts only the
embedded-checkout experience (payment, 3DS, result) using the same
shared `packages/account-ui` checkout as the cloud app. Each host app
owns plan selection (pricing table, Monthly/Yearly, plan changes, team
credit stop) and opens `/v1/checkout` with `plan` (plus `workspace`,
`team_credit_stop_id`).

## Root cause

The Milestone 2 live run on 2026-09-27 found that the billing-web plan
grid and plan-change quote (#17798, #17937) had been built without a
design source and had drifted from the in-app UX: yearly credits were
labelled "monthly credits", and the quote showed credits as dollars. A
second plan-selection UI for the same journey drifts by default.

## How

- New
`docs/adr/BILLING-WEB-0038-checkout-only-hosts-own-plan-selection.md`
(Accepted): `/v1/checkout` requires `plan`; `/v1/pricing` and a
plan-less `/v1/checkout` redirect to the host via `return_to`;
`SubscriptionPanel` plan cards, `PlanCard` and `SubscriptionQuote` are
removed; `/v1/subscription` keeps cancel/resubscribe;
`/v1/payment-methods`, `/v1/invoices`, `/v1/result` and `/sign-in` stay.
Rejected alternatives: polishing the billing-web grid, or a separate
billing-web design spec.
- BILLING-WEB-0031: amendment note replacing the stale "flag redirects
Plans & pricing" line.
- PACKAGES-ACCOUNT-UI-0034: rule 4 amendment note allowing design-system
token classes so both hosts render identically.
- Cross-links AUTH-BILLING-0032. ADR index updated; `pnpm adr:check`
passes.

## AS IS / TO BE

Docs only.
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 2d74852442d4cfae400df354925c09cb1f935d9a

Full docs: ADR-DEVEX-LINT-0015

@github-actions github-actions Bot added the risk:medium PR risk grade (advisory shadow check; grader-owned) label Sep 28, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against the original PR's file list and checked the diff for conflict markers. Any omitted files are already represented on the target branch.

@comfy-pr-bot
comfy-pr-bot merged commit e81cb64 into cloud/1.55 Sep 28, 2026
83 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-19096-to-cloud-1.55 branch September 28, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:medium PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants