Skip to content

[backport core/1.54] perf: skip document-wide modal scans while typing - #19195

Closed
christian-byrne wants to merge 1 commit into
core/1.54from
backport-19057-to-core-1.54-manual
Closed

christian-byrne wants to merge 1 commit into
core/1.54from
backport-19057-to-core-1.54-manual

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports #19057 to core/1.54 after the automated cherry-pick conflicted.

This preserves the release branch behavior while adding the editor hot-path guard, store-backed auto-queue handling, performance harness, and regression coverage. Release-specific compatibility uses the existing Comfy.Agent.ThreadId storage key.

Validation:

  • focused ChangeTracker + PerformanceHelper suites pass
  • app typecheck passes
  • browser typecheck passes
  • pre-push Knip passes
  • git diff --check passes

- skip document-wide modal scans for native text-editing events while
preserving modal handling for other inputs
- honor store-backed auto-queue mode and cover native editor fast paths
- measure composer typing during the workload, with two unmeasured
type-and-clear warm-ups and named Playwright phases
- close both frame-measurement boundaries and recover cleanly from page
closure or bounded rAF timeouts

This is the measured optimization following the original harness in
[#19051](#19051) and
the protocol-compliant warmed baseline in
[#19159](#19159).

- [Warmed baseline exact-head
run](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36371643330):
46/46 localhost and 4/4 cloud performance tests passed; retained
`perf-metrics` contains 49 measurements, including two samples for each
agent-composer arm.
- The current exact-head run compares the same 73-character workload
after rebasing onto that warmed baseline.
- The durable regression assertion verifies native contenteditable,
input, and textarea events do not invoke the document-wide modal scan.

- `pnpm vitest run src/scripts/changeTracker.test.ts` — 80 passed
- `pnpm vitest run
browser_tests/fixtures/helpers/PerformanceHelper.test.ts` — 2 passed
- real Chromium immediate-block frame falsifier — 1 passed
- `pnpm typecheck:browser`
- focused formatting and lint checks
- pre-push Knip and changed-file Fallow audit passed

Backport targets: core/1.54, cloud/1.54, core/1.55, cloud/1.55.

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>
@vercel

vercel Bot commented Sep 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 28, 2026 5:17am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 28, 2026 5:17am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 6ae470ea-e2a9-4c5e-a9cb-36c5ba835d30

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate greenlight cursor-review Trigger multi-model Cursor agent review on this PR agent Comfy Agent product, integration, tests or product documentation agent-test-unit Touches Agent-related unit/component tests or their support agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration labels Sep 28, 2026
@DrJKL
DrJKL self-requested a review September 28, 2026 05:17
@christian-byrne
christian-byrne removed the request for review from DrJKL September 28, 2026 05:19
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Superseded by automated backport #19192, which landed after the prerequisite scrolling backport reached this release branch.

@christian-byrne
christian-byrne deleted the backport-19057-to-core-1.54-manual branch September 28, 2026 05:22

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — 70a482da Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants