Repository navigation
[backport cloud/1.55] perf: skip document-wide modal scans while typing (#19057) - #19191
Conversation
- skip document-wide modal scans for native text-editing events while preserving modal handling for other inputs - honor store-backed auto-queue mode and cover native editor fast paths - measure composer typing during the workload, with two unmeasured type-and-clear warm-ups and named Playwright phases - close both frame-measurement boundaries and recover cleanly from page closure or bounded rAF timeouts This is the measured optimization following the original harness in [#19051](#19051) and the protocol-compliant warmed baseline in [#19159](#19159). - [Warmed baseline exact-head run](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36371643330): 46/46 localhost and 4/4 cloud performance tests passed; retained `perf-metrics` contains 49 measurements, including two samples for each agent-composer arm. - The current exact-head run compares the same 73-character workload after rebasing onto that warmed baseline. - The durable regression assertion verifies native contenteditable, input, and textarea events do not invoke the document-wide modal scan. - `pnpm vitest run src/scripts/changeTracker.test.ts` — 80 passed - `pnpm vitest run browser_tests/fixtures/helpers/PerformanceHelper.test.ts` — 2 passed - real Chromium immediate-block frame falsifier — 1 passed - `pnpm typecheck:browser` - focused formatting and lint checks - pre-push Knip and changed-file Fallow audit passed Backport targets: core/1.54, cloud/1.54, core/1.55, cloud/1.55. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> (cherry picked from commit ad31025)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2125 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fa8003870ceaea3fa0e6006d6fa61d8f99607c08
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19191 +/- ##
=============================================
Coverage ? 80.60%
=============================================
Files ? 2198
Lines ? 117577
Branches ? 35694
=============================================
Hits ? 94768
Misses ? 22463
Partials ? 346
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Target-native backport of #19057. Includes the production change and unit coverage; omits main-only performance harness/CI files absent from this release branch. App typecheck passed locally.