Repository navigation
[backport core/1.52] fix: accept output media listed in widget options - #19066
Conversation
## ELI5 A local output image can be listed in its node's selector even when it is absent from job history. Missing-media detection now accepts either source, so a valid selectable file is not incorrectly marked missing. ## Summary Local scans now check widget options before falling back to generated history. An exact output option is accepted immediately; an absent option still uses the existing history verification. ## Changes - Accept output-annotated image, video and audio values present in widget options, including when history is empty. - Preserve history-only selections, missing-file warnings, input/output path identity and Cloud asset validation. - Check that valid output selections remain selectable in Vue node popovers, including LoadImageOutput's remote options. ## Review Focus An input option named `photo.png` must not validate `photo.png [output]`. Remote options are allowed to settle before the direct LoadImageOutput rescan; cold remote initialization is a separate concern. The existing "not in options" fixture now omits the selected value, matching its stated purpose; separate new cases assert that an exact option is valid. ## Red-green proof | Phase | Commit | Unit | E2E | | --- | --- | --- | --- | | Red | [fd1f809](fd1f809) | [3 regression failures](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/34328633650/job/102391769657) | [2 regression failures](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/34328633912/job/102392632172) | | Green | [4bcbae8](4bcbae8) | [20,555 passed](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/34331275748/job/102400243503) | [122 passed in regression shard](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/34331275891/job/102401133953) | RED failures were limited to the new output-option cases. GREEN passes the same unchanged tests, all other E2E shards, and the remaining CI checks. ## Provenance - **Authored by:** interactive session. - **Verified:** 112 targeted unit tests and 3 Chromium E2E tests passed with one worker, including history-only fallback. Restoring the old production code reproduced exactly 3 unit and 2 E2E failures; restoring the fix passed all 115 again. Tests are unchanged from the RED commit. `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm lint`, `pnpm format:check` and `pnpm knip` passed. Independent final review found no issues. Both complete CI workflows passed at the GREEN commit, and all other checks passed or were skipped. - **Deviations:** none. ## Cache freshness boundary An exact loader option, including its `[output]` annotation, is accepted as the best available evidence that an OSS output is present. This avoids falsely rejecting a valid file solely because generated history does not contain it. It is not a fresh disk-existence check: after a successful fetch, a deleted file can remain in cached options until refresh, including while the option endpoint is unavailable. Input options already have the same freshness limitation, and history itself does not verify disk existence. Shared refresh/invalidation and unavailable-endpoint policy for input and output are tracked in #17815. Cloud asset verification and the history fallback when no exact output option exists remain unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 1982 passed, 2 failed · 2 flaky❌ Failed Tests📊 Browser Reports
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.52 #19066 +/- ##
===========================================
Coverage 82.01% 82.02%
===========================================
Files 1909 1909
Lines 109083 109086 +3
Branches 30246 29778 -468
===========================================
+ Hits 89462 89473 +11
- Misses 19269 19276 +7
+ Partials 352 337 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 28 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backports #17240 to the active desktop release line.
The production change and regression coverage cherry-picked cleanly. The unit test was adapted to the release branch’s hoisted
mockFetchHistoryPageAPI, and the newer shared view-file mock was inlined because that helper is not present on 1.52.Validation:
pnpm exec vitest run src/platform/missingMedia/missingMediaScan.test.ts(62 passed)pnpm exec oxfmt --checkon changed TypeScript filesOriginal: #17240
Relates to PM-1501 and PM-1598.